Commit Graph

34 Commits

Author SHA1 Message Date
Jeff Morriss 61317d2dbd Remove an unreached return.
svn path=/trunk/; revision=35390
2011-01-05 22:33:25 +00:00
Martin Mathieson fa74c2694c Add current list of ROHC profile names, taken from:
http://www.iana.org/assignments/rohc-pro-ids/rohc-pro-ids.txt

As raised by bug 5536, we now at least show which profile is present.
Supporting all of the specific message types is another matter...

svn path=/trunk/; revision=35314
2010-12-31 00:24:50 +00:00
Martin Mathieson 77cf0462dc From Pascal Quantin:
I just found a small bug in LTE PDCP dissector with current top of tree.
If global preference global_pdcp_dissect_user_plane_as_ip is set to true, the dissector will try to decode an IP frame even with signalling plane.
PDCP-LTE
    ...0 0000 = Seq Num: 0
    Signalling Data: 0800183aa808
    MAC: 0x00000000 (0)
[Malformed Packet: IP]
    [Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]

With the attached patch, I get the correct output for both signalling and user plane PDUs.

svn path=/trunk/; revision=35076
2010-11-30 15:10:17 +00:00
Martin Mathieson 74a74645b1 Add sequence analysis for PDCP, based upon RLC/UM.
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

svn path=/trunk/; revision=35000
2010-11-22 13:28:49 +00:00
Martin Mathieson 76bc0e537b Pass ueid + channel-info into PDCP dissector.
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
2010-11-05 18:00:35 +00:00
Martin Mathieson 3c5b012771 Don't allocate context struct until/unless heuristic signature string matches.
svn path=/trunk/; revision=34752
2010-11-02 15:17:58 +00:00
Jeff Morriss f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts.
svn path=/trunk/; revision=34725
2010-10-30 18:18:12 +00:00
Bill Meier 4d56c5b57b Define a variable as static; Minor code simplification.
svn path=/trunk/; revision=34461
2010-10-10 20:28:22 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Martin Mathieson 28681e2200 From Pascal Quantin: Add offset of 1 to FMS.
svn path=/trunk/; revision=33467
2010-07-07 17:13:53 +00:00
Martin Mathieson 97df849b98 Add new strings/dissector function for signalling RRC messages that will add
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
2010-06-18 07:07:55 +00:00
Martin Mathieson f1f528deeb From Pascal Quantin: fid some LTE MAC and PDCP typos
svn path=/trunk/; revision=31661
2010-01-25 16:45:46 +00:00
Stig Bjørlykke c198fc6546 From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Martin Mathieson 63fc401318 From Pascal Quantin: add PDCP framing method over UDP.
svn path=/trunk/; revision=31243
2009-12-11 14:31:40 +00:00
Martin Mathieson 1a46552674 Allow LTE RRC dissector to call PDCP/RRC dissectors as appropriate for signalling PDUs.
svn path=/trunk/; revision=30971
2009-11-16 15:35:56 +00:00
Martin Mathieson af67d9d1d8 Status report bitmap can be empty, so add test.
svn path=/trunk/; revision=30555
2009-10-13 13:52:23 +00:00
Kovarththanan Rajaratnam 633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Martin Mathieson 29d6ae0ed5 Remove calls to check_col().
svn path=/trunk/; revision=29079
2009-07-13 11:23:40 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Martin Mathieson ab7a96c2e6 Trivial: add spaces to info column string text.
svn path=/trunk/; revision=28703
2009-06-11 14:05:31 +00:00
Martin Mathieson 4e6962056a Don't dissect IP-ID and UDP checksum for IR, IR-DYN frames.
Name hf items and filter strings to consistently include "rohc"

svn path=/trunk/; revision=28539
2009-05-31 12:11:44 +00:00
Martin Mathieson 8315e941ac Add a few more missing ROHC RTP fields.
svn path=/trunk/; revision=28413
2009-05-19 17:26:14 +00:00
Martin Mathieson 4dda12f0be - add direction filter to PDCP
- fix PDCP fields ("pdcp.*" -> "pdcp-lte.*")
- improve PDCP info column output (to be more like RLC)

svn path=/trunk/; revision=28342
2009-05-13 09:36:42 +00:00
Martin Mathieson ea18cc4095 Enable preference to call LTE RRC for data inside PDCP frames.
svn path=/trunk/; revision=28329
2009-05-11 15:19:51 +00:00
Martin Mathieson 76332049f8 Rename lis to fms & some ROHC feedback format improvements.
svn path=/trunk/; revision=28322
2009-05-08 23:29:42 +00:00
Bill Meier 79a1441582 FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).
svn path=/trunk/; revision=28317
2009-05-08 20:35:57 +00:00
Martin Mathieson 7bff5bf554 The abbreviation is "TOHC", not "RoHC".
svn path=/trunk/; revision=27700
2009-03-11 12:04:58 +00:00
Martin Mathieson e6662f6223 Set and use 'plane' more carefully.
svn path=/trunk/; revision=27488
2009-02-20 10:17:52 +00:00
Martin Mathieson 34423cbcc3 From Vincent Helfre:
#define some constants, and move constants into header files.
Hopfully this will make it easier for these dissectors to be reused.

svn path=/trunk/; revision=27487
2009-02-19 22:25:36 +00:00
Bill Meier 4725b0a0f0 Prefs callback & etc not req'd ...
svn path=/trunk/; revision=27303
2009-01-26 21:41:44 +00:00
Martin Mathieson fa74972a7e Remove C++-style comment.
svn path=/trunk/; revision=27294
2009-01-26 14:05:24 +00:00
Martin Mathieson 938c049286 Add dissector for LTE PDCP.
This dissector has lots of TODOs, and hasn't really been worked on in a while, but since
a couple of people had been asking about PDCP support I thought I'd check it in now.

svn path=/trunk/; revision=27293
2009-01-26 12:18:32 +00:00