osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
34,013 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

79 Commits

Author SHA1 Message Date
Jeff Morriss 6cfdeed280 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str(). 
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

svn path=/trunk/; revision=35529
 2011-01-14 03:44:58 +00:00
Anders Broman 46f62f1b49 Mark a parameter as unused. 
svn path=/trunk/; revision=35507
 2011-01-12 17:05:58 +00:00
Anders Broman 93cbda72dd Enhance IE dissection. 
svn path=/trunk/; revision=35506
 2011-01-12 16:43:59 +00:00
Anders Broman 852c75636e Improve dissection of UE Time Zone. 
svn path=/trunk/; revision=35477
 2011-01-11 17:06:38 +00:00
Anders Broman 275c3c8818 Shorten long winded strings. 
svn path=/trunk/; revision=35456
 2011-01-10 17:34:00 +00:00
Jeff Morriss dc22fbfc50 Give CSID an abbreviation. 
svn path=/trunk/; revision=35446
 2011-01-10 03:02:43 +00:00
Anders Broman 5c6ab22ff3 Get rid of check_col(). 
svn path=/trunk/; revision=35432
 2011-01-09 13:50:03 +00:00
Anders Broman f23d884631 Try to fix: 
packet-gtpv2.c:2648: warning: return type defaults to 'int'
packet-gtpv2.c: In function 'dissect_udp_s_port_nr':
packet-gtpv2.c:2690: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_fq_csid':
packet-gtpv2.c:2845: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_emlpp_pri':
packet-gtpv2.c:2927: warning: implicit declaration of function 'be_emlpp_prio'
packet-gtpv2.c: At top level:
packet-gtpv2.c:3056: warning: initialization from incompatible pointer type

svn path=/trunk/; revision=35431
 2011-01-08 20:26:35 +00:00
Anders Broman b6427b53b5 Further IE dissection updates. 
svn path=/trunk/; revision=35430
 2011-01-08 20:09:29 +00:00
Jeff Morriss bf2796ab92 Don't try to display a string in BASE_DEC. Also delete duplicate registration of hf_gtpv2_pti. 
svn path=/trunk/; revision=35422
 2011-01-07 19:01:17 +00:00
Anders Broman f235eadf25 ** (process:23326): WARNING **: Field 'Reserved bit(s)' does not have an 
abbreviation

** ERROR **: Field 'IPv4 Address' (gtpv2.ipv4_addr) is an FT_IPv4 but is being
displayed as BASE_DEC instead of BASE_NONE

svn path=/trunk/; revision=35420
 2011-01-07 18:04:03 +00:00
Anders Broman 6d801a2052 Fix buildbot. 
svn path=/trunk/; revision=35419
 2011-01-07 16:12:01 +00:00
Anders Broman 863e3f80a6 Add dissection of more IE:s 
svn path=/trunk/; revision=35417
 2011-01-07 15:21:23 +00:00
Anders Broman 660d827706 Enhance IE dissection. 
svn path=/trunk/; revision=35378
 2011-01-05 16:46:40 +00:00
Jeff Morriss f94b75c658 Give a couple of fields abbreviations. 
svn path=/trunk/; revision=35362
 2011-01-04 18:41:25 +00:00
Anders Broman 95397594c9 Maeke use of dissect_e212_mcc_mnc_ep_str(). 
svn path=/trunk/; revision=35361
 2011-01-04 16:58:55 +00:00
Anders Broman 9eb2d42bac Add more info to the tree. 
svn path=/trunk/; revision=35354
 2011-01-04 07:14:11 +00:00
Anders Broman da59924551 Prettify dissection of User Location Info (ULI). (Complete) 
svn path=/trunk/; revision=35352
 2011-01-03 23:21:49 +00:00
Anders Broman 5045d66232 Prettify dissection of User Location Info (ULI). 
svn path=/trunk/; revision=35351
 2011-01-03 22:13:11 +00:00
Anders Broman 24550de720 Mark unused parameters as such. 
svn path=/trunk/; revision=35341
 2011-01-03 17:32:15 +00:00
Anders Broman 288d47d1f2 Mark unused parameters as such. 
svn path=/trunk/; revision=35340
 2011-01-03 17:30:35 +00:00
Anders Broman 56c1d1569c Comment out a faulty line. 
svn path=/trunk/; revision=35339
 2011-01-03 17:26:12 +00:00
Anders Broman 9794ffb051 Enhance IE dissection and a number of bug fixes. 
svn path=/trunk/; revision=35338
 2011-01-03 17:22:02 +00:00
Anders Broman f27aa6297a Extend IE dissetcion. 
svn path=/trunk/; revision=35307
 2010-12-30 14:09:09 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[]; 
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
 2010-09-17 04:51:21 +00:00
Anders Broman 187baa00fa GTPv2: IMSI is decoded improperly. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5179

svn path=/trunk/; revision=34062
 2010-09-03 17:10:52 +00:00
Martin Mathieson 21ec91d326 Fix warnings as seen in gcc 3.4.6 
svn path=/trunk/; revision=33604
 2010-07-21 12:29:32 +00:00
Stig Bjørlykke a731837323 From KATAOKA Toshihiro via bug 5033: 
3GPP GTPv2 header Update:
- piggybacked flag
- sequence number

From me:
Updated the comments for sequence number.

svn path=/trunk/; revision=33603
 2010-07-21 10:28:46 +00:00
Anders Broman 2903a17305 Dissect one F-container 
svn path=/trunk/; revision=33372
 2010-06-29 14:56:39 +00:00
Stig Bjørlykke 51ef439176 Mark an unused argument. 
svn path=/trunk/; revision=33357
 2010-06-28 21:05:31 +00:00
Anders Broman 7ba4ce1983 Dissect more GTPV2 IE's 
svn path=/trunk/; revision=33351
 2010-06-28 15:31:41 +00:00
Anders Broman 5cdc63be46 Remove C++ style comment. 
svn path=/trunk/; revision=33159
 2010-06-08 10:37:03 +00:00
Anders Broman 92c247bf70 Fix packet-gtpv2.c:945:1: error: "/*" within comment 
svn path=/trunk/; revision=33158
 2010-06-08 08:55:07 +00:00
Anders Broman 7f9a9231dd From Tamás Regõs: 
Change dissection of  User Location Info (ULI) to show the spare bits
in the protocol tree and don't show ECI as a bitfield.

svn path=/trunk/; revision=33157
 2010-06-08 08:36:22 +00:00
Anders Broman 6d64725ae5 ECI (E-UTRAN Cell Identifier) wrongly decoded. 
Spotted by Tamás Regõs.

svn path=/trunk/; revision=33128
 2010-06-07 14:29:03 +00:00
Anders Broman 2fdf04a43e Update value_strings with IE names. 
svn path=/trunk/; revision=33043
 2010-06-02 06:17:02 +00:00
Anders Broman c58a769956 Remove the now unused value_strings. 
svn path=/trunk/; revision=33038
 2010-06-01 22:23:22 +00:00
Anders Broman 875240d59e - Traffic flow template miss dissected, use de_sm_tflow_temp() 
insted.
- Dissect vendor id of private message.

svn path=/trunk/; revision=33037
 2010-06-01 22:22:09 +00:00
Bill Meier 10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces) 
svn path=/trunk/; revision=32735
 2010-05-10 15:54:57 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed. 
svn path=/trunk/; revision=32411
 2010-04-06 22:09:47 +00:00
Anders Broman b3607a98ae From Toshihiro KATAOKA: 
The decoded MSISDN AVP in 3GPP diameter AVP and the decoded MSISDN IE in 3GPP
GTPv2 IE are not correct. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4638

svn path=/trunk/; revision=32377
 2010-04-05 07:37:04 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis dfde72f247 Fix for Bug 4588: 
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
 2010-03-20 23:53:22 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits 
svn path=/trunk/; revision=31102
 2009-11-27 22:57:50 +00:00
Anders Broman d9a86550c2 Remove debug printout. 
svn path=/trunk/; revision=29968
 2009-09-17 13:53:06 +00:00
Martin Mathieson 9467ccee2c Also mark tree as an unmarked parameter. 
svn path=/trunk/; revision=29928
 2009-09-15 17:07:54 +00:00
Anders Broman 70fabd5881 Remove now unused variables. 
svn path=/trunk/; revision=29925
 2009-09-15 16:46:30 +00:00
Anders Broman 6a5a9b2174 Bearer Context not dissected correctly. 
Use the built in IE decoding by calling dissect_gtpv2_ie_common() for
the grouped IE:s.

svn path=/trunk/; revision=29924
 2009-09-15 15:54:06 +00:00
Anders Broman eeb1f0df18 From swapnil: 
Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940

svn path=/trunk/; revision=29556
 2009-08-26 04:36:14 +00:00