Commit Graph

360 Commits

Author SHA1 Message Date
AndersBroman 2d7c2421f6 [Diameter] Add command code 8388637 and 8388638.
Change-Id: Ia135204ba4931ca0805f49b99b937a6185807ca2
Reviewed-on: https://code.wireshark.org/review/25282
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-12 15:06:59 +00:00
Anders 5be009d48d Fix typo.
Change-Id: I99f122fb154aedce7c129043d55661ce4de09bbc
Reviewed-on: https://code.wireshark.org/review/24388
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-12 18:38:18 +00:00
Anders 54e54c64bd [Diameter] Fix typo avp name="OC-Feature-Vector" code="622"
Change-Id: I678d6f4aa563630db1abdfe03474166de18b2a01
Reviewed-on: https://code.wireshark.org/review/24387
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-12 18:27:39 +00:00
Jeff Dyer 1bc6d4e965 Diameter: Add Huawei DCC AVPs
Change-Id: I480e58a1676677bb362bb4e9dc866c5d5f0814e1
Reviewed-on: https://code.wireshark.org/review/24111
Reviewed-by: Jeff Dyer <jmasterfunk@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-29 16:40:40 +00:00
Pascal Quantin bd28737d7f Diameter 3GPP: update S6a/S6d/S13/S13' AVPs
Change-Id: Ief76bcd529576ccd5324efb042acc4cad7d79c9b
Reviewed-on: https://code.wireshark.org/review/23648
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-21 14:45:45 +00:00
Yury Gargay ab39fac52e Diameter: NAS-Identifier and Acct-Multi-Session-Id are UTF8String
They should be UTF8String not OctetString according these specifications:

* https://tools.ietf.org/html/rfc4005#section-9.3.1
* https://tools.ietf.org/html/rfc6733#section-9.8.5

Change-Id: I96ddc6f5a98ff945dbde34f9844b582a7db924ad
Reviewed-on: https://code.wireshark.org/review/23383
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-04 10:33:07 +00:00
Mike Lugo 31dc0310e2 Added AVP definitions for the following AVPs:
132017 - Override-Control
132019 - Override-Charging-Action-Parameters
132021 - Override-Charging-Action-Exclude-Rule
132022 - Override-Charging-Parameters
132024 - Override-Rating-Group
132026 - Override-Online
132027 - Override-Offline

For reference, page 51: http://www.cisco.com/c/en/us/td/docs/wireless/quantum-policy-suite/R13-0-0/CPS13-0-0MobileConfigurationGuide/bk_Mobile_Config_Guide_chapter_01000.pdf

Change-Id: I397dfad5ea0bd7d06d8b06034c44cc676c293416
Reviewed-on: https://code.wireshark.org/review/22925
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-02 17:22:35 +00:00
KasperDeng fbc4d83ae7 update diameter dictionary for t6a/t6b/s6t
Change-Id: I795efa89c59d2ba84398fc3e42ecc917405ca236
Reviewed-on: https://code.wireshark.org/review/22800
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-26 15:29:20 +00:00
AndersBroman b92c8a2e56 [Diameter] Add a couple of command codes from IANA.
Bug:13895
Change-Id: Icaffd828eef2853d73da807040e5f550548d2804
Reviewed-on: https://code.wireshark.org/review/22698
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-18 13:17:02 +00:00
Michael Mann 9b24ffcd6f Add Inovar specific Diameter AVP codes
Bug: 13349
Change-Id: I2a06ee3bd7ab1f81414ad8e4155c1430a7287644
Reviewed-on: https://code.wireshark.org/review/21778
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-30 10:34:46 +00:00
Marius Paliga e79488911f Rename AVP Emergency-Indication to Emergency-Services
Renamed in 29.273 Rel 14

Change-Id: I171510869ed2c8a77a983e7c37bbdcb7494ad076
Reviewed-on: https://code.wireshark.org/review/21696
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-18 21:43:20 +00:00
AndersBroman 1ef6013d89 [Diameter dictionary] Add some AVPs from TS 32.299 V14.3.0 (2017-03)
Change-Id: I887e11697784c487391b2ea7ec3e0d2e69025c82
Reviewed-on: https://code.wireshark.org/review/21679
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-16 08:11:04 +00:00
AndersBroman b23536ff18 [Diameter] Update experimental result codes according to 3GPP TS 29.230
V14.4.0 (2017-03).

Change-Id: Ia9624ca6668dea8f673a70eb87482cd05238e920
Reviewed-on: https://code.wireshark.org/review/21365
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-27 14:12:07 +00:00
Guy Davies d4519ff28d [Diameter] Add Juniper SCG AVPs
Change-Id: I832a82b4edbfce26e3edceb0f6baed3b7a1c8b62
Reviewed-on: https://code.wireshark.org/review/21190
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-19 14:13:51 +00:00
Pascal Quantin 166c9cfe32 Diameter: update Reservation-Priority AVP values
Change-Id: I5609385ee0a13fe5262a35ac65e206f0bc492a61
Reviewed-on: https://code.wireshark.org/review/21085
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-14 09:11:33 +00:00
AndersBroman 8db347bf61 [Diameter] Fix typos
Change-Id: I535605f29ce052c7d86e1646797456d2c02a8643
Reviewed-on: https://code.wireshark.org/review/20685
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-23 13:54:32 +00:00
AndersBroman 50a30c194f [Diameter] Update with AVPs from TS 29.273 V14.2.2
Change-Id: I4095beebfd8f9bd0f5a74b338eff91722843ad8d
Reviewed-on: https://code.wireshark.org/review/20684
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-23 11:50:25 +00:00
Pascal Quantin c7f554c513 TGPP.xml: add a new enum value for Specific-Action AVP
Change-Id: If45c6b196fc55ff7452f83e022b585cb9a816d53
Reviewed-on: https://code.wireshark.org/review/20562
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-03-16 08:03:39 +00:00
AndersBroman 94559de849 [Diameter] Add 3GPP AVPs
Change-Id: I53c2298584b53943924da417ac407e13f7c23d40
Reviewed-on: https://code.wireshark.org/review/20206
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-20 14:52:37 +00:00
AndersBroman ae0bdcc78c [Diameter AVPs] Add 3GPP AVP 1664 to 1680 from TS 29.272
Change-Id: Iccc98e4bb6f7923c9ed0720d6fc469f5c3f74d39
Reviewed-on: https://code.wireshark.org/review/20096
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-14 04:55:05 +00:00
Jan Spevak d13da6c408 diameter_3gpp: added decoding of TWAN-Identifier AVP
Change-Id: Ib3adec4f7abbdd0313e0017f540044ac45a8883a
Reviewed-on: https://code.wireshark.org/review/19930
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-10 20:27:02 +00:00
Jan Spevak d6d5168881 Diameter: decode Emergency-Indication AVP (1538)
Change-Id: Ie40d61944fd47eb532b759cb122367c18840feff
Reviewed-on: https://code.wireshark.org/review/19615
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-12 15:43:49 +00:00
Jan Spevak dd5697b02e diameter: add values for AVP 2037
Change-Id: I7bddb48d1c6c88f9a6edfce2dd527603878c5ac4
Reviewed-on: https://code.wireshark.org/review/18931
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-25 20:41:31 +00:00
Jeff Morriss 963bd67901 Add a few more T6a/T6b and charging AVPs.
Fix a mistake in a comment.

Change-Id: Ibb12ff3036fb42fe5e3955c67c7c9989f8ffca63
Reviewed-on: https://code.wireshark.org/review/18610
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02 04:40:02 +00:00
Jeff Morriss 446dbea4eb Fix a couple typos in the Diameter XML.
Also:
 - Move new T6a/T6b AVPs into TGPP.xml (to keep them all together).
 - Put back a comment that was (accidentally?) deleted; add some similar notes
   in other places.

Change-Id: I2a468aa3be0069cd8124dd9e5b0a27e333849059
Reviewed-on: https://code.wireshark.org/review/18433
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-25 03:54:04 +00:00
Jan Spevak def19eed53 Update several AVPs according to latest 3GPP TS
Change-Id: Iada3166c93801d3f693714ad8c08bd4f68a70d3e
Reviewed-on: https://code.wireshark.org/review/18425
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-10-24 12:51:15 +00:00
Jeff Morriss 20e2edca57 Add some Diameter AVPs referenced by (recently added) grouped AVPs.
... In order to make the Diameter XML valid again.

This includes adding T6a/T6b and most of the AVPs of that application.

Fix up some white space while at it.

Change-Id: Ie39b3e574065628fdba215cc9c045eebcbd3077e
Reviewed-on: https://code.wireshark.org/review/18422
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-24 04:26:33 +00:00
Joakim Karlsson ed187592ae diameter: add new standardized QCI
Change-Id: If8c29934515b61081d0cbd44a0356144d5d3c466
Reviewed-on: https://code.wireshark.org/review/18407
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-22 23:38:35 +00:00
Anders 25207d70bb [Diameter] Add some 3GPP AVPs fom TS 39.299 v 14.1.0
Change-Id: Ie3995e81de8faee844dbcb794796ecacb6bfe28e
Reviewed-on: https://code.wireshark.org/review/18353
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-21 10:24:17 +00:00
Jan Spevak 5cbdbecc35 GTPv2: Add support for NB-IoT features
Bug: 13026
Change-Id: I75de63bd58a35e234eef308fa592922e01ea3c18
Reviewed-on: https://code.wireshark.org/review/18300
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-19 07:42:37 +00:00
Jeff Morriss 25e7b63ea5 Fix a few typos in the Diameter XML to make it (mostly) valid XML again.
Fix up some white space while at it.

Change-Id: I41efa63ad33288046b56c2eee6a20e066ac6b334
Reviewed-on: https://code.wireshark.org/review/18190
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-10-13 20:17:21 +00:00
Marius Paliga 9934fff4c0 Add support for Enhanced-Diagnostics AVP
Bug: 13004
Change-Id: I20a3faec635a8c86e2d45eb17ce24e2a9db81b5e
Reviewed-on: https://code.wireshark.org/review/18154
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-12 11:16:37 +00:00
Jan Spevak d78c5e0ac2 Diameter: Upadte AVPs 1003, 1094 and 1099
Bug: 13010
Change-Id: I8a3f8ea551ec959e1e5344f825c8bba7bd4ff866
Reviewed-on: https://code.wireshark.org/review/18160
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-12 11:14:10 +00:00
Marius Paliga 1e532f2f6f Diameter: Add support for DRMP AVP
Bug: 12961
Change-Id: I4d9abbae3893916fdd317263a74398d2242f53de
Reviewed-on: https://code.wireshark.org/review/17969
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-28 14:35:16 +00:00
Pascal Quantin 4528da9f01 Diameter: fix a typo in AVP TGPP 1656
Bug: 12927
Change-Id: I6a6507d7b3b0321d2d12d3d306003e480070e79e
Reviewed-on: https://code.wireshark.org/review/17833
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-21 12:21:30 +00:00
AndersBroman c2c8dc38fe [Diameter AVPs] Correct 3GPP AVPs 1655. 1656 531 and 532
Bug: 12927
Change-Id: I545d5c54396431ab67f78fbc31111460d758f8b1
Reviewed-on: https://code.wireshark.org/review/17827
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-21 11:19:29 +00:00
Michael Sweet 35affe3be4 Changes to the IPP dissector:
- xxx-time values are not UNIX timestamps (that is a CUPS-ism - they are
      time since bootup in IPP itself)
    - Change all of the display strings to use the official IANA values
      (confusing otherwise)
    - Add support for newer value/group tags.
    - Add support for all enum attribute values.
    - Add request/response tracking so you can easily match things up.
    - Decode octetString, rangeOfInteger, textWithLanguage, nameWithLanguage,
      dateTime, and resolution values.
    - Don't treat integers and enums as interchangeable (they aren't).
    - Integers and enums are signed integers.
    - Put operation id or status code in info column.

Change-Id: I9fb5cd89d3c386a2b3932ef4c75967ce2547bc22
Reviewed-on: https://code.wireshark.org/review/17192
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Smith Kennedy <smith.kennedy@hp.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-07 21:42:19 +00:00
Marius Paliga 693c745e36 Add support for TWAN-User-Location-Info
Bug: 12834
Change-Id: Ibb196a4e1e8d05b3f124409b18093623f3694af0
Reviewed-on: https://code.wireshark.org/review/17553
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-07 10:15:14 +00:00
AndersBroman e8ba606348 [Diameter] Add Command codes 8388718 - 8388722.
Bug: 12774
Change-Id: I413ba4a195ee1bd3d7de66399d1be714ef77d7e2
Reviewed-on: https://code.wireshark.org/review/17227
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-22 10:36:41 +00:00
AndersBroman f52ce40459 [Diameter] Add stray AVP "Pseudonym-Indicator" code="2519"
Change-Id: I050c27b7118fb98fea20fec697279dc68820763d
Reviewed-on: https://code.wireshark.org/review/17176
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19 13:12:16 +00:00
AndersBroman f92f16916a [Diameter] Add a couple of AVP:s
Change-Id: If7b6a1ba5e81ccb5395df33b7bbcb24a616727c9
Reviewed-on: https://code.wireshark.org/review/17112
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-17 13:53:03 +00:00
AndersBroman 1dfa478b9e [Diameter] Add two LCS AVPs
Change-Id: Ia649a3c88116745b77ae2ffeb243730d3dd13146
Reviewed-on: https://code.wireshark.org/review/17007
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-11 13:32:32 +00:00
Marius Paliga 52ed7d3b5c Add support for new AVPs defined in 29.273
Bug: 12643
Change-Id: Ic9c26dc864b2b016ba722620098caf44a800f0f4
Reviewed-on: https://code.wireshark.org/review/16581
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-22 14:01:37 +00:00
AndersBroman cde7b03f59 [Diameter] Update with new AVPs
Change-Id: I6dfa43320ae3e02afb2b795dd352d492c75a0e60
Reviewed-on: https://code.wireshark.org/review/16526
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18 12:55:45 +00:00
Jeff Morriss 0e8fef5827 Finish getting making the Diameter XML valid XML.
... Except for the fact that many AVP names start with "3GPP".

Make the AVP names XML IDs again.

Fix all the grouped AVPs that reference AVPs (by name) or vice-versa.  This
includes:
 * Fixing a bunch of typos (including type mismatches).
 * Commenting out a number of references to vendor AVPs for which we don't have
   the specs.
 * Adding a few missing AVPs.

Change-Id: Ic2ddb50cc947877de9086be51f7813e8f9be02b4
Reviewed-on: https://code.wireshark.org/review/15973
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-16 17:12:08 +00:00
Jeff Morriss b223d649fe Make the rest of the Diameter AVP names unique.
In most cases this means prepending the application- or vendor-name to force
uniqueness.  A few vendors have duplicates within their namespace--append the
AVP code to these.

Also fix a few other invalid names (with spaces or parentheses in the names).

Change-Id: I5bb78d31526122dd5782055638af410cc497e49d
Reviewed-on: https://code.wireshark.org/review/15960
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-16 04:38:32 +00:00
Jeff Morriss 66d26d701f Remove a bunch of unassigned ETSI AVPs.
These were presumably there to allow indexed search of the AVP list but it
wasn't working anyway (binary search was used).  And the expert info for
"unknown" (to Wireshark) AVPs is a good thing.

Change-Id: Id6b9e5c90b8a2a6e3cf4415cd1b6114308c74440
Reviewed-on: https://code.wireshark.org/review/15956
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-16 02:23:15 +00:00
Jeff Morriss c5528d0b06 Make some more Diameter AVP names unique.
In some cases this means using the correct (updated?) name from the
specification. In others it means prepending the application- or vendor-name
to force uniqueness.

Remove a few more "Unassigned" AVPs from the XML files.

Change-Id: I61d55ef97ff8efc3317c91bf79e73031735f740a
Reviewed-on: https://code.wireshark.org/review/15949
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15 23:41:04 +00:00
Jeff Morriss 66efbdbc01 Make some Diameter AVP names unique.
In some cases this means using the correct (updated?) name from the
specification. In others it means prepending the application name to force
uniqueness.

Change-Id: I8301c769af2b2279c0be7c1bc65e99fe25c1cc80
Reviewed-on: https://code.wireshark.org/review/15935
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15 20:54:48 +00:00
Jeff Morriss d74113fbfb Don't list "AVP" as a possible member of a grouped AVP.
There's no AVP named "AVP".  And there's no need to tell Wireshark that any AVP
may put in the group (the RFC lists "AVP" for that purpose).

Change-Id: I3591af725ebe089e13eae7b712ef4404cb7924a2
Reviewed-on: https://code.wireshark.org/review/15906
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-14 21:44:08 +00:00