Commit Graph

118 Commits

Author SHA1 Message Date
Gerald Combs 5a9393c646 Switch our boolean preferences to bool
With the aid of a script, convert our boolean preferences from gboolean
to bool.

Ping #19116
2024-03-31 16:09:23 +00:00
Martin Mathieson 2640465545 tools/check_val_to_str.py: add option to test generated files 2024-01-18 13:20:24 +00:00
Pascal Quantin feff9a8b80 LTE RRC: upgrade dissector to v17.7.0 2024-01-16 15:22:26 +01:00
Stig Bjørlykke 2cac1ca9e0 asn2wrs: Update to not initialize static proto values 2023-11-02 22:56:41 +00:00
Pascal Quantin 15af80bf09 LTE RRC: upgrade dissector to v17.6.0 2023-10-02 12:22:14 +02:00
Pascal Quantin dcca8c9ec9 LTE RRC: upgrade dissector to v17.5.0 2023-07-06 12:01:45 +02:00
Pascal Quantin 7a20672841 LTE RRC: upgrade dissector to v17.4.0 2023-04-03 16:33:11 +02:00
Pascal Quantin da0c933aa8 LTE RRC: upgrade dissector to v17.3.0 2023-01-16 13:59:13 +00:00
Joakim Karlsson 5b8cb733fa asn2wrs: disable line directive by default
To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-11-30 11:03:09 +00:00
Pascal Quantin 1ef5af31ce LTE RRC: upgrade dissector to v17.2.0 2022-10-04 17:34:17 +00:00
Pascal Quantin af558f672b NR RRC: upgrade dissector to v17.1.0 2022-08-10 18:05:01 +02:00
Pascal Quantin dc03586983 LTE RRC: upgrade dissector to v17.1.0 2022-08-10 12:58:20 +02:00
Pascal Quantin 58af12cac7 LTE RRC: upgrade dissector to v16.8.0 2022-04-19 09:22:58 +00:00
Pascal Quantin d6a9d00cd5 LTE RRC: upgrade dissector to v16.7.0 2022-01-03 14:01:27 +00:00
João Valverde b054f9aee6 ASN1: Convert I/O from GLib to stdio.h 2021-12-17 19:34:54 +00:00
João Valverde 19dcb725b6 epan: Remove STR_ASCII and STR_UNICODE
These display bases work to replace unprintable characters so the
name is a misnomer. In addition they are the same option and this
display behaviour is not something that is configurable.

This does not affect encodings because all our internal text strings
need to be valid UTF-8 and the source encoding is specified using
ENC_*.

Remove the assertion for valid UTF-8 in proto.c because
tvb_get_*_string() must return a valid UTF-8 string, always, and we
don't need to assert that, it is expensive.
2021-12-03 04:35:56 +00:00
Anders Broman fa687143b8 LTE-RRC: Make more ASN1 structures available trough dissector handles. 2021-11-03 05:33:15 +00:00
Anders Broman 83446c4719 LTE-RRC: Add a couple of more "protocols". 2021-10-07 12:22:26 +00:00
Pascal Quantin 35826bbb95 LTE RRC: upgrade dissector to v16.6.0 2021-10-01 15:05:02 +02:00
Evan Huus cdfab0d6e9 tvbuff: convert helper methods to pinfo->pool
A few of them just needed scratch memory, so allocate and free it
manually after doing any exception-raising checks.

A few others were returning memory, and needed conversion to accept a
wmem scope argument.
2021-09-01 03:54:52 +00:00
Evan Huus e69446aa55 asn1: convert most dissectors to pinfo->pool
Part 1/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 15:30:11 +00:00
Pascal Quantin ce9b01f059 LTE RRC: upgrade dissector to v16.5.0 2021-07-07 17:34:28 +02:00
Pascal Quantin 352b555b7c LTE RRC: upgrade dissector to v16.4.0 2021-04-01 20:01:52 +00:00
Pascal Quantin c5c6a5a9cc LTE RRC: use _ instead of - in filter names
Like what asn2wrs.py does
2021-03-21 18:46:53 +00:00
Anders Broman 1910e416a9 LTE-RRC: Rename some duplicated fields names. 2021-03-08 17:16:44 +00:00
Pascal Quantin 879a33f158 LTE RRC: add dissection of NAS 5GS PDUs
A ng-eNB connects to a 5GC, not an EPC, and thus transports 5GS NAS PDUs
2021-03-08 13:02:19 +01:00
Stig Bjørlykke cb3d463a38 lte-rrc: Add preference to put NAS in the root tree
Add a preference to put DedicatedInfoNAS in the root packet
details tree.
2021-02-10 10:08:21 +00:00
Pascal Quantin 102a53c852 NR RRC: upgrade dissector to v16.3.0 2021-01-07 15:07:56 +01:00
Pascal Quantin 3551dfe56e LTE RRC: upgrade dissector to v16.3.0 2021-01-07 12:22:46 +00:00
Anders Broman d139fe3bc7 LTE-RRC: Fix duplicated filter names. 2021-01-05 15:13:12 +00:00
Martin Mathieson 9164d7f9ce PDCP-NR: add ciphering and integrity checking
There may be some scope to share some code with PDCP-LTE,
but it may make the code harder to read.
2020-12-31 13:59:46 +00:00
Pascal Quantin 59efc252dc LPP: upgrade dissector to v16.2.0 2020-11-29 22:48:08 +01:00
Stig Bjørlykke edd71daa90 lte-rrc: Pluralize PagingRecord(s) 2020-10-27 15:51:11 +01:00
Pascal Quantin 21c3bdff06 NR RRC: upgrade dissector to v16.2.0 2020-10-08 10:24:28 +02:00
Pascal Quantin 7924aaae00 LTE RRC: update message identifier value_string array 2020-10-07 21:30:08 +00:00
Pascal Quantin 1fd6a542fe LTE RRC: upgrade dissector to v16.2.0 2020-10-07 17:17:02 +00:00
Pascal Quantin aeb68eb68c X2AP: upgrade dissector to v16.3.0 2020-10-05 13:25:02 +02:00
Pascal Quantin 4707c16add X2AP: upgrade dissector to v16.2.0
Change-Id: I6fc049e0ce07d3938e486c4e6075d70340b3e3e2
Reviewed-on: https://code.wireshark.org/review/38208
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-20 21:39:50 +00:00
Pascal Quantin abd6f143c7 S1AP: upgrade dissector to v16.2.0
Change-Id: Ifa71f952f5aca11f99ae751d1c1404a2af95e3a5
Reviewed-on: https://code.wireshark.org/review/38204
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Tomáš Kukosa <keksa@email.cz>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-20 12:14:30 +00:00
Pascal Quantin 1b88c72776 NR RRC: upgrade dissector to v16.1.0
Change-Id: I961820125dca0f6b72dc84658d3010ca94a563ac
Reviewed-on: https://code.wireshark.org/review/38180
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-17 15:12:48 +00:00
Pascal Quantin 057d50bfdf NR LTE: add dissection of capabilityRequestFilter for EUTRA and EUTRA-NR RATs
Change-Id: I4c21885a43110228379d684aa739817d473506ae
Reviewed-on: https://code.wireshark.org/review/38139
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-12 11:29:56 +00:00
Pascal Quantin c3dbba350c LTE RRC: upgrade dissector to v16.1.1
Change-Id: I52534b6a5dab43ee10501383f3fb76f47255b9a5
Reviewed-on: https://code.wireshark.org/review/38102
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-08-10 04:48:34 +00:00
Guy Harris e1d9a226a2 Fix the type of arrays of pointers to hf_ values for bitfield routines.
The static arrays are supposed to be arrays of const pointers to int,
not arrays of non-const pointers to const int.

Fixing that means some bugs (scribbling on what's *supposed* to be a
const array) will be caught (see packet-ieee80211-radiotap.c for
examples, the first of which inspired this change and the second of
which was discovered while testing compiles with this change), and
removes the need for some annoying casts.

Also make some of those arrays static while we're at it.

Update documentation and dissector-generator tools.

Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
Reviewed-on: https://code.wireshark.org/review/37517
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19 11:32:26 +00:00
Pascal Quantin c97076b7d7 MAC LTE: add support for extended LCID
This feature introduced in V15.5.0 allows to have up to 15 DRBs by
adding LCID 32 to 38

Change-Id: I4442e26d115efe484eda4f2d8921483cf4278b99
Reviewed-on: https://code.wireshark.org/review/37462
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-06-12 04:13:25 +00:00
Pascal Quantin 3d9b2807aa LTE RRC: dissect nas-SecurityParamFromEUTRA for the 5GS to EPS handover case
Change-Id: I3bc14209ad1be8d4f8bdac710baf04a29b521c93
Reviewed-on: https://code.wireshark.org/review/37457
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-06-11 15:18:29 +00:00
Moshe Kaplan fd7895d37c Replace instances of wmem_alloc with wmem_new
This commit replaces instances of
  (myobj *)wmem_alloc(wmem_file_scope(), sizeof(myobj))
and replaces them with:
  wmem_new(wmem_file_scope(), myobj)
to improve the readability of Wireshark's code.

The replacement locations were identified with grep
and replaced with the Python script below.

grep command:
  egrep "wmem_alloc0?\(wmem_file_scope\(\), sizeof\([a-z_]+\)\)" . -R -l

python script:

import re
import sys
import fileinput

pattern = r'\(([^\s]+) ?\*\) ?wmem_alloc(0?)\((wmem_[a-z]+_scope\(\)), sizeof\(\1\)\)'
replacewith = r'wmem_new\2(\3, \1)'

fname = sys.argv[1]

for line in fileinput.input(fname, inplace=1, mode='rb'):
    output = re.sub(pattern, replacewith, line)
    sys.stdout.write(output)

Change-Id: Ieac246c104bf01e32cbc6e11e53e81c7f639d870
Reviewed-on: https://code.wireshark.org/review/37158
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-05-07 14:47:54 +00:00
Pascal Quantin 64daf0136c LTE RRC: upgrade dissector to v15.9.0
Change-Id: I214a985e5d421070d931eb90d5f0848998dfdca2
Reviewed-on: https://code.wireshark.org/review/36697
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-04-04 17:29:53 +00:00
Pascal Quantin adeeb7f2da LTE RRC: fix a memory leak in composite TVB handling
Bug: 16341
Change-Id: Ib6c020ea3df8b39a02f742f0684fca7db96f1fc3
Reviewed-on: https://code.wireshark.org/review/35899
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-22 11:26:11 +00:00
Guy Harris a152e041fa Put various epoch time deltas into wsutil/epochs.h.
There are some deltas between the UN*X epoch and other epochs that are
used in a number of places; put them into a header.

Change-Id: Ia2d9d69b9d91352d730d97d9e4897518635b4861
Reviewed-on: https://code.wireshark.org/review/35895
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-21 23:37:05 +00:00
Pascal Quantin b4e37280c5 LTE RRC: upgrade dissector to v15.8.0
Change-Id: Ib480626891c1796623902c6dfe24183ead59112e
Reviewed-on: https://code.wireshark.org/review/35722
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-09 16:56:13 +00:00