Anders Broman
eb31fad0b5
Add 3GPP Sv interface.
...
svn path=/trunk/; revision=38271
2011-07-30 14:05:55 +00:00
Anders Broman
0a65432f96
Use ENC_BIG_ENDIAN.
...
svn path=/trunk/; revision=38135
2011-07-20 14:09:19 +00:00
Anders Broman
7dce5861cc
From Pascal Quantin:
...
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866
svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00
Anders Broman
aaf0d277b8
Get rid of gsm_a_dtap_pinfo.
...
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc
Change the signature of elem_fcn():ns to include pinfo.
...
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5
Change the msg_fcn() signature to include pinfo.
...
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
Anders Broman
ed66081a4d
From Alexis La Goutte:
...
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713
svn path=/trunk/; revision=36031
2011-02-23 13:51:49 +00:00
Anders Broman
a469849210
From Pascal Quantin:
...
[3GPP protocols] Prettify the display of Mandatory Value information elements
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711
svn path=/trunk/; revision=36026
2011-02-22 11:56:10 +00:00
Anders Broman
0e6aa74d54
From Pascal Quantin:
...
NAS EPS] Fix display of Authentication (Failure) Parameter IEs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5704
svn path=/trunk/; revision=36001
2011-02-18 18:40:29 +00:00
Anders Broman
f108c58805
Complement to
...
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477
svn path=/trunk/; revision=35483
2011-01-11 20:02:30 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
b78ec52693
Use value_string_ext fcns to access certain value_string arrays;
...
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.
svn path=/trunk/; revision=34794
2010-11-05 22:44:03 +00:00
Anders Broman
c522f01e2b
From Pascal Quantin:
...
[NAS EPS] Add dissection of special conformance testing functions
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278
svn path=/trunk/; revision=34394
2010-10-06 14:33:27 +00:00
Bill Meier
69df32fb11
#include <string.h> not needed.
...
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
f8d7a4c4b4
Show the substrings of AUTN and AUTS. Expert info warnings
...
when their lengths is not the expected one.
svn path=/trunk/; revision=31869
2010-02-12 21:57:07 +00:00
Gerasimos Dimitriadis
fab0f16c18
Create FT_BYTES fields for the RAND, AUTN, SRES, XRES
...
and AUTS octet strings in DTAP
svn path=/trunk/; revision=31859
2010-02-10 22:34:34 +00:00
Bill Meier
de4c6ff515
Fix a number of gcc _Wshadow warnings
...
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Guy Harris
68cf37f81b
Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
...
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).
svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00
Guy Harris
fb3fccfc67
Some SMS characters require more than 2 bytes when encoded as UTF-8; the
...
maximum number of bytes required by UTF-8 for a single code point is 6 -
that's probably overkill here, as I don't think any *SMS* characters
require 6 bytes, but we'll go with an expansion factor of 6 anyway.
This fixes bug 4358.
svn path=/trunk/; revision=31365
2009-12-27 21:33:28 +00:00
Gerasimos Dimitriadis
8c1b66f33a
Expert info warning when Keypad Facility IE contains character that is
...
not a DTMF digit
svn path=/trunk/; revision=31284
2009-12-16 20:46:47 +00:00
Gerasimos Dimitriadis
021f402e5f
Update CC Capabilities IE to decode ENICM and MCAT
...
svn path=/trunk/; revision=31283
2009-12-16 19:16:15 +00:00
Gerasimos Dimitriadis
060ac76f82
Show spare bits under the IEs they belong
...
svn path=/trunk/; revision=31144
2009-12-01 20:19:01 +00:00
Gerasimos Dimitriadis
8a70d722d9
Explicitly show LAC and RAC when dissecting Routing Area
...
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.
svn path=/trunk/; revision=31103
2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
029f3641ae
Basic support for the DTAP User-User IE; print bitfields in a way more
...
similar to proto_tree_add_bits_item(); Minor comment edits
svn path=/trunk/; revision=31057
2009-11-23 20:23:30 +00:00
Gerasimos Dimitriadis
55b982b031
- Use the spare_bits hf from packet_gsm_a_common.c in
...
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
contribute to which header fields
svn path=/trunk/; revision=31006
2009-11-18 20:39:14 +00:00
Gerasimos Dimitriadis
c840cdd5a0
Remove the address operator from value_string arrays fed to VALS()
...
svn path=/trunk/; revision=30995
2009-11-17 18:35:27 +00:00
Gerasimos Dimitriadis
4dbe3a5e3a
Fix for bug 4209:
...
After reading a SysID group, current_offset was off by 1
svn path=/trunk/; revision=30847
2009-11-06 21:20:17 +00:00
Anders Broman
67697bad60
From Gerasimos Dimitriadis:
...
DTAP: Update of Reject Cause IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4179
svn path=/trunk/; revision=30759
2009-10-29 18:13:17 +00:00
Anders Broman
53e44c4a73
From Gerasimos Dimitriadis:
...
DTAP: MAP component of indefinite length within Facility IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4157
svn path=/trunk/; revision=30688
2009-10-25 10:14:47 +00:00
Anders Broman
9db0d46eba
Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len);
...
svn path=/trunk/; revision=30671
2009-10-23 05:32:15 +00:00
Anders Broman
ea679ff697
From Gerasimos Dimitriadis:
...
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150
svn path=/trunk/; revision=30670
2009-10-23 02:12:39 +00:00
Anders Broman
3faf5345ab
From Gerasimos Dimitriadis:
...
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146
svn path=/trunk/; revision=30661
2009-10-22 05:28:53 +00:00
Anders Broman
f5f2bf6ecd
From Gerasimos Dimitriadis:
...
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145
svn path=/trunk/; revision=30655
2009-10-21 09:38:51 +00:00
Anders Broman
e12ab4d346
From Gerasimos Dimitriadis:
...
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143
svn path=/trunk/; revision=30637
2009-10-20 14:42:58 +00:00
Anders Broman
923b04dd82
From Gerasimos Dimitriadis:
...
DTAP: Various enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142
svn path=/trunk/; revision=30628
2009-10-20 07:33:01 +00:00
Anders Broman
77c3bfd8c1
From Gerasimos Dimitriadis:
...
DTAP: Decoding of Text String in Network Name IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4121
svn path=/trunk/; revision=30571
2009-10-16 10:38:42 +00:00
Anders Broman
d31ddb200f
From Gerasimos Dimitriadis:
...
DTAP: Facility IE resets PROTOCOL and INFO columns
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4110
svn path=/trunk/; revision=30545
2009-10-12 15:38:16 +00:00
Anders Broman
5ba10f7062
From Gerasimos Dimitriadis:
...
DTAP: Decoding of Emergency Number List IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4111
svn path=/trunk/; revision=30544
2009-10-12 15:32:53 +00:00
Anders Broman
330b2ce091
From Gerasimos Dimitriadis:
...
DTAP: Wrong decoding of ITC in Bearer Capability IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4108
svn path=/trunk/; revision=30426
2009-10-09 10:14:00 +00:00
Stig Bjørlykke
be0f4aa44b
Moved the block for second octet to avoid a warning about an uninitialized
...
variable.
svn path=/trunk/; revision=30332
2009-10-05 16:36:31 +00:00
Anders Broman
131296f6f0
From Gerasimos Dimitriadis:
...
DTAP decoding of Alerting Pattern IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4072
svn path=/trunk/; revision=30242
2009-10-01 18:38:14 +00:00
Kovarththanan Rajaratnam
65c53fedb6
Don't guard col_append_str with check_col
...
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Anders Broman
b8af7c77c8
From Gerasimos Dimitriadis:
...
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032
svn path=/trunk/; revision=30064
2009-09-22 06:42:10 +00:00
Anders Broman
c9dcf6c415
From Gerasimos Dimitriadis:
...
DTAP decoding of Notification Indicator IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4029
svn path=/trunk/; revision=30028
2009-09-20 21:54:39 +00:00
Jaap Keuter
79241dc331
From Gerasimos Dimitriadis:
...
Add decoding support for the codec bitmap in DTAP Supported Codec List IE.
svn path=/trunk/; revision=29963
2009-09-17 06:41:44 +00:00
Bill Meier
6c545e0d79
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman
174c2047b1
From Gerasimos Dimitriadis:
...
DTAP decoding of Cause Diagnostics.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3968
svn path=/trunk/; revision=29637
2009-08-31 18:37:15 +00:00
Bill Meier
3c1bc8f251
Fix some individual cases of 'if (unsigned) < 0'
...
svn path=/trunk/; revision=29320
2009-08-06 23:51:45 +00:00
Jaap Keuter
c9e3f66d14
Optimize empty strings to NULL pointers.
...
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Jaap Keuter
2c9c96744d
From Gerasimos Dimitriadis:
...
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.
svn path=/trunk/; revision=29280
2009-08-03 21:12:41 +00:00
Anders Broman
d446944c82
From Gerasimos Dimitriadis:
...
Decoding support for 4 DTAP IEs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777
svn path=/trunk/; revision=29204
2009-07-27 13:08:17 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke
fc3f1b5283
From Artem Tamazov (bug 3472):
...
Save/Restore pinfo->private_data when used.
svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Anders Broman
b68b9d2ccf
From Reinhard Speyerer:
...
GSM DTAP: incorrect display of Suppl. Service Message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3452
Patch slightly modified.
svn path=/trunk/; revision=28308
2009-05-08 18:10:39 +00:00
Michael Tüxen
dccaadc3dc
Remove duplicate code.
...
svn path=/trunk/; revision=28171
2009-04-27 08:24:21 +00:00
Anders Broman
fb1f3f0825
More IE decoding and bug fixes.
...
svn path=/trunk/; revision=28156
2009-04-26 16:17:00 +00:00
Anders Broman
526cf5d50d
Keep the buildbot happy.
...
svn path=/trunk/; revision=27958
2009-04-04 17:29:46 +00:00
Anders Broman
757a6bf29a
Wrong tree used, add Codec list dissection.
...
svn path=/trunk/; revision=27957
2009-04-04 15:19:45 +00:00
Anders Broman
13282b7a7c
Add value strings and code clenup.
...
svn path=/trunk/; revision=27944
2009-04-03 16:19:12 +00:00
Anders Broman
2db386dfd4
- Use correct length in TLV-E and LV-E.
...
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.
svn path=/trunk/; revision=27605
2009-03-04 19:51:55 +00:00
Bill Meier
3c11319ea4
Adjust some indentation
...
svn path=/trunk/; revision=27323
2009-01-28 21:22:30 +00:00
Jaap Keuter
322d89cf15
From Duncan Salerno:
...
Added LAPDm protocol dissector, GSM Um layer, and wiretap support for dct3trace
captures, generated by gammu (many available at http://wiki.thc.org/gsm ).
svn path=/trunk/; revision=27176
2009-01-07 07:21:31 +00:00
Anders Broman
7eb3e33d28
Add dummy IE decoding to get correct length.
...
svn path=/trunk/; revision=27174
2009-01-06 23:03:05 +00:00
Anders Broman
2100f9aa4e
Update to Rel 8.
...
svn path=/trunk/; revision=27163
2009-01-06 12:40:45 +00:00
Anders Broman
b631b88d61
Implement TLV-E and LV-E type IE dissection (2 byte length value).
...
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Bill Meier
ba7be20b74
Revert queueing --> queuing spelling changes made in SVN #27050
...
svn path=/trunk/; revision=27058
2008-12-19 04:41:54 +00:00
Bill Meier
c544c20956
Fix various typos and spelling errors (mostly in text strings)
...
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Anders Broman
e9ad3ced49
Add some comments.
...
svn path=/trunk/; revision=26794
2008-11-16 22:51:49 +00:00
Anders Broman
fbb3653573
Fix a typo.
...
svn path=/trunk/; revision=26781
2008-11-15 14:34:43 +00:00
Anders Broman
67e29d7f7e
Update comments add Emergensy number list IE.
...
svn path=/trunk/; revision=26780
2008-11-15 11:38:27 +00:00
Stig Bjørlykke
bd08ae7ee6
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Anders Broman
f8a1888e9f
From Bruno Hivert:
...
Pretify Bearer Capability.
svn path=/trunk/; revision=26411
2008-10-11 11:06:58 +00:00
Anders Broman
fdb832cf1b
Dissect Bearer cap in Signal info.
...
svn path=/trunk/; revision=26396
2008-10-09 17:51:51 +00:00
Anders Broman
39941336e4
Add Sequence Number for DTAP messages.
...
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2490
svn path=/trunk/; revision=26290
2008-09-29 16:53:28 +00:00
Bill Meier
ffa7320de2
Minor cleanup related to proto_register & proto_reg_handoff
...
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Anders Broman
ebc8f1f8bf
From Niel Percy:
...
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.
svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Anders Broman
2226bccd44
From Neil Piercy:
...
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.
svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman
bafcc127f8
From Neil Piercy:
...
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.
Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.
svn path=/trunk/; revision=26039
2008-08-19 08:05:04 +00:00
Anders Broman
082a5aec04
From Neil Piercy:
...
All I've done in these is to split the 3 obviously distinct protocols (BSSMAP & RP) from the still-large (and wrongly-named) DTAP (really the whole of layer 3 - it includes RR and packet parts too).
So far I've only split in a "minimum change" manner - there is clearly some tidying and structure enhancement of how the common bits are used, removing the globals just added, and great scope for consistency of white space, improved naming etc. - but I thought it best to keep it very close to the original initially to establish the split.
With some changes to make it compile on Windows.
svn path=/trunk/; revision=25917
2008-08-04 19:44:03 +00:00