Commit Graph

3146 Commits

Author SHA1 Message Date
Guy Harris 88adb489c3 Add extra parenthesization, tweak name of argument to some macros to
more accurately reflect what it is.

svn path=/trunk/; revision=23814
2007-12-09 09:02:14 +00:00
Ronnie Sahlberg b57ce9e48f some updates to make it compile with gtk/glib < 2
svn path=/trunk/; revision=23810
2007-12-08 22:45:30 +00:00
Bill Meier 01ec87aee5 Revert SVN #23728 since change (to fix a Windows issue) is in code not used on Windows
and thus does not actually fix anything.
See Bug #2055 for further info.

svn path=/trunk/; revision=23809
2007-12-08 20:59:15 +00:00
Stig Bjørlykke 4783f12c08 Added "Apply as filter"/"Prepare a filter"/"Find frame"/"Colorize Protocol"
menu.  Simplified getting the Display filter.

svn path=/trunk/; revision=23786
2007-12-06 18:10:35 +00:00
Gerald Combs e66660cd84 Make sure the "auto scroll in live capture" toolbar button and menu item
correctly reflect the auto scroll state. Re-enable the ability to use
the auto scroll toolbar button and menu item during a live capture.

svn path=/trunk/; revision=23777
2007-12-05 23:50:28 +00:00
Stig Bjørlykke 11c616f11e Do not redraw graph and goto frame 1 if selecting an "item" outside the list
in Graph Analysis list.

svn path=/trunk/; revision=23770
2007-12-05 13:32:09 +00:00
Guy Harris d31730a21b Use G_GINT64_MODIFIER for gint64 and guint64 values.
svn path=/trunk/; revision=23763
2007-12-05 10:17:58 +00:00
Stig Bjørlykke d3c4d1b221 Do not create an illegal filter when having an empty display filter and
selecting Apply/Prepare "and/or (not) Selected" in Conversations, Endpoints
and Service Response Time.

svn path=/trunk/; revision=23756
2007-12-04 23:47:30 +00:00
Gerald Combs 0fa29bb1ea Add an oid_get_default_mib_path() function, and use it to display the MIB
path in About->Folders.

svn path=/trunk/; revision=23753
2007-12-04 18:43:40 +00:00
Tomas Kukosa 08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366)
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
2007-12-04 11:19:29 +00:00
Tomas Kukosa 236e14d9f6 add missing emem.h include (prefs-int.h uses emem structures now)
svn path=/trunk/; revision=23748
2007-12-04 08:33:20 +00:00
Guy Harris 15f3b2c750 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23747
2007-12-04 08:27:48 +00:00
Guy Harris a8ce49d758 More whitespace cleanup.
svn path=/trunk/; revision=23746
2007-12-04 07:53:23 +00:00
Guy Harris 353d921d66 Clean up indentation.
svn path=/trunk/; revision=23745
2007-12-04 07:50:44 +00:00
Guy Harris d226610d55 Add a break statement - not necessary in this case, but cleaner, and
matches similar code in other files.

svn path=/trunk/; revision=23744
2007-12-04 07:50:18 +00:00
Guy Harris 9f720bb78f Note in a comment the sad truth that CFURLCreateWithString() fails
either because of a bad URL string or a failure to allocate memory, and
that we can't easily determine which of those happened.

svn path=/trunk/; revision=23740
2007-12-04 04:33:44 +00:00
Stig Bjørlykke 1b7aed33ca - Added three more y axis scale values to be able to draw time values
up to 2000 seconds (maximum when using guint32).
- Combined some common code to draw the y axis values.

svn path=/trunk/; revision=23732
2007-12-04 01:28:38 +00:00
Stig Bjørlykke b20e64d4f9 Simplified y-positions for FBAR and DOT to ensure out-of-graph values are
drawn as they should be.  I hope this is the last fix this time...

svn path=/trunk/; revision=23729
2007-12-04 00:36:39 +00:00
Gerald Combs ed0bb11925 If we're using the native Windows file dialog, don't bother to see if the
file exists before we try to save it. The Windows file dialog code does that
for us.

svn path=/trunk/; revision=23728
2007-12-04 00:23:56 +00:00
Stig Bjørlykke 96586ead65 Use same notation for all y axis time labels, so we don't end up having one
in seconds, one in milliseconds and one in microseconds.

svn path=/trunk/; revision=23722
2007-12-03 22:11:06 +00:00
Guy Harris b370727bf3 Fix indentation.
svn path=/trunk/; revision=23720
2007-12-03 21:57:57 +00:00
Guy Harris 3066148a2b Clean up indentation.
svn path=/trunk/; revision=23719
2007-12-03 21:55:44 +00:00
Guy Harris 835bcbd5e5 If CoreFoundation create calls fail, fail, don't drive on.
svn path=/trunk/; revision=23716
2007-12-03 21:41:06 +00:00
Guy Harris ae459b483f Parenthesize the operand of the cast, to make it clearer that we're
casting the result of the entire computation.

svn path=/trunk/; revision=23714
2007-12-03 21:35:54 +00:00
Anders Broman ea19a489e1 Add another cast.
svn path=/trunk/; revision=23712
2007-12-03 20:53:26 +00:00
Stig Bjørlykke e9090e24bc Add some casts to get the windows compiler happy.
svn path=/trunk/; revision=23711
2007-12-03 20:43:30 +00:00
Stig Bjørlykke 96e82fb78f Added two more y axis scale values to be able to draw time values up to
200 seconds.

svn path=/trunk/; revision=23710
2007-12-03 20:17:31 +00:00
Stig Bjørlykke 4efc9ba371 Ensure we don't wrap the values when calculating advanced time values.
With default window size the limit for this wrap is ~27 seconds when having
0-50 seconds on the y axis, and decreases greatly on higher window size.  

svn path=/trunk/; revision=23708
2007-12-03 19:44:27 +00:00
Stig Bjørlykke 79b3da4b00 Changed from Ok button to Close button.
svn path=/trunk/; revision=23697
2007-12-02 14:43:41 +00:00
Ulf Lamping e4d7a5c236 fix bug #1594: compositions must be differentiated by both protocol and summary, not only the summary - otherwise this results in a single entry if two protocols share the same summary, e.g. TCP/UDP "Bad Checksum"
svn path=/trunk/; revision=23696
2007-12-02 10:13:57 +00:00
Sake Blok e8ca13de9e After taking a closer look at SVN 23089, I believe it was intended only to add the
file-name to the window title and not change the rest of the name.
(the graph window is both used from "Flow Graph" and from "VoIP calls")


svn path=/trunk/; revision=23695
2007-12-01 02:10:03 +00:00
Ulf Lamping a912ab234c move "Display Filter Macros" from View to Analyze menu, just below "Display Filter" - I guess it fit's much better there
svn path=/trunk/; revision=23693
2007-11-30 23:28:06 +00:00
Sake Blok e825cba61b Give the flow graph window the correct title.
svn path=/trunk/; revision=23689
2007-11-30 18:55:34 +00:00
Stig Bjørlykke 44145c21ed Show the Display filter in Protocol Hierarchy Statistics.
svn path=/trunk/; revision=23686
2007-11-30 15:37:21 +00:00
Stig Bjørlykke facb4b5d50 Move the "copy" button down to the button bar, to match the layout in
the conversations window.

svn path=/trunk/; revision=23685
2007-11-30 14:36:18 +00:00
Stig Bjørlykke 0abea9b7d9 More summary enhancements:
- Don't hide columns in the GUI
- Show Packets count first
- Always show values in Packets count
- Don't show Avg. packet size if 1 packet
- Don't show time between packets if 1 packet

svn path=/trunk/; revision=23684
2007-11-30 13:28:12 +00:00
Tomas Kukosa a5ca7ec384 hide implementation of module list
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)

svn path=/trunk/; revision=23669
2007-11-29 07:52:52 +00:00
Sake Blok e2598d0c92 Remove "Reset coloring" from context menu's to keep the GUI consistent
svn path=/trunk/; revision=23657
2007-11-28 22:36:53 +00:00
Sake Blok 069ddc1335 Add sensitivity to some temporary coloring menu items.
svn path=/trunk/; revision=23654
2007-11-28 22:07:44 +00:00
Stig Bjørlykke 311ec68206 Put double click on a frame link back.
svn path=/trunk/; revision=23644
2007-11-28 12:30:18 +00:00
Stephen Fisher 9d83eb39fc Fix bug #954 for LDAP SRT stats along with the same problem in all the other
SRT code.


svn path=/trunk/; revision=23640
2007-11-28 03:04:09 +00:00
Stephen Fisher c232d0b385 Fix a problem whereby the smb2 service resposne time statistics filter was
getting a comma added to be beginning of the filter that the user entered.


svn path=/trunk/; revision=23639
2007-11-28 02:54:23 +00:00
Ronnie Sahlberg e6ed260aca some more path fixes for g_ascii_strcasecmp.h
svn path=/trunk/; revision=23638
2007-11-28 01:31:23 +00:00
Ronnie Sahlberg abb4bc4fae no need to include those xpm's unless we are building for gtk2
svn path=/trunk/; revision=23637
2007-11-28 01:27:07 +00:00
Ronnie Sahlberg 2830cf2045 fix the path to include g_ascii_strcasecmp.h
svn path=/trunk/; revision=23636
2007-11-28 01:23:09 +00:00
Stig Bjørlykke 6e39bc94d1 Summary enhancements:
- Added traffic statistics for marked packages.
- Do not show Displayed column unless using it.
- Removed Marked packets line, as this info is in the marked packets column.

Will add documentation changes if keeping this feature.

svn path=/trunk/; revision=23633
2007-11-28 01:09:02 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Jaap Keuter 3f8ffe514f Fix for bug 2000. Make sure that both datalink layer and application layer agree that information is missing before refusing to write a payload.
svn path=/trunk/; revision=23618
2007-11-27 06:49:48 +00:00
Gerald Combs 85d12e73b3 Disable splash message logging, since it seems to ignore the log level mask.
svn path=/trunk/; revision=23611
2007-11-26 21:54:00 +00:00
Gerald Combs 9e16f1313c If the user has G_LOG_LEVEL_INFO enabled, provide startup progress messages.
svn path=/trunk/; revision=23606
2007-11-26 18:38:03 +00:00