Jeff Morriss
f3648fc66d
Fix up indentation to get it consistent and other minor cleanup issues.
...
svn path=/trunk/; revision=34598
2010-10-21 00:54:58 +00:00
Jeff Morriss
30ab866b25
From Holger Freyther via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5320 :
...
Doing a Dumper:close() and then forcing the dumper to be garbage collected will
cause a segfault.
The code attempts to handle the GC that could follow but fails to do it
properly. Assigning Dumper dp = NULL will only have an affect within the scope
of this method... Assumingly this should be a *dp = NULL.
svn path=/trunk/; revision=34597
2010-10-21 00:37:40 +00:00
Anders Broman
773a7f4c59
From Fred Fierling:
...
Cleanup of unnecessary tree == NULL checks in ZCL dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5321
svn path=/trunk/; revision=34595
2010-10-20 20:50:39 +00:00
Anders Broman
b7d293bdc0
Target system changed by mistake.
...
svn path=/trunk/; revision=34594
2010-10-20 20:49:30 +00:00
Anders Broman
2f9403ab15
Prepartaions to use GTK 2.22
...
svn path=/trunk/; revision=34593
2010-10-20 20:41:39 +00:00
Jeff Morriss
f6a88f2be5
From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
...
I made a patch to support more COAP options.
some options includes variable length field.
svn path=/trunk/; revision=34592
2010-10-20 20:40:53 +00:00
Bill Meier
06325a1bd6
(Minor): pretfs callback not req'd;
...
Move call to data dissector undet 'if(tree)' so same value of
offset used whether or not 'tree == NULL'.
svn path=/trunk/; revision=34591
2010-10-20 18:14:49 +00:00
Jeff Morriss
d14bdd492e
Add IPFIX_RECORDS_TO_CHECK to the environment variable section.
...
svn path=/trunk/; revision=34590
2010-10-20 18:00:25 +00:00
Bill Meier
ce9f471175
From Jeff Morriss: Fix crash: WTAP_ERR_BAD_RECORD error return needs to fill in *err_info.
...
From me: For ipfix_open() don't actually return with *err=WTAP_ERR_BAD_RECORD.
Also: Move #define RECORDS_FOR_IPFIX_CHECK to ipfix.c from ipfix.h since
the definition is only used in ipfix.c.
svn path=/trunk/; revision=34589
2010-10-20 17:20:56 +00:00
Bill Meier
54fa1f56da
Fix bug which caused ascend_open() to return "I/O error" (instead of "not me").
...
(This happened if ascend_open was called with *err != 0).
svn path=/trunk/; revision=34588
2010-10-20 17:07:55 +00:00
Jeff Morriss
185d387f62
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
...
Add dissector for PAPI (Aruba AP Control Protocol), used by Aruba WLAN
Controller).
There is no documentation on this protocol, the dissector is based on my
analysis ...
There is also an experimental "debug dissector" (not enable by default) for
dissecting the rest of data.
Changes by me:
- make it a new-style dissector
- change the name of the "debug" preference
- other minor changes
svn path=/trunk/; revision=34587
2010-10-20 16:49:21 +00:00
Bill Meier
c587b61e2d
Fix a typo in a comment
...
svn path=/trunk/; revision=34586
2010-10-20 15:14:56 +00:00
Anders Broman
64d4b08a82
From Vincent Helfre:
...
various bug fix and enhancement for Release 8 additionnal parameters.
svn path=/trunk/; revision=34585
2010-10-20 12:40:13 +00:00
Martin Mathieson
d086e935e1
Add longer desriptions of SOStart and SOEnd fields.
...
svn path=/trunk/; revision=34584
2010-10-20 12:08:22 +00:00
Stig Bjørlykke
8be03c48ec
Copy GDK pixbuf loaders libs to the Wireshark.app.
...
svn path=/trunk/; revision=34583
2010-10-20 10:37:11 +00:00
Martin Mathieson
81a49eec81
In heuristic dissector, don't check/allocate struct until/unless signature pattern matches.
...
svn path=/trunk/; revision=34582
2010-10-20 09:58:40 +00:00
Jeff Morriss
dfa6aa82a7
Fix SE memory corruption reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5318 :
...
Ensure the digest is smaller than our buffer before copying it.
svn path=/trunk/; revision=34581
2010-10-20 01:49:32 +00:00
Jeff Morriss
df0692a8e6
Use while loops instead of goto's.
...
svn path=/trunk/; revision=34580
2010-10-20 01:37:03 +00:00
Jeff Morriss
8a7125f063
From Colin O'Flynn and Owen Kirby via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5266 :
...
The attached patch begins to add support for RPL to the ICMPv6 file. All
locations that RPL code have been added are marked with a comment allowing this
patch to be reverted at a future time if it is decided to e.g. move all the RPL
code to it's own dissector.
A few values await IANA assignment and are also clearly marked (in
packet-ipv6.h).
Only the 'metric' option is left unsupported, as it is primarily defined in
another I-D.
svn path=/trunk/; revision=34579
2010-10-20 01:23:32 +00:00
Bill Meier
25130bd482
From Hadriel Kaplan: Update wiretap/README.developer
...
svn path=/trunk/; revision=34578
2010-10-20 01:15:12 +00:00
Bill Meier
6c08c2c43a
Use DISSECTOR_ASSERT (not g_assert) in dissectors...
...
svn path=/trunk/; revision=34577
2010-10-20 00:47:23 +00:00
Bill Meier
9787a5734a
From Hadriel Kaplan: IPFIX file format support.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5242
svn path=/trunk/; revision=34576
2010-10-20 00:36:53 +00:00
Anders Broman
a75d7209f5
From Fred Fierling:
...
Infinite loop in ZCL Discover Attributes dissection
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5303
svn path=/trunk/; revision=34575
2010-10-19 19:19:42 +00:00
Anders Broman
9d2a6d1b97
From Alexis La Goutte:
...
GRE Enhancements
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5314
svn path=/trunk/; revision=34574
2010-10-19 18:28:29 +00:00
Anders Broman
c94d711d8e
From Alexis La Goutte:
...
GRE Enhancements
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5314
svn path=/trunk/; revision=34573
2010-10-19 18:28:00 +00:00
Bill Meier
a88357dbf4
Remove some #if 0'd code I left in by mistake a while back....
...
svn path=/trunk/; revision=34572
2010-10-19 17:43:52 +00:00
Bill Meier
6e011bbf6e
Change dummy MAC addresses so we don't get Wireshark expert message:
...
"[...] Source MAC must not be a group address: IEEE 802.3-2002, Section 3.2.3(b)"
Specifically: use 0a:01:01:01:01:01 and 0a:02:02:02;02:02 (and dummy IP addresses
10.1.1.1 and 10.2.2.2).
svn path=/trunk/; revision=34571
2010-10-19 16:13:48 +00:00
Anders Broman
88622252b1
From Tamás Regõs:
...
Make application ID readable from sub dissectors.
svn path=/trunk/; revision=34570
2010-10-19 15:21:05 +00:00
Bill Meier
7ae3e56828
Use dynamically created value_string_ext to store hash/symbol value_strings;
...
Also: minor code reformatting and re-arrangement.
svn path=/trunk/; revision=34569
2010-10-19 14:31:05 +00:00
Jeff Morriss
a3bf744a0f
From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
...
Remove some unused hf variables.
svn path=/trunk/; revision=34568
2010-10-19 13:30:40 +00:00
Martin Mathieson
3dbfdb13cc
Fix problem with creating filter expressions (where stats window is limited by existing filter).
...
svn path=/trunk/; revision=34567
2010-10-19 09:19:53 +00:00
Stig Bjørlykke
1f2b9eca16
Init ett_coap_noop, another fix for bug 5305.
...
svn path=/trunk/; revision=34566
2010-10-19 06:58:08 +00:00
Jeff Morriss
8ad4c4efdd
Don't use g_strcmp0(): it only exists in glib > 2.16.
...
Make read_length() static.
Start function names at column 0.
svn path=/trunk/; revision=34565
2010-10-18 21:55:56 +00:00
Jeff Morriss
83caffd358
Fix the win64 build
...
svn path=/trunk/; revision=34564
2010-10-18 21:36:41 +00:00
Jeff Morriss
94e072c92f
Fix progress bar when loading compressed files.
...
Continue to use the data offset ((uncompressed) bytes read) as our progress
indicator, at least until we get a progress value greater than 1.0. Then,
in addition to checking if the size of the file changed, check our position in
the file and use that as our progress indicator.
This optimizes uncompressed file accesses (avoiding an lseek()) at the "expense"
of switching progress measures (from data read to position in the file) while
loading a file. Tests have shown that the progress bar never shows the data
offset number when loading a compressed file, so this should be okay.
svn path=/trunk/; revision=34563
2010-10-18 20:52:54 +00:00
Anders Broman
9ebba15246
(GUIManager) Make opening a recent file work from the recent files menu.
...
svn path=/trunk/; revision=34562
2010-10-18 19:19:27 +00:00
Bill Meier
be1a3f5a7e
Try to fix compile errors on 64 bit systems.
...
svn path=/trunk/; revision=34561
2010-10-18 18:37:07 +00:00
Bill Meier
8832221ca4
Remove some unneeded #includes ...
...
svn path=/trunk/; revision=34560
2010-10-18 17:46:12 +00:00
Martin Mathieson
7e938c7071
Don't clear info column when showing MAC or RLC-level info.
...
svn path=/trunk/; revision=34559
2010-10-18 17:02:19 +00:00
Bill Meier
13b8efbf25
From Holger Grandy: ETCH dissector
...
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5095
From me: Fix a bug in add_symbol which caused occasional Wireshark crashes;
Add additional checking during parse of symbol hash file;
Improve "directory not found" error message;
Do misc code cleanup and simplification.
svn path=/trunk/; revision=34558
2010-10-18 16:15:12 +00:00
Jeff Morriss
b0ab72ac70
Use port range for SCTP too.
...
svn path=/trunk/; revision=34557
2010-10-18 15:56:06 +00:00
Anders Broman
bcd5ed10c3
(GTKUImanger)
...
- Make Open file from the welocme screen work again.
svn path=/trunk/; revision=34556
2010-10-18 15:40:51 +00:00
Jeff Morriss
418b9b2958
Add SVN:Id tag. Copy copyright notice to the header file.
...
svn path=/trunk/; revision=34555
2010-10-18 13:26:35 +00:00
Jeff Morriss
13c4798e8c
Add SVN:Id tag.
...
svn path=/trunk/; revision=34554
2010-10-18 13:24:10 +00:00
Bill Meier
175ec40ea0
Add fuzz-test option (-C) to specify a configuration profile.
...
svn path=/trunk/; revision=34553
2010-10-18 13:21:04 +00:00
Anders Broman
02a19a65c2
Remove "Obsolete" as it may be confusing in erarlier applications.
...
svn path=/trunk/; revision=34552
2010-10-18 08:56:51 +00:00
Stig Bjørlykke
dcbd634884
Remove blurbs equal to name.
...
svn path=/trunk/; revision=34551
2010-10-18 07:41:47 +00:00
Stig Bjørlykke
7e42c00c9c
Added some length checks for integers.
...
This fixes bug 5305.
svn path=/trunk/; revision=34550
2010-10-18 07:13:45 +00:00
Stig Bjørlykke
4b1be2be63
Remove some unused hf entries.
...
svn path=/trunk/; revision=34549
2010-10-17 20:57:11 +00:00
Jörg Mayer
6ab1662ca7
Add expert info if the eth src mac has the I/G bit set
...
svn path=/trunk/; revision=34548
2010-10-17 20:28:20 +00:00