Commit graph

46963 commits

Author SHA1 Message Date
Pascal Quantin
c553280339 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 :
Upgrade AP-title ASN.1 description

svn path=/trunk/; revision=49684
2013-06-01 23:10:37 +00:00
Martin Mathieson
d41ce46c92 Make Earthquake and Tsunami Warning Sytem indications stand out a
bit more.

svn path=/trunk/; revision=49683
2013-06-01 22:26:47 +00:00
Pascal Quantin
c310bd7dcc Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 :
Display C12.22 Invocation Id as unsigned integer

svn path=/trunk/; revision=49682
2013-06-01 20:51:14 +00:00
Guy Harris
e1b276bbc6 More constification.
svn path=/trunk/; revision=49681
2013-06-01 19:33:44 +00:00
Guy Harris
1b96c468d2 More constification.
svn path=/trunk/; revision=49680
2013-06-01 18:38:36 +00:00
Guy Harris
d957f1d7df More constification.
svn path=/trunk/; revision=49678
2013-06-01 17:49:12 +00:00
Chris Maynard
59ef0c60d9 Change a forward-slash to a back-slash as the path separator..
svn path=/trunk/; revision=49677
2013-06-01 13:05:28 +00:00
Sake Blok
cf079d0a6c Check on fh_tree is already done within add_ethernet_trailer()
svn path=/trunk/; revision=49676
2013-06-01 12:00:56 +00:00
Sake Blok
b2a6a6c15c Add ethernet protocol preference to manually set the trailer length.
(some TAPs can slice packets and then add a custom trailer)


svn path=/trunk/; revision=49675
2013-06-01 09:05:56 +00:00
Guy Harris
9c4488cedf More constification.
svn path=/trunk/; revision=49674
2013-06-01 07:02:34 +00:00
Guy Harris
6b4c30b69d When allocating the frame table for a NetMon file, use g_try_malloc(),
and fail with ENOMEM if that fails (and the frame table is not empty -
g_try_malloc() will return NULL if you ask it to allocate zero bytes).

Have an error message for ENOMEM on an open that attempts to tell the
user what the problem is without making their head explode.

svn path=/trunk/; revision=49673
2013-06-01 06:48:37 +00:00
Guy Harris
7658263b0e Note which *particular* IDL this is. (Actually, is that the OSF's DCE
RPC IDL, Microsoft's DCE RPC IDL, or Samba's DCE RPC IDL?)

Constify some stuff to squelch warnings.

svn path=/trunk/; revision=49672
2013-06-01 03:17:59 +00:00
Guy Harris
6e336d74a1 Move the record header processing code into a common routine, and read
that header in both the read and seek-read routines.

svn path=/trunk/; revision=49671
2013-06-01 02:58:58 +00:00
Guy Harris
15a0d1f945 Update various warning-option lists to match what the configure script
adds by default.

svn path=/trunk/; revision=49670
2013-06-01 02:20:12 +00:00
Guy Harris
00ea06430a Implement PARAM_UINT as a spin button with a range of 0 to G_MAXUINT.
svn path=/trunk/; revision=49669
2013-06-01 01:23:59 +00:00
Jörg Mayer
7ad85db8e1 Move -Wlogical-op to list of standard compiler flags for c-only.
svn path=/trunk/; revision=49668
2013-06-01 00:13:25 +00:00
Jörg Mayer
bbdb29725a Fix buildbot:
cc1: warnings being treated as errors
packet-wccp.c: In function 'wccp_fmt_ipadddress':
packet-wccp.c:555: warning: declaration of 'index' shadows a global declaration
/usr/include/string.h:125: warning: shadowed declaration is here
packet-wccp.c: In function 'dissect_wccp2_alternate_mask_value_set_element':
packet-wccp.c:2570: warning: declaration of 'index' shadows a global declaration
/usr/include/string.h:125: warning: shadowed declaration is here
make[5]: *** [libdissectors_la-packet-wccp.lo] Error 1
make[5]: *** Waiting for unfinished jobs....


svn path=/trunk/; revision=49667
2013-06-01 00:11:29 +00:00
Jörg Mayer
3d636a2777 Peter Van Eynde <pevaneyn@cisco.com>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8635

This is an enhanced WCCP decoder handling the new draft 2.01 standard from http://tools.ietf.org/html/draft-mclaggan-wccp-v2rev1


svn path=/trunk/; revision=49666
2013-05-31 23:17:10 +00:00
Jörg Mayer
65e74551b8 Try to port glbp dissector to new expert info infrastructure.
Compile tested only.

svn path=/trunk/; revision=49665
2013-05-31 23:11:43 +00:00
Guy Harris
a8e7b7ccfe Neither gtk_mac_lte_stat_init() nor gtk_rlc_lte_stat_init() are referred
to outside the files that define them; make them static.

svn path=/trunk/; revision=49664
2013-05-31 23:07:51 +00:00
Guy Harris
6c4ceb643b The SIP and WSP statistics taps register themselves; get rid of their
hardcoded menu items.

svn path=/trunk/; revision=49663
2013-05-31 23:05:40 +00:00
Guy Harris
e8947ae24d Add a REGISTER_STAT_GROUP_TELEPHONY_SCTP, make the SCTP chunk counter
register itself in that group, and get rid of its hardcoded menu item.

Also, as the H.225 counter is registering itself, get rid of its
hardcoded menu item.

svn path=/trunk/; revision=49662
2013-05-31 23:00:39 +00:00
Gerald Combs
d5e30ea820 Fix the name resolution tests so that they run on Windows. Enable them
by default. Remove some unused code.

svn path=/trunk/; revision=49661
2013-05-31 22:32:14 +00:00
Guy Harris
cfebdcd2f5 The BOOTP/DHCP statistics tap registers itself; get rid of the explicit
menu item for it.

svn path=/trunk/; revision=49660
2013-05-31 22:10:43 +00:00
Guy Harris
a24a4db3f8 Consistently use "/Statistics", rather than "/StatisticsMenu", in action
names, to avoid confusion.  (Action names are not, in fact, paths; we're
just using path syntax for them as a convention.)

svn path=/trunk/; revision=49659
2013-05-31 22:07:11 +00:00
Guy Harris
c7bd9ae115 Add a REGISTER_STAT_GROUP_TELEPHONY_LTE for the Telephony/LTE menu, and
use it o register the MAC and RLC statistics dialogues.  Get rid of the
explicit menu items for them, as they now show up in the menu as a
result of the tap registering itself.

svn path=/trunk/; revision=49658
2013-05-31 21:57:15 +00:00
Gerald Combs
bfe9967fc8 nameres.hosts_file_handling shouldn't affect loading the profile "hosts"
file. That should be loaded no matter what if we have name resolution
enabled.

Add a name resolution test suite. Currently disabled until I can test it
on Windows.

svn path=/trunk/; revision=49657
2013-05-31 21:40:26 +00:00
Balint Reczey
6974bcecb1 Don't call gtk_widget_unregister_window() in bytes_view_unrealize() after GTK+ 3.8.0
to prevent double invocation causing crash.

This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8604 .
The patch is from Jakub Zawadzki.

svn path=/trunk/; revision=49655
2013-05-31 20:57:07 +00:00
Michael Mann
81820b20ce Add UDT dissector. Bug 8741 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8741)
From Chas Williams

svn path=/trunk/; revision=49654
2013-05-31 20:37:46 +00:00
Guy Harris
7d17d600b5 Report the operation number in all places where we note that we don't
know about a given operation number.

svn path=/trunk/; revision=49653
2013-05-31 19:00:28 +00:00
Evan Huus
64a4df1963 Fix the integer overflow case Jakub caught in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c26

Also use indentation consistent with the rest of the file.

svn path=/trunk/; revision=49652
2013-05-31 13:08:03 +00:00
Michael Mann
5d6a74fd68 Check USB CCID length to see if subdissectors should be called instead of doing it blindly (which could lead to malformed packets). Bug 8735 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8735)
Also minor cleanup of column info.

svn path=/trunk/; revision=49651
2013-05-31 12:54:35 +00:00
Guy Harris
15894ac4dd Use #ifdefs in the XML to include or exclude the packet-editor and
capture menu items, rather than hiding them at run time.

For the capture menu items, translate the GtkAction callback calling
sequence to the normal widget callback calling sequence with individual
routines for each action, rather than a generic translator.

svn path=/trunk/; revision=49649
2013-05-31 07:06:10 +00:00
Jeff Morriss
813dcf79a1 Don't intentionally use -1 as an hfindex: while only naughty before, with the
changes from r49644 you'll get complaints about the hf being unregistered...

Note that this code also intentionally passes -1 as an ett_index.  It doesn't
currently complain so I'm leaving it alone for now...

svn path=/trunk/; revision=49648
2013-05-31 02:27:40 +00:00
Ronnie Sahlberg
eb8217a371 IOSTAT: plot LOAD y-axis in number of I/O not number of I/O times 1000
svn path=/trunk/; revision=49647
2013-05-31 02:14:19 +00:00
Jeff Morriss
b49c3e7eca Oh yeah, -R is now -Y in trunk.
svn path=/trunk/; revision=49646
2013-05-31 02:03:03 +00:00
Jeff Morriss
4361e2a4ed Get rid of most of the if(tree) checks: the proto_tree_add_*() functions
don't need them any more and, as shown in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c16
we really want to check if we're looking at something beyond the end of the TVB
(in order to break out of very long loops).

svn path=/trunk/; revision=49645
2013-05-31 01:46:40 +00:00
Jeff Morriss
0e61a0ec05 (Finally!) check in part of Didier's patch to fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290
(TRY_TO_FAKE_THIS_ITEM disables bounds errors):

Before calling TRY_TO_FAKE_THIS_ITEM() check if the length given (or, in
the case of FT_UINT_{STRING,BYTES}, the length we retrieve from the TVB)
exceeds what's left in the TVB.

Do this only for proto_tree_add_item() for now (it's the most commonly used
and thus the biggest trouble maker in this area).

Similar changes for other APIs will come later (if nothing blows up).  Despite
the fuzz failures this bug has caused I'm not sure about back-porting it...

svn path=/trunk/; revision=49644
2013-05-31 01:46:28 +00:00
Jeff Morriss
c56c403a52 As discussed in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8728#c4 :
Running tshark with a read filter ("-R") and without building the full tree
("-V") causes it to run into some more bugs (usually loops adding more than
100000 items to the tree).  Add some (commented out for now) code to do
this...

svn path=/trunk/; revision=49643
2013-05-31 01:38:55 +00:00
Guy Harris
ecf32a1e7a Put back some conversation list and endpoint list statistics presumably
lost in the conversion to GTKUiManager.

svn path=/trunk/; revision=49642
2013-05-30 22:40:31 +00:00
Guy Harris
d34f9683b0 Add a stat group REGISTER_STAT_GROUP_TELEPHONY_GSM for the Telephony/GSM
statistics menu.

Have the CAMEL counter register itself in that menu, rather than having
main_menubar.c create the menu item for it.

svn path=/trunk/; revision=49641
2013-05-30 22:32:10 +00:00
Gerald Combs
d14fa4914d Add Doxygen boilerplate for some of our core modules and data structures.
svn path=/trunk/; revision=49640
2013-05-30 22:20:21 +00:00
Jeff Morriss
b047518b18 Install fop and asciidoc too
svn path=/trunk/; revision=49639
2013-05-30 21:47:24 +00:00
Jeff Morriss
bd25e827be Oops: revert 49636. We tell a2x to use fop to generate the PDFs.
svn path=/trunk/; revision=49638
2013-05-30 21:41:17 +00:00
Jeff Morriss
c7741660a2 Add SEL RTAC to list of new protocols.
svn path=/trunk/; revision=49637
2013-05-30 21:37:26 +00:00
Jeff Morriss
3428bf9168 Which release notes targets we can build no longer depends on whether we HAVE_FOP.
svn path=/trunk/; revision=49636
2013-05-30 21:33:04 +00:00
Pascal Quantin
55da3a2254 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8644 :
SEL RTAC (Real Time Automation Controller) EIA-232 Serial-Line Dissection

svn path=/trunk/; revision=49635
2013-05-30 20:51:18 +00:00
Pascal Quantin
bc78191e31 Upgrade user manual
svn path=/trunk/; revision=49634
2013-05-30 20:13:56 +00:00
Balint Reczey
c7501cbf67 Use gtk_widget_register_window() and gtk_widget_unregister_window()
instead of deprecated gdk_window_set_user_data() for GTK+ 3 >= 3.8

svn path=/trunk/; revision=49633
2013-05-30 16:42:32 +00:00
Jeff Morriss
d4f44f4979 Get rid of C++/C99-style comments.
svn path=/trunk/; revision=49632
2013-05-30 12:54:24 +00:00