Commit Graph

60 Commits

Author SHA1 Message Date
AndersBroman 065d5c8417 Don't include ctype.h and replace isascii() with _ascii_isprint().
Remove deprecated APIs while at it.

Change-Id: I002ed4a696782caaeeb70a3e4ced4ae81f3d5372
Reviewed-on: https://code.wireshark.org/review/4983
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-29 15:35:53 +00:00
Stig Bjørlykke 4e1b5ea866 ASN1: Register PDU-dissectors as NEW
Change-Id: I1a317b19d8076588c9305dae6287bb80cc14da64
Reviewed-on: https://code.wireshark.org/review/4494
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-13 11:24:07 +00:00
Pascal Quantin d0ac937567 Revert "Update ASN.1 source files with the API changes done in g021e7af"
This reverts commit e308e7c4de.

Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071
Reviewed-on: https://code.wireshark.org/review/2435
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19 18:42:28 +00:00
Pascal Quantin e308e7c4de Update ASN.1 source files with the API changes done in g021e7af
Change-Id: I52ecfccbce423206242e3cf99401a8c9e1655d88
Reviewed-on: https://code.wireshark.org/review/2385
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18 16:15:42 +00:00
AndersBroman 09a9c86473 Add the possibillity to add a string to the termination id.
Change-Id: I3b48b28273a8c1a1558045d2a4ab5104160840de
Reviewed-on: https://code.wireshark.org/review/1510
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-05 15:51:18 +00:00
Bill Meier 1dff4e309d Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors.
Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4
Reviewed-on: https://code.wireshark.org/review/412
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26 19:38:21 +00:00
Jeff Morriss 8c608e6e82 Remove $Id$ from the ASN.1 dissectors and regenerate them.
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-18 03:05:28 +00:00
Evan Huus a6415ece0a Rename a couple of to_str functions to have ep_ in the name. This makes it
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).

svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
Michael Mann 4945174ae6 Pass "wild_card" directly to dissector instead of using private_data. "h248term" dissector is not in Wireshark source, so third-party will need to update accordingly.
svn path=/trunk/; revision=53241
2013-11-10 21:33:45 +00:00
Pascal Quantin a0c53ffaa1 emem -> wmem conversion:
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Anders Broman 96d29a5d50 Get rid of a duplicated filter name.
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
Michael Mann 3eafc74e2b Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride.
svn path=/trunk/; revision=51136
2013-08-04 13:46:25 +00:00
Evan Huus 8b0f1addd9 Apparently one of our major global headers must include emem.h, because I just
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.

svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
Michael Mann 7fe5422c4b Convert ASN.1 dissectors to use filterable expert info.
NOTE: Kerberos ASN.1 template was updated, but not generated to source.

svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
Anders Broman 7c56677cf9 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48429
2013-03-19 21:22:31 +00:00
Anders Broman 189ea54f0b from Alex Lindberg:
Update to packet-h248.c and associated h248 dissecorts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332

svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Guy Harris c51cadd00e Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42488
2012-05-07 22:46:14 +00:00
Anders Broman fd19aa7c89 H.248 Annex E dissector does not properly dissect event parameters
(Update the h.248 dissector's package registration to support v1 packets.)

Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand.
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842

svn path=/trunk/; revision=41526
2012-03-13 13:26:13 +00:00
Jeff Morriss f3f9f2697f Make TVBs opaque for most users.
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Anders Broman eb136e00d8 From Alex Lindberg:
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999

svn path=/trunk/; revision=31597
2010-01-21 06:39:25 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Kovarththanan Rajaratnam a9ed97b344 From Gerasimos Dimitriadis via. bug 4104:
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.

svn path=/trunk/; revision=30398
2009-10-08 13:17:51 +00:00
Anders Broman 8a23b29c91 From Alex Lindberg:
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953

svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
Anders Broman 9b9880a25a From yin sun:
h248 term wildcard enhancement

svn path=/trunk/; revision=28861
2009-06-27 13:37:03 +00:00
Anders Broman 02c27c89f0 transactionId wasn't processed for:
SegmentReply/transactionId
TransactionReply/transactionId
TransactionPending/transactionId
Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2165

svn path=/trunk/; revision=24077
2008-01-13 16:07:52 +00:00
Anders Broman 73fee653de Get rid of ber_last_created_item(). (Final?)
svn path=/trunk/; revision=24010
2008-01-04 13:39:24 +00:00
Anders Broman 079e1446f9 Update to use the -X and -T asn2wrs flags.
svn path=/trunk/; revision=23394
2007-11-07 21:22:25 +00:00
Anders Broman f08cd1e5e3 actx in the rest of dissect_ber..()l
svn path=/trunk/; revision=21773
2007-05-15 05:49:43 +00:00
Anders Broman c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Luis Ontanon 753ac01760 Remove the context tracing from packet-h248.c ( migrated to <epan/gcp.c> )
svn path=/trunk/; revision=21188
2007-03-25 21:39:40 +00:00
Luis Ontanon 7a7e743627 add a tap to h248
svn path=/trunk/; revision=21054
2007-03-18 21:54:07 +00:00
Jörg Mayer 5bd45dfdb9 Make things build on my system again
svn path=/trunk/; revision=19866
2006-11-08 00:10:09 +00:00
Anders Broman 8d8af34ba4 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
MEGACO message cannot be decoded correctly for ServiceChange Command
And decoding of serviceChangeReason.

svn path=/trunk/; revision=19861
2006-11-07 19:25:59 +00:00
Anders Broman 6c0254b1cb Upadte to H.248 V3 and add some annex E parameters.
svn path=/trunk/; revision=19543
2006-10-15 16:06:02 +00:00
Luis Ontanon c284a7f9ab more cleanup... almost there...
svn path=/trunk/; revision=19426
2006-10-04 15:31:31 +00:00
Luis Ontanon 8f737d2587 Get it to compile...
svn path=/trunk/; revision=19412
2006-10-03 18:38:04 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Anders Broman 316453598a From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

svn path=/trunk/; revision=19136
2006-09-04 18:10:14 +00:00
Luis Ontanon 4e1ca8f2c3 fix coverity CIDs 113 and 114.
while at it change the h248 context analysis to use se_trees instead of GHashTables


svn path=/trunk/; revision=17571
2006-03-10 22:01:10 +00:00
Luis Ontanon be94b45514 - Decode some more annex C fields
- Keep track of terminations (link wildcarded ones to real ones)
- Keep termination info and link aal2 terminations to alcap legs


svn path=/trunk/; revision=16914
2005-12-28 19:46:57 +00:00
Gerald Combs 6b376c9c0e asn2eth.py:
Catch a TypeError that gets thrown if we don't use any conversion
specifiers during string formatting.

H.248:

Don't dereference a null pointer.  Fixes bug 626.

svn path=/trunk/; revision=16773
2005-12-13 03:48:26 +00:00
Luis Ontanon 94110893b7 It crashed when keep_persistent_data == FALSE
svn path=/trunk/; revision=16705
2005-12-06 19:47:22 +00:00
Luis Ontanon d6c5410b18 - Fix few issues with context analysis
- Add used terminations tree to the context analysis tree

Regenerate Dissector


svn path=/trunk/; revision=16703
2005-12-06 18:52:17 +00:00
Luis Ontanon e622f903f9 Rewrite of the analisys and summary code.
Analysis code is still  not working so it is disabled.


svn path=/trunk/; revision=16658
2005-12-03 11:43:19 +00:00
Luis Ontanon ff20ed3e10 Some cleanup,
- Improve expert info
- Remove the debug tree (one warning unused function, will go)
- Make Sure Pending messages have a cmdmsg (and so a colinfo label)


svn path=/trunk/; revision=16383
2005-11-02 23:01:15 +00:00
Luis Ontanon b10fcd969a - terminate a value_string
- wildcard field subdissector


svn path=/trunk/; revision=16378
2005-11-02 19:46:47 +00:00
Luis Ontanon f100a33216 - Embryonic Transaction & Context tracing
svn path=/trunk/; revision=16372
2005-11-01 16:28:13 +00:00
Guy Harris c5b0fc27d7 Fix a bunch of places where we were calling "dissect_ber_octet_string()"
with a non-null pointer-to-pointer-to-tvbuff and not checking whether
the returned tvbuff pointer was non-null.

svn path=/trunk/; revision=15948
2005-09-22 00:51:11 +00:00
Luis Ontanon bfa7197fcf if exists call the h248term subdissector.
svn path=/trunk/; revision=14717
2005-06-20 21:21:06 +00:00
Luis Ontanon acdc3d771a - make sure there's something to add to colinfo.
- auditValueRequest is a request too

svn path=/trunk/; revision=14567
2005-06-06 18:51:05 +00:00