Commit Graph

137 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam b97cfa22fd offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Gerald Combs 7cf4114654 If we have a format error, don't try adding something to the
tree. Fixes bug 3822.

svn path=/trunk/; revision=29331
2009-08-08 00:27:31 +00:00
Gerald Combs 517d9cec5f Don't crash if we happen to load a bad MIB file.
svn path=/trunk/; revision=29118
2009-07-16 17:00:58 +00:00
Anders Broman aec691c11f Reworked patch from massimo:
SNMP cannot be decoded in case of appended data to message
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3684

svn path=/trunk/; revision=29047
2009-07-09 21:43:57 +00:00
Stig Bjørlykke 4d8dd01e8e Changed flags_set_truth -> tfs_set_notset
svn path=/trunk/; revision=28989
2009-07-07 14:54:15 +00:00
Anders Broman 6d7ba64d68 From Kovarththanan Rajaratnam:
More "Cleanup header_field_info definitions"

svn path=/trunk/; revision=28962
2009-07-06 18:36:00 +00:00
Stig Bjørlykke c08baee3d8 More header_field_info cleanup.
svn path=/trunk/; revision=28798
2009-06-22 05:18:37 +00:00
Stig Bjørlykke 9391dce6b2 From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup.

svn path=/trunk/; revision=28772
2009-06-19 02:09:52 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke c47e788c94 Regenerate all asn2wrs generated dissectors.
svn path=/trunk/; revision=28379
2009-05-16 22:07:03 +00:00
Anders Broman 64a33ad7af Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28364
2009-05-14 20:04:28 +00:00
Jaap Keuter a503077b85 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28203
2009-05-01 06:57:27 +00:00
Jaap Keuter b751e5367c Constify some more value_strings.
svn path=/trunk/; revision=28101
2009-04-21 05:33:32 +00:00
Stig Bjørlykke 62f60df6b4 From Jakub Zawadzki (bug 3331):
g_free() is NULL safe, so we don't need check against it.

svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
Guy Harris 5742ede54c Add an additional "title" attribute for UAT fields; that's what's
displayed to the user.

svn path=/trunk/; revision=27462
2009-02-16 04:10:06 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Guy Harris ec08463198 Fix previous fix.
svn path=/trunk/; revision=26774
2008-11-13 18:26:38 +00:00
Guy Harris 373f142bcd Fix some warnings.
svn path=/trunk/; revision=26773
2008-11-13 17:58:14 +00:00
Anders Broman 1b0b2bb4b6 From Paul Stath:
Dissector fails for OIDs with MacAddress in index.

svn path=/trunk/; revision=26746
2008-11-10 20:25:38 +00:00
Anders Broman e375c3990a Regenerate all asn2wrs generated dissectors
svn path=/trunk/; revision=26670
2008-11-01 22:30:14 +00:00
Jaap Keuter 49fe94aa3f Fix for bug 2823
Do not pass automatic variables back into caller space.

svn path=/trunk/; revision=26426
2008-10-13 06:56:27 +00:00
Gerald Combs aac8e0d91d Fix a spelling error pointed out by Noam Rathaus.
svn path=/trunk/; revision=26228
2008-09-18 17:19:15 +00:00
Bill Meier d13bc6c7f4 Fix a (probably benign) case where it appears that && should be &
svn path=/trunk/; revision=26058
2008-08-22 14:28:03 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Luis Ontanon 1cbce0623f It is useless in a Protocol Analyzer to avoid the user to have a password shorter than 8 chars.
svn path=/trunk/; revision=25043
2008-04-15 12:12:20 +00:00
Gerald Combs f8e75ecd32 Make the SMI preference a little more verbose. In the COPS and SNMP
preferences, tell the user where they can change the SMI settings. In
the 802.11 preferences, fix a tooltip.

svn path=/trunk/; revision=24620
2008-03-13 22:17:11 +00:00
Stig Bjørlykke aa9b4bf541 Add a const.
svn path=/trunk/; revision=24592
2008-03-09 14:20:28 +00:00
Stig Bjørlykke 9f412a5a8a Show VarBind OIDs and trap enterprise OID in info column.
Initialize pdu_type in dissect_snmp_PDUs() and param_tvb in
dissect_snmp_SnmpEngineID() to avoid potential crashes.

svn path=/trunk/; revision=24591
2008-03-09 13:58:58 +00:00
Stig Bjørlykke 3c6ecbf54b Corrected a typo: octestring -> octetstring.
svn path=/trunk/; revision=24589
2008-03-09 11:24:37 +00:00
Stig Bjørlykke 293e337c2b Display agent-addr as IPv4 address.
svn path=/trunk/; revision=24588
2008-03-09 10:54:55 +00:00
Stig Bjørlykke fdc980e79d Added an option to uat_new() to set if configuration shall be saved in the
selected profile.

Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).

svn path=/trunk/; revision=24580
2008-03-06 22:13:24 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Stig Bjørlykke 6b59696fd7 Added missing array for hf_snmp_big_counter_value.
svn path=/trunk/; revision=24516
2008-03-01 11:43:04 +00:00
Gerald Combs 2ed9d7d43e Make sure we don't dereference a NULL pointer. Fixes bug 2277.
svn path=/trunk/; revision=24467
2008-02-26 01:17:18 +00:00
Gerald Combs 1997308ac1 Handle unsigned SMI types. This should fix bug 2292.
svn path=/trunk/; revision=24457
2008-02-25 00:00:41 +00:00
Tomas Kukosa e6e926d5f1 get rid of get_ber_last_created_item()
svn path=/trunk/; revision=24001
2008-01-03 13:07:17 +00:00
Stig Bjørlykke 3fe2bbe38f Fetch ObjectName and its relative oid_info before handling an eventual error
value, so we have valid values to put in the VarBind entry.  Include the error
note text as the label.

This should fix bug 2144.

svn path=/trunk/; revision=23962
2007-12-28 22:19:33 +00:00
Tomas Kukosa 0ba8976eb7 fix confusion in tag handling
svn path=/trunk/; revision=23702
2007-12-03 13:48:45 +00:00
Tomas Kukosa 7eb5048da9 fix tag handling inside snmp trap
svn path=/trunk/; revision=23508
2007-11-20 13:55:39 +00:00
Ronnie Sahlberg 5770b859b6 updated snmp dissector
svn path=/trunk/; revision=23455
2007-11-15 09:50:36 +00:00
Gerald Combs 7d8064f548 Initialize var_list in dissect_smux(), so that we don't use previously
ep_freed() memory and abort.

svn path=/trunk/; revision=23436
2007-11-12 18:44:29 +00:00
Anders Broman 44470bc5f4 SNMP with option -X and -T
svn path=/trunk/; revision=23352
2007-11-04 16:47:30 +00:00
Bill Meier b337d20d4c Include winposixtypes.h only if building with GNUTLS; Bug 1942: part 2 of 2 of fix.
asn1 template file plus generated .[hc] files;
Note that the generated files include changes which are a result of previous
changes to snmp.cnf (SVN #23252) and of other changes (eg: svn 21145).

svn path=/trunk/; revision=23302
2007-10-29 01:14:51 +00:00
Jörg Mayer 094e2a9a5f Get rid of the remains of NET-SNMP in the build process.
svn path=/trunk/; revision=22934
2007-09-24 06:59:40 +00:00
Jaap Keuter 2ae2f20203 Try to get the Windows buildbot going by avoiding namespace collision.
svn path=/trunk/; revision=22871
2007-09-14 06:51:07 +00:00
Luis Ontanon 168f8923e7 eliminate an anonymous enum.
svn path=/trunk/; revision=22868
2007-09-13 20:27:05 +00:00