(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
The attached patch adds the following enhancements:
- remove duplicated code for Reduced Frame Number computation, and solve
guint64 issue in the same time (see bug 3028 for details)
- BA Range IE decoding
- BA List Pref IE decoding
- UTRAN Frequency List IE decoding
- Cell Selection Indicator after Release of all TCH and SDCCH IE decoding
- UTRAN Classmark Change message decoding (with a call to RRC dissector to
decode the INTER RAT HANDOVER INFO message)
- add Inter System To UTRAN Handover Command message decoding
As usual it compiles fine on Windows but I could not check on Linux.
svn path=/trunk/; revision=26688
please find attach the patch to fix the bug for the "'xdd_indic0' may be used uninitialized in this function" warning. Initializinf it to 0 will not be sufficient as it will fail to decode properly the TDD Cell Information Field.
Builds on Windows hopfully woun't break the build bot.
svn path=/trunk/; revision=26668
packet-gsm_bsslap.c:374: warning: unused parameter 'len'
packet-gsm_a_rr.c:3035: warning: 'xdd_indic0' may be used uninitialized in this function
svn path=/trunk/; revision=26630
The attached patch fix several bugs in the decoding function to display the
Cell Channel Description (44.018 chapter 10.5.2.1b) and the Frequency List
(44.018 chapter 10.5.2.13) information elements content.
Without this patch the ARFCNs displayed are completely wrong.
svn path=/trunk/; revision=26354
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.
svn path=/trunk/; revision=26140
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.
svn path=/trunk/; revision=26064
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.
Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.
svn path=/trunk/; revision=26039
Bill Meier