Commit Graph

38 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Anders Broman b8af7c77c8 From Gerasimos Dimitriadis:
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

svn path=/trunk/; revision=30064
2009-09-22 06:42:10 +00:00
Anders Broman c9dcf6c415 From Gerasimos Dimitriadis:
DTAP decoding of Notification Indicator IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4029

svn path=/trunk/; revision=30028
2009-09-20 21:54:39 +00:00
Jaap Keuter 79241dc331 From Gerasimos Dimitriadis:
Add decoding support for the codec bitmap in DTAP Supported Codec List IE.

svn path=/trunk/; revision=29963
2009-09-17 06:41:44 +00:00
Bill Meier 6c545e0d79 Save some memory: Don't statically allocate ett[] arrays used "dynamically".
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman 174c2047b1 From Gerasimos Dimitriadis:
DTAP decoding of Cause Diagnostics.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3968

svn path=/trunk/; revision=29637
2009-08-31 18:37:15 +00:00
Bill Meier 3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0'
svn path=/trunk/; revision=29320
2009-08-06 23:51:45 +00:00
Jaap Keuter c9e3f66d14 Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Jaap Keuter 2c9c96744d From Gerasimos Dimitriadis:
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.

svn path=/trunk/; revision=29280
2009-08-03 21:12:41 +00:00
Anders Broman d446944c82 From Gerasimos Dimitriadis:
Decoding support for 4 DTAP IEs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777

svn path=/trunk/; revision=29204
2009-07-27 13:08:17 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke fc3f1b5283 From Artem Tamazov (bug 3472):
Save/Restore pinfo->private_data when used.

svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Anders Broman b68b9d2ccf From Reinhard Speyerer:
GSM DTAP: incorrect display of Suppl. Service Message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3452
Patch slightly modified.

svn path=/trunk/; revision=28308
2009-05-08 18:10:39 +00:00
Michael Tüxen dccaadc3dc Remove duplicate code.
svn path=/trunk/; revision=28171
2009-04-27 08:24:21 +00:00
Anders Broman fb1f3f0825 More IE decoding and bug fixes.
svn path=/trunk/; revision=28156
2009-04-26 16:17:00 +00:00
Anders Broman 526cf5d50d Keep the buildbot happy.
svn path=/trunk/; revision=27958
2009-04-04 17:29:46 +00:00
Anders Broman 757a6bf29a Wrong tree used, add Codec list dissection.
svn path=/trunk/; revision=27957
2009-04-04 15:19:45 +00:00
Anders Broman 13282b7a7c Add value strings and code clenup.
svn path=/trunk/; revision=27944
2009-04-03 16:19:12 +00:00
Anders Broman 2db386dfd4 - Use correct length in TLV-E and LV-E.
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.

svn path=/trunk/; revision=27605
2009-03-04 19:51:55 +00:00
Bill Meier 3c11319ea4 Adjust some indentation
svn path=/trunk/; revision=27323
2009-01-28 21:22:30 +00:00
Jaap Keuter 322d89cf15 From Duncan Salerno:
Added LAPDm protocol dissector, GSM Um layer, and wiretap support for dct3trace
captures, generated by gammu (many available at http://wiki.thc.org/gsm).

svn path=/trunk/; revision=27176
2009-01-07 07:21:31 +00:00
Anders Broman 7eb3e33d28 Add dummy IE decoding to get correct length.
svn path=/trunk/; revision=27174
2009-01-06 23:03:05 +00:00
Anders Broman 2100f9aa4e Update to Rel 8.
svn path=/trunk/; revision=27163
2009-01-06 12:40:45 +00:00
Anders Broman b631b88d61 Implement TLV-E and LV-E type IE dissection (2 byte length value).
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Bill Meier ba7be20b74 Revert queueing --> queuing spelling changes made in SVN #27050
svn path=/trunk/; revision=27058
2008-12-19 04:41:54 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Anders Broman e9ad3ced49 Add some comments.
svn path=/trunk/; revision=26794
2008-11-16 22:51:49 +00:00
Anders Broman fbb3653573 Fix a typo.
svn path=/trunk/; revision=26781
2008-11-15 14:34:43 +00:00
Anders Broman 67e29d7f7e Update comments add Emergensy number list IE.
svn path=/trunk/; revision=26780
2008-11-15 11:38:27 +00:00
Stig Bjørlykke bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Anders Broman f8a1888e9f From Bruno Hivert:
Pretify Bearer Capability.

svn path=/trunk/; revision=26411
2008-10-11 11:06:58 +00:00
Anders Broman fdb832cf1b Dissect Bearer cap in Signal info.
svn path=/trunk/; revision=26396
2008-10-09 17:51:51 +00:00
Anders Broman 39941336e4 Add Sequence Number for DTAP messages.
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2490

svn path=/trunk/; revision=26290
2008-09-29 16:53:28 +00:00
Bill Meier ffa7320de2 Minor cleanup related to proto_register & proto_reg_handoff
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Anders Broman ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Anders Broman 2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman bafcc127f8 From Neil Piercy:
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.

Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.

svn path=/trunk/; revision=26039
2008-08-19 08:05:04 +00:00
Anders Broman 082a5aec04 From Neil Piercy:
All I've done in these is to split the 3 obviously distinct protocols (BSSMAP & RP) from the still-large (and wrongly-named) DTAP (really the whole of layer 3 - it includes RR and packet parts too).

So far I've only split in a "minimum change" manner - there is clearly some tidying and structure enhancement of how the common bits are used, removing the globals just added, and great scope for consistency of white space, improved naming etc. - but I thought it best to keep it very close to the original initially to establish the split.

With some changes to make it compile on Windows.

svn path=/trunk/; revision=25917
2008-08-04 19:44:03 +00:00