Commit Graph

103 Commits

Author SHA1 Message Date
Olivier Biot 4f900c8f3a Fix the multipart dissection in WSP so media embedded in a multipart entity
gets handed off to subdissectors. However nested multipart entities are not
supported yet.

Add more information to the WSP protocol summary line.

Add some more clarifications (comments) in the WSP code.

Skip parsing of URL encoded data if tree is NULL.

svn path=/trunk/; revision=9540
2004-01-04 02:55:03 +00:00
Olivier Biot 2a6e130e10 Move the GSM SMS dissection to a dedicated subdissector (currently still within
packet-smpp.c).

Now the higher-level protocols show up without the need of unfolding the SMPP
dissector tree.

Add a new address type AT_STRINGZ, and use it for GSM SMS message reassembly.

Get rid of the different UDH IE subtrees, and replace them with one subtree
for all UDH IEs.

Add debug logging to SMPP and SMPP GSM SMS dissectors.

Move the Short Message reassembly from the SMPP dissector to the SMPP GSM SMS
dissector. Fix duplicated "reassembled in" header fields.

Rename header fields that are now part of SMPP GSM SMS (including the dissector
table name, so it has also been updated in packet-wsp.c and packet-wtp.c).

Add an explicit "if (!tree) return" in the WSP add_headers() method.

NOTE: it would be great if we were able to merge the existing packet-gsm_sms.c
and the SMPP GSM SMS dissector.

svn path=/trunk/; revision=9431
2003-12-23 12:07:14 +00:00
Olivier Biot f4451d312b Move SIR to a dedicated subdissector.
Question: should we define "media type" subdissectors as special?

svn path=/trunk/; revision=9418
2003-12-22 22:57:09 +00:00
Jörg Mayer e78aba0a40 warning: ISO C does not allow extra ; outside of a function
svn path=/trunk/; revision=9387
2003-12-21 05:51:34 +00:00
Jörg Mayer 3f020f582e Compiling with -pedantic:
warning: comma at end of enumerator list

svn path=/trunk/; revision=9383
2003-12-21 04:31:58 +00:00
Olivier Biot a1f13f591e Add extra debug logging. Fix typo in debug log explanation.
svn path=/trunk/; revision=9358
2003-12-19 20:16:04 +00:00
Olivier Biot 8d6c6099d9 Get rid of unused registered header fields. Some white-space changes.
svn path=/trunk/; revision=9330
2003-12-17 22:43:21 +00:00
Olivier Biot d6b851b8d7 WBXML dissector: Move summary update code outside of if (tree) construct.
WSP dissector: clean up redirect dissection, add generic address field
dissection, add Session Initiation Request dissection, rewrite capability
dissection, and various small updates.

svn path=/trunk/; revision=9301
2003-12-16 22:39:32 +00:00
Olivier Biot 283f925b93 Remove unused dissector handles from the WAP dissectors.
Rename the WAP protocols so that they reflect the protocol name and not the
protocol stack name.

Fix the WSP content-type header.

Rename the WSP header fields from 'hdr' to 'header'.

Rename the WSP Openwave header fields from header code page 'x-up-1':
replace 'openwave' with 'x_up_1' (is more intuitive).

Remove unused WSP header fields.

Rename the WTLS header fields so they do not contain 'wsp' anymore.

Correct the WBXML code page switches in the token parsers.

Fix the code page support of multi-codepage content.

Update the PROV WBXML content (and find bugs in the new OMA Prov spec :).

svn path=/trunk/; revision=9291
2003-12-15 22:38:29 +00:00
Olivier Biot 2b8a6c6f4d Get rid of the integer media type dissector table in WSP, WBXML and MMSE.
svn path=/trunk/; revision=9203
2003-12-08 20:37:15 +00:00
Olivier Biot 3565f7da28 Remove the literal WSP content type dissector table, and replace it with the "media_type" table defined in the HTTP dissector.
svn path=/trunk/; revision=9194
2003-12-07 18:09:52 +00:00
Gilbert Ramirez fca733dc44 Add {0, NULL} to the vals_wsp_reason_codes value_string array.
svn path=/trunk/; revision=9168
2003-12-04 06:02:45 +00:00
Guy Harris 05ad6d03d4 From Olivier Biot:
* Fix the WSP dissector so a Quoted-string with extraneous
	  trailing quote is displayed without duplicated final quote, and
	  issue a warning in the protocol tree.
	* Remove the Openwave x-up-proxy-client-id header decoding as it
	  was incorrectly decoded as a text string, and process it with
	  the default Openwave header parser.
	* Fix byte highlighting of some WSP parameters.
	* Rename the WSP parameter filter names so they don't all refer to
	  content_type.

svn path=/trunk/; revision=9062
2003-11-21 22:00:25 +00:00
Guy Harris 49af7e1586 From Olivier Biot:
correct (and document) the offset computation in the parameter()
	and parameter_value_q() functions.

From Lo�c Minier:

	- a copy-paste with a missing replacement;
	- content-disposition uses parameters not q-values;
	- missing "+" for the calculation of parameter-offsets;
	- white-space cleanup;
	- comment fixes.

svn path=/trunk/; revision=9038
2003-11-19 21:24:19 +00:00
Guy Harris 3fe5ef9396 From Olivier Biot: get rid of no-longer-used routines.
svn path=/trunk/; revision=9035
2003-11-19 09:43:29 +00:00
Guy Harris de402f57a6 From Olivier Biot:
Implement quoted-string parsing by appending the closing quote
	to the string value.  If the quoted-string value does not start
	with a quote, dissection resumes but a warning is displayed.
	Textual headers are assumed to be 0x00 terminated (otherwise we
	have a malformed packet or a short frame).

	The Trailer header is also dissected now, and the charset
	parameter dissection has been rewritten.

	The Content-ID header dissector was registered at the place of
	the Trailer dissector; this has also been fixed.

svn path=/trunk/; revision=9024
2003-11-19 01:45:26 +00:00
Guy Harris 5c33ae3c36 From Olivier Biot: fix the offset for the Encoding-Version header in the
general form.

svn path=/trunk/; revision=8976
2003-11-15 23:58:53 +00:00
Guy Harris a6d31930ab From Olivier Biot: use "g_strdup_printf()" to generate
dynamically-allocated sprintf output.

svn path=/trunk/; revision=8960
2003-11-13 23:44:05 +00:00
Gerald Combs 87332bc8fe We can't pass NULLs to proto_tree_add_text(). Replace a bunch of occurrences
of match_strval() with val_to_str() so that we don't throw an assertion.

These changes fix a problem with a file from Martin Dubovsky; otherwise
they haven't been heavily tested.

svn path=/trunk/; revision=8954
2003-11-13 05:08:58 +00:00
Guy Harris a5a8bba3dd From Olivier Biot:
implement the TE header decoding;

	fix the exported add_content_type function;

	reimplement the header parameter dissection so the parameters
	also show up in the related header.

svn path=/trunk/; revision=8952
2003-11-12 22:44:16 +00:00
Guy Harris a3793b2ade From Olivier Biot: implement the Range, Content-Range and
Content-Disposition headers.

svn path=/trunk/; revision=8909
2003-11-07 20:23:55 +00:00
Guy Harris 67569e5a76 From Olivier Biot: add dissection for the Content-Base headeer.
svn path=/trunk/; revision=8908
2003-11-07 20:07:01 +00:00
Guy Harris 8df7feb67d From Olivier Biot:
* Extra headers: Encoding-Version, WWW-Authenticate,
	  Proxy-Authenticate

	* Fix memory allocate/free in header parsing functions & macros

	* Add missing "ok = TRUE" for some header parsing functions

	* Header subfields all share the same subtree identifier (more
	  intuitive)

	* Get rid of unused header fields and subtrees

	* Some whitespace changes

svn path=/trunk/; revision=8879
2003-11-04 19:47:29 +00:00
Guy Harris 12e8688326 From Olivier Biot:
* Use function reference arrays for header parse function lookup
	  (avoids switch())

	* Use macros for the common parts of the header parse functions

	* Use macros for identical header dissection functions

	* Implement many missing header parse functions

	* Automatic header parse error notification

	* Some minor edits

	* Add HTTP equivalents to WSP status codes

svn path=/trunk/; revision=8865
2003-11-03 10:16:00 +00:00
Guy Harris 836f12e207 From Lo�c Minier: get rid of the second of a pair of identical checks.
As per a note by Olivier Biot, make the "multipart/XXX" items all lower
case.

svn path=/trunk/; revision=8802
2003-10-28 17:59:29 +00:00
Guy Harris dbd286ef2e "add_content_type()" returns either a numerical content type and a null
content type pointer or a 0 numerical content type and a non-null
content type pointer; if the content type is numerical, we cannot match
on the string content type (as we'd dereference a null pointer) and, if
the content type is a string, we should not match on the numerical
content type (as the value is bogus).

We also have to call "add_content_type()" to get the content type
regardless of whether we're building a protocol tree, as we need to call
subdissectors regardless of whether we're building a protocol tree.

We also need to set the columns regardless of whether we're building a
protocol tree.

svn path=/trunk/; revision=8675
2003-10-11 00:10:58 +00:00
Guy Harris 98b0611239 From Biot Olivier:
Rename WSP defines to avoid collisions with Windows defines.

	Rename WSP dissector table for integer-value content types.

	Add WSP dissector table for literal content types.

	Add WSP dissection registration for literal content types.

	Register literal and extra WBXML content types to WSP dissector.

	Register textual MMS content type to WSP dissector.

svn path=/trunk/; revision=8648
2003-10-09 18:54:06 +00:00
Guy Harris 7826e4db4a From Olivier Biot: decode the Push-Flag WSP header.
svn path=/trunk/; revision=8376
2003-09-04 19:12:38 +00:00
Guy Harris 75ae0e30c7 From Jean-Michel Fayard: BOOTP/DHCP, HTTP, and WSP statistics taps.
svn path=/trunk/; revision=8345
2003-09-02 22:47:59 +00:00
Guy Harris f9ded39a63 From Lo�c Minier: if the field name for "x-wap.tod" is shown as a text
string, decode the value as a text string, as per 1.0, section 8.4.1.2
("Field Values"):

	If the field name is encoded in text format, textual values MUST
	be used.

svn path=/trunk/; revision=8130
2003-08-04 23:36:13 +00:00
Guy Harris cf51d8d4c6 As suggested by Georg von Zezschwitz, check whether all the bytes of the
URI are present before processing it, to catch bogus length values.

svn path=/trunk/; revision=8099
2003-07-29 21:30:32 +00:00
Gilbert Ramirez c91b8e713f Fix signed/unsigned comparison warnings.
svn path=/trunk/; revision=8084
2003-07-25 04:11:51 +00:00
Guy Harris 259609e677 Don't define "vals_wsp_reason_codes[]" in "packet-wsp.h", define it in
"packet-wsp.c", and just *declare* it in "packet-wsp.h" - no need to
have everybody who includes "packet-wsp.h" get their own copy
(especially as they might not use it).

svn path=/trunk/; revision=7993
2003-07-08 18:10:39 +00:00
Guy Harris 299f79c4f7 From Olivier Biot:
UDH dissection in SMPP message
	WTP and WSP dissection over SMPP (no reassembly)
	WSP status code rendering in Info column

svn path=/trunk/; revision=7954
2003-06-30 23:24:39 +00:00
Guy Harris 181be03665 The last byte of "foo[N]" is "foo[N-1]", not "foo[N]".
svn path=/trunk/; revision=7740
2003-05-25 19:37:36 +00:00
Gerald Combs 356ddbd284 Fix instances where the return value of snprintf() was being checked for -1,
but not for <buf_size> or greater.  Discovered by Timo Sirainen.

svn path=/trunk/; revision=7731
2003-05-24 17:45:10 +00:00
Guy Harris 580e0f8e7b From Olivier Biot:
* Add decoding of Basic authentication scheme for the Authorization
  and Proxy-Authorization headers, and create a summary line
  with proto_item_append_text().
* Update Warning header decoding: warn code mapping to warn text,
  and create a summary line with proto_item_append_text().

svn path=/trunk/; revision=7651
2003-05-08 08:36:25 +00:00
Guy Harris b9ed0197a5 From Olivier Biot:
* Fix the Extended Method PDU mapping (move code some lines down)
* Decode more WSP Parameter entries (now WAP Provisioning Push OK)
* First check whether the PDU content for Post, Reply and Push PDUs
  can be dissected (dissector_try_X function calls), if not then
  display the PDU data as "Data" in the WSP protocol tree.
* Replaced "Unsupported header" by "Undecoded header" for clarity

svn path=/trunk/; revision=7376
2003-03-27 19:15:28 +00:00
Guy Harris 7a5e0860a2 From Olivier Biot: add WSP protocol dissection for extended method PDUs,
and let the Protocol Options header code page and extended methods calls
refer to hexadecimal representation as used everywhere else in the WSP
dissection code.

svn path=/trunk/; revision=7372
2003-03-26 19:45:21 +00:00
Guy Harris d48ec06a6a From Olivier Biot: WBXML/WMLC support.
svn path=/trunk/; revision=7084
2003-02-06 01:23:32 +00:00
Jörg Mayer 4de3370e14 Replace Transmission ID by Transaction ID (spotted by Olivier Biot)
svn path=/trunk/; revision=6330
2002-09-25 00:01:18 +00:00
Jörg Mayer 7c4176d868 Removed trailing whitespaces from .h and .c files using the
winapi_cleanup tool written by Patrik Stridvall for the wine
project.

svn path=/trunk/; revision=6117
2002-08-28 21:04:11 +00:00
Guy Harris 48dbb301c8 From Tom Uijldert: modify MMSE dissector to also accept content that is
not multipart.

Replace my fix to create subtrees for POST data with Tom's.

svn path=/trunk/; revision=5968
2002-08-07 08:34:55 +00:00
Jörg Mayer 173fe5aef4 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

svn path=/trunk/; revision=5932
2002-08-02 23:36:07 +00:00
Guy Harris 9c900f33ea Call "proto_item_add_subtree()" to create a subtree for POST data, don't
just use the return value of a "proto_tree_add" routine as if it could
be used as a protocol tree.

svn path=/trunk/; revision=5915
2002-07-30 07:36:22 +00:00
Guy Harris 77fa06b899 From Joerg Mayer:
dftest.c:
	     Remove #if-0-ed includes

	packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
	     Remove redundant include varargs (already in snprintf.h,
	     and required only for snprintf.h)

	Remove unused include of snprintf.h from files not using
	"snprintf()".

svn path=/trunk/; revision=5889
2002-07-17 00:43:03 +00:00
Guy Harris 1204dfc523 Character set values are in hex in the WSP spec; always display them in
hex.

svn path=/trunk/; revision=5674
2002-06-15 23:23:31 +00:00
Guy Harris 32567ff10f Use "proto_tree_add_item()" to add the URI string to the protocol tree,
rather than extracting a string and adding that explicitly (which runs
the risk of leaking memory if the "tvb_get_ptr()" throws an exception).

Use "tvb_format_text()" when adding the string to the Info column, so
that non-printable characters are displayed as escapes.

svn path=/trunk/; revision=5283
2002-04-29 00:33:30 +00:00
Guy Harris 9971cb529e From Tom Uijldert: comment out an unused function.
svn path=/trunk/; revision=5088
2002-04-02 20:16:19 +00:00
Guy Harris cbda24e612 From Dermot Bradley:
support for Openwave-specific WSP headers;

	support for Openwave-specific field names;

	support for additional content types from Openwave;

	support for additional language values.

svn path=/trunk/; revision=4775
2002-02-22 07:23:25 +00:00