obsolete; we silently ignore attempts to set those in a preferences
file, so that we don't spam the user with error messages caused by them
having saved preferences in an earlier release that contained those
preferences.
Make the Diameter and iSCSI dissectors register obsolete preferences.
Crash if some code tries to register a preferences module with a name
that contains something other than lower-case ASCII letters, numbers, or
underscores, or that has already been registered, or if some code tries
to register a preference with a name that contains something other than
lower-case ASCII letters, numbers, underscores, or periods, or that has
already been registered, so that we don't put code like that in a
release and have to shovel code into "prefs.c" to fix it up later. (The
problem with multiple modules or preferences with the same name should
be obvious; the problem with names with blanks, or upper-case letters,
or punctuation, is that they're a pain to type on the command line.)
svn path=/trunk/; revision=4148
the declarations of the functions to which a pointer to them is passed;
this also fixes it so it compiles with MSVC++, as there's no "uint" type
declared by MSVC++ by default.
svn path=/trunk/; revision=4054
The enclosed code contains the following improvements:
1 - Compatible with 08 version of the protocol
2 - Handles both header and data digests
3 - Supports desegmentation
4 - Dissects multiple PDUs per packet
5 - Stronger heuristics to avoid dissecting non-iSCSI packets
6 - General rationalisation and de-crufting!
The old code that attempted to automatically detect the presence
of a header digest has been removed. You now have to specify in
the iSCSI preferences whether digests are enabled and if they
are, whether they are CRC32 or not. If not CRC32, you also need
to specify the size of the digests (in bytes).
Another new option specifies the iSCSI port number. This is
used in the heuristics to filter out packets with silly port
numbers, set to 0 to disable the port filter.
One problem that I haven't been able to track down is that if
desegmentation is enabled and you turn digests on or off
ethereal throws a SEGV.
svn path=/trunk/; revision=4051
width of the item containing the bitfield is "n", so you don't have to
specify it explicitly, as you have to do with FT_BOOLEAN bitfields.
svn path=/trunk/; revision=4047
getting a pointer to the first byte of the string with "tvb_get_ptr()"
and then assuming you can safely do a "strlen()" with that pointer
(it's not guaranteed that you can, as the terminating null byte might
not be in the tvbuff).
Add the resulting string with "proto_tree_add_item()".
svn path=/trunk/; revision=3728
tvb_get_ptr(tvb, offset, length))" calls to "proto_tree_add_item()"
calls.
Do the same, in "packet-iscsi.c" and "packet-mrdisc.c", for
"proto_tree_add_uint()" and "proto_tree_add_boolean()" calls.
svn path=/trunk/; revision=3726