Commit Graph

25 Commits

Author SHA1 Message Date
Michael Mann bc40848385 Rework debug_print_hash logic so that it's supported by older versions of perl.
Change-Id: I1720681dc367e01268ffbb1f31035464fa642496
Reviewed-on: https://code.wireshark.org/review/971
Reviewed-by: Michael Mann <mmann78@netscape.net>
Tested-by: Michael Mann <mmann78@netscape.net>
2014-04-05 12:03:49 +00:00
Bill Meier f1f06014c4 (Trivial) Fix a typo.
Change-Id: Ib084b7e9d463c54fc836745833005b1456a82709
Reviewed-on: https://code.wireshark.org/review/518
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-05 15:29:57 +00:00
Jeff Morriss 82e2865739 Remove $Id$ and other Subversion leftovers from the tools.
There are a few things in here which could still use attention.

Don't regenerate anything now.

Change-Id: I283c224d3523212144707fca3d6265916cb11792
Reviewed-on: https://code.wireshark.org/review/205
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-14 01:35:57 +00:00
Bill Meier 19ffe7eb4c Update a comment; tweak a RegEx.
svn path=/trunk/; revision=47612
2013-02-10 18:40:54 +00:00
Bill Meier 233fcd672f Remove blank lines separately after removing comments rather than as
part of the 'remove comments' regex.

Fixes a bug introduced in SVN #47583 which broke '#if 0' handling.


svn path=/trunk/; revision=47598
2013-02-09 22:14:13 +00:00
Bill Meier 404460c14d Cleanup: Ditch CamelCase; use braces around references.
svn path=/trunk/; revision=47585
2013-02-09 16:28:01 +00:00
Bill Meier 7b40629a16 Fix a syntax error which causes a compile error
(altho not in my version Cygwin Perl V5.14 for some reason).

svn path=/trunk/; revision=47584
2013-02-09 14:52:02 +00:00
Bill Meier 4c41fd5df9 Tweaks to RegEx usage for consistency and performance (and
to fix a monor bug or two).

svn path=/trunk/; revision=47583
2013-02-09 14:25:18 +00:00
Bill Meier f5dd71e30e Fix code to delete blank lines to remove all blank lines;
Update some Perl usage.

svn path=/trunk/; revision=47569
2013-02-08 16:25:46 +00:00
Bill Meier 1e64a82f02 Add addition test to reduce false positives for 'ERROR: NO ARRAY: '
Essentially:
 Detect when an hf_... var is effictively initialized
 via the use of proto_registrar_get_id_byname() or
 proto_get_id_by_filter_name() (instead of
 proto_register_field_array()).

svn path=/trunk/; revision=47542
2013-02-07 22:16:39 +00:00
Bill Meier 669e68dfde Add a hack to fix false positive 'unused ...' related to use of ..._add_oui().
svn path=/trunk/; revision=47536
2013-02-07 19:36:29 +00:00
Bill Meier 64e97d9ec5 Fix a few minor bugs;
Do some small tweaks for readability & consistency.

svn path=/trunk/; revision=47532
2013-02-07 17:17:21 +00:00
Bill Meier 29b72be420 Add checking to verify that global hf_... defs are referenced in hf[] entry in same file.
(Commented out for now since a few false positives are currently generated).

Fix a few minor bugs;
Tweak the calling sequences for various subs.


svn path=/trunk/; revision=47476
2013-02-04 20:06:46 +00:00
Bill Meier 7fa9cf9209 Improvements:
- Handle preprocessed (as well as original) .c source files.
  (Running checkhf on the source after it has been pre-processed
   should give few false positives).
- Remove blank lines, comments & quoted text strings before
   doing the hf_... tests: reduces false positives/negatives.

svn path=/trunk/; revision=47458
2013-02-03 22:12:33 +00:00
Bill Meier d1ae197ae4 Re-implemention of checkhf.pl:
Main objective: reduce the number of false positives.

  (Committed as a patch to the original
   checkhf.pl written by Joerg Mayer so as to
   keep the history for the original program).


svn path=/trunk/; revision=47331
2013-01-28 22:23:32 +00:00
Bill Meier be4c8badd8 Handle hf_... definitions which are not static;
For .../dissectors/(non-generated dissectors):
 Reduces the number of "unused" false positives (and
 adds about 2 different false positives).

svn path=/trunk/; revision=47280
2013-01-25 20:12:09 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Jörg Mayer 462245ba9a Add a few comments and return with an error code if
appropriate, that way the whole stuff gets scriptable.
right now warnings are error code 0 (like completely
fine code).

svn path=/trunk/; revision=34730
2010-10-31 09:05:11 +00:00
Jeff Morriss 53ba99cd9b Say that an hf_ variable is used if we find "variable = hf_variable".
Add some debug statements.
Tweak one regexp to catch more hf_ variable uses.

svn path=/trunk/; revision=34684
2010-10-29 15:15:26 +00:00
Jeff Morriss 6683e22b44 Fix detection of hf entries being used in the hf array where the opening brace
is on the preceding line.  There was code here to do it but it needed to be
moved inside the preceding 'else' (in particular, before the 'next' sent us
around the loop again).

The bug was noticed by Alexis La Goutte in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5329 

svn path=/trunk/; revision=34623
2010-10-22 17:54:08 +00:00
Jörg Mayer e78edf4d28 Small comment fixes
svn path=/trunk/; revision=28519
2009-05-29 10:59:27 +00:00
Anders Broman 996d4db495 Ethereal->Wireshark
svn path=/trunk/; revision=18234
2006-05-28 19:49:07 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Jörg Mayer 33097899f8 Small update
svn path=/trunk/; revision=15860
2005-09-18 21:58:39 +00:00
Jörg Mayer 344fc629fc Add a tool to check the hf_ values.
svn path=/trunk/; revision=15611
2005-08-29 14:15:32 +00:00