GSM ENHANCED MEASUREMENT REPORT PDUs were not
dissected when present as L3_INFO in RSL MEAS_RES PDUs.
It seems that the RSL L3_INFO needs to be handled by a different dissector
depending on whether it contains a DTAP, SACCH or CCCH PDU, which fortunately
can be deduced from the RSL PDU type. packet-rsl.c is updated to implement
this.
In packet-gsm_a_rr.c the dissection of PDUs with RR Short PD format is
improved, and also some items are renamed to make clearer the difference
between SACCH PDUs (which cna be normal or Short PD format) and RR Short PD
format PDUs (which can occur on SACCH, CCCH, or DCH).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6699
svn path=/trunk/; revision=40357
support extended ICMP for multi-part messages as specified by
RFC 4884. Additionally, it adds support for the Interface Information Object
extension to ICMP as specified by RFC 5837.
1. RFC 4884 - This redefines certain ICMP messages to support multi-part
messages with extensions. It adds a length field to the ICMP header and defines
an extension structure to define extension objects that can be appended to the
selected ICMP messages. It retains backward compatibility with messages that do
not support the extensions defined by this RFC.
2. RFC 5837 - This defines an extension object to identify the interface and
next-hop information to selected ICMP messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6632
svn path=/trunk/; revision=40298
aspell and my own spelling preferences do not always agree with the spelling variations used by folks across the pond. Revert a couple of spelling changes.
svn path=/trunk/; revision=40275
Enable decryption of TLS 1.2.
Add some cipher suites from RFC5246 and RFC5289.
Fixed a bug in the handling of stream cipher.
(The explicit IV field in the application record doesn't exist when stream ciphers are used. But the original code handles it as if one-byte IV exists.)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6688
svn path=/trunk/; revision=40273
Make wireshark to support SKINNY new version
Current wireshark version can not support the new skinny packets when the header version == "14 00 00 00". It should be the same handling process with "12 00 00 00"(CM7_MSG_TYPE_B), So we added the same function to support CM7_MSG_TYPE_C(we defined it by ourselves, just want to keep the consistency with CM7_MSG_TYPE_B).
From me :
Fix encoding attribut (via fix-encoding.args.pl)
svn path=/trunk/; revision=40263
Dissector for the bzr smart server protocol
The attached patch adds basic support for dissecting the bzr smart server protocol ( http://wiki.wireshark.org/Bazaar ).
svn path=/trunk/; revision=40260
Dissector for the bzr smart server protocol
The attached patch adds basic support for dissecting the bzr smart server protocol ( http://wiki.wireshark.org/Bazaar ).
svn path=/trunk/; revision=40259
[Actually 1 g_malloc() + N tvb_memcpy() instead of
~ N g_malloc()/g_free() + N*(N+1)/2 tvb_memcpy() where N = number of chunks].
svn path=/trunk/; revision=40242
- New Config option to configure the sequence of frames using UDP
- an Info will be added, if the SCM UDID is not configured or if it is wrongly
configured, so that the user can act on it.
- SCM UDID will only be printed if configured correctly, if not a warning will
be added to inform, that the first byte for the UDID will be assumed to be 00
- UDP dissection can enforce the number of sub-package the dissection should
assume
- SSDO: isRequest is determined by it's field not by the message id
- SSDO: Unused code for SNMT Reset Guarding SCM has been removed
- SNMT: error_group and error_code for SN_FAIL have not been dissected
correctly
- Sercos III: bug != instead of ==, is fixed
- dissect_opensafety_udp renamed to dissect_opensafety_udpdata, because of
future dissector called opensafety_udp which will handle transport of
openSAFETY data over UDP
- dissect_opensafety_udpdata enhanced to determine the index of the given frame
in the package. Needed for correct assembly of COL_INFO
- Added heuristic dissector hook for opensafety_udp dissector. The dissector
will be submitted to this list at a future point
- Enhanced description of the dissector to reflect it's capabilities
- Reworked the description for the config options to be more understandable
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6672
svn path=/trunk/; revision=40214
Essentially: generate tvbuffs as needed; don't save them for later reuse
with the result they are never freed.
Also:
- move a struct from packet-nfs.h to packet-nfs.c since it's only used locally;
- reformat some long lines.
svn path=/trunk/; revision=40205
call, and using ep_address_to_str(), so it can handle any address type,
including AT_NONE if the source address isn't available.
svn path=/trunk/; revision=40196
protocol.
Point to an HP document o the protocol, and discuss the two ways to hook
up the dissector.
Don't bother checking the destination address - either the OUI/PID
suffices, or the MAC address is both necessary and, presumably,
sufficient and we need to introduce a heuristic dissector table for SNAP
frames. What's more, there's no guarantee that the destination address
is a MAC address - it might be absent, e.g. because you're capturing on
the Linux "any" device and are getting the "Linux cooked" header, with
only a destination address.
Don't put the source address into the Info column - it's already in the
source column *if* it exists (which it might not, for packets captured
from the "any" device and sent by the machine doing the capturing).
svn path=/trunk/; revision=40195
Actual problem:
A REAL_DATA tvbuff wasn't being added to the "data_sources"
for a frame. When displaying the frame, when a field referencing the tvb was selected
for display there was no 'hex bytes' tab for the field and so bytes ended up being
highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane
not related to the field).
Consider: Add some code in field creation (proto_tree_add...) to at least warn if
a field is being created using a tvb whose data_source is not in the
data_sources list for the frame ?
svn path=/trunk/; revision=40182
uninitialised. The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...
Also removed some unnecessary braces from switch cases (no local variables were defined).
svn path=/trunk/; revision=40181
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.
There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.
The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658
svn path=/trunk/; revision=40157
Do more length checks, so we reject trailers that have nothing to
dissect.
Test for the trailer length being >= 8, rather than for having the 0x08
bit set (they amount to the same thing, as the trailer length is <= 14,
and >= 8 is what we really want if we're checking whether there's a
timestamp).
svn path=/trunk/; revision=40142
Some commands and IEs from the current release of Asterisk are missing from the
IAX protocol dissector. This patch provides them.
svn path=/trunk/; revision=40141
ASCONF and ASCONF_ACK chunks have a "Sequence Number" field (RFC 5061, 4.1.1
and 4.1.2). The dissector wrongly calls it "Serial number". The attached patch
fixes this issue.
svn path=/trunk/; revision=40140
ZigBee ZCL Dissector reports invalid status
The status code 0x8d contained in an attriute status record in a configure reporting response frame is incorrectly displayed as "Write only" (where WRITE_ONLY = 0x8f). According to the ZigBee Cluster Library Specification, Document 075123r03ZB, April 26, 2010 a status of 0x8d should display as "INVALID_DATA_TYPE"
From me :
Fix this issue (Wrong value define) based on Specs available in ZigBee.org
svn path=/trunk/; revision=40133
Mesh Peering Management reason code field interpreted as status code
The Mesh Peering Management tag displays a status code instead of a reason code
svn path=/trunk/; revision=40132
It's tedious to parse the blockack bitmap by hand, showing it in wireshark
directly is much nicer. Attached patch does so, only for compressed BA for now.
From me: made it filterable.
svn path=/trunk/; revision=40126