osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
38605 commits 26 branches 0 tags 795 MiB
Commit graph

86 commits

Author SHA1 Message Date
Anders Broman
f5f746f54f From Mike Morrin: 
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.

There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.

The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658

svn path=/trunk/; revision=40157
 2011-12-12 07:24:57 +00:00
Anders Broman
2f5fc639dd From Pascal Quantin: 
updates the decoding of the Test Procedures functions
described in 3GPP 44.014, 34.109 and 36.509.
It also fixes a small issue where Wireshark was trying to decode the skip
indicator as a transaction identifier for those messages.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6638

svn path=/trunk/; revision=40064
 2011-12-01 20:09:01 +00:00
Bill Meier
54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier
d7a1840204 Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string(); 
Fix encoding arg as needed.

svn path=/trunk/; revision=39530
 2011-10-23 22:58:45 +00:00
Anders Broman
797c140887 Set ENC 
svn path=/trunk/; revision=39244
 2011-10-03 16:47:54 +00:00
Bill Meier
ad1efb6b9c (Trivial) Remove trailing whitespace from lines for a few files. 
svn path=/trunk/; revision=39084
 2011-09-21 23:42:55 +00:00
Anders Broman
eb31fad0b5 Add 3GPP Sv interface. 
svn path=/trunk/; revision=38271
 2011-07-30 14:05:55 +00:00
Anders Broman
0a65432f96 Use ENC_BIG_ENDIAN. 
svn path=/trunk/; revision=38135
 2011-07-20 14:09:19 +00:00
Anders Broman
7dce5861cc From Pascal Quantin: 
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
 2011-04-27 22:18:00 +00:00
Anders Broman
aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Anders Broman
ed66081a4d From Alexis La Goutte: 
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
 2011-02-23 13:51:49 +00:00
Anders Broman
a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Anders Broman
0e6aa74d54 From Pascal Quantin: 
NAS EPS] Fix display of Authentication (Failure) Parameter IEs

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5704

svn path=/trunk/; revision=36001
 2011-02-18 18:40:29 +00:00
Anders Broman
f108c58805 Complement to 
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477

svn path=/trunk/; revision=35483
 2011-01-11 20:02:30 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Bill Meier
b78ec52693 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
 2010-11-05 22:44:03 +00:00
Anders Broman
c522f01e2b From Pascal Quantin: 
[NAS EPS] Add dissection of special conformance testing functions

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278

svn path=/trunk/; revision=34394
 2010-10-06 14:33:27 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed. 
svn path=/trunk/; revision=32411
 2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
f8d7a4c4b4 Show the substrings of AUTN and AUTS. Expert info warnings 
when their lengths is not the expected one.

svn path=/trunk/; revision=31869
 2010-02-12 21:57:07 +00:00
Gerasimos Dimitriadis
fab0f16c18 Create FT_BYTES fields for the RAND, AUTN, SRES, XRES 
and AUTS octet strings in DTAP

svn path=/trunk/; revision=31859
 2010-02-10 22:34:34 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings 
svn path=/trunk/; revision=31557
 2010-01-18 21:49:47 +00:00
Guy Harris
68cf37f81b Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which 
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).

svn path=/trunk/; revision=31376
 2009-12-28 21:58:43 +00:00
Guy Harris
fb3fccfc67 Some SMS characters require more than 2 bytes when encoded as UTF-8; the 
maximum number of bytes required by UTF-8 for a single code point is 6 -
that's probably overkill here, as I don't think any *SMS* characters
require 6 bytes, but we'll go with an expansion factor of 6 anyway.

This fixes bug 4358.

svn path=/trunk/; revision=31365
 2009-12-27 21:33:28 +00:00
Gerasimos Dimitriadis
8c1b66f33a Expert info warning when Keypad Facility IE contains character that is 
not a DTMF digit

svn path=/trunk/; revision=31284
 2009-12-16 20:46:47 +00:00
Gerasimos Dimitriadis
021f402e5f Update CC Capabilities IE to decode ENICM and MCAT 
svn path=/trunk/; revision=31283
 2009-12-16 19:16:15 +00:00
Gerasimos Dimitriadis
060ac76f82 Show spare bits under the IEs they belong 
svn path=/trunk/; revision=31144
 2009-12-01 20:19:01 +00:00
Gerasimos Dimitriadis
8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area 
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
 2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
029f3641ae Basic support for the DTAP User-User IE; print bitfields in a way more 
similar to proto_tree_add_bits_item(); Minor comment edits

svn path=/trunk/; revision=31057
 2009-11-23 20:23:30 +00:00
Gerasimos Dimitriadis
55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in 
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
 2009-11-18 20:39:14 +00:00
Gerasimos Dimitriadis
c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Gerasimos Dimitriadis
4dbe3a5e3a Fix for bug 4209: 
After reading a SysID group, current_offset was off by 1 


svn path=/trunk/; revision=30847
 2009-11-06 21:20:17 +00:00
Anders Broman
67697bad60 From Gerasimos Dimitriadis: 
DTAP: Update of Reject Cause IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4179

svn path=/trunk/; revision=30759
 2009-10-29 18:13:17 +00:00
Anders Broman
53e44c4a73 From Gerasimos Dimitriadis: 
DTAP: MAP component of indefinite length within Facility IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4157

svn path=/trunk/; revision=30688
 2009-10-25 10:14:47 +00:00
Anders Broman
9db0d46eba Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len); 
svn path=/trunk/; revision=30671
 2009-10-23 05:32:15 +00:00
Anders Broman
ea679ff697 From Gerasimos Dimitriadis: 
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150

svn path=/trunk/; revision=30670
 2009-10-23 02:12:39 +00:00
Anders Broman
3faf5345ab From Gerasimos Dimitriadis: 
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146

svn path=/trunk/; revision=30661
 2009-10-22 05:28:53 +00:00
Anders Broman
f5f2bf6ecd From Gerasimos Dimitriadis: 
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145

svn path=/trunk/; revision=30655
 2009-10-21 09:38:51 +00:00
Anders Broman
e12ab4d346 From Gerasimos Dimitriadis: 
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143

svn path=/trunk/; revision=30637
 2009-10-20 14:42:58 +00:00
Anders Broman
923b04dd82 From Gerasimos Dimitriadis: 
DTAP: Various enhancements.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142

svn path=/trunk/; revision=30628
 2009-10-20 07:33:01 +00:00
Anders Broman
77c3bfd8c1 From Gerasimos Dimitriadis: 
DTAP: Decoding of Text String in Network Name IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4121

svn path=/trunk/; revision=30571
 2009-10-16 10:38:42 +00:00
Anders Broman
d31ddb200f From Gerasimos Dimitriadis: 
DTAP: Facility IE resets PROTOCOL and INFO columns

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4110

svn path=/trunk/; revision=30545
 2009-10-12 15:38:16 +00:00
Anders Broman
5ba10f7062 From Gerasimos Dimitriadis: 
DTAP: Decoding of Emergency Number List IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4111

svn path=/trunk/; revision=30544
 2009-10-12 15:32:53 +00:00
Anders Broman
330b2ce091 From Gerasimos Dimitriadis: 
DTAP: Wrong decoding of ITC in Bearer Capability IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4108

svn path=/trunk/; revision=30426
 2009-10-09 10:14:00 +00:00
Stig Bjørlykke
be0f4aa44b Moved the block for second octet to avoid a warning about an uninitialized 
variable.

svn path=/trunk/; revision=30332
 2009-10-05 16:36:31 +00:00
Anders Broman
131296f6f0 From Gerasimos Dimitriadis: 
DTAP decoding of Alerting Pattern IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4072

svn path=/trunk/; revision=30242
 2009-10-01 18:38:14 +00:00
Kovarththanan Rajaratnam
65c53fedb6 Don't guard col_append_str with check_col 
svn path=/trunk/; revision=30125
 2009-09-24 20:00:21 +00:00
Anders Broman
b8af7c77c8 From Gerasimos Dimitriadis: 
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

svn path=/trunk/; revision=30064
 2009-09-22 06:42:10 +00:00