Commit graph

69 commits

Author SHA1 Message Date
Anders Broman
f5f746f54f From Mike Morrin:
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.

There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.

The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658

svn path=/trunk/; revision=40157
2011-12-12 07:24:57 +00:00
Anders Broman
ae8165fd4c Fix some set but not used [-Wunused-but-set-variable] warnings.
svn path=/trunk/; revision=39579
2011-10-25 20:08:26 +00:00
Bill Meier
8fc194c881 Fix a 'set but not used' compiler warning.
svn path=/trunk/; revision=39430
2011-10-15 20:39:35 +00:00
Anders Broman
0a65432f96 Use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=38135
2011-07-20 14:09:19 +00:00
Anders Broman
7dce5861cc From Pascal Quantin:
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00
Anders Broman
a7d7365f4a Mark pinfo as unused.
svn path=/trunk/; revision=36445
2011-04-04 15:09:22 +00:00
Anders Broman
aaf0d277b8 Get rid of gsm_a_dtap_pinfo.
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
a469849210 From Pascal Quantin:
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
2011-02-22 11:56:10 +00:00
Stephen Fisher
1980a286ac Fix compilation error: gsm_a_dir_of_ver_speed_vals is a VALS not a TFS.
svn path=/trunk/; revision=35739
2011-02-01 00:46:59 +00:00
Anders Broman
882874e91c More IE dissection.
svn path=/trunk/; revision=35736
2011-01-31 22:25:19 +00:00
Stephen Fisher
53fec4ae34 Fix compilation errors
svn path=/trunk/; revision=35673
2011-01-26 23:11:08 +00:00
Anders Broman
68f4f61017 Dissect PS-HANDOVER-REQUEST.
svn path=/trunk/; revision=35666
2011-01-26 19:44:23 +00:00
Anders Broman
57f8048743 Add 10.5.1.14 NAS container for PS HO.
svn path=/trunk/; revision=35665
2011-01-26 19:37:30 +00:00
Anders Broman
dd1ab4b227 Use EXTRANEOUS_DATA_CHECK_EXPERT
svn path=/trunk/; revision=35608
2011-01-21 09:31:25 +00:00
Anders Broman
cbc7cbd1b2 Handle two length octets correctly in TELV.
svn path=/trunk/; revision=35573
2011-01-17 21:12:30 +00:00
Anders Broman
fe7213590b Restore dissection of Mobile Identity(revert the code).
svn path=/trunk/; revision=35567
2011-01-17 14:18:54 +00:00
Anders Broman
862e2d498c - Add TELV to dissct IE's with an extention bit in the length vallue.
- Add a BSSGP PDU type
- Put IE name in the top tree for ELEM_V

svn path=/trunk/; revision=35539
2011-01-14 21:43:31 +00:00
Anders Broman
f108c58805 Complement to
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477

svn path=/trunk/; revision=35483
2011-01-11 20:02:30 +00:00
Anders Broman
852c75636e Improve dissection of UE Time Zone.
svn path=/trunk/; revision=35477
2011-01-11 17:06:38 +00:00
Anders Broman
356aced5bf Start of a SGSAP (TS 29.118) dissector for LTE.
svn path=/trunk/; revision=35266
2010-12-26 21:06:08 +00:00
Anders Broman
348e0bc54b Use value_string_ext for gsm_a_rr_rxlev_vals.
svn path=/trunk/; revision=34818
2010-11-09 07:28:04 +00:00
Gerald Combs
62087e2eab Remove an unused variable.
svn path=/trunk/; revision=32607
2010-04-29 22:35:00 +00:00
Anders Broman
447faa6082 From Mike Morrin:
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
2010-04-29 20:45:53 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Gerasimos Dimitriadis
448b9a5199 Fix for Bug 4480:
Octet containing first digit of IMEI(SV) highlighted
when IMEI(SV) selected

svn path=/trunk/; revision=31868
2010-02-12 20:52:54 +00:00
Gerasimos Dimitriadis
8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Gerasimos Dimitriadis
299d64d458 Use range_string for the decoding of the CN specific DRX
cycle length coefficient; fixed the decoding of unknown 
values for Split PG Cycle Code; updated function for
Identity Type 2, now spare bit is explicitly shown; Reuse
the definition of the Switch-Measure-Switch values from
packet-gsm_a_common.c

svn path=/trunk/; revision=31060
2009-11-23 23:02:02 +00:00
Gerasimos Dimitriadis
029f3641ae Basic support for the DTAP User-User IE; print bitfields in a way more
similar to proto_tree_add_bits_item(); Minor comment edits

svn path=/trunk/; revision=31057
2009-11-23 20:23:30 +00:00
Gerasimos Dimitriadis
55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
2009-11-18 20:39:14 +00:00
Anders Broman
1ef7157d71 From Gerasimos Dimitriadis:
Mobile Classmark3 wrong dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4082

svn path=/trunk/; revision=30372
2009-10-06 18:51:11 +00:00
Stig Bjørlykke
0488967f29 Corrected check for dtmEgprsHighMultiSlotClassPresent.
svn path=/trunk/; revision=30331
2009-10-05 16:33:41 +00:00
Jeff Morriss
3f5d86d86b From Gerasimos Dimitriadis via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4020 :
Associated Radio Capability 1 should not be added to a subtree, but to the IE
tree.

svn path=/trunk/; revision=29945
2009-09-16 13:45:58 +00:00
Anders Broman
6aed88fadc From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891

svn path=/trunk/; revision=29399
2009-08-13 07:56:13 +00:00
Anders Broman
088110624e From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886

svn path=/trunk/; revision=29398
2009-08-12 22:40:13 +00:00
Anders Broman
6c2c08c082 From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R4 and R5).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866

svn path=/trunk/; revision=29377
2009-08-11 12:22:00 +00:00
Anders Broman
6c352a2959 From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3819

svn path=/trunk/; revision=29368
2009-08-10 19:48:42 +00:00
Bill Meier
b38516fbd9 Fix some indentation and spacing
svn path=/trunk/; revision=29314
2009-08-06 21:42:40 +00:00
Jaap Keuter
b5aa261da6 From Gerasimos Dimitriadis:
Fixes/enhances the decoding of the Mobile Identity IE for type of identity
"TMGI and optional MBMS Session Identity".

svn path=/trunk/; revision=29307
2009-08-05 18:42:45 +00:00
Anders Broman
f0d16b990f From Gerasimos Dimitriadis:
Minor enhancement to LAI decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3770

svn path=/trunk/; revision=29182
2009-07-23 20:36:16 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman
1b5af9ff1f Updates to Jun spec. version.
svn path=/trunk/; revision=28706
2009-06-11 16:26:31 +00:00
Jaap Keuter
e93d5f5314 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28211
2009-05-01 07:08:59 +00:00
Anders Broman
13282b7a7c Add value strings and code clenup.
svn path=/trunk/; revision=27944
2009-04-03 16:19:12 +00:00
Anders Broman
0d2fb53b74 - Fix APDU dissection.
- NAS EPS bugfixes and enhancements.

svn path=/trunk/; revision=27778
2009-03-18 19:40:54 +00:00
Anders Broman
2db386dfd4 - Use correct length in TLV-E and LV-E.
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.

svn path=/trunk/; revision=27605
2009-03-04 19:51:55 +00:00
Anders Broman
5e2ccb0ecd Some more NAS updates.
svn path=/trunk/; revision=27147
2009-01-01 22:54:30 +00:00