Bill Meier
95977fcc8b
Fix a memory leak of a tvb.
...
svn path=/trunk/; revision=40163
2011-12-13 00:02:30 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
293049dfba
Do some conversions of proto_tree_add_item() 'encoding' arg.
...
(previously missed).
57 FT_BOOLEAN: FALSE-->ENC_BIG_ENDIAN
31 FT_BOOLEAN: TRUE-->ENC_LITTLE_ENDIAN
10 FT_BYTES: ENC_BIG_ENDIAN-->ENC_NA
1 FT_BYTES: ENC_LITTLE_ENDIAN-->ENC_NA
21 FT_BYTES: FALSE-->ENC_NA
2 FT_BYTES: TRUE-->ENC_NA
2 FT_IPXNET: ENC_BIG_ENDIAN-->ENC_NA
6 FT_IPv6: ENC_BIG_ENDIAN-->ENC_NA
1 FT_IPv6: FALSE-->ENC_NA
6 FT_NONE: ENC_BIG_ENDIAN-->ENC_NA
19 FT_NONE: FALSE-->ENC_NA
3 FT_NONE: TRUE-->ENC_NA
1 FT_STRING: ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA
1 FT_STRING: ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA
5 FT_STRING: FALSE-->ENC_ASCII|ENC_NA
1 FT_STRING: TRUE-->ENC_ASCII|ENC_NA
4 FT_STRINGZ: ENC_NA-->ENC_ASCII|ENC_NA
8 FT_STRINGZ: FALSE-->ENC_ASCII|ENC_NA
1 FT_INT32: FALSE-->ENC_BIG_ENDIAN
1 FT_INT32: TRUE-->ENC_LITTLE_ENDIAN
11 FT_UINT8: 0-->ENC_BIG_ENDIAN
111 FT_UINT8: FALSE-->ENC_BIG_ENDIAN
17 FT_UINT8: TRUE-->ENC_LITTLE_ENDIAN
1 FT_UINT16: 0-->ENC_BIG_ENDIAN
68 FT_UINT16: FALSE-->ENC_BIG_ENDIAN
18 FT_UINT16: TRUE-->ENC_LITTLE_ENDIAN
4 FT_UINT24: FALSE-->ENC_BIG_ENDIAN
70 FT_UINT32: FALSE-->ENC_BIG_ENDIAN
1 FT_UINT32: TRUE-->ENC_LITTLE_ENDIAN
4 FT_UINT64: FALSE-->ENC_BIG_ENDIAN
1 FT_UINT64: TRUE-->ENC_LITTLE_ENDIAN
1 FT_UINT_STRING: FALSE-->ENC_ASCII|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39442
2011-10-16 23:38:49 +00:00
Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman
b87f9143e4
Get rid of check_col, while at it set ENC.
...
svn path=/trunk/; revision=39149
2011-09-26 14:50:59 +00:00
Stig Bjørlykke
5359494b1f
Second try to move crc routines to libwsutil.
...
This time keep the tvb routines in epan.
Now we can use common crc routines outside epan.
svn path=/trunk/; revision=38810
2011-08-31 09:00:54 +00:00
Stig Bjørlykke
71f903b956
Revert r38800, as the crc routines contains some tvb functions.
...
svn path=/trunk/; revision=38803
2011-08-30 14:17:40 +00:00
Stig Bjørlykke
4132d40e50
Move all crc routines to libwsutil.
...
This way we can use the crc routines in wiretap.
svn path=/trunk/; revision=38800
2011-08-30 13:46:42 +00:00
Bill Meier
fb54240c34
Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
...
Also: misc minor cleanup: unneeded #include; whitespace, tvb_length-->tvb_reported_length
svn path=/trunk/; revision=37757
2011-06-22 23:03:56 +00:00
Chris Maynard
dac93d45dd
Delete 2 assignments to 'i' as neither were used. Fixes Coverity CID 875.
...
svn path=/trunk/; revision=37132
2011-05-13 19:29:15 +00:00
Stig Bjørlykke
84bc28bd6a
Introduce "Fragment count" filter element for all protocols doing reassembly.
...
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Jeff Morriss
705f2ede5d
Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
...
of going through a temporary variable). This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.
Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.
svn path=/trunk/; revision=35593
2011-01-20 03:49:44 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Stig Bjørlykke
539b558f8c
Renamed some reassembled data texts.
...
Removed some check_col().
svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
Stig Bjørlykke
88b72356ad
Introduce "Reassembled length" filter element for all protocols doing
...
reassembly.
svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Anders Broman
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68
Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman
c91a384702
Apply some of the patches from:
...
http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier
fef69c8dd3
FT_BOOLEAN fields with bitmask: Display is 'parent bitfield width' not BASE...
...
Use consistent indentation.
svn path=/trunk/; revision=28307
2009-05-08 17:48:23 +00:00
Gerald Combs
6d04f793f0
Back out r27047 and r27053.
...
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs
fc71188963
Update calls to proto_tree_add_bytes_format to reflect r27047.
...
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Anders Broman
6771996389
Fix Bug 2860 Malformed Packet DCP ETSI error with UDP packet length 9 by
...
not accepting packages shorter than 10 bytes in the heuristic(min header length).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2860
svn path=/trunk/; revision=26311
2008-09-30 18:15:09 +00:00
Bill Meier
ffa7320de2
Minor cleanup related to proto_register & proto_reg_handoff
...
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Bill Meier
5f26848657
prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
...
svn path=/trunk/; revision=26081
2008-08-25 19:53:32 +00:00
Bill Meier
f8e3822738
Fix some warnings reported by gcc -Wshadow ...
...
Fix some spacing in packet-dcom.c
svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Gerald Combs
09360857b8
Don't try to reassemble a huge number of fragments.
...
svn path=/trunk/; revision=23463
2007-11-15 19:38:04 +00:00
Jeff Morriss
d47443ba38
Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks.
...
svn path=/trunk/; revision=22542
2007-08-17 21:21:50 +00:00
Ronnie Sahlberg
10588355f9
move some variable declarations to the start of the block.
...
many compilers do not support the nonstandard feature to declare variables in the middle of a block.
svn path=/trunk/; revision=21012
2007-03-09 20:02:25 +00:00
Gerald Combs
0e181d05c8
Fix for bug 1264 from Julian Cable:
...
I've refactored the offending code branch and added some comments so
hopefully the intent is a bit clearer. The loop termination conditions
are now obviously independent of the content on the wire (they were
meant to be before, but I admit it was obscure). I've tried using the
ephemeral memory routines.
Add a check for a maximum fragment count, and bail out of reassembly instead
of triggering an ep_alloc exception. Add Julian to AUTHORS. Update the
release notes.
svn path=/trunk/; revision=21007
2007-03-09 01:40:30 +00:00
Bill Meier
09f508b57b
A few more ethereal --> wireshark
...
svn path=/trunk/; revision=20559
2007-01-26 01:34:29 +00:00
Gerald Combs
c5a181d425
Remove dead code. Fixes Coverity CID 228. Squelch various compiler warnings.
...
svn path=/trunk/; revision=20553
2007-01-25 07:06:47 +00:00
Anders Broman
1509562c0f
From Julian Cable:
...
New dissector for ETSI DCP (ETSI TS 102 821).
Code rearranged to look more like other Wireshark dissectors and some warnings/errors
on Windows fixed.
svn path=/trunk/; revision=19981
2006-11-25 13:03:48 +00:00