Commit graph

76 commits

Author SHA1 Message Date
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman
ab901be153 Get rid of check_col, while at it set ENC.
svn path=/trunk/; revision=39148
2011-09-26 11:33:10 +00:00
Jeff Morriss
339136d1d0 Based on patch from Denis Ovsienko via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
2011-08-16 13:16:33 +00:00
Guy Harris
c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Gerald Combs
b223e99e5a get_host_ipaddr() was returning numeric addresses in host byte order
and hostnames in network byte order. Have it return everything in
network byte order.

svn path=/trunk/; revision=36873
2011-04-26 17:13:37 +00:00
Jeff Morriss
067a076179 Use tvb_ip_to_str().
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35545
2011-01-16 03:29:03 +00:00
Jeff Morriss
47e2d75820 Move some code (including the optional objects) into libwsutil
svn path=/trunk/; revision=33012
2010-05-28 20:19:55 +00:00
Jeff Morriss
0eb841fdf7 Fix the fuzz failure found in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4685 :

Don't store pointers to g_malloc()'d memory (in this case GLists) in
se_alloc()'d memory: the se_alloc()'d memory is freed before the reinit
functions are called so it's no longer safe to use.

svn path=/trunk/; revision=32490
2010-04-16 14:48:30 +00:00
Bill Meier
9a3b1a78d1 Fix some memory leaks; Fix some indentation.
This is a re-submission of SVN #31838 this time
properly using g_list_free() instead of g_free().

svn path=/trunk/; revision=31848
2010-02-09 17:48:41 +00:00
Bill Meier
9fc016d8b9 Revert SVN #31838; It's NG.
svn path=/trunk/; revision=31847
2010-02-09 14:43:30 +00:00
Bill Meier
b3be21c93b Fix some memory leaks; Fix some indentation.
svn path=/trunk/; revision=31838
2010-02-08 23:45:10 +00:00
Stig Bjørlykke
e9977dda66 Removed an unused variable.
svn path=/trunk/; revision=30880
2009-11-09 14:08:54 +00:00
Stig Bjørlykke
f47bd1e8bf Make ett_* values static.
svn path=/trunk/; revision=30508
2009-10-11 14:33:04 +00:00
Stig Bjørlykke
d200281ff6 Initialize u32BoundElements.
svn path=/trunk/; revision=30333
2009-10-05 16:40:38 +00:00
Kovarththanan Rajaratnam
17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Stig Bjørlykke
4d8dd01e8e Changed flags_set_truth -> tfs_set_notset
svn path=/trunk/; revision=28989
2009-07-07 14:54:15 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Ulf Lamping
597ee656db try to fix some solaris buildbot warnings
svn path=/trunk/; revision=27449
2009-02-14 01:18:11 +00:00
Bill Meier
8afa208ffb Windows build: #include winsock2.h only when needed.
#include winsock2.h pulls in about 90 distinct .h files
and about 140 total .h files. 
Currently winsock2.h is (mostly unnecessarily) included
for each dissector via packet.h/wtap.h.
This patch removes #include winsock2.h from wtap.h and 
then includes winsock2.h (or windows.h) in the 
few specific places required. 
With this patch, my Windows Wireshark build takes 
about 30% less time.


svn path=/trunk/; revision=26535
2008-10-24 00:42:09 +00:00
Bill Meier
119d449880 Fix a bit more spacing
svn path=/trunk/; revision=26506
2008-10-20 21:38:53 +00:00
Bill Meier
6da6ad6451 Oops ! Revert (Remove) development stuff ....
svn path=/trunk/; revision=26505
2008-10-20 21:14:21 +00:00
Bill Meier
145e8f7b74 Adjust indentation to be more consistent ....
svn path=/trunk/; revision=26504
2008-10-20 20:51:04 +00:00
Bill Meier
a14b7b5264 Addt'l minor cleanup
svn path=/trunk/; revision=26279
2008-09-26 17:12:15 +00:00
Bill Meier
c60c77ba4a prefs callback not req'd
svn path=/trunk/; revision=26278
2008-09-26 17:06:44 +00:00
Bill Meier
f8e3822738 Fix some warnings reported by gcc -Wshadow ...
Fix some spacing in packet-dcom.c

svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Stig Bjørlykke
677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Stephen Fisher
c38ff43591 Fix compilation on OS X with GLib 1.2 by including ctype.h since our
isprint.h override only kicks in for GLib 2+.


svn path=/trunk/; revision=22125
2007-06-18 01:42:17 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris
1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Stephen Fisher
8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Stephen Fisher
ab8f589336 Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors
svn path=/trunk/; revision=21233
2007-03-27 22:50:11 +00:00
Ulf Lamping
0f8dbb8dc2 correct multidimensional SAFEARRAYs
svn path=/trunk/; revision=21123
2007-03-22 22:41:16 +00:00
Guy Harris
a0fecf54bd Correctly return the item value through the pointer.
svn path=/trunk/; revision=21030
2007-03-14 18:25:19 +00:00
Ulf Lamping
7887d478cc add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Bill Meier
103bf29730 Continuing the tradition: squelch some compiler warnings ....
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Ulf Lamping
0f7e40945e dissector changes:
- new: ICBALogicalDevice2::PBAddressInfo
- enhanced: GROUPERRORDEF

simplify ett registration
add a callback for SAFEARRAY data dissection

svn path=/trunk/; revision=20723
2007-02-06 01:33:39 +00:00
Jaap Keuter
5f955a0fcc From Albert Chin:
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX,
ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there
are other uses of g_ntohl().

svn path=/trunk/; revision=19844
2006-11-07 07:39:16 +00:00
Jörg Mayer
b9c69db9d3 Remove some // comments.
Fix a warning about nested comments.

svn path=/trunk/; revision=19828
2006-11-06 19:56:11 +00:00
Jaap Keuter
7ded21f336 Squelch compiler warnings
svn path=/trunk/; revision=19597
2006-10-18 19:42:10 +00:00
Ulf Lamping
4a03300106 distinguish between things "ToBeDone" and "NoSpecificationAvailable" as some DCOM things are just unknown and cannot be implemented therefore
svn path=/trunk/; revision=19174
2006-09-07 20:30:48 +00:00
Ulf Lamping
4ad1f977d2 add a new this/that flag value
svn path=/trunk/; revision=19066
2006-08-28 21:14:36 +00:00
Guy Harris
7cb6f60b18 Fix some format strings and format string arguments.
svn path=/trunk/; revision=18957
2006-08-19 03:01:15 +00:00
Ulf Lamping
7d04019388 some further work on the GUID/UUID resolvings
most of the relevant code moved to guid_utils
lot of corresponding code cleanup in packet-dcerpc.c
still using GHashTable
still not using a manuf like file

svn path=/trunk/; revision=18939
2006-08-17 19:09:41 +00:00
Ulf Lamping
de0594b9a5 various UUID/GUID based changes.
I think I've changed all corresponding appearances from FT_STRING to FT_GUID, so assert the FT_ type as it should only be a FT_GUID now.

Add a generic implementation in guid_utils.h to have a way to store data about GUID to name resolving (something like value_string for e.g. int). It might be better to have a single registry for all GUID's of all dissectors and implement the GUID name resolving into the proto_tree_add... functions.

svn path=/trunk/; revision=18935
2006-08-16 23:13:26 +00:00
Ulf Lamping
b2751079ac various minor DCOM dissection enhancements:
- add a generic guid register to dissect UUID's (move this to a seperate file?)
- this enables us to set some known names for special UUID's
- use standard DCOM fields for IID and alike in remunk.c
- cleanup dcom_protseq_vals handling
- some FT_STRING to FT_GUID changes

svn path=/trunk/; revision=18904
2006-08-14 23:39:48 +00:00
Ulf Lamping
d0aed5f920 add an experimental DCOM object "database" based on the exchanged interface pointers
add a lot more PROFINET CBA dissection output based on these DCOM context information
still need some improvements, e.g. dissection uses a simple (slow) linear list search
changes are fuzz-tested

svn path=/trunk/; revision=18882
2006-08-11 19:15:12 +00:00
Ulf Lamping
692a3adfbb remove two old comments
svn path=/trunk/; revision=18632
2006-07-01 12:13:54 +00:00
Ulf Lamping
690bfd0bff add dissection of custom marshalled OBJREF's (as far as known)
svn path=/trunk/; revision=18596
2006-06-28 18:51:24 +00:00
Ulf Lamping
39e7f020e6 fix the hresult "filter" fields
svn path=/trunk/; revision=18469
2006-06-15 11:42:47 +00:00
Ulf Lamping
aa748fc102 dcom_tvb_get_nwstringz0(): convert output to hexdump if the string contains nonprintable characters
svn path=/trunk/; revision=18453
2006-06-13 18:18:53 +00:00