Commit graph

61 commits

Author SHA1 Message Date
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Anders Broman
6bde918078 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
Bill Meier
1823aa007c it's ==> its & its ==> it's as needed.
svn path=/trunk/; revision=47891
2013-02-26 01:06:19 +00:00
Bill Meier
c439b805e2 Comment out unused hf[] entries & etc.
(found by checkhf)

svn path=/trunk/; revision=47389
2013-01-31 17:55:31 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Bill Meier
832b999c2c - Don't call col...() under 'if (tree)';
- Move proto_reg_handoff...() to the end of the file;
- Remove some uneeded variable initialization;
- Use consistent indentation (e.g., no 4 space tabs) and whitespace formatting.

svn path=/trunk/; revision=44541
2012-08-16 15:53:39 +00:00
Bill Meier
638d74d43f Use val_to_str_const() where appropriate;
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Guy Harris
6a92b2a472 Get rid of non-ASCII character.
svn path=/trunk/; revision=42569
2012-05-11 08:29:40 +00:00
Anders Broman
3cf5f7412a Correct wrong value in h264_level_bitrate_values
svn path=/trunk/; revision=42559
2012-05-11 05:21:22 +00:00
Anders Broman
f7b39033d4 Unescape NAL units
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6975

svn path=/trunk/; revision=41739
2012-03-22 15:10:14 +00:00
Bill Meier
54b72021bb Fix encoding arg for various fcn calls:
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Anders Broman
0f2e6c6cc5 Get rid of check_col, while at it set ENC.
svn path=/trunk/; revision=39164
2011-09-27 12:05:32 +00:00
Bill Meier
2bf572bc41 Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,...
svn path=/trunk/; revision=38413
2011-08-08 17:59:32 +00:00
Alexis La Goutte
c127eb2d51 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36702
2011-04-18 17:47:16 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Anders Broman
3f9913f7ed Do DISSECTOR_ASSERT_NOT_REACHED(); if golmb coded data is > 32 bits.
svn path=/trunk/; revision=33778
2010-08-11 21:56:19 +00:00
Stig Bjørlykke
7de3dc3167 Call tvb_get_bits32() if leading_zero_bits > 16.
svn path=/trunk/; revision=33775
2010-08-11 21:37:04 +00:00
Jaap Keuter
55528cacba From Chidambaram Arunachalam:
Currently, H.264 dissector in Wireshark allows only one value for the "H264 
dynamic payload type" preference value.
This patch allows users to specify a value range for this parameter (96-127) 
so that both streams can be decoded for a video call with asymmetric rtp 
payload types.

svn path=/trunk/; revision=32831
2010-05-16 10:58:50 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Jeff Morriss
d163d9cad7 Remove non-ASCII characters
svn path=/trunk/; revision=30656
2009-10-21 12:56:28 +00:00
Anders Broman
a85999a691 Fix higlight the correct hex value and add a value_string.
svn path=/trunk/; revision=30629
2009-10-20 07:42:27 +00:00
Kovarththanan Rajaratnam
17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier
08ab843143 Fix two usages of non-ascii characters.
svn path=/trunk/; revision=28019
2009-04-09 12:41:40 +00:00
Anders Broman
184a60e0d6 Handle NAL-unit start code correctly.
svn path=/trunk/; revision=27894
2009-03-30 16:35:58 +00:00
Anders Broman
564e51f8cc - Dissect Supplemental enhancement information (SEI).
- Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27886
2009-03-29 16:08:17 +00:00
Anders Broman
e1eed93101 Start code is 24 bits, use bit_offset to read it.
svn path=/trunk/; revision=27302
2009-01-26 20:08:12 +00:00
Anders Broman
a0e2569109 Dissect DecoderConfiguration in h245.
svn path=/trunk/; revision=26969
2008-12-11 20:35:19 +00:00
Bill Meier
66f5c47447 Trivial changes related to proto_reg_handoff
svn path=/trunk/; revision=26914
2008-12-04 20:10:16 +00:00
Anders Broman
23e9b1de65 Add bitrate values to levels.
svn path=/trunk/; revision=26753
2008-11-11 20:38:29 +00:00
Anders Broman
cacf4e9a14 Bugfixes:
- Wrong item lengths.
- rtsp traling bits gave"Malformed packet" if not present.
- Frame_num removed as length needs info from previous packet.

svn path=/trunk/; revision=26744
2008-11-10 20:20:11 +00:00
Jaap Keuter
1bc4ea382c From Sebastian Stollenwerk:
While sniffing h264-packets with more than 8 leading zero bits they're displayed in error: fixed.
If there are FU-A(28) encoded packets, you can't see them in Wireshark: upgraded.

svn path=/trunk/; revision=26549
2008-10-25 10:32:01 +00:00
Bill Meier
c5ebd555b7 Trivial changes: comment and spacing
svn path=/trunk/; revision=26251
2008-09-23 00:45:05 +00:00
Bill Meier
6aa5f8aa6a Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26246
2008-09-22 16:26:41 +00:00
Jaap Keuter
2b04d42e4b From Shinsuke SUZUKI:
Since this leads to a compilation failure (Warning C4819: unexpected character
in the current code page) on non-european Windows, I'd like you to avoid using
non-ASCII characters in Wireshark code (even in comment).

svn path=/trunk/; revision=25214
2008-05-02 08:23:21 +00:00
Stig Bjørlykke
b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Stig Bjørlykke
28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Anders Broman
6e0a5815e3 Correct a typo.
svn path=/trunk/; revision=24130
2008-01-18 05:55:58 +00:00
Anders Broman
6bcc12eabb More Generic parameters.
svn path=/trunk/; revision=24022
2008-01-07 19:16:26 +00:00
Tomas Kukosa
a8e80e0cc9 put capability parameters into a table
svn path=/trunk/; revision=23992
2008-01-03 08:14:28 +00:00
Anders Broman
fe35806343 Add decoding of most of the generic parameters from H.241 and 3gpp.
svn path=/trunk/; revision=23987
2008-01-02 14:05:16 +00:00
Stig Bjørlykke
1bdcd82f19 Mark some unused parameters with _U_.
Added a missing return value.

svn path=/trunk/; revision=23986
2008-01-02 11:34:35 +00:00
Tomas Kukosa
b1e1b232aa dissect some capability parameters
svn path=/trunk/; revision=23985
2008-01-02 11:09:36 +00:00
Stig Bjørlykke
74f01ee7c6 Initialize se_value to avoid a warning.
svn path=/trunk/; revision=23972
2007-12-29 11:29:36 +00:00
Anders Broman
779e204759 Handle se(v) encoding and minor bug fixes.
svn path=/trunk/; revision=23971
2007-12-29 09:55:02 +00:00
Stig Bjørlykke
67261c278c Comment out unused code.
svn path=/trunk/; revision=23891
2007-12-16 20:27:55 +00:00