79b3d4e32f
From Hauke Mehrtens via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8567
...
[PATCH 1/8]
Add a subtree for the random DTLS elements. This is what TLS already does, and
it makes more sense than prefixing their display names.
[PATCH 2/8]
Show the actual hex content of the cookie by just using proto_tree_add_item.
The cookie length has its own field, so there's no need to display it twice.
[From me]
Fix an @ in the AUTHORS file
svn path=/trunk/; revision=49172
2013-05-05 13:49:49 +00:00
9d6d7f78c3
Remove an unnecessary header include.
...
svn path=/trunk/; revision=49171
2013-05-05 11:32:00 +00:00
2a9201a34f
Remove if (tree) so expert_info will always be called.
...
svn path=/trunk/; revision=49170
2013-05-05 11:02:42 +00:00
e70f754cff
Yet another protocol update via
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616
svn path=/trunk/; revision=49165
2013-05-04 23:37:02 +00:00
23f134d48e
From Joe McEachern via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8614
...
Add tcp.analysis.spurious_retransmission. Although RFC 793 does not define
spurious TCP retransmissions, TCP spurious retransmissions are referenced in
other RFCs and research.
svn path=/trunk/; revision=49160
2013-05-04 12:37:01 +00:00
648ac74b5e
Fix errors found by fix-encoding-args tools
...
svn path=/trunk/; revision=49158
2013-05-04 08:12:50 +00:00
f6fd237a35
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=49157
2013-05-04 08:12:36 +00:00
71f1f8b9d3
Fix indents (Use Spaces) Add Modelines
...
svn path=/trunk/; revision=49156
2013-05-04 08:12:25 +00:00
e5fe6b1dca
LISP control packet incorrectly identified as LISP data based when UDP source port is 4341. Bug 8627 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8627 )
...
Also did some minor cleanup/improvements while I was there.
svn path=/trunk/; revision=49154
2013-05-04 02:20:59 +00:00
d9077264d6
missed adding packet-ssl.h.
...
svn path=/trunk/; revision=49153
2013-05-04 01:37:55 +00:00
377470abe3
Decrypt Fix protocol over SSL. Bug 8625 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8625 )
...
svn path=/trunk/; revision=49152
2013-05-04 01:27:33 +00:00
33e738bf97
Remove unnecessary lines from handoff function.
...
svn path=/trunk/; revision=49149
2013-05-03 18:28:58 +00:00
9032963cf7
Add a dissector for the Ixia Anue encoding of timestamps in the ethernet
...
trailer.
svn path=/trunk/; revision=49148
2013-05-03 17:52:31 +00:00
ed0861abaa
Add 3gpp2_type16.
...
svn path=/trunk/; revision=49147
2013-05-03 17:34:49 +00:00
ce537f6b94
Remove static packet_info *gpinfo and just use the packet_info provided by the function.
...
svn path=/trunk/; revision=49145
2013-05-03 14:54:39 +00:00
b542526248
Remove global packet_info* current_pinfo
...
svn path=/trunk/; revision=49143
2013-05-03 02:43:43 +00:00
f25ebae549
Add some casts to hush the buildbots, and fix what I assume was a copy-pasto
...
to ensure that the return value of strlen is actually used as the length of the
string.
svn path=/trunk/; revision=49142
2013-05-03 01:37:27 +00:00
c83619a25a
Remove unnecessary global variables
...
svn path=/trunk/; revision=49141
2013-05-03 00:39:14 +00:00
cd2d46ab21
Finish improving NTLM and PLAIN authentication. Bug 8600 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8600 )
...
From Uli Heilmeier
svn path=/trunk/; revision=49140
2013-05-03 00:04:36 +00:00
31320e7271
Dissect SSID List element.
...
From Jouni Malinen, bug 8613 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613 )
svn path=/trunk/; revision=49137
2013-05-02 13:08:31 +00:00
ccf8013f95
Remove useless global variables
...
svn path=/trunk/; revision=49136
2013-05-02 13:03:45 +00:00
f52ecf47c8
Remove global variable g_pinfo.
...
svn path=/trunk/; revision=49135
2013-05-02 12:59:07 +00:00
cacddebdb7
From Sandeep Dahiya:
...
Extend the value_string that show the platform from where the packet was captured.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8624
svn path=/trunk/; revision=49133
2013-05-02 05:16:09 +00:00
25e62daeb9
Add a subtree for P2P Client Info Descriptor. Part of bug 8613 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613 )
...
From Jouni Malinen
svn path=/trunk/; revision=49132
2013-05-02 02:09:08 +00:00
5b416c8479
IEEE802.11 improvements:
...
1. ANQP Venue Name is a UTF-8 string
2. Dissect Hotspot 2.0 indication and ANQP elements
3. Dissect TFS Request/Response
4. Dissect WNM-Notification Request frames
svn path=/trunk/; revision=49131
2013-05-02 01:59:34 +00:00
f1d06a226b
Fix P2P Group Info validation code for Device Name length field. Bug 8613 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613 )
...
From Jouni Malinen
svn path=/trunk/; revision=49130
2013-05-02 01:51:02 +00:00
f1918b01e1
Add BSS Max Idle Period, WNM-Sleep Mode.
...
Fix and enhance TCLAS dissection.
From Jouni Malinen, bug 8613 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613 )
svn path=/trunk/; revision=49129
2013-05-02 01:15:25 +00:00
195e87f3ea
Protect a "divide by zero" operation. Bug 7359 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7359 ). This seems to have been generated through a corrupted UAT file switching between 1.8 and 1.10, but it's a good check to have regardless.
...
svn path=/trunk/; revision=49128
2013-05-01 23:59:16 +00:00
1fe16c1d6a
Fix warning.
...
svn path=/trunk/; revision=49118
2013-05-01 21:15:47 +00:00
b787f03df3
Remove some global variables in favor of private_data member of asn1_ctx_t. Bug 7060 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060 ). This should (mostly) passify the bug, but it appears like this could be done with a lot more ASN.1 dissectors.
...
svn path=/trunk/; revision=49117
2013-05-01 20:54:31 +00:00
dbd718c606
Whitespace fixes: Indented lines should not start with
...
spaces followed by tabs.
svn path=/trunk/; revision=49115
2013-05-01 19:51:46 +00:00
695d3fde1c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8622 :
...
hsrp2.md5_auth_data is added to the tree with a length of 16 so declare it as
FT_BYTES instead of FT_UINT32 (using the latter causes an assertion in
trunk-1.8 and an expert info in trunk and trunk-1.10).
svn path=/trunk/; revision=49114
2013-05-01 19:42:28 +00:00
acc90e3d59
Diederik de Groot <dkgroot@talon.nl>
...
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616
Further enhancements to packet-skinny.c, change cast. filters
to skinny. filters.
While I'm not sure whether that this is really correct, we don't
have any sample capture to verify whether the old solution really
worked. At least that way checkfiltername.pl doesn't complain
any more ;-)
Me: Tiny whitespace fixes.
svn path=/trunk/; revision=49113
2013-05-01 19:16:02 +00:00
56552cb0fa
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8618 :
...
Allow port 0 in RSA Key List.
(This has been broken since r36875.)
svn path=/trunk/; revision=49111
2013-05-01 14:19:10 +00:00
e9f90d8c42
Make C12.22 work over UDP.
...
svn path=/trunk/; revision=49104
2013-05-01 08:34:40 +00:00
0844929247
Follow-up to r49055 as noted on
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7359
The BER integer dissection routines take an hf_id, but that can be -1.
Only fetch the type (to check signedness) if hf_id >= 0, as otherwise this
causes a dissector bug. Default to signed if given no hf_id - I don't know
whether this should be unsigned or not, but the old behaviour was that
everything was signed so it's not a regression at least.
svn path=/trunk/; revision=49101
2013-04-30 23:19:47 +00:00
e4f71b08a0
Diederik de Groot <dkgroot@talon.nl>
...
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616
Update Skinny Dissection Code (CM7.1 + / SPCP Message)
Me:
- Remove some trailing whitespace
- Numerically sort deviceTypes and replace older values with new ones
- Reenable the return FALSE statement in the heuristics - it works for me.
svn path=/trunk/; revision=49099
2013-04-30 21:53:39 +00:00
78ebc850ba
Convert 'Old GFID' and 'New GFID' to FT_GUID type.
...
From Niels de Vos, Bug 8612 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8612 )
svn path=/trunk/; revision=49093
2013-04-30 00:55:18 +00:00
c0c0b10f96
A few more doxygen fix-ups.
...
svn path=/trunk/; revision=49092
2013-04-30 00:55:03 +00:00
c17893650c
Silence a false-positive warning from older GCCs:
...
'acetype4' may be used uninitialized in this function
svn path=/trunk/; revision=49076
2013-04-27 15:00:52 +00:00
132ee18259
From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8605
...
Numerous improvements to NFS ACL/ACE dissection. For a complete list see
comment #11 of the bug.
From me:
- fix an infinite loop caught by fuzzing
- fix an out-of-bounds memory access caught by valgrind
- add missing {0,NULL} terminator to value_string array
svn path=/trunk/; revision=49074
2013-04-27 13:59:46 +00:00
600e5ac301
remove unnecessary if (tree) checks
...
I hope this prevents bugs like the one fixed in r48917
svn path=/trunk/; revision=49073
2013-04-27 13:06:28 +00:00
5b8a3df249
From me: only sign-extend BER integers if the field is actually signed
...
From Guy: override two fields in the GOOSE ASN.1 dissector to be unsigned
Together these fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8250
svn path=/trunk/; revision=49055
2013-04-26 19:23:36 +00:00
74e15c70cc
Flag as malformed expert info if we see padding subheaders at start and
...
end of subheader list.
svn path=/trunk/; revision=49035
2013-04-25 21:07:32 +00:00
9264cc1137
From Mathias Guettler
...
correct value for "ATN Systems Management No Preference"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8562
svn path=/trunk/; revision=49034
2013-04-25 20:54:56 +00:00
b3da159427
Enhance dissection of feedback
...
svn path=/trunk/; revision=49032
2013-04-25 15:21:48 +00:00
df0bbb4ffc
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8611
...
svn path=/trunk/; revision=49030
2013-04-25 13:57:02 +00:00
35d3fa75be
Try to please the OSX buildbots
...
svn path=/trunk/; revision=49024
2013-04-25 05:24:07 +00:00
eba34e00e7
Convert a few proto_tree_add_text to proto_tree_add_items. The dissector was originally under the 50% mark that checkAPIs.pl like, but subsequent patches pushed it over the limit, so I thought I'd knock it back down.
...
svn path=/trunk/; revision=49023
2013-04-24 23:20:24 +00:00
a18e128b44
convert some proto_tree_add_texts into expert_add_info_format. Didn't quite make checkAPIs.pl happy, but given the nature of the dissector (mostly raw text), I'm not sure it can hit the 50% ratio.
...
svn path=/trunk/; revision=49022
2013-04-24 23:17:44 +00:00
Evan Huus