Commit Graph

29 Commits

Author SHA1 Message Date
Bill Meier aa30dcd129 Minor proto_reg_handoff cleanup: use find_dissector when appropriate.
svn path=/trunk/; revision=26308
2008-09-30 14:49:44 +00:00
Jeff Morriss 20193e363e From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2707
The SMPP dissector currently supports only version 3.4. The latest version of
the protocol is version 5.0 and it has been around for a while. However, the
usage of this version of the protocol is only now picking up. 

This patch adds basic support for SMPP 5.0. By basic I mean:
- New Operations and Responses.
- New TLVs.
- New Error codes.
- Any changes to earlier values. 

svn path=/trunk/; revision=25787
2008-07-22 12:13:38 +00:00
Jeff Morriss 71c1e4faf0 Change the stats tree API to use signed chars instead of guint8s for all its
strings; this should fix a number of signed/unsigned char warnings.
Reindent a bunch, too.

svn path=/trunk/; revision=25716
2008-07-11 21:13:39 +00:00
Jaap Keuter c22bfae716 Fix for bug 1603:
SMPP validity period as relative time interpretation corrected.

svn path=/trunk/; revision=25001
2008-04-13 21:54:07 +00:00
Jaap Keuter 9f82b15448 From Abhik Sarkar:
The attached patch changes the handling of the parameters in question to octet
string instead of string

svn path=/trunk/; revision=24662
2008-03-17 07:30:22 +00:00
Jeff Morriss d7fb23f849 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2111 : After verifying that there's enough TVB for the smallest possible message, also verify that the length parameter in the message is at least that big.
svn path=/trunk/; revision=24063
2008-01-10 23:16:59 +00:00
Jaap Keuter 7a76c45b04 From Abhik Sarkar:
This patch adds initial support for statistics to the SMPP dissector using the Stats Tree API.

svn path=/trunk/; revision=23931
2007-12-21 08:16:47 +00:00
Martin Mathieson 325bd496a4 Make this dissector finable by name.
svn path=/trunk/; revision=22908
2007-09-19 17:33:08 +00:00
Jeff Morriss caf9f71cee When saving off a temporary copy of an address, use SET_ADDRESS instead of COPY_ADDRESS so as to avoid a memory leak (or adding g_free() calls to fix said memory leak).
svn path=/trunk/; revision=22568
2007-08-21 20:24:17 +00:00
Jaap Keuter e9577b77f5 Fix for bug 1512:
Present user with the invalid time string.

svn path=/trunk/; revision=22052
2007-06-05 20:36:23 +00:00
Jaap Keuter 08a6f4ed7b Fix for bug 1642:
Added hf_smpp_sms_signal to hf_array.

svn path=/trunk/; revision=22051
2007-06-05 20:26:03 +00:00
Ronnie Sahlberg 2d1bb39121 change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size



svn path=/trunk/; revision=19751
2006-10-31 09:29:07 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 2bf7bd3a45 From Jacques, Olivier
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits.
It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function.

svn path=/trunk/; revision=17739
2006-03-27 18:48:33 +00:00
Jörg Mayer 735ba01eb1 Bill Meier: More spelling fixes
svn path=/trunk/; revision=16965
2006-01-06 03:26:45 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Olivier Biot e931881626 Use g_print() instead of fprintf() to write messages to the debug console.
svn path=/trunk/; revision=16373
2005-11-01 18:18:46 +00:00
Ulf Lamping 9a42ef9536 fix #480: Change defaults for all reassembling settings to ON
I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often.

svn path=/trunk/; revision=16048
2005-09-28 22:15:38 +00:00
Ronnie Sahlberg ec488447dc more sprintf removals,
replace some char arrays on the stack to ep_alloc()ed memory


svn path=/trunk/; revision=15446
2005-08-19 23:28:23 +00:00
Ronnie Sahlberg e3a0e74e8d some more tcv_get_stringz() to tvb_get_ephemeral_stringz() conversions
svn path=/trunk/; revision=15288
2005-08-11 07:44:38 +00:00
Ulf Lamping 2ce8d2a30f fixed various issues (two serious ones) found by "private" fuzz-testing
svn path=/trunk/; revision=14830
2005-07-01 21:04:13 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Gerald Combs 06a47f5880 Fix Win32 compilation, broken by yesterday's checkin.
svn path=/trunk/; revision=14664
2005-06-16 19:51:14 +00:00
Gerald Combs c2b9534398 Catch an infinite loop in smpp_handle_dlist(). Fixes bug 246.
svn path=/trunk/; revision=14639
2005-06-15 21:42:30 +00:00
Ulf Lamping fdb5b1af02 just to get things straight: a dissector should *never* do any g_assert() calls!
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()

this will replace application crash by showing a dissector bug, which is the desired behaviour

there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too

one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

svn path=/trunk/; revision=14608
2005-06-10 18:28:22 +00:00
Guy Harris 0667d869b2 From Chris Maynard: free mallocated strings when we're done with them.
(There's still the risk of a leak if we throw an exception before we
free the string.)

Clean up indentation.

svn path=/trunk/; revision=12973
2005-01-07 10:39:51 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Ulf Lamping d530bd4e14 Prevent the word "desegmentation" at the GUI, but use reassembling at that places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions.
I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences.

Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect.

If you encounter any mistakes I've made here, please let me know...

svn path=/trunk/; revision=11784
2004-08-21 09:02:52 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00