Anders Broman
7bff8c664b
From Benjamin Meyer:
...
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090
svn path=/trunk/; revision=30320
2009-10-04 19:31:02 +00:00
Kovarththanan Rajaratnam
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam
124faf721c
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
Kovarththanan Rajaratnam
633bb05380
Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
...
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
Jörg Mayer
ebfcf3c387
Build more plugins with cmake.
...
svn path=/trunk/; revision=30084
2009-09-23 04:41:14 +00:00
Kovarththanan Rajaratnam
c28bafe341
Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30082
2009-09-22 21:18:11 +00:00
Jeff Morriss
4661aad9a4
Run checkapi on the dissector header files
...
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
Kovarththanan Rajaratnam
2547ce21bf
We no longer support the old plugin API so remove it completely from the build system
...
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Gerald Combs
9bc8469d96
Remove a couple of unused variables.
...
svn path=/trunk/; revision=29286
2009-08-03 23:50:55 +00:00
Anders Broman
617077e94a
From Benjamin Meyer:
...
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753
svn path=/trunk/; revision=29150
2009-07-21 06:08:45 +00:00
Stig Bjørlykke
7881d1ccd7
From Kovarththanan Rajaratnam:
...
More FT_XXX cleanup.
svn path=/trunk/; revision=28970
2009-07-07 09:00:33 +00:00
Michael Tüxen
9518d53ab4
Make the compiler on Mac OS X happy...
...
svn path=/trunk/; revision=28934
2009-07-03 10:29:45 +00:00
Ulf Lamping
d180d37c8d
update to the latest PROFINET drafts
...
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)
svn path=/trunk/; revision=28932
2009-07-03 09:12:43 +00:00
Stig Bjørlykke
2bba6be84f
From Kovarththanan Rajaratnam via bug 3548:
...
Cleanup header_field_info in plugins.
svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Jaap Keuter
b7dc0a3e51
From Reinhard Speyerer:
...
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.
svn path=/trunk/; revision=28204
2009-05-01 06:58:28 +00:00
Bill Meier
321506c076
(Trivial) Fix some spelling & etc in comments
...
svn path=/trunk/; revision=27996
2009-04-08 13:41:30 +00:00
Ulf Lamping
f681477e33
remove GPLv2 CRC code, the new epan CRC stuff is working well
...
svn path=/trunk/; revision=27803
2009-03-20 10:44:42 +00:00
Gerald Combs
dd903ca9c8
Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch],
...
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
svn path=/trunk/; revision=27790
2009-03-18 21:59:30 +00:00
Ulf Lamping
870e139576
fix type
...
svn path=/trunk/; revision=27749
2009-03-16 22:36:34 +00:00
Ulf Lamping
dcdda03610
update to the latest PROTINET changes:
...
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4
crc16 algorithm copied from Linux sources (GPL V2 only!)
svn path=/trunk/; revision=27748
2009-03-16 21:40:00 +00:00
Gerald Combs
07e5df616e
Disable manifest building for our DLLs. This attempts to fix bug 3272.
...
svn path=/trunk/; revision=27579
2009-03-02 18:57:35 +00:00
Ulf Lamping
043532d63e
add missing mt.exe calls, to include manifest files into exe / dll files
...
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
Guy Harris
2ba37de400
Fix uninitialized variable.
...
More indentation cleanups.
svn path=/trunk/; revision=27306
2009-01-26 23:48:10 +00:00
Guy Harris
248db0a42a
Non-constant strings should not be used as format items; the format
...
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.
Clean up indentation.
svn path=/trunk/; revision=27304
2009-01-26 22:58:47 +00:00
Ulf Lamping
f9e110d4cd
fix a minor comment bug
...
svn path=/trunk/; revision=27299
2009-01-26 19:53:22 +00:00
Ulf Lamping
269cec3108
add some expert infos
...
svn path=/trunk/; revision=27298
2009-01-26 19:52:19 +00:00
Bill Meier
9a3563e807
Fix some typos and spelling (mostly in text strings)
...
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Stig Bjørlykke
e4e7334be0
From Jim Young (bug 3105):
...
Trivial patch to change two C++ style comments to standard C style comments.
svn path=/trunk/; revision=26944
2008-12-09 13:42:00 +00:00
Ulf Lamping
4f46066fa0
add missing version check for new block
...
svn path=/trunk/; revision=26917
2008-12-04 21:26:35 +00:00
Ulf Lamping
6e0a9d6df0
add block dissections:
...
- PDIRBeginEndData
- PDIRData V1.1
svn path=/trunk/; revision=26916
2008-12-04 20:52:11 +00:00
Stig Bjørlykke
94e9e2b1ec
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Bill Meier
05c1929f1d
proto_register/proto_reg_handoff; Various small cleanup and bug-fixing
...
remove unnecessary #include prefs.f and emem.h in a few cases...
svn path=/trunk/; revision=26554
2008-10-25 20:24:31 +00:00
Jeff Morriss
b4d2c37635
Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
...
Also use $(top_builddir) instead of ../../ in a couple of other spots.
svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
Guy Harris
a04774395f
Add Makefile.common files for epan/dfilter and epan/ftypes.
...
Add checkapi rules to Makefile.am files.
svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris
b6e20d89be
Put printf into a separate "termoutput" API group. For most files,
...
check for it - but not for TShark plugins, as they are expected to
print to the standard output.
svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Gerald Combs
83aacf0a09
Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
...
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Ulf Lamping
bd8528644e
fix BlockError strings
...
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
Jeff Morriss
a5cee04fad
Move the file utility functions from wiretap to libwsutil so that
...
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.
While doing that, rename the eth_* functions to ws_*.
svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Anders Broman
023a81709a
Make it possible to run checkapi on all plugins trough makefile.nmake
...
Note: Commented out in the plugins giving errors for now.
svn path=/trunk/; revision=25231
2008-05-05 16:55:19 +00:00
Jaap Keuter
b704bdcbc5
Remove the pre-release flag from FILEFLAGS in the resource file.
...
svn path=/trunk/; revision=24757
2008-03-29 23:04:33 +00:00
Jaap Keuter
fcf8509f69
Create proper dependancies for plugin.c
...
svn path=/trunk/; revision=24520
2008-03-01 12:31:01 +00:00
Stig Bjørlykke
fc5527ef6c
Quote argument to test in plugins Makefiles, as proposed by Greg A. Woods.
...
svn path=/trunk/; revision=24488
2008-02-27 16:18:30 +00:00
Gerald Combs
7abeb02747
If we have an SVN revision number, use it as the build number under Windows
...
instead of "0".
svn path=/trunk/; revision=24376
2008-02-18 18:08:14 +00:00
Ulf Lamping
adccc10596
add some parentheses as suggested by the OS X buildbot
...
svn path=/trunk/; revision=24122
2008-01-17 19:30:35 +00:00
Ulf Lamping
6cfbb485bf
better conformance to the released DCP protocol spec:
...
- redesign/refactoring the code to support BlockQualifier
- fix handling of BlockInfo
- rename some display strings for better spec conformance
- remove LLDP suboption
svn path=/trunk/; revision=24120
2008-01-17 18:29:51 +00:00
Jeff Morriss
309f7503e5
Get rid of C++/C99 style comments--not all compilers support them
...
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Ulf Lamping
5c901658e7
add FSParameterBlock and ARFSUDataAdjust blocks
...
svn path=/trunk/; revision=23140
2007-10-10 18:33:21 +00:00
Ulf Lamping
37d9fc37da
- add DomainName fields for PDInterfaceMrpDataAdjust and PDInterfaceMrpDataReal
...
- lower expert info level if AR wasn't found
svn path=/trunk/; revision=23106
2007-10-09 05:39:48 +00:00
Stig Bjørlykke
87cffefe2f
Added parentheses to make the buildbot happy.
...
svn path=/trunk/; revision=23065
2007-10-03 19:35:32 +00:00
Ulf Lamping
2a8f9b4c99
check version of each block and don't try to dissect a block if the version is not as expected (to avoid "miss-dissections")
...
svn path=/trunk/; revision=23064
2007-10-03 18:02:27 +00:00
Ulf Lamping
c3131594a8
update to latest IEC draft
...
svn path=/trunk/; revision=23041
2007-10-02 05:04:35 +00:00
Ulf Lamping
33f27f437f
slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header
...
svn path=/trunk/; revision=22970
2007-09-25 21:56:43 +00:00
Ulf Lamping
b57c83f6eb
fix length calculation for 802.11 packets - the 802.11 dissector will strip off the 4 byte FCS at the end of a packet (while the Ethernet dissector does not).
...
svn path=/trunk/; revision=22759
2007-08-30 19:50:56 +00:00
Ulf Lamping
b0f5c26ebf
update to latest draft:
...
- add PDSyncData block with Version 1.2
- add IOXBlockReq/s ids 0x116, 0x117, 0x8116 and 0x8117
svn path=/trunk/; revision=22734
2007-08-30 02:14:36 +00:00
Bill Meier
516ca59b99
Add .c.obj:: inference rule (to cause "batch compile")
...
svn path=/trunk/; revision=22696
2007-08-27 22:56:27 +00:00
Ulf Lamping
3a0c285065
fix return types, hopefully this will make the osx buildbot happy
...
svn path=/trunk/; revision=22531
2007-08-16 22:45:36 +00:00
Ulf Lamping
4b215597ae
experimental feature: dissector filters
...
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI
svn path=/trunk/; revision=22530
2007-08-16 22:03:10 +00:00
Ulf Lamping
2d11b0813e
mark some parameters as unused
...
svn path=/trunk/; revision=22445
2007-08-03 20:07:06 +00:00
Ulf Lamping
12aed7290c
- add PDInterfaceFSUDataAdjust block
...
- start to implement an AR conversation handler
svn path=/trunk/; revision=22444
2007-08-03 19:29:34 +00:00
Ulf Lamping
f4cabf95a1
update PTCP dissection to latest specification draft
...
svn path=/trunk/; revision=22432
2007-07-31 19:01:15 +00:00
Ulf Lamping
6970aff017
add helper function dissect_pn_int32()
...
svn path=/trunk/; revision=22431
2007-07-31 18:57:51 +00:00
Ulf Lamping
85e09ecdd5
fix unused parameter warning by adding _U_
...
svn path=/trunk/; revision=22400
2007-07-25 08:38:31 +00:00
Ulf Lamping
9f2478f46c
from HPfrommer@hilscher.com:
...
I’ve fixed a bug in the Profinet-Dissector
(plugins/profinet/packet-dcerpc-pn-io.c).
In PROFINET IO DCE RPC write-requests, only the first IR frame dataset
in PDIRFrameData was dissected.
I’ve fixed the problem, now all IR frame datasets are dissected into
individual sub-trees.
svn path=/trunk/; revision=22398
2007-07-24 21:15:34 +00:00
Ulf Lamping
a5ba21acf8
remove ProvCRID from expert info output, so the composite view is more compact
...
svn path=/trunk/; revision=22386
2007-07-23 20:08:53 +00:00
Ulf Lamping
94b3dbf3f6
add dissection of blocks:
...
{ 0x021E, "CheckSyncDifference"},
{ 0x021F, "CheckMAUTypeDifference"},
svn path=/trunk/; revision=22385
2007-07-23 20:07:51 +00:00
Guy Harris
5a43799a17
Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
...
routines and routines using those routines. GLib might use different
modifiers for 64-bit quantities than the platform's C library does.
svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris
a7c42e75e0
Use $(PLUGIN_LDFLAGS) for LDFLAGS.
...
svn path=/trunk/; revision=21963
2007-05-27 18:56:39 +00:00
Guy Harris
d99b6c0a8b
Clean up white space.
...
svn path=/trunk/; revision=21959
2007-05-27 18:30:03 +00:00
Ulf Lamping
2fd09672de
add dissection of PortTime
...
svn path=/trunk/; revision=21360
2007-04-10 02:26:39 +00:00
Gerald Combs
5620d4fa15
Add the make-dissector-reg scripts to the dependency list for each copy
...
of plugin.c.
svn path=/trunk/; revision=21342
2007-04-05 23:23:06 +00:00
Ulf Lamping
0104002d2e
Add PN-IO FSHelloBlock and PN-DCP Device/AliasName
...
svn path=/trunk/; revision=21298
2007-04-02 05:18:31 +00:00
Stephen Fisher
2896811274
Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
...
Comment out -Werror in plugins/asn1/ until warnings can be fixed.
svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher
8973617e4b
From Sebastien Tandel:
...
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.
svn path=/trunk/; revision=21155
2007-03-23 18:16:53 +00:00
Stephen Fisher
62f88a4a04
From Sebastien Tandel:
...
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)
Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)
svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
Stephen Fisher
cdf47e536b
Add -Werror when using GCC only to the Makefile.am of the base
...
directory and most of the plugins to match the same command
put in the Makefile.nmake files for Windows compliations. Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD. Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition.
svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
Ulf Lamping
af9ae7eebb
set CFLAGS to block new warnings for all plugins (except for giop and h223, which has remaining issues - for now)
...
svn path=/trunk/; revision=21102
2007-03-21 23:59:41 +00:00
Ulf Lamping
c3bf838051
as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
...
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
Jeff Morriss
62596bffb3
Fix bug 552:
...
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552
by enforcing that header fields have names of length > 0. This should fix
the display of those fields and also make them filterable (which was the
subject of the bug). Abbreviations are (still) optional: if they are empty
then the field is not filterable.
Update README.developer with this information.
Add header field names in several dissectors where they were missing.
In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.
Also remove trailing white space from all the files checked in.
svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Ulf Lamping
e30640be45
PROFINET RT frames can also be transported over UDP Port 0x8892 - to be routable
...
svn path=/trunk/; revision=20985
2007-03-06 21:54:53 +00:00
Ulf Lamping
00335ac48e
fix read handling of index 0x8051 and 0xe00c
...
svn path=/trunk/; revision=20963
2007-03-03 09:33:02 +00:00
Jaap Keuter
cf13f56dc8
-Add the compiler version to the plugin resource
...
-Remove the SPECIAL_BUILD tag
-Set to OS type to NT_WINDOWS32
svn path=/trunk/; revision=20934
2007-02-26 20:39:38 +00:00
Ulf Lamping
cd08e6448f
fix the padding in the read/write headers, some other minor changes
...
svn path=/trunk/; revision=20927
2007-02-25 15:50:40 +00:00
Ulf Lamping
7887d478cc
add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
...
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Jaap Keuter
a8fb7d24d0
Properly introduce packet-pn.c as a helper
...
svn path=/trunk/; revision=20903
2007-02-23 19:37:01 +00:00
Guy Harris
c127df0bc8
Include <string.h> to declare memcpy().
...
svn path=/trunk/; revision=20842
2007-02-19 00:56:22 +00:00
Ulf Lamping
822bb2e489
fix an error added lately
...
svn path=/trunk/; revision=20832
2007-02-17 11:13:24 +00:00
Ulf Lamping
2172e293d6
some more compiler warnings removed
...
svn path=/trunk/; revision=20829
2007-02-17 09:42:38 +00:00
Ulf Lamping
16aa7c17db
squelch some compiler warnings
...
svn path=/trunk/; revision=20828
2007-02-17 08:08:40 +00:00
Ulf Lamping
d6e22b2d9a
major code cleanup:
...
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code
svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
Ulf Lamping
aad5a4e6b1
add remaining TLV blocks (complete now?)
...
add a lot of missing index values
fix some minor bugs
svn path=/trunk/; revision=20795
2007-02-12 19:01:20 +00:00
Ulf Lamping
44ee701ba6
remove some warnings
...
svn path=/trunk/; revision=20785
2007-02-11 04:12:07 +00:00
Ulf Lamping
59a86ae3e9
remove a g_warning left over from debugging
...
svn path=/trunk/; revision=20784
2007-02-11 03:45:21 +00:00
Ulf Lamping
b04c53a23c
add a lot more TLV block decodes, some code cleanup, ...
...
svn path=/trunk/; revision=20763
2007-02-10 08:03:47 +00:00
Ulf Lamping
98f2412a6f
various major enhancements to the PROFINET-IO dissector (including some new TLV blocks)
...
svn path=/trunk/; revision=20751
2007-02-08 18:29:47 +00:00
Ulf Lamping
8559a25d23
- add dissection for "I&M0" block
...
- enhance dissection or ErrorDecode2 (ErrorCode1 rta_err_cls_protocol specific) - a lot more of ErrorCode1/ErrorCode2 combinations still to go ...
svn path=/trunk/; revision=20724
2007-02-06 01:37:32 +00:00
Ulf Lamping
39956903b5
PropagationDelayFactor -> LineDelay
...
svn path=/trunk/; revision=20348
2007-01-08 22:11:56 +00:00
Ulf Lamping
d53f947b16
clean should also remove generated plugin.c and manifest files
...
svn path=/trunk/; revision=20291
2007-01-03 06:06:53 +00:00