Commit graph

33410 commits

Author SHA1 Message Date
Bill Meier
b94da93586 Minor reformatting and whitespace cleanup.
svn path=/trunk/; revision=34716
2010-10-30 15:10:30 +00:00
Anders Broman
a401f477d5 From Jouni Malinen:
Add an item for IEEE 802.11 vendor specific subtypes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4971

svn path=/trunk/; revision=34715
2010-10-30 14:48:46 +00:00
Bill Meier
b883b87c4a Use value_string_ext to access one of the value-string arrays.
Whitespace cleanup.

svn path=/trunk/; revision=34714
2010-10-30 14:48:21 +00:00
Jeff Morriss
554ed113a9 Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be sent upstream to the Samba developers.
svn path=/trunk/; revision=34713
2010-10-30 14:35:05 +00:00
Anders Broman
738813862b From Robert Bullen:
Improve the HTTP dissection of the Response Status Line.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5338

svn path=/trunk/; revision=34712
2010-10-30 14:29:20 +00:00
Jeff Morriss
9dcabb82c9 Make the hf_ checks errors (they've been running clean for a while now anyway).
svn path=/trunk/; revision=34711
2010-10-30 13:23:58 +00:00
Jeff Morriss
58da72c54e Fix the randpkt assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5348 :
Always pass a length of 1 to proto_tree_add_item() for the ctype (this fixes
the assertion).  If the length indicated in the message is not 1, add an
expert info.

svn path=/trunk/; revision=34710
2010-10-30 12:48:29 +00:00
Stig Bjørlykke
c0ea7f05bf Redissect packets instead of reload file on UAT changes.
This way we can do changes while capturing.

svn path=/trunk/; revision=34709
2010-10-30 11:43:11 +00:00
Chris Maynard
fd2c5fbccc Should be a "new-style" dissector because its caller expects it to be now, but
need to create the dissector handle using new_create_dissector_handle().
(Similar to SVN #34707).

svn path=/trunk/; revision=34708
2010-10-30 04:29:19 +00:00
Guy Harris
19ac4ab745 The ASF dissector should be a new-style dissector, so its caller knows
how much of the packet data it's consumed - but that means the dissector
handle for it must be created with new_create_dissector_handle().

svn path=/trunk/; revision=34707
2010-10-30 03:34:29 +00:00
Bill Meier
5c0ce795b3 It never rejects a packet, so it's not a "new-style" dissector.
(Similar to SVN #34704).

svn path=/trunk/; revision=34706
2010-10-30 02:38:44 +00:00
Chris Maynard
bc2a15d93c Fixed checkAPIs.pl warning, which I forgot to run earlier. Ugh.
svn path=/trunk/; revision=34705
2010-10-30 01:09:17 +00:00
Guy Harris
97b0de2fe8 It never rejects a packet, so it's not a "new-style" dissector.
svn path=/trunk/; revision=34704
2010-10-29 23:58:38 +00:00
Jeff Morriss
3b34edd421 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 :
Return an error if the user specifies a value in a range in excess of the
range-specified maximum.

Except when reading in preferences files which might have ranges that exceed
the maximum (because we didn't use to check): in that case silently lower the
out-of-range values.

svn path=/trunk/; revision=34703
2010-10-29 23:30:36 +00:00
Chris Maynard
e6bbbe1071 Added -b and -C options to usage.
svn path=/trunk/; revision=34702
2010-10-29 23:05:55 +00:00
Chris Maynard
a12e86f59f Fixes bug 974 by adding RSP trailer. Also resolves packet-asp "FIXME" for
IANA Enterprise ID as well as extended packet-asp decoding of authentication
and integrity payloads using the sample capture file attached to the bug.
Fuzz tested ~500 passes on that 3 packet capture file.

svn path=/trunk/; revision=34701
2010-10-29 22:37:31 +00:00
Gerald Combs
c469f5cd6e You can build portable packages with Express Edition compilers. You just
have to install the CRT package on the target machine.

svn path=/trunk/; revision=34700
2010-10-29 22:31:45 +00:00
Bill Meier
28402479cc Use value_string_ext fcns to access two value-string arrays;
Reorder value-string arrays slightly so they are in ascending order.

svn path=/trunk/; revision=34699
2010-10-29 22:18:44 +00:00
Jeff Morriss
6eba069093 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 :
Return an error if the user specifies a value in a range in excess of the
range-specified maximum.

Except when reading in preferences files which might have ranges that exceed
the maximum (because we didn't use to check): in that case silently lower the
out-of-range values.

svn path=/trunk/; revision=34698
2010-10-29 22:09:31 +00:00
Bill Meier
e21ca35116 Improve g_warning text slightly.
svn path=/trunk/; revision=34697
2010-10-29 22:01:29 +00:00
Stig Bjørlykke
c5bebaa771 One more:
Make the third argument to a UAT copy callback a size_t.

svn path=/trunk/; revision=34696
2010-10-29 21:55:04 +00:00
Stig Bjørlykke
340d64e780 Make the third argument to a UAT copy callback a size_t.
svn path=/trunk/; revision=34695
2010-10-29 21:51:59 +00:00
Guy Harris
17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
Stig Bjørlykke
04b977c4e6 Added a cast from size_t to unsigned int.
svn path=/trunk/; revision=34693
2010-10-29 20:54:08 +00:00
Bill Meier
f543357d14 Use value_string_ext fcns to access certain value_string arrays.
svn path=/trunk/; revision=34692
2010-10-29 20:22:02 +00:00
Stig Bjørlykke
fd52258052 Added a Copy button in UAT dialogs.
Fixed setting sensitivity when having a selected row.

svn path=/trunk/; revision=34691
2010-10-29 19:48:51 +00:00
Bill Meier
1a365d735c Use value_string_ext to access 'commands' value_string.
svn path=/trunk/; revision=34690
2010-10-29 18:33:21 +00:00
Bill Meier
4a43e13976 Use value_string_ext to access several "relatively large" value-strings.
svn path=/trunk/; revision=34689
2010-10-29 17:48:39 +00:00
Bill Meier
46416bddda (Trivial) Do 'find_dissector("data");' only once.
svn path=/trunk/; revision=34688
2010-10-29 17:42:24 +00:00
Chris Maynard
61d26e2c7b Use Wireshark installer icon for portable apps installer. Fixes bug 4374.
svn path=/trunk/; revision=34687
2010-10-29 15:57:47 +00:00
Jeff Morriss
aac7d5596e From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 :
RequestID and ResponseID are unsigned.  Show them in hex and decimal.

svn path=/trunk/; revision=34686
2010-10-29 15:44:11 +00:00
Anders Broman
f01cbcd296 Add cause values.
svn path=/trunk/; revision=34685
2010-10-29 15:19:47 +00:00
Jeff Morriss
53ba99cd9b Say that an hf_ variable is used if we find "variable = hf_variable".
Add some debug statements.
Tweak one regexp to catch more hf_ variable uses.

svn path=/trunk/; revision=34684
2010-10-29 15:15:26 +00:00
Jeff Morriss
3971cb5d13 Copy hf variables by value, not by reference.
svn path=/trunk/; revision=34682
2010-10-28 18:49:40 +00:00
Jeff Morriss
54e10cb509 Use ENC_LITTLE_ENDIAN and ENC_NA.
svn path=/trunk/; revision=34681
2010-10-28 18:37:41 +00:00
Jeff Morriss
e257f75449 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 :
A patch to add support of Mongo Wire Protocol (Used by MongoDB)

From me: use ENC_xxx in proto_tree_add_item() calls.

svn path=/trunk/; revision=34680
2010-10-28 17:33:18 +00:00
Jeff Morriss
336adde8df Use ENC_NA too
svn path=/trunk/; revision=34679
2010-10-28 16:54:04 +00:00
Jeff Morriss
772edf8fb5 Use ENC_BIG_ENDIAN and ENC_LITTLE_ENDIAN
svn path=/trunk/; revision=34677
2010-10-28 16:46:38 +00:00
Gerald Combs
cfe3d49619 From g.khueny via bug 5346:
If PYTHON_DIR is specificed in config.nmake the variable will be overritten by
PYTHON_DIR=C:\Python$(PYTHON_VER). 
It looks like the problem was created by revision 34246.

svn path=/trunk/; revision=34673
2010-10-28 16:29:39 +00:00
Anders Broman
fe71cbcc99 From Pascal Quantin:
[NAS EPS] Fix TFT decoding in case of "delete packet filters from existing TFT" operation

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5347

svn path=/trunk/; revision=34666
2010-10-28 15:06:48 +00:00
Anders Broman
37e8e4cde6 From Stephen Donnelly:
Wireshark tools do not detect and read some ERF files correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5344

svn path=/trunk/; revision=34665
2010-10-28 14:33:55 +00:00
Jaap Keuter
e942385e06 From Matt Parrisimo:
Calculate packet length and checksum.

svn path=/trunk/; revision=34664
2010-10-27 21:11:46 +00:00
Jeff Morriss
505fbf012a Fix the disssector assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3877 :
The rest of the code assumes that sip can be NULL, so don't assert when it's
not.

Also make fid_cmp() static since it's only used in this module.

svn path=/trunk/; revision=34663
2010-10-27 21:08:49 +00:00
Jeff Morriss
4a120508d6 Fix the reassembly assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3881 :
Ensure the fragment bytes exist before passing them to the reassembly code.

svn path=/trunk/; revision=34662
2010-10-27 18:26:54 +00:00
Stig Bjørlykke
e111567e7e Calculate correct io->start_time.
This fixes bug 5340.

svn path=/trunk/; revision=34661
2010-10-27 07:45:31 +00:00
Stig Bjørlykke
321188339e Added two new functions: nstime_diff() and nstime_subtract().
svn path=/trunk/; revision=34660
2010-10-27 07:44:26 +00:00
Jaap Keuter
b4d195f256 Try to decode the unknown multipart subtype anyway.
svn path=/trunk/; revision=34659
2010-10-27 06:49:39 +00:00
Jaap Keuter
3db66ff53e Try to decode the unknown multipart subtype anyway.
svn path=/trunk/; revision=34658
2010-10-27 06:49:18 +00:00
Jaap Keuter
b67c9b05cb Supply an entry to use for unknown multipart subtype.
svn path=/trunk/; revision=34657
2010-10-27 06:48:39 +00:00
Anders Broman
f8ba652b62 From Fred Fierling:
Found a bug in the changes from sizeof -> numeric.

svn path=/trunk/; revision=34656
2010-10-27 05:30:01 +00:00