Commit Graph

14851 Commits

Author SHA1 Message Date
Martin Kaiser bdb0898ff8 dissect the ISO 7816 class byte
svn path=/trunk/; revision=43832
2012-07-19 20:32:24 +00:00
Martin Kaiser eb6823f6ed use defines for the ISO 7816 instruction byte
svn path=/trunk/; revision=43831
2012-07-19 19:51:36 +00:00
Guy Harris defeb589d6 Rename ENC_HDRLEN to BSD_ENC_HDRLEN, to see if that squelches the false
positive in the "you're passing an ENC_ value as a field value" check in
checkAPI.pl.

svn path=/trunk/; revision=43816
2012-07-19 03:28:39 +00:00
Michael Mann 757361f4d4 Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5469. Added more comments to make the function of vnc_is_client_or_server_version_message() very clear.
Also includes some minor cleanup of proto_tree_add_text -> proto_tree_add_item

svn path=/trunk/; revision=43814
2012-07-19 00:29:11 +00:00
Guy Harris 7b1be4c91e Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43812
2012-07-18 23:44:15 +00:00
Guy Harris d91978600c Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43810
2012-07-18 23:37:59 +00:00
Guy Harris 4c3fd1012a Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43808
2012-07-18 23:34:59 +00:00
Guy Harris bdf148e3ea Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43806
2012-07-18 23:30:45 +00:00
Guy Harris 9667a4703b Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43804
2012-07-18 23:27:37 +00:00
Guy Harris 682d1f34b6 Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43802
2012-07-18 23:18:01 +00:00
Guy Harris 4f84db81e2 Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43800
2012-07-18 23:06:20 +00:00
Guy Harris 754711b757 Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43798
2012-07-18 22:59:54 +00:00
Guy Harris 87ad190d49 exit() must not be used in dissectors. Use REPORT_DISSECTOR_BUG() and
just return NULL instead.

svn path=/trunk/; revision=43797
2012-07-18 22:57:04 +00:00
Guy Harris b40db9cf4c Add to the 802.11 pseudo-header a "this is already decrypted" flag, set
it as appropriate in the code to read Network Instruments Observer
captures (rather than tweaking the "protected" flag in the packet data),
and use that flag in the 802.11 dissector.

Fix indentation while we're at it (tabs are not *ipso facto* 4 spaces).

svn path=/trunk/; revision=43795
2012-07-18 22:10:34 +00:00
Guy Harris 1e7c2d7d51 Eliminate some gsize's I missed in the previous checkin.
svn path=/trunk/; revision=43794
2012-07-18 21:43:39 +00:00
Guy Harris d0df3d4c5a Nobody uses the return value of dissect_sender_array(), so don't have it
return anything.

Don't use gsize for offsets in packets; the type used in Wireshark is
int.

svn path=/trunk/; revision=43793
2012-07-18 21:22:10 +00:00
Guy Harris b695d863aa Set svn:keywords and svn:eol-style, and fix the EOL style (I'm on UN*X,
so with svn:eol-style native, there should be no CRs).

svn path=/trunk/; revision=43792
2012-07-18 20:56:24 +00:00
Michael Mann b16b7e951e Adds CliqueRM protocol (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2076)
svn path=/trunk/; revision=43791
2012-07-18 20:11:32 +00:00
Michael Mann e298722f5b svn path=/trunk/; revision=43789 2012-07-18 19:40:56 +00:00
Guy Harris bbe3a78d3a That comment might have confused the API checker into thinking we were
calling abort(); try changing it.

svn path=/trunk/; revision=43788
2012-07-18 18:50:29 +00:00
Balint Reczey 1f37a8cf14 Fix crash in PPP dissector
Make sure that there is enough space allocated for PPP encapsulated CRTP
packet's header.
The bug can be triggered on an x86_64 system using the cpature file attached to
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680056

svn path=/trunk/; revision=43784
2012-07-18 15:14:45 +00:00
Pascal Quantin 2350d1aecf Put back r43768 that got removed by error in r43781
svn path=/trunk/; revision=43783
2012-07-18 08:37:46 +00:00
Anders Broman 0649041b1c Merge the rest of Jacob Nordgren and Rishie Sharmas work on
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43782
2012-07-18 07:47:05 +00:00
Anders Broman fccbea6702 Merge the rest of Jacob Nordgren and Rishie Sharmas work on
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43781
2012-07-18 07:45:19 +00:00
Guy Harris 9d470cceb9 Clean up indentation.
svn path=/trunk/; revision=43780
2012-07-18 04:45:41 +00:00
Evan Huus a234b68ff0 Fix some system header files that were #included with "" instead of <>.
They made cppcheck unhappy.

svn path=/trunk/; revision=43779
2012-07-18 02:47:56 +00:00
Martin Mathieson c0a913afda Match R9 versions of some more LTE protocols to registered dissector names.
svn path=/trunk/; revision=43777
2012-07-18 01:19:48 +00:00
Pascal Quantin c0a5bc9aa8 Fix copy/paste error
svn path=/trunk/; revision=43775
2012-07-17 21:36:34 +00:00
Jörg Mayer c8579ac82c - Make dns srv elemnts filterable (were: text only)
- Don't suppress first character in srv service and protocol
  as some services don't use _ as first character

svn path=/trunk/; revision=43774
2012-07-17 21:10:02 +00:00
Pascal Quantin 574f57d5ba From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7491 :
DNP3 protocol dissector does not fully decode application layer object 50 variation 3

svn path=/trunk/; revision=43772
2012-07-17 19:54:35 +00:00
Pascal Quantin e9de91f53e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7470 :
Add support for OID 1.3.6.1.5.2.2

svn path=/trunk/; revision=43771
2012-07-17 19:43:17 +00:00
Chris Maynard 2c773fad77 Fix Coverity CID 709726: Structurally dead code. Also, convert tabs to spaces.
svn path=/trunk/; revision=43769
2012-07-17 19:22:55 +00:00
Pascal Quantin c2883b7be2 Fix 'dereferencing type-punned pointer will break strict-aliasing rules' warning when compiling with gcc 4.1.3
svn path=/trunk/; revision=43768
2012-07-17 14:55:27 +00:00
Pascal Quantin c312f14022 More a few ASN.1 based dissectors from the dirty to celan lib (as they should compile without any error now)
svn path=/trunk/; revision=43765
2012-07-17 13:14:23 +00:00
Pascal Quantin babe622987 Use G_MININT32 instead of -2^31 so as to get rid of 'this decimal constant is unsigned only in ISO C90' warning
svn path=/trunk/; revision=43764
2012-07-17 13:12:50 +00:00
Jakub Zawadzki a8016f6a57 Fix bug #7488: Unable to correctly identify IEC 61850 MMS packets
In r39066 was added 'final check to see if the next SPDU, if present, is also valid',
but it didn't properly check for tvb length which causes exception if there's no next SPDU.

svn path=/trunk/; revision=43763
2012-07-17 13:01:17 +00:00
Anders Broman db3f6fe80c From Peter Paluch:
recognize VLAN-bridge STP 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7487

svn path=/trunk/; revision=43762
2012-07-17 12:55:37 +00:00
Pascal Quantin 777bbfb20d Use same capitalization for Service request message as for other messages
svn path=/trunk/; revision=43761
2012-07-17 10:35:21 +00:00
Pascal Quantin 3a682212f5 Remove extra space after message name
svn path=/trunk/; revision=43760
2012-07-17 10:13:22 +00:00
Pascal Quantin ec17920a3e From Wayne Brassem via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7485 :
Add support for IPv6 over PPP in Jmirror dissector

svn path=/trunk/; revision=43759
2012-07-17 07:33:20 +00:00
Pascal Quantin a76f4990b8 Comment a few unused variables / functions
svn path=/trunk/; revision=43754
2012-07-16 15:54:53 +00:00
Jakub Zawadzki b0e44929a3 Gadu-Gadu: dissect more packets.
svn path=/trunk/; revision=43753
2012-07-16 14:34:35 +00:00
Alexis La Goutte c9690704be From Zdravko Velinov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7483
Enhancements to the HP ERM protocol dissector 

I have done some reverse engineering of the HP ERM protocol. I had injected
some 802.1Q frames on a network that contained a HP ProCurve 5406zl switch,
then I examined the resulting encapsulated traffic. It was quite easy to spot
the VLAN identifier and the priority field because part of the header closely
resembled the 802.1Q header. There were just some minor differences in the
priority numbering between 802.1Q and HP ERM.


From me :
Add Modeline info
Fix Clang warning

svn path=/trunk/; revision=43752
2012-07-16 14:23:28 +00:00
Anders Broman d8be496cd5 From Jacob Nordgren and Rishie Sharma:
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43751
2012-07-16 14:06:36 +00:00
Anders Broman 37fdb21ec2 From Jacob Nordgren and Rishie Sharma:
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43750
2012-07-16 13:54:20 +00:00
Anders Broman fe630ec1df From Jacob Nordgren and Rishie Sharma:
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43749
2012-07-16 13:11:20 +00:00
Bill Meier f41a04b7ab Minor cleanup, including:
- Remove unneeded #includes;
- Simplify code slightly;
- Remove unused ett variable and related;
- Remove empty proto_reg_handoff...() functions;
- Fix a few cases of "set but unused".
- Do some whitespace changes.

svn path=/trunk/; revision=43748
2012-07-16 12:34:33 +00:00
Jakub Zawadzki 1e95104860 proto_tree_add_boolean() takes value not ENC_ flag.
svn path=/trunk/; revision=43747
2012-07-16 12:09:19 +00:00
Bill Meier 66f163af90 (trivial) Explicitly initialize a static variable to NULL.
svn path=/trunk/; revision=43746
2012-07-16 11:47:55 +00:00
Anders Broman ac335fc5f4 From Jacob Nordgren and Rishie Sharma:
Handle RRC_MESSAGE_TYPE_BCCH_FACH.

svn path=/trunk/; revision=43741
2012-07-16 07:02:29 +00:00