Pascal Quantin
cfee2019c6
LTE RRC: upgrade dissector to v11.8.0
...
Change-Id: I2bb0861029d0d30ae372b0b8085fbedeb4932217
Reviewed-on: https://code.wireshark.org/review/2949
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-07-08 22:06:46 +00:00
Michael Mann
9356d5c689
convert to proto_tree_add_subtree[_format] for ASN.1 dissectors
...
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef
Reviewed-on: https://code.wireshark.org/review/2509
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-22 21:08:21 +00:00
Guy Harris
ce3d2ff3de
Rename dissector_add_handle() to dissector_add_for_decode_as().
...
Hopefully that name makes it clear what the routiner's purpose is, and
will encourage people to use it rather than using dissector_add_uint()
with a bogus integer value.
Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8
Reviewed-on: https://code.wireshark.org/review/2483
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20 16:43:56 +00:00
Evan Huus
de00c49bd8
Convert a bunch of time_to_str functions to wmem
...
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983
Reviewed-on: https://code.wireshark.org/review/2245
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16 17:26:25 +00:00
Michael Mann
73217d9f3f
tvb_new_subset -> tvb_new_subset_length when length parameters are equal.
...
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.
Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07 15:41:07 +00:00
Pascal Quantin
4eaf1c82c5
MAC LTE: get extended BSR sizes configuration from RRC
...
Change-Id: I09afa7c17be5e0ed902a2c2f5ea9989df3380615
Reviewed-on: https://code.wireshark.org/review/1550
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-08 06:29:21 +00:00
Martin Mathieson
1ddce8bb4c
Have RRC tell MAC about RAPID ranges so it can show for RAPIDs seen
...
Change-Id: Ie9adbe3015c63e53997068053b6f8ec224a5bf82
Reviewed-on: https://code.wireshark.org/review/1474
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-05-03 21:39:20 +00:00
Martin Mathieson
bd6ffea1cd
LTE RRC: break the sr-configIndex down into periodicity and subframe offset
...
Change-Id: I5e153ebba9957f3dc5551f540cf333a1d0ff89f7
Reviewed-on: https://code.wireshark.org/review/1141
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-15 04:16:52 +00:00
Pascal Quantin
b981173669
LTE RRC: fix dissection of SystemInfoListGERAN IE
...
Change-Id: I502f7cd97cf00822900b4cd09e183e3b491c1437
Reviewed-on: https://code.wireshark.org/review/831
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-25 23:14:50 +00:00
Pascal Quantin
3626f860a6
Upgrade LTE RRC dissector to v11.7.0
...
Change-Id: If1f64241846cc18463c8c5e9da7dd2a5eaba6733
Reviewed-on: https://code.wireshark.org/review/752
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-20 15:41:44 +00:00
Bill Meier
1dff4e309d
Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors.
...
Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4
Reviewed-on: https://code.wireshark.org/review/412
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26 19:38:21 +00:00
Jeff Morriss
8c608e6e82
Remove $Id$ from the ASN.1 dissectors and regenerate them.
...
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-18 03:05:28 +00:00
Martin Mathieson
f903141d65
Send news of SecurityModeFailure to PDCP dissector, which will attempt to roll back to previous setting
...
svn path=/trunk/; revision=54978
2014-01-27 12:06:46 +00:00
Guy Harris
c85b34ed66
The strings in question are generated as UTF-8 from the CBS encoding, so
...
process them as such.
svn path=/trunk/; revision=54891
2014-01-22 04:13:37 +00:00
Pascal Quantin
a48b6f4aac
Upgrade LTE RRC dissector to v11.6.0
...
svn path=/trunk/; revision=54789
2014-01-14 16:51:10 +00:00
Jakub Zawadzki
064082e68a
Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)
...
svn path=/trunk/; revision=54314
2013-12-20 22:39:32 +00:00
Evan Huus
2ae8edccea
Rename more to_str functions to have ep_ in the name if they return ephemeral
...
buffers. Remove two unused functions.
svn path=/trunk/; revision=54250
2013-12-19 16:28:39 +00:00
Anders Broman
0d46cdae53
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53876
2013-12-09 06:20:42 +00:00
Pascal Quantin
93398e794e
Use STR_UNICODE display instead of proto_tree_add_unicode_string() in the remaining dissectors
...
svn path=/trunk/; revision=53867
2013-12-08 20:03:15 +00:00
Pascal Quantin
db7405bb13
Dissect UE Rx - Tx time difference field
...
svn path=/trunk/; revision=53557
2013-11-24 23:09:48 +00:00
Michael Mann
9b7fb8a811
Create the ability to have packet scoped "proto" data. Bug 9470 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470 )
...
I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do.
The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As.
All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data.
svn path=/trunk/; revision=53520
2013-11-23 02:20:13 +00:00
Pascal Quantin
ea45be32c5
Add a way to retrieve a PER variable bit string length
...
svn path=/trunk/; revision=53382
2013-11-17 13:31:32 +00:00
Jakub Zawadzki
ae59b09443
Add missing includes in order to remove exceptions.h from proto.h (next commit).
...
svn path=/trunk/; revision=53230
2013-11-10 15:59:37 +00:00
Jakub Zawadzki
1899903f69
Include <epan/to_str.h> only when needed.
...
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
Martin Mathieson
66d64c686e
Pass security command details (integrity and ciphering algorithms) to PDCP (which doesn't yet do much with them)
...
svn path=/trunk/; revision=52946
2013-10-29 13:49:14 +00:00
Pascal Quantin
d74564d6cf
Ensure to release an existing DRX configuration when receiving a RRC Connection Setup message
...
svn path=/trunk/; revision=52193
2013-09-23 21:21:58 +00:00
Pascal Quantin
102c452bcb
More emem -> wmem conversion:
...
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly
svn path=/trunk/; revision=52180
2013-09-22 20:04:35 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Michael Mann
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
Michael Mann
00dd0adc0d
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51851
2013-09-09 00:28:48 +00:00
Martin Mathieson
201f3a3cca
Submit forgotten generated file.
...
svn path=/trunk/; revision=51587
2013-08-30 04:31:02 +00:00
Guy Harris
0675ed7494
Clang, clang, clang went the warning....
...
Fix a memset (drb_mapping is a pointer, so its size is the size of a
pointer; we want the size of what it points to).
svn path=/trunk/; revision=51500
2013-08-23 23:51:52 +00:00
Pascal Quantin
ae4f556630
Simplify logic a bit now that we do not use anymore GUINT_TO_POINTER macro
...
svn path=/trunk/; revision=51490
2013-08-23 12:51:07 +00:00
Pascal Quantin
483ee317f7
From Martin Mathieson:
...
Follow-up of r51429 that
- uses accessors to lazily allocate a private_data struct and returns the different parts based upon their use
- includes the v1130 DRX Config
svn path=/trunk/; revision=51489
2013-08-23 10:42:11 +00:00
Pascal Quantin
75f4fa5b4b
Remove tree check when dissecting PCCH message so as to avoid filtering expert info on first pass
...
svn path=/trunk/; revision=51477
2013-08-22 19:55:25 +00:00
Chris Maynard
b3dc1eed1c
Fix Coverity CID's 1063706-1063710: Out-of-bounds read (OVERRUN_STATIC)
...
svn path=/trunk/; revision=51450
2013-08-21 14:08:42 +00:00
Martin Mathieson
641032ea44
Gather together dedicated DRX configuration, and make sure that it
...
is internally consistent.
TODO: include r11 sequence that can overwrite some of these values.
TODO: actx->private_data gets reused for several purposes, need to
separate these uses out and avoid possible conflicts...
svn path=/trunk/; revision=51429
2013-08-19 17:06:42 +00:00
Pascal Quantin
24e7b8aefd
Fix copy paste error and reinitialize actx->private_data to NULL once used
...
svn path=/trunk/; revision=51311
2013-08-12 09:26:24 +00:00
Martin Mathieson
237182ba42
Use proper macros to cast between uint and pointer
...
svn path=/trunk/; revision=51246
2013-08-10 17:09:12 +00:00
Martin Mathieson
11304a30ee
Try again...
...
svn path=/trunk/; revision=51245
2013-08-10 16:53:05 +00:00
Martin Mathieson
8cddb7a24e
Try using guint.
...
svn path=/trunk/; revision=51244
2013-08-10 16:34:19 +00:00
Martin Mathieson
0fb73abcc9
Add a malformed check to show if GroupA has more RAPIDs than A & B
...
combined.
svn path=/trunk/; revision=51243
2013-08-10 16:17:33 +00:00
Pascal Quantin
802e7bed77
Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0
...
svn path=/trunk/; revision=50837
2013-07-23 14:34:46 +00:00
Pascal Quantin
8c9ab802ce
Upgrade LTE RRC dissector to v11.4.0
...
svn path=/trunk/; revision=50473
2013-07-09 20:39:09 +00:00
Pascal Quantin
b91b990a77
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 :
...
Check actx->private_data validity before using it
svn path=/trunk/; revision=50338
2013-07-03 08:53:47 +00:00
Pascal Quantin
830ebed406
Get rid of global variables
...
svn path=/trunk/; revision=50032
2013-06-19 06:44:39 +00:00
Martin Mathieson
2cf27a92a6
Set PDCP SN length for DRBs for separate RRC element.
...
svn path=/trunk/; revision=50021
2013-06-18 22:38:54 +00:00
Martin Mathieson
868f74d628
Also signal value of PDCP SN (only used if enabled by RLC preferences).
...
svn path=/trunk/; revision=50019
2013-06-18 21:44:48 +00:00
Martin Mathieson
ece132a5ce
Configure MAC LCID -> RLC channel settings from RRC.
...
svn path=/trunk/; revision=50016
2013-06-18 21:02:00 +00:00
Michael Mann
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00