e_ip->ip_ttl is currently always set to 0, in attachment fix.
I also (in same patch, sorry) submit cleanup to use ep_alloc() instead
of static e_ip buffers, I didn't test it, but I hope it's ok.
There's note about static buffers in doc/README.tapping, which should
also be updated, but I don't feel so good with my English :)
From me:
Rename e_ip to ws_ip. Update the static buffers note in README.tapping.
svn path=/trunk/; revision=28425
- Fix typo which caused Properties|Descriptions value field to be incorrectly right-justified;
- Fix several (small) memory leaks;
- Rename variables & rework comments: What was a clist was replaced by a treeview/liststore;
- Remove a left-over line of code still calling a gtk_clist function;
- Rename some constants and variables to more closely reflect usage;
- Add some defensive coding;
- Use gtk_combo_box_get_active_text if GTK+ is 2.6 or greater;
- Simplify code in several places;
- Use consistent indentation;
svn path=/trunk/; revision=28398
The hexdump of the "Follow TCP Stream" feature creates a file that is about 160
characters wide. That's far beyond the size of my screen. The appended patch
suggests a narrower layout.
From me:
Add a note about prepending each line with "C" or "S" instead.
svn path=/trunk/; revision=28386
Consolidate some common code. Rename a bunch of variables. Remove some
unused code.
Fix an offset flag bug in airpcap_loader.c.
This had to be merged by hand with r28349. Hopefully none of those
changes were clobbered.
svn path=/trunk/; revision=28350
that a retap doesn't build the protocol tree unless there's a tap with a
filter; presumably "the expert_item value" refers to the item to which
expert information is being attached.
However, if there's no protocol item, the only thing
expert_add_info_format() doesn't do is set the severity and group for a
protocol item, but the expert info composite dialog doesn't appear to
look at that.
Thus, it appears we can just use cf_retap_packets(); do so, as it's
faster.
svn path=/trunk/; revision=28270
- Re-create packet-list only when Columns change vs every time Edit!Preferences invoked;
- Select next row in Column List after delete of a row;
- Remove no-longer needed code;
- ...
svn path=/trunk/; revision=28268
screen header, similar to the status bar. Hide the welcome body if the
message stack length is > 0. Use this to display the "Waiting for
capture input data..." message when we're capturing from a pipe. This
lets the user know what's going on and keeps them from clicking on a
welcome screen item while we're waiting for data to arrive. You can see
this in action by running
(sleep 5; cat /path/to/a/capture) | wireshark -k -i -
svn path=/trunk/; revision=28196