Commit graph

3943 commits

Author SHA1 Message Date
Bill Meier
9fc44860ff g_string_append_printf() is the correct name of the function (oops).
svn path=/trunk/; revision=28447
2009-05-22 13:08:54 +00:00
Bill Meier
1f80cfc65c Fix usage of several GTK/Glib deprecated functions.
svn path=/trunk/; revision=28446
2009-05-22 12:58:48 +00:00
Bill Meier
6cdedfddd1 gtk_exit() is deprecated; "use the standard exit() function instead"
svn path=/trunk/; revision=28444
2009-05-22 12:36:20 +00:00
Stig Bjørlykke
a6555ef9c3 Small improvements for the compare capture files dialog:
- Added autocompletion in the filter entry
- Added a help button (documentation TBD)

svn path=/trunk/; revision=28440
2009-05-21 22:10:17 +00:00
Gerald Combs
fcd9a56161 From Vincenzo Condoleo via bug 2589:
Add IP packet comparison statistics.

svn path=/trunk/; revision=28426
2009-05-20 17:07:18 +00:00
Gerald Combs
e2c0d132e1 From Jakub Zawadzki via bug 3421:
e_ip->ip_ttl is currently always set to 0, in attachment fix. 

I also (in same patch, sorry) submit cleanup to use ep_alloc() instead
of static e_ip buffers, I didn't test it, but I hope it's ok.

There's note about static buffers in doc/README.tapping, which should
also be updated, but I don't feel so good with my English :)

From me:

Rename e_ip to ws_ip. Update the static buffers note in README.tapping.

svn path=/trunk/; revision=28425
2009-05-20 15:50:40 +00:00
Bill Meier
79e537af33 expert_comp: Fix some memory leaks (several non-trivial);
Fix hack wherein a ptr was stored using the address of an int (could cause Win64 crash ?)
  Use consistent indentation;

svn path=/trunk/; revision=28410
2009-05-19 15:53:26 +00:00
Bill Meier
b65b001476 prefs_column: fix a small memory leak.
svn path=/trunk/; revision=28403
2009-05-18 22:21:16 +00:00
Stig Bjørlykke
4d3a7aa966 Use g_strdup_printf() instead of g_snprintf() with a fixed buffer.
svn path=/trunk/; revision=28402
2009-05-18 22:01:19 +00:00
Stig Bjørlykke
cfde6d67df Fix a small memory leak.
svn path=/trunk/; revision=28401
2009-05-18 21:48:48 +00:00
Bill Meier
7b6265b63e pixmap_save: fix a small memory leak.
svn path=/trunk/; revision=28400
2009-05-18 21:42:09 +00:00
Bill Meier
5daf89e386 mtp3_summary: fix a small memory leak.
svn path=/trunk/; revision=28399
2009-05-18 21:23:24 +00:00
Bill Meier
0608bff3c2 prefs_capture: Interface Options Edit dialog: code cleanup;
- Fix typo which caused Properties|Descriptions value field to be incorrectly right-justified;
- Fix several (small) memory leaks;
- Rename variables & rework comments: What was a clist was replaced by a treeview/liststore;
- Remove a left-over line of code still calling a gtk_clist function;
- Rename some constants and variables to more closely reflect usage;
- Add some defensive coding; 
- Use gtk_combo_box_get_active_text if GTK+ is 2.6 or greater;
- Simplify code in several places;
- Use consistent indentation;

svn path=/trunk/; revision=28398
2009-05-18 20:57:06 +00:00
Anders Broman
25329d1427 Don't skipp the first entry.
svn path=/trunk/; revision=28393
2009-05-18 16:43:48 +00:00
Gerald Combs
2dacd2ff63 From Roland Illig via bug 1764:
The hexdump of the "Follow TCP Stream" feature creates a file that is about 160
characters wide. That's far beyond the size of my screen. The appended patch
suggests a narrower layout.

From me:

Add a note about prepending each line with "C" or "S" instead.

svn path=/trunk/; revision=28386
2009-05-17 19:34:30 +00:00
Jaap Keuter
5f900d062c Extend error reporting from PortAudio library.
svn path=/trunk/; revision=28358
2009-05-14 06:26:16 +00:00
Jörg Mayer
6d2afb455a Remove airpcap_get_all_channels_list, it isn't used
anywhere.

svn path=/trunk/; revision=28354
2009-05-13 17:46:16 +00:00
Jörg Mayer
c3011f7b22 Forgot to convert the types in these files as well.
svn path=/trunk/; revision=28353
2009-05-13 17:43:03 +00:00
Jörg Mayer
32becb4637 () -> (void)
svn path=/trunk/; revision=28352
2009-05-13 17:29:13 +00:00
Stig Bjørlykke
e4aa2ae13f Don't check if unsigned values are > 0.
Removed some unused variables and marked some unused arguments.

svn path=/trunk/; revision=28351
2009-05-13 17:13:03 +00:00
Gerald Combs
0a069bc6a3 Migrate the Airpcap UI code from GtkCombos (deprecated) to GtkComboBoxes.
Consolidate some common code. Rename a bunch of variables. Remove some
unused code.

Fix an offset flag bug in airpcap_loader.c.

This had to be merged by hand with r28349. Hopefully none of those
changes were clobbered.

svn path=/trunk/; revision=28350
2009-05-13 16:14:28 +00:00
Stig Bjørlykke
95be22667a Do not prototype static functions in the header file.
Removed some unused empty functions.
Mark some unused arguments.
Removed some unused variables.

svn path=/trunk/; revision=28349
2009-05-13 10:29:42 +00:00
Stig Bjørlykke
a5c7194afc Make it compile without warnings on OSX.
Removed unused wep_closed_24.xpm.

svn path=/trunk/; revision=28348
2009-05-13 10:15:18 +00:00
Stig Bjørlykke
c38de722d0 Fixed some compiler warnings on OSX.
Removed some unused variables.

svn path=/trunk/; revision=28347
2009-05-13 10:13:33 +00:00
Stig Bjørlykke
afa8408b1c Removed some unused variables.
svn path=/trunk/; revision=28346
2009-05-13 10:04:58 +00:00
Stig Bjørlykke
ccf0c65532 Initialize some uninitialized variables.
svn path=/trunk/; revision=28345
2009-05-13 10:03:12 +00:00
Stig Bjørlykke
182c7138e4 Removed an unused variable.
svn path=/trunk/; revision=28344
2009-05-13 10:02:23 +00:00
Jörg Mayer
797bd60ef7 ULONG -> guint32
svn path=/trunk/; revision=28339
2009-05-13 04:51:48 +00:00
Jörg Mayer
54d5fdd08d #if 0 out an unused function declaration. Make it
match its implementation return type anyway.

The Airpcap icon should only depend of HAVE_AIRPCAP
but not on _WIN32


svn path=/trunk/; revision=28330
2009-05-11 18:29:23 +00:00
Tomas Kukosa
0a101aacf6 Make gtk/capture_if_details_dlg_win32.c compileable using MSVC6 with SDK
svn path=/trunk/; revision=28314
2009-05-08 19:53:41 +00:00
Anders Broman
4c2cdc36bc Clist -> list_store
svn path=/trunk/; revision=28310
2009-05-08 18:12:13 +00:00
Jörg Mayer
af417beb8e Warningfix:
function() -> function(void)

svn path=/trunk/; revision=28302
2009-05-08 15:16:07 +00:00
Bill Meier
fc0a57d2ca Restore original spacing in several constant strings
(as it was before I introduced some incorrect 'tabification' in SVN 27773)

svn path=/trunk/; revision=28294
2009-05-07 17:54:32 +00:00
Bill Meier
d436de7985 Change some usage of tabs within string constants to spaces.
svn path=/trunk/; revision=28293
2009-05-07 15:30:59 +00:00
Bill Meier
e88bdea0bb gtk_check_menu_item_set_show_toggle() is deprecated and not needed.
[show_toggle is always TRUE].

svn path=/trunk/; revision=28292
2009-05-07 14:35:02 +00:00
Bill Meier
809966abb3 Analyze!EnabledProtocols: Remove unnecessary line of code added in the previous commit;
svn path=/trunk/; revision=28290
2009-05-06 15:38:43 +00:00
Bill Meier
2bcb8d7418 Analyze!Enabled Protocols: For OK/Apply/Cancel: Cancel reverts to "Last Saved" (ie: state after any Apply)
svn path=/trunk/; revision=28289
2009-05-06 15:27:39 +00:00
Anders Broman
7daa41088b Get rid of deprecated functions by removing
"#if 0":ed code.

svn path=/trunk/; revision=28278
2009-05-05 18:37:22 +00:00
Anders Broman
a388c435fc Get rid of deprecated functions:
gtk_type_class (); ->  g_type_class_ref ();

svn path=/trunk/; revision=28277
2009-05-05 18:35:44 +00:00
Bill Meier
f7f397581e prefs_dlg: Cancel always reverts to "Last Saved" [Part 1]
svn path=/trunk/; revision=28276
2009-05-05 13:19:46 +00:00
Guy Harris
27bc1690c7 The reason why the expert_item value is null when performing a retap is
that a retap doesn't build the protocol tree unless there's a tap with a
filter; presumably "the expert_item value" refers to the item to which
expert information is being attached.

However, if there's no protocol item, the only thing
expert_add_info_format() doesn't do is set the severity and group for a
protocol item, but the expert info composite dialog doesn't appear to
look at that.

Thus, it appears we can just use cf_retap_packets(); do so, as it's
faster.

svn path=/trunk/; revision=28270
2009-05-05 00:35:54 +00:00
Stig Bjørlykke
6e0dc25aa9 From Didier Gautheron (bug 3126):
Update expert info icon on redissect.

svn path=/trunk/; revision=28269
2009-05-04 21:13:14 +00:00
Bill Meier
40d7944873 prefs_column: Rework & cleanup Column Preferences dialog code
- Re-create packet-list only when Columns change vs every time Edit!Preferences invoked;
 - Select next row in Column List after delete of a row;
 - Remove no-longer needed code;
 - ...

svn path=/trunk/; revision=28268
2009-05-04 14:46:51 +00:00
Bill Meier
99620ce502 Fix some spelling, reword some comments & etc.
svn path=/trunk/; revision=28267
2009-05-04 14:22:30 +00:00
Bill Meier
94c5bee0db prefs_dlg: Fix an inadvertant character deletion in last commit;
svn path=/trunk/; revision=28266
2009-05-03 17:57:06 +00:00
Bill Meier
6d5ce0f34e prefs_dlg: use consistent indentation
svn path=/trunk/; revision=28265
2009-05-03 17:50:51 +00:00
Bill Meier
3cae24b6fe Use consistent indentation
svn path=/trunk/; revision=28233
2009-05-01 16:36:04 +00:00
Gerald Combs
4ea71f1095 Add the ability to push and pop messages in to and out of the welcome
screen header, similar to the status bar. Hide the welcome body if the
message stack length is > 0.  Use this to display the "Waiting for
capture input data..." message when we're capturing from a pipe. This
lets the user know what's going on and keeps them from clicking on a
welcome screen item while we're waiting for data to arrive.  You can see
this in action by running

   (sleep 5; cat /path/to/a/capture) | wireshark -k -i -

svn path=/trunk/; revision=28196
2009-04-29 22:42:33 +00:00
Bill Meier
ac06ea0517 find_dlg: handler_id returned from g_signal_connect is gulong (not int)
svn path=/trunk/; revision=28189
2009-04-28 03:00:40 +00:00
Bill Meier
9428d8a7d0 follow_stream: Oops: revert making functions static.
svn path=/trunk/; revision=28178
2009-04-27 14:56:07 +00:00