Commit Graph

50 Commits

Author SHA1 Message Date
Anders Broman 4763f36a75 Omit assignment for not used types.
svn path=/trunk/; revision=54588
2014-01-04 11:26:30 +00:00
Anders Broman 2b32fed0ef Omit assignment for not used types.
svn path=/trunk/; revision=54587
2014-01-04 11:24:33 +00:00
Anders Broman 72970675bd Add the rest of the NOKIA extensions.
svn path=/trunk/; revision=54586
2014-01-04 10:06:04 +00:00
Anders Broman 4f62f2cfa3 Add a few more of the NOKIA extensions.
svn path=/trunk/; revision=54580
2014-01-03 13:29:48 +00:00
Pascal Quantin 6ebc058f47 Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it.
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.

svn path=/trunk/; revision=54534
2014-01-01 14:33:19 +00:00
Guy Harris edb6cf0b16 Get rid of no-longer-used variables.
svn path=/trunk/; revision=54433
2013-12-24 01:30:00 +00:00
Guy Harris 0d7a48a8bf Add a ENC_3GPP_TS_23_038 encoding, for the standard SMS alphabet in a
bit-packed string, and use it in some places.

svn path=/trunk/; revision=54428
2013-12-24 00:20:09 +00:00
Guy Harris 5084f58ce2 We support ENC_UCS_2, so use that in proto_tree_add_item() and
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.

svn path=/trunk/; revision=54350
2013-12-22 02:12:32 +00:00
Anders Broman 861e0334f4 From Vineeth:
Support for Nokias GSM MAP Private Extensions

svn path=/trunk/; revision=53600
2013-11-26 20:29:17 +00:00
Michael Mann c0fcebb07a Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new.
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector.  For now, all calls to call_ber_oid_callback have the data parameter set to NULL.

svn path=/trunk/; revision=52994
2013-10-31 00:57:03 +00:00
Bill Meier 0ad98563a2 From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for  replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
    + before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set

   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344


svn path=/trunk/; revision=52948
2013-10-29 14:09:20 +00:00
Pascal Quantin 76e8ff1d8d Replace the 3 dissector tables (with a single entry in each) by a direct call to the GSM SMS dissector
svn path=/trunk/; revision=52336
2013-10-02 18:04:06 +00:00
Pascal Quantin a0c53ffaa1 emem -> wmem conversion:
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Jörg Mayer c5ffff76d8 Fix checkapi warnings (missing id)
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.

svn path=/trunk/; revision=52062
2013-09-15 15:00:03 +00:00
Anders Broman 08d223eb71 When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015

svn path=/trunk/; revision=51208
2013-08-08 04:36:54 +00:00
Anders Broman 5b279569d2 Export CellGlobalIdOrServiceAreaIdOrLAI.
svn path=/trunk/; revision=49312
2013-05-15 16:48:49 +00:00
Balint Reczey 1ebdb2e521 Export libwireshark symbols using WS_DLL_PUBLIC define
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.

svn path=/trunk/; revision=47992
2013-03-01 23:53:11 +00:00
Pascal Quantin 7fdbff4822 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 :
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly.

svn path=/trunk/; revision=47927
2013-02-27 23:08:17 +00:00
Anders Broman e5556e29ce Export TBCD-STRING.
svn path=/trunk/; revision=47496
2013-02-05 15:12:13 +00:00
Jaap Keuter f177deead0 Fix for CID 280252.
We can be sure we've at least 0 bytes remaining in the TVB.

svn path=/trunk/; revision=47162
2013-01-19 13:06:26 +00:00
Pascal Quantin f2fbb79c49 Add dissection of locationInformation IE in Ericsson proprietary extension
svn path=/trunk/; revision=44605
2012-08-21 15:14:50 +00:00
Pascal Quantin 9f3c1253f7 Fix filter names for Ericsson proprietary extensions
svn path=/trunk/; revision=44604
2012-08-21 10:40:04 +00:00
Pascal Quantin 45a25dbf9e Avoid defining 2 entries with incompatible types (FT_BYTES vs FT_NONE) and same filter
svn path=/trunk/; revision=44595
2012-08-20 09:28:01 +00:00
Pascal Quantin f275aeadd9 Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2
svn path=/trunk/; revision=43059
2012-06-04 10:02:08 +00:00
Anders Broman 10fe76d8a0 Get rid of a couple of warnings.
svn path=/trunk/; revision=43057
2012-06-04 08:56:48 +00:00
Guy Harris dedf907787 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42485
2012-05-07 21:04:05 +00:00
pascal 7ded30acc1 Set direction according to destination address field also (and not only originating address).
svn path=/trunk/; revision=42065
2012-04-14 11:59:14 +00:00
Anders Broman 95a7a04557 Location Number not decoded as per Q.763 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6781
svn path=/trunk/; revision=41393
2012-03-07 12:06:16 +00:00
Anders Broman 6b3c0cd4f8 Remove now unused variables.
svn path=/trunk/; revision=41319
2012-03-02 11:25:17 +00:00
Alexis La Goutte c1ff84a632 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41296
2012-03-02 10:57:48 +00:00
Anders Broman e1d434ee6a From Mike Morrin:
Add dissectors for GSM and UMTS Cell Broadcast protocols.
( - the patch for gsmtap )

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40735
2012-01-26 19:51:48 +00:00
Anders Broman 512e379901 Wireshark crashes in gsm_map dissector
For now use Jeff's fix:
"The REAL problem is that the GSM_MAP dissector is using this value_string_ext
in the hf without BASE_EXT_STRING:

    { &hf_gsm_old_localValue,
      { "localValue", "gsm_old.localValue",
        FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0,
        "OperationLocalvalue", HFILL }},

This, in turn, appears to be caused because OperationLocalValue is an alias
for/of GSMMAPOperationLocalValue and only the latter is defined with
.USE_VALS_EXT.

I can fix it by doing:

Index: asn1/gsm_map/gsm_map.cnf
===================================================================
--- asn1/gsm_map/gsm_map.cnf    (revision 39628)
+++ asn1/gsm_map/gsm_map.cnf    (working copy)
@@ -54,6 +54,7 @@

 #.USE_VALS_EXT
 GSMMAPOperationLocalvalue
+OperationLocalvalue

 #.EXPORTS
 AddressString


But it seems to be that asn2wrs should arguably be figuring this out on its
own."

svn path=/trunk/; revision=40033
2011-11-29 07:03:31 +00:00
Anders Broman 7669c6affd Export NAEA-CIC to be used by Camel.
svn path=/trunk/; revision=39711
2011-11-02 06:38:46 +00:00
Anders Broman 83b98f5e2c Add exports
svn path=/trunk/; revision=39296
2011-10-06 18:46:47 +00:00
Anders Broman 0007775464 Make it possible to dissect proprietarry Opcodes.
svn path=/trunk/; revision=39183
2011-09-29 15:23:23 +00:00
Anders Broman a5839116d3 Pretyfy APN display and make it filterable as a string.
svn path=/trunk/; revision=37731
2011-06-20 10:29:46 +00:00
Jeff Morriss 7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields
directly.

svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman 23e6582724 Add miisng file from
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36079

svn path=/trunk/; revision=36085
2011-02-27 19:41:34 +00:00
Anders Broman 527942b05a Add exports.
svn path=/trunk/; revision=36049
2011-02-24 15:06:16 +00:00
Anders Broman 6d4964bb49 Export more functions.
svn path=/trunk/; revision=35757
2011-02-02 17:09:05 +00:00
Anders Broman 568605ae13 r35546 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.
Make the change also in the .cnf file

svn path=/trunk/; revision=35551
2011-01-16 08:24:11 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Gerasimos Dimitriadis dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Anders Broman 0aabfbf3f8 Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31413
2010-01-02 22:12:14 +00:00
Guy Harris 68cf37f81b Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).

svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Kovarththanan Rajaratnam cdcd98e0bb gsmmap -> gsm_map to make directory name consistent with filenames
svn path=/trunk/; revision=30470
2009-10-10 12:37:56 +00:00