Stig Bjørlykke
8c48b5f932
Make it compile.
...
svn path=/trunk/; revision=38254
2011-07-29 10:53:51 +00:00
Guy Harris
eaecea41a3
Get rid of non-ASCII characters.
...
Clean up white space.
Clean up capitalization a bit.
svn path=/trunk/; revision=38253
2011-07-29 10:28:29 +00:00
Michael Tüxen
c6b79979c2
Get it compiling.
...
svn path=/trunk/; revision=38250
2011-07-29 07:24:15 +00:00
Anders Broman
bbf4437af0
From Wido Kelling:
...
Add Dissection of newly released PNIO IEC 61158 Version 2.3.
From me use ENC_BIG_ENDIAN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6154
svn path=/trunk/; revision=38249
2011-07-29 05:36:57 +00:00
Bill Meier
f161dc95fa
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38150
2011-07-21 19:10:10 +00:00
Guy Harris
c34b796445
Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
...
representation. Use it rather than a raw 0x10.
Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".
Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.
Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().
Clean up white space.
svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Anders Broman
8e4aa22fa0
From Kluchnikov Ivan:
...
Decoding Phy Synchronization Field in wimax DL-MAP and Compressed DL-MAP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6068
svn path=/trunk/; revision=37921
2011-07-06 15:39:25 +00:00
Anders Broman
42dcd2af62
From Guido Reismueller:
...
This patch includes alle modem capabilities from DOCSIS 3.0
Until now only modem capabilities 1-12 where implemented.
Now all capabilities 1-40 are included.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6070
svn path=/trunk/; revision=37892
2011-07-04 20:34:04 +00:00
Anders Broman
cdfadace98
From Kluchnikov Ivan:
...
Update wimax DCD Message mac version values.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6069
svn path=/trunk/; revision=37891
2011-07-04 15:04:50 +00:00
Anders Broman
d6fda1f1f5
From Kluchnikov Ivan:
...
Wrong length of items in wimax Compressed DL-MAP and UL-MAP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6067
svn path=/trunk/; revision=37890
2011-07-04 14:57:12 +00:00
Anders Broman
4257e61b6c
From Kluchnikov Ivan:
...
Wireshark cannot decode wimax compressed DL-MAP without FCH burst.
Function is_down_link use the base station address (bs_address), which is set
in function dissect_wimax_fch_decoder.
Changed function is_down_link, it use packet_info->p2p_dir for check if packet
is downlink.
packet_info->p2p_dir set in GSMTAP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6066
svn path=/trunk/; revision=37889
2011-07-04 14:33:22 +00:00
Anders Broman
3826755b0a
From Roland Knall:
...
implement a named dissector for the PN/IO sub-protocol for
Profinet, as well as a heuristic dissector ("pn_io"), other protocols can
attach too.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6062
svn path=/trunk/; revision=37882
2011-07-03 19:25:34 +00:00
Stig Bjørlykke
8443bbbf75
Replace all strerror() with g_strerror().
...
Remove our local strerror implementation.
Mark strerror as locale unsafe API.
This fixes bug 5715.
svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Anders Broman
f2c3e81b4a
Remove theinterlinki plugin dir as it's now a builtin dissector.
...
svn path=/trunk/; revision=37611
2011-06-08 05:23:17 +00:00
Anders Broman
afb0e8b434
From Michael Mann:
...
Make interlink built-in dissector (from plugin).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6005
svn path=/trunk/; revision=37610
2011-06-08 05:20:43 +00:00
Anders Broman
6ad93d0bd9
Remove the sercosiii plugin dir as it's now a builtin dissector.
...
svn path=/trunk/; revision=37608
2011-06-08 04:55:29 +00:00
Anders Broman
d8e1b0d3d5
Move packet-sercosiii.c to be a builtin dissector.
...
svn path=/trunk/; revision=37597
2011-06-07 20:33:26 +00:00
Anders Broman
2bc6ecf4c1
From Michael Mann:
...
I made 2 changes when merging the source into a single file:
1. Changed filtername to "siii" to match display filter fields (was quicker
than changing all display filter fields to "sercosiii"
2. Converted the "ett_siii arrays" to a single value. Each subtree doesn't
need its own ett_ value.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5990
svn path=/trunk/; revision=37574
2011-06-06 19:45:51 +00:00
Chris Maynard
87e588c336
Add SVN Id and GPL. Minor whitespace cleanup.
...
svn path=/trunk/; revision=37412
2011-05-26 16:03:29 +00:00
Anders Broman
39adb6e303
Add the possibillity of adding custom extra dist files.
...
svn path=/trunk/; revision=37411
2011-05-26 14:44:12 +00:00
Bill Meier
7062abeb00
Don't assign a value to a variable which is then never used: Coverity 1160 [UNUSED]
...
svn path=/trunk/; revision=37290
2011-05-19 14:11:01 +00:00
Jörg Mayer
2b3167dcf9
Fix another old style function declaration warning
...
svn path=/trunk/; revision=37281
2011-05-19 05:08:42 +00:00
Gerald Combs
b223e99e5a
get_host_ipaddr() was returning numeric addresses in host byte order
...
and hostnames in network byte order. Have it return everything in
network byte order.
svn path=/trunk/; revision=36873
2011-04-26 17:13:37 +00:00
Chris Maynard
cfca66f6e1
Remove const qualifier to name, abbrev and blurb to pacify the buildbots.
...
svn path=/trunk/; revision=36860
2011-04-26 01:06:25 +00:00
Guy Harris
34f8f7e77d
Get rid of some unnecessary casts that just provoke uninteresting
...
warnings.
More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".
svn path=/trunk/; revision=36856
2011-04-25 21:20:47 +00:00
Guy Harris
d6fdc37988
More fun with GArrays: cast away some warnings that don't report real
...
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".
svn path=/trunk/; revision=36855
2011-04-25 21:19:54 +00:00
Guy Harris
61fcd3200b
Assume the tags are mallocated, so they're properly aligned. Cast away
...
the warnings.
svn path=/trunk/; revision=36816
2011-04-22 17:05:28 +00:00
Jeff Morriss
1229678a46
Use the return value of proto_item_add_subtree(): put the filter masks in their own subtree (as it appears was intended).
...
svn path=/trunk/; revision=36811
2011-04-22 14:48:10 +00:00
Alexis La Goutte
2fc740d7d1
Fix (latest) Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36802
2011-04-22 13:11:52 +00:00
Alexis La Goutte
ed3a223400
From http://www.wireshark.org/lists/wireshark-dev/201104/msg00231.html
...
Always use the returned tree value of proto_tree_add_subtree (and not the item!)
svn path=/trunk/; revision=36801
2011-04-22 13:07:11 +00:00
Alexis La Goutte
83aea790d4
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=36772
2011-04-21 16:01:03 +00:00
Alexis La Goutte
0c598a950d
Fix Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36756
2011-04-21 13:33:04 +00:00
Alexis La Goutte
ab38454697
Fix Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36754
2011-04-21 13:32:11 +00:00
Jörg Mayer
4b87a3d770
CID 1161: Not really used variable
...
svn path=/trunk/; revision=36725
2011-04-19 21:20:15 +00:00
Jörg Mayer
8efd127f31
CID 1162: Not really used variable
...
svn path=/trunk/; revision=36724
2011-04-19 21:15:58 +00:00
Anders Broman
67900c23be
Fix Unused varaiable warnings.
...
CID 1163 - 1166
svn path=/trunk/; revision=36675
2011-04-17 09:34:38 +00:00
Bill Meier
e07cb22a47
Rework whitespace.
...
svn path=/trunk/; revision=36583
2011-04-12 14:33:30 +00:00
Bill Meier
c424bd7c83
Don't assign to a proto_item * if the value won't be used: Coverity 1158 & 1159.
...
svn path=/trunk/; revision=36581
2011-04-12 13:27:08 +00:00
Bill Meier
e3f4dc17a9
localtime() can return a NULL ptr.
...
svn path=/trunk/; revision=36580
2011-04-12 13:21:32 +00:00
Gerald Combs
3e44421764
Either remove or use unused values found by Coverity. Fixes CIDs
...
1169-1172.
svn path=/trunk/; revision=36500
2011-04-06 18:59:36 +00:00
Chris Maynard
735b61500c
Don't dereference a NULL pointer. Fixes CID 426.
...
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
Anders Broman
645cfe9ef2
Add a missing break.
...
CID 487
svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
Anders Broman
ce248d9ea9
Add a missing break.
...
CID 488
svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
Anders Broman
2b81b097e5
Add a missing break.
...
CID 490
svn path=/trunk/; revision=36401
2011-03-29 21:08:34 +00:00
Anders Broman
bc0fbb792a
Added FALLTHRU comment to avoid a "missing break" warning.
...
CID 489
svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Martin Mathieson
7356320a2a
Don't assign proto_item pointers that are not used.
...
Coverity 1174
svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Chris Maynard
10928bc0cc
Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
...
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.
svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Bill Meier
7c41d527fd
Removed uneeded 'continue'.
...
Fixes Coverity 815 ("UNREACHABLE").
svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
Bill Meier
78c5c20d08
Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;
...
Also:
- Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
done on an already hidden item).
- Minor indentation cleanup;
svn path=/trunk/; revision=36315
2011-03-24 21:19:39 +00:00
Bill Meier
b9331456e9
Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;
...
svn path=/trunk/; revision=36312
2011-03-24 17:37:07 +00:00