clearer what it does (dissect a single T.38-over-TCP or T.38-over-TPKT
PDU).
Have "dissect_t38_udp()" that does T.38-over-UDP dissection and
"dissect_t38_tcp()" that does T.38-over-TCP dissection; register handles
for them for the appropriate protocols, rather than having a single
dissector that checks the IP protocol type.
Use -1 rather than "tvb_length(tvb)" as the length for top-level
protocol tree items.
Clean up indentation.
svn path=/trunk/; revision=9870
- support both T.38IFP/TCP and T38IFP/TPKT/TCP
There is one new preference setting tpkt_usage where you can specify if TPKT
header is used. With the default setting (tpkt_usage=Maybe) the dissector
will look on the first four octets and try to determine if TPKT is used or
not. This setting seems to work well with the captures I have tried,
but there might be some scenarios where it will be better to set the value
to 'Always' or 'Never' dependant on if TPKT header is used or not.
There is also a new preference setting regarding TCP desegmentation. TCP
desegmentation is currently only supported when TPKT header
is used.
You will need to set the preference setting "Allow subdisectors to desegment
TCP streams" for TCP and also the "Desegment all TPKT
messages spanning multiple TCP segments" for TPKT if you want to use this
feature. I don't have any T.38 captures with segmented packets
so I have not been able to test this so much.
- Support for T.38 (2002) ASN.1 specification
http://www.itu.int/ITU-T/asn1/database/itu-t/t/t38/2003/T38(2002).html
Note: This ASN.1 specification is incompatible with the Pre-Corigendum T.38
ASN.1 specification (1998) so you will need to set the preference setting
accordingly.
- When there are extra octets after the T.38 UDPTL packet you will now see
[Malformed?] in the Info-column. I thought that it
was quite irritating that non-T.38 packets could look like they were
correctly coded T.38 packets.
- There might be several T.38 IFP packets in a TCP packet for the T.38
directly over TCP scenario. There is now at least some support for this, but
since
TCP desegmentation is only supported for the TPKT scenario this will not
work if an IFP packet is splitted into several TCP packets.
svn path=/trunk/; revision=9868
temporary hack added to check for packets that look like RTPv2
packets and to dissect them as such (the right fix is to support
starting and ending frames in conversations and to have H.245
close UDP conversations when appropriate and start new ones);
add preferences for the UDP and TCP port numbers;
add a preference to specify whether to use pre-corrigendum T.38
or post-corrigendum T.38;
give a summary in the Info column.
svn path=/trunk/; revision=9622
Guy Harris