ba14c67566
Use correct field types for variable length fields.
...
Fixed types by adding new types for "undissected" blocks:
- Replace Bridge Address
- Multicast With Response
- Confirm Network Encryption Key
- Host Tag
svn path=/trunk/; revision=29741
2009-09-06 11:24:56 +00:00
ecd9ddd845
Tigthen the condition under which we create a protocol create while sorting
...
svn path=/trunk/; revision=29740
2009-09-06 10:41:35 +00:00
09237c27f9
Inline col_has_time_fmt() into col_based_on_frame_data()
...
svn path=/trunk/; revision=29739
2009-09-06 10:03:06 +00:00
8edec9be91
Sort the visible list while traversing the physical row list. This halves the time needed to sort
...
svn path=/trunk/; revision=29738
2009-09-06 09:36:21 +00:00
474f5930db
Macrofy have_custom_cols() -> HAVE_CUSTOM_COLS() internally in columns-utils.c
...
svn path=/trunk/; revision=29737
2009-09-06 09:11:17 +00:00
22077a8eb1
Macrofy check_col() -> CHECK_COL() internally in columns-utils.c
...
svn path=/trunk/; revision=29736
2009-09-06 09:03:15 +00:00
137b886960
From Didier Gautheron:
...
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize address handling.
The address hash should be possible to use from the new_packet_list.
svn path=/trunk/; revision=29735
2009-09-06 08:59:30 +00:00
b91827f5a0
Avoid calling emem_create_chunk() needlessly
...
svn path=/trunk/; revision=29734
2009-09-06 08:10:12 +00:00
b3b9be09c7
We track all protocols that appear in each packet in the frame dissector. This is an expensive operation because we:
...
* Disable the TRY_TO_FAKE_THIS_ITEM optimization
* Use GString to store the protocols
We should only do this if the 'hf_frame_protocols' is referenced (unlikely)
svn path=/trunk/; revision=29733
2009-09-06 07:55:17 +00:00
820ce62af5
This fix was supposed to be in r29731 which some how only contained whitespace changes.
...
svn path=/trunk/; revision=29732
2009-09-06 07:33:07 +00:00
9c512f7cb4
Introduce TRY_TO_FAKE_THIS_REPR which is an optimization similar to the existing TRY_TO_FAKE_THIS_ITEM. The purpose of TRY_TO_FAKE_THIS_REPR is to avoid generating the string representation for the protocol item. There is no point in doing this if the protocol tree isn't visible. In this case the result will be discarded any way.
...
svn path=/trunk/; revision=29731
2009-09-06 07:24:54 +00:00
4df25480b7
The frame dissector disables the TRY_TO_FAKE_THIS_ITEM() optimization by marking the protocol tree as permamently visible. It only needs to disable the optimization temporarily while it creates the protocol item it intends to use proto_item_append_string() on
...
svn path=/trunk/; revision=29730
2009-09-06 06:33:13 +00:00
5c51aacb21
Add NEW_PACKET_LIST guard to color_filters_colorize_packet()
...
svn path=/trunk/; revision=29729
2009-09-06 06:07:53 +00:00
2ab0685d8a
Make sure that we can enable/disable color filtering.
...
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12
svn path=/trunk/; revision=29728
2009-09-06 05:49:00 +00:00
f352fa6d90
s/col_add_fstr/col_add_str
...
svn path=/trunk/; revision=29727
2009-09-06 05:29:51 +00:00
6fe1060cd1
Don't pass ep_alloc()'ed strings to col_set_str().
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984
svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
a9e644f382
Changed type for "Wireless data" to FT_BYTES.
...
svn path=/trunk/; revision=29725
2009-09-05 22:12:51 +00:00
07b1329a7c
Remove an obsolete gui_time_format setting.
...
svn path=/trunk/; revision=29724
2009-09-05 19:42:43 +00:00
0326f65bf3
Don't copy constant column strings. This reduces memory foot print because COL_PROTOCOL is usually a constant string. This saves us 3-4 bytes for each frame
...
svn path=/trunk/; revision=29723
2009-09-05 19:07:04 +00:00
7d4cf0b966
col_custom_set_fstr() is unused. Remove it
...
svn path=/trunk/; revision=29722
2009-09-05 18:45:55 +00:00
a108023b2a
COL_BSSGP_TLLI is deprecated
...
svn path=/trunk/; revision=29721
2009-09-05 18:39:46 +00:00
7e8455ff63
Reorder col_fill_in()
...
svn path=/trunk/; revision=29720
2009-09-05 18:28:06 +00:00
8024460bc0
Move reloading pane geometry to a point where we have the correct
...
main_first_pane and main_second_pane.
svn path=/trunk/; revision=29719
2009-09-05 18:13:48 +00:00
f493e75db6
Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now.
...
svn path=/trunk/; revision=29718
2009-09-05 16:35:05 +00:00
e1eaab161d
Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort
...
svn path=/trunk/; revision=29717
2009-09-05 15:46:47 +00:00
583d41904c
Inline cache_columns()
...
svn path=/trunk/; revision=29716
2009-09-05 15:30:34 +00:00
4aa6c8baef
Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame
...
svn path=/trunk/; revision=29715
2009-09-05 15:25:53 +00:00
5a7d9922c1
Fetch old column width values if we have not initialized the packet list,
...
so we don't write zero width values if closing before loading a capture.
svn path=/trunk/; revision=29714
2009-09-05 14:37:02 +00:00
fb54567dae
Restore original condition in packet_list_iter_n_children()
...
svn path=/trunk/; revision=29713
2009-09-05 13:46:17 +00:00
45bdd7577b
Apply user font when changing profile with new packet list.
...
svn path=/trunk/; revision=29712
2009-09-05 13:30:16 +00:00
fcf25fe42b
Get rid of row_data_t
...
svn path=/trunk/; revision=29711
2009-09-05 13:27:34 +00:00
2d5a1323e1
Make sure that we can resort with an active display filter
...
svn path=/trunk/; revision=29710
2009-09-05 13:24:16 +00:00
e275d24c39
Ignore preferences for deleted protocols "etheric" and "isup_thin".
...
svn path=/trunk/; revision=29709
2009-09-05 13:06:45 +00:00
a71f9bbde3
Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking.
...
svn path=/trunk/; revision=29708
2009-09-05 12:42:44 +00:00
2db51a0b3e
Bail out gracefully on colums we cant sort on yet instead of crashing
...
svn path=/trunk/; revision=29707
2009-09-05 11:58:44 +00:00
f91c46757a
Make it build without warnings.
...
svn path=/trunk/; revision=29706
2009-09-05 11:15:50 +00:00
95ddec4d07
Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible.
...
svn path=/trunk/; revision=29705
2009-09-05 10:36:29 +00:00
b7bdf3efc1
A few minor revisions:
...
- if (check_col ...) no longer required;
- Use match_strval when verifying the fcn code;
- Add a missing #ifdef;
- Make a global variable static;
- Fix indentation to be consistent in a few places.
svn path=/trunk/; revision=29701
2009-09-04 18:40:02 +00:00
3ab20de02b
From Rob Casey: Fix for: Incorrect station identifier parsing in Kingfisher dissector
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3946
svn path=/trunk/; revision=29700
2009-09-04 18:18:34 +00:00
314b693828
Rename new_packet_list_reset_dissected to packet_list_reset_dissected
...
svn path=/trunk/; revision=29699
2009-09-04 17:42:03 +00:00
798b1ecdb2
Cleanup whitespaces.
...
svn path=/trunk/; revision=29698
2009-09-04 13:23:51 +00:00
471111ffc6
Fix handling of multiple duplicate TSNs.
...
svn path=/trunk/; revision=29697
2009-09-04 13:10:59 +00:00
648bdb564b
Fix compilation.
...
svn path=/trunk/; revision=29696
2009-09-04 12:52:28 +00:00
56366dcb59
From Irene Ruengeler: Show duplicate TSNs in SACKs.
...
svn path=/trunk/; revision=29695
2009-09-04 12:42:22 +00:00
a3c38e1057
Include "proto.h" instead of <proto.h>
...
svn path=/trunk/; revision=29694
2009-09-04 11:48:04 +00:00
e99983ab3a
From Vincent Helfre:
...
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901
svn path=/trunk/; revision=29693
2009-09-04 11:06:52 +00:00
f0ea776605
From : Didier Gautheron
...
Addresse hash is slow on little endian CPU.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3973
svn path=/trunk/; revision=29692
2009-09-04 10:53:37 +00:00
266c357d81
Start the feature list for 1.4.
...
svn path=/trunk/; revision=29691
2009-09-03 18:15:23 +00:00
4930802fa1
Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again
...
svn path=/trunk/; revision=29690
2009-09-03 17:56:57 +00:00
5a8df08491
Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c
...
svn path=/trunk/; revision=29689
2009-09-03 17:39:42 +00:00
Stig Bjørlykke