Commit Graph

40552 Commits

Author SHA1 Message Date
Chris Maynard 21863ad163 Convert tabs to spaces. Fix some typos.
svn path=/trunk/; revision=42617
2012-05-13 17:55:06 +00:00
Anders Broman 82ba410214 Tabs spelling
svn path=/trunk/; revision=42616
2012-05-13 16:34:53 +00:00
Bill Meier f9a08c84d5 General cleanup:
- whitespace;
- formatting (including long lines & hf[] entries).

svn path=/trunk/; revision=42614
2012-05-13 14:53:26 +00:00
Gerald Combs 6c1dd6f0de [Automatic manuf, services and enterprise-numbers update for 2012-05-13]
svn path=/trunk/; revision=42612
2012-05-13 14:03:29 +00:00
Anders Broman 6d757a2083 Renove redundant code
svn path=/trunk/; revision=42611
2012-05-13 14:00:10 +00:00
Anders Broman 09c5089ebc Fix de_rr_cell_opt_sacch decoding the DTX cell options wrongly, by using proto_tree_add_split_bits_item_ret_val https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7253
svn path=/trunk/; revision=42610
2012-05-13 13:58:10 +00:00
Guy Harris f354e31304 A routine that processes a struct_XXX() won't necessarily use its
encoding argument; mark it as (potentially) unused.

svn path=/trunk/; revision=42609
2012-05-12 23:00:15 +00:00
Guy Harris 13095234ad "byte_order" is an encoding value, so it should be guint.
svn path=/trunk/; revision=42608
2012-05-12 22:56:46 +00:00
Guy Harris 268f5c9f51 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Replaced the "little_endian" Boolean value with an "byte_order" value
containing the setting of the byte-order ENC_ bit. 

svn path=/trunk/; revision=42607
2012-05-12 22:25:29 +00:00
Bill Meier f2cd5350f6 Fix a compile error
svn path=/trunk/; revision=42606
2012-05-12 22:19:02 +00:00
Bill Meier b8712813cc General cleanup:
- Fix two minor bugs which resulted in missing entries in packet details pane;
- Remove packet-rdp.h: It's not used elsewhere;
- Define 3 global fcns as static: they're only referenced within packet-rdp.c;;
- Localize some variable definitions & remove uneeded variable initializations;
- ...
- Fix whitespace and indentation.


svn path=/trunk/; revision=42605
2012-05-12 22:14:02 +00:00
Guy Harris e4b688d5dc Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Replaced the "little_endian" Boolean value with an "byte_order" value
containing the setting of the byte-order ENC_ bit. 

svn path=/trunk/; revision=42604
2012-05-12 20:27:35 +00:00
Chris Maynard 82fa509542 Fix display filter prefix from "ntpctrl." to "ntp.ctrl." Part of a patch submitted by Michael Mann in bug 2794, but for some reason the patch specified the filter prefix as "nap.ctrl.", which I don't think is right.
svn path=/trunk/; revision=42603
2012-05-12 20:26:42 +00:00
Guy Harris 1c7269a6d1 Mention ENC_UCS_2 and ENC_UTF_16.
svn path=/trunk/; revision=42602
2012-05-12 20:10:18 +00:00
Guy Harris 3896fea6c0 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Updated tools/process-x11-xcb.pl to support different encoding values
for different fields.  Replaced the "little_endian" Boolean value with a
"byte_order" value containing the setting of the byte-order ENC_ bit. 
Regenerated X11 fields from current x.org git.

svn path=/trunk/; revision=42601
2012-05-12 20:07:08 +00:00
Jakub Zawadzki 57e6b25735 From r37696 default file format for dumpcap is pcap-ng. Fix manuals.
svn path=/trunk/; revision=42600
2012-05-12 19:49:49 +00:00
Chris Maynard da5ea5a8dd From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7239
Make inputint and outputint fields UINT32s instead of UINT16s.

svn path=/trunk/; revision=42599
2012-05-12 17:55:09 +00:00
pascal 78d983a963 From Akos Lukovics:
Fix div-by-zero error in the moving average filter of IO graph
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6236

svn path=/trunk/; revision=42598
2012-05-12 15:19:25 +00:00
Alexis La Goutte 466988126d From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7252
Add wlan.ra field value to wlan.addr

The (hidden) field wlan.addr==xx:xx:xx:xx:xx:xx currently matches wlan.da,
wlan.bssid, wlan.sa and wlan.da fields but not wlan.ra field.

svn path=/trunk/; revision=42597
2012-05-12 13:12:01 +00:00
Jakub Zawadzki 35745a33cd Fix bug #7251
We're already checking in gtk if end highlight offsets don't exceed len.
Do the same for start offset.

I wonder if it this checks should be also done when adding items to tree...

svn path=/trunk/; revision=42596
2012-05-12 07:57:51 +00:00
Guy Harris bd42162bfe hf_x11_keycodes is an FT_NONE; use ENC_NA with it.
svn path=/trunk/; revision=42595
2012-05-12 01:59:00 +00:00
Guy Harris 675416c0de string16_with_buffer_preallocated() takes a byte-order gboolean as its
argument.

svn path=/trunk/; revision=42594
2012-05-12 01:54:49 +00:00
Guy Harris f1020435f8 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42593
2012-05-12 00:43:46 +00:00
Guy Harris 7a87d7b6a3 Add ENC_UTF_16 and ENC_UCS_2. Note that UTF-16 and UCS-2 are not the
same, and that the routines to get "Unicode" strings are really doing
UCS-2 (and not doing anything about code values that aren't valid in
UCS-2 strings).

Have tvb_get_ephemeral_string_enc() separate cases for ASCII and UTF-8,
even though they're *currently* treated the same.

For FT_UINT_STRING, treat an encoding value of TRUE as meaning
"little-endian ASCII"; pass all other encodings through to
tvb_get_ephemeral_string_enc().

svn path=/trunk/; revision=42592
2012-05-11 23:55:54 +00:00
Chris Maynard bb524c6b64 Despite the OSX-10.5-x86 buildbot insisting that they are, neither 'flags' nor 'fh_tree' were used uninitialized, but make a change to shut it up.
svn path=/trunk/; revision=42591
2012-05-11 20:24:27 +00:00
Guy Harris 944ae5ae49 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42590
2012-05-11 20:02:52 +00:00
Guy Harris 0adedfaaee Show m2m.fch_burst_tlv_value in decimal.
svn path=/trunk/; revision=42589
2012-05-11 19:53:43 +00:00
Guy Harris 0fb9759eec Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Add hf[] entries for some fields that didn't have them.

svn path=/trunk/; revision=42588
2012-05-11 19:27:59 +00:00
Guy Harris 4217008691 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42587
2012-05-11 19:22:25 +00:00
Guy Harris 90f564717f Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Clean up indentation.

svn path=/trunk/; revision=42586
2012-05-11 19:20:23 +00:00
Guy Harris 7962b11c0f Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Also, fix the type of what appears to be a 24-bit integral field
(cut-and-pasteo?).

svn path=/trunk/; revision=42585
2012-05-11 19:08:31 +00:00
Guy Harris 774028e5fc Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42584
2012-05-11 18:57:51 +00:00
Guy Harris 0e1de63173 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42583
2012-05-11 18:54:32 +00:00
Guy Harris ccb24a5ab7 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42582
2012-05-11 18:52:36 +00:00
Chris Maynard 7748862a65 Further LCP improvements:
-> Support RFC 2153's Vendor Specific decode
-> Make more fields filterable by converting some add_text()'s to add_xyz().
-> Don't wrap call_dissector_only() within an if(tree){} block.

svn path=/trunk/; revision=42581
2012-05-11 18:01:51 +00:00
Guy Harris 47fadf1d2a Clean up indentation. (HT should not be assumed to work on 4-space tab
stops.)

svn path=/trunk/; revision=42580
2012-05-11 17:35:56 +00:00
Guy Harris f1b11f62f8 proto_registrar_get_ftype() returns an FT_ value; make its return type
"enum ftenum" to reflect that, and fix the "switch doesn't handle XXX"
warnings that provokes.

svn path=/trunk/; revision=42579
2012-05-11 17:29:56 +00:00
Gerald Combs 88ae29c149 Use "%parse-param" instead of a global variable. Fixes a scan-build
warning.

svn path=/trunk/; revision=42578
2012-05-11 17:15:12 +00:00
Guy Harris f42de82580 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_bitmask() calls.

svn path=/trunk/; revision=42577
2012-05-11 16:38:08 +00:00
Anders Broman dfadac5d9a Make it possible to add "dirty" custom dissectors.
svn path=/trunk/; revision=42576
2012-05-11 12:14:29 +00:00
pascal 633a538cdb Commit forgotten file in revision 42573
svn path=/trunk/; revision=42575
2012-05-11 10:22:32 +00:00
pascal 079f737508 Remove useless '+0' in proto_tree_add_* function calls
svn path=/trunk/; revision=42574
2012-05-11 09:50:28 +00:00
pascal 0264b67ed7 From Niels de Vos:
Add dissection of AUTH_GLUSTERFS as used in GlusterFS-3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42573
2012-05-11 09:44:55 +00:00
pascal f982541723 From Niels de Vos:
Add a helper function to dissect AUTH_UNIX groups
Fix hf_rpc_auth_lk_owner entry
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42572
2012-05-11 09:38:49 +00:00
pascal b42423a8dc From Frank Lahm:
In FPSpotlightRPC packets, check for elements with 0 childs (denoted by L in TLV is sizeof(TLV tag))
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7245

svn path=/trunk/; revision=42571
2012-05-11 09:03:22 +00:00
Anders Broman 1fe00a4c44 Make it possible to dissect private IE's
svn path=/trunk/; revision=42570
2012-05-11 08:42:23 +00:00
Guy Harris 6a92b2a472 Get rid of non-ASCII character.
svn path=/trunk/; revision=42569
2012-05-11 08:29:40 +00:00
Guy Harris 25917db46e Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_bitmask() calls.

svn path=/trunk/; revision=42568
2012-05-11 08:10:42 +00:00
Guy Harris 32ec3275bd Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_bits_item() calls.

svn path=/trunk/; revision=42567
2012-05-11 08:05:35 +00:00
Guy Harris fde0260bee Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42566
2012-05-11 07:49:27 +00:00