Commit Graph

31 Commits

Author SHA1 Message Date
Anders Broman 1e1df99990 From Tim Endean:
Small patch to ber.c

The tcap dissector has been updated to use this length. I have not tested other asn.1 dissectors to ensure that they correctly use the indefinite encoding flag instead of the length value returning zero. 

There may also be some problems when re-assembly is needed, but the ability to deal with indefinite length is much more useful.

For developers the get_ber_length now returns the length of the pdu including the EOC, where you have dissectors that use packet-ber.c the eoc may need to be dealt with separately.

The tcap dissector has had numerous changes to make it less cluttered, and the useful feature of the previous version where a dialogue could be filtered out by selecting either the source or destination transaction ID has been incorporated into this version.

svn path=/trunk/; revision=15414
2005-08-18 21:36:59 +00:00
Ronnie Sahlberg 0ca30abe65 change the symbol dissect_ber_CHOICE back into dissect_ber_choice
svn path=/trunk/; revision=14980
2005-07-21 21:12:09 +00:00
Guy Harris 2fcce4b6c4 Fix some more signed vs. unsigned warnings.
svn path=/trunk/; revision=14903
2005-07-12 01:01:19 +00:00
Ronnie Sahlberg 3a51ba4293 make dissect_ber_choice take a guint* that will return the
index of the branch taken or -1  to make prettifications easier to implement.


change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all
occurences of the use of this function

update asn2eth to use the new name/signature

update all occurences of this function to the new name and new signature.



svn path=/trunk/; revision=14758
2005-06-26 05:48:50 +00:00
Anders Broman 6f9d56ddd0 From Valery Vybornov:
add register_dissector to packet-tcap.c

svn path=/trunk/; revision=14738
2005-06-23 22:17:03 +00:00
Ronnie Sahlberg 33f4400f83 the maximum ASN OID length is 256 bytes and there is a define to control this.
fix bug251 and all other occurances where an oid string  passed to packet_ber_object_identifier()
is not defined as foo[MAX_OID_STR_LEN]

svn path=/trunk/; revision=14720
2005-06-21 09:38:59 +00:00
Ronnie Sahlberg 5f334f7f7b move two functions that are not used by tcap and only used by gsm_a and gsm_ss into gsm_ss.
remove the include <epan.asn1.h> from tcap since it no longer needs that file.

only 9 dissectors remain that use asn1.h



svn path=/trunk/; revision=14710
2005-06-20 07:18:10 +00:00
Guy Harris ddbee0ffd0 Clean up white space.
Register "standard" and "lock_info_col" as obsolete preferences, so
they're silently ignored rather than triggering warnings.

Propagate changes to check for "dissect_ber_octet_string()" supplying a
null tvbuff pointer from the checkins to the generated dissector ("Do
not modify this file" means "Do not modify this file"!) to the tcap.cnf
file, so that they're not lost if the dissector is regenerated.  (Don't
propagate the checks for "tvb_new_subset()" returning null - it never
returns null.)

Pass -1 to "tvb_new_subset()" when appropriate.

When looping over packet data, check against the reported length, not
the captured length, so we indicate a short frame if we get stopped by
the snapshot length.

Get rid of unused variables.

svn path=/trunk/; revision=14658
2005-06-16 07:46:03 +00:00
Anders Broman 89ddd6077a From Tim Endean:
Check for tvb.

svn path=/trunk/; revision=14592
2005-06-09 04:28:13 +00:00
Anders Broman d82116f2aa From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

svn path=/trunk/; revision=14590
2005-06-08 18:52:34 +00:00
Anders Broman 1ce165a446 From Tim Endean:
Fix ssn range

svn path=/trunk/; revision=14585
2005-06-08 05:04:26 +00:00
Anders Broman b3934176cb Some fixes from Tim Endean
svn path=/trunk/; revision=14578
2005-06-07 20:29:23 +00:00
Anders Broman 86a56ba7cc From Tim Endean:
- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.


svn path=/trunk/; revision=14572
2005-06-07 05:49:06 +00:00
Gerald Combs 2ab34cb095 Fix two places where we might loop infinitely, including the one found in
bug 155.  Fix a couple of compiler warnings.

svn path=/trunk/; revision=14289
2005-05-03 14:36:08 +00:00
Anders Broman 3f395aec51 Use the correct parameters in a function call.
svn path=/trunk/; revision=14271
2005-05-02 18:30:14 +00:00
Gerald Combs 17fa218ed5 Make sure we pass a positive length to proto_item_set_len().
svn path=/trunk/; revision=14254
2005-05-01 13:52:15 +00:00
Gerald Combs 6ba8b243b0 Fix a buffer overflow found during fuzz testing.
svn path=/trunk/; revision=14247
2005-04-30 19:37:03 +00:00
Lars Roland ec9ca01616 Move the following files from /trunk to /trunk/epan:
asn1.[ch]
follow.[ch]
ptvcursor.[ch]
reassemble.[ch]
xmlstub.[ch]

fix #include statements accordingly.

svn path=/trunk/; revision=13366
2005-02-09 23:38:00 +00:00
Anders Broman 6e4f24c0d9 Improve handling of pinfo->private_data
svn path=/trunk/; revision=13228
2005-02-01 22:57:22 +00:00
Anders Broman a960b72f5f Put application context OID in pinfo->private data to be used by sub-dissector(s).
svn path=/trunk/; revision=13218
2005-01-31 21:38:56 +00:00
Guy Harris 43cf3c2480 Use "proto_tree_add_item()" to add a chunk of bytes to the protocol
tree.

svn path=/trunk/; revision=12900
2004-12-31 03:18:13 +00:00
Ulf Lamping 5bcad85d01 Again, some warnings removed.
svn path=/trunk/; revision=12842
2004-12-27 13:17:20 +00:00
Ulf Lamping bf5bf359e0 Again, some warnings removed.
svn path=/trunk/; revision=12837
2004-12-26 10:11:42 +00:00
Anders Broman 784fece9c0 Improve OID dissection and make it possible to call an "OID" Dissector for Dialougedata parameter.
svn path=/trunk/; revision=12413
2004-10-27 20:04:56 +00:00
Guy Harris 6d53294988 "ssn_range" needs to be a copy of "global_ssn_range", so that it's not
freed if "global_ssn_range" is changed because the preference was
changed.

svn path=/trunk/; revision=12321
2004-10-17 00:48:37 +00:00
Guy Harris 727ad67453 Remove the fixed maximum number of subranges in a range_t; dynamically
allocate them to be large enough.

Add checks that the numbers in the range fit in a guint32.

Check the validity of a range before saving or printing, and report
errors in an alert box.

Clean up white space.

svn path=/trunk/; revision=12320
2004-10-16 23:32:24 +00:00
Guy Harris c2d2988e4f Don't declare functions inside functions - not all C compilers support
that.

svn path=/trunk/; revision=12301
2004-10-15 05:54:33 +00:00
Guy Harris abd16b297f From Jeff Morriss: PREF_RANGE preference type, for ranges of integers.
svn path=/trunk/; revision=12300
2004-10-14 23:45:09 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Guy Harris 94e6a44cb4 From Jeff Morriss: the code path that's bypassed with the "if (tree)"
and "if (!tree)" checks updates the Info column and calls subdissectors,
so we can't bypass all of it - don't bypass any of it.

svn path=/trunk/; revision=11903
2004-09-04 21:20:08 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00