Commit Graph

66 Commits

Author SHA1 Message Date
Luis Ontanon 5d40bae072 MSVCC does not like mixing code and variable declarations
svn path=/trunk/; revision=19409
2006-10-03 18:07:31 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Anders Broman 96c13a1000 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091
h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames.

svn path=/trunk/; revision=19190
2006-09-11 20:35:24 +00:00
Guy Harris ee7166aff1 Declare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
used.

svn path=/trunk/; revision=19141
2006-09-04 23:20:52 +00:00
Anders Broman 316453598a From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

svn path=/trunk/; revision=19136
2006-09-04 18:10:14 +00:00
Tomas Kukosa 5cd8c719e6 ASN.1 dissectors regenerated with new asn2wrs to get updated field blurb
svn path=/trunk/; revision=18921
2006-08-16 05:58:39 +00:00
Ronnie Sahlberg 8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Anders Broman c72d4e8f2e From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.

svn path=/trunk/; revision=18521
2006-06-20 05:57:29 +00:00
Tomas Kukosa 604000a6b3 - remove some #.MODULE_IMPORT from .cng files
- regenerate BER dissectors so as to change rest of Ethereal->Wireshark and asn2eth -> asn2wrs

svn path=/trunk/; revision=18217
2006-05-24 12:24:54 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 9aa7db0042 From LEGO fix "Dissector bug, Protocol H248"
svn path=/trunk/; revision=18093
2006-05-04 18:25:43 +00:00
Ronnie Sahlberg 27de4cfd39 give se_trees names so that it is easier to debug and to log how often certain trees are accessed
svn path=/trunk/; revision=17587
2006-03-11 13:02:41 +00:00
Ronnie Sahlberg 76a2df4a58 dont declare variables in the middle of a code block. many compilers do not like that.
svn path=/trunk/; revision=17573
2006-03-11 00:58:16 +00:00
Luis Ontanon 4e1ca8f2c3 fix coverity CIDs 113 and 114.
while at it change the h248 context analysis to use se_trees instead of GHashTables


svn path=/trunk/; revision=17571
2006-03-10 22:01:10 +00:00
Luis Ontanon 8284947d84 Hide #line directives inside comments so that coverrity shows the errors it has found. It appears that Coverity doesn't look for source files but in the same dir where the generated file resides.
svn path=/trunk/; revision=17519
2006-03-08 09:49:31 +00:00
Luis Ontanon a2f7c569e0 H.248 over UDP
svn path=/trunk/; revision=17163
2006-02-05 04:24:51 +00:00
Gerald Combs faef737b31 Before we begin dissection, NULLify some global variables that might
contain ep_alloc()ed data from a previous dissection.  Correctly fixes
bug 651 (the previous fix was incorrect).

svn path=/trunk/; revision=17015
2006-01-12 02:06:34 +00:00
Gerald Combs 20b00dd581 Don't dereference a null pointer. Fixes bug 651. Update the release notes
accordingly.

svn path=/trunk/; revision=16967
2006-01-06 20:03:52 +00:00
Guy Harris 35743cded8 Fix a typo.
svn path=/trunk/; revision=16931
2006-01-02 10:52:50 +00:00
Luis Ontanon be94b45514 - Decode some more annex C fields
- Keep track of terminations (link wildcarded ones to real ones)
- Keep termination info and link aal2 terminations to alcap legs


svn path=/trunk/; revision=16914
2005-12-28 19:46:57 +00:00
Anders Broman 8d05164bec Get rid of duplicted dissector tables for MTP3 Service indicator and SCCP ssn:s
svn path=/trunk/; revision=16815
2005-12-16 07:05:50 +00:00
Gerald Combs 6b376c9c0e asn2eth.py:
Catch a TypeError that gets thrown if we don't use any conversion
specifiers during string formatting.

H.248:

Don't dereference a null pointer.  Fixes bug 626.

svn path=/trunk/; revision=16773
2005-12-13 03:48:26 +00:00
Luis Ontanon 55d5c5cc66 Avoid dereferencing pointers to the message, context and transaction object if they have not been created.
svn path=/trunk/; revision=16725
2005-12-07 21:08:51 +00:00
Luis Ontanon 94110893b7 It crashed when keep_persistent_data == FALSE
svn path=/trunk/; revision=16705
2005-12-06 19:47:22 +00:00
Luis Ontanon d6c5410b18 - Fix few issues with context analysis
- Add used terminations tree to the context analysis tree

Regenerate Dissector


svn path=/trunk/; revision=16703
2005-12-06 18:52:17 +00:00
Luis Ontanon ff20ed3e10 Some cleanup,
- Improve expert info
- Remove the debug tree (one warning unused function, will go)
- Make Sure Pending messages have a cmdmsg (and so a colinfo label)


svn path=/trunk/; revision=16383
2005-11-02 23:01:15 +00:00
Luis Ontanon b10fcd969a - terminate a value_string
- wildcard field subdissector


svn path=/trunk/; revision=16378
2005-11-02 19:46:47 +00:00
Luis Ontanon c5ff846c22 - add a counter for pending messages
- do not use a value string for context ids
- remove the plugin registration as it is not supposedd to be a plugin


svn path=/trunk/; revision=16375
2005-11-01 21:09:28 +00:00
Luis Ontanon f100a33216 - Embryonic Transaction & Context tracing
svn path=/trunk/; revision=16372
2005-11-01 16:28:13 +00:00
Guy Harris c5b0fc27d7 Fix a bunch of places where we were calling "dissect_ber_octet_string()"
with a non-null pointer-to-pointer-to-tvbuff and not checking whether
the returned tvbuff pointer was non-null.

svn path=/trunk/; revision=15948
2005-09-22 00:51:11 +00:00
Ronnie Sahlberg eba5b5b225 sometimes it seems that we have the text based h248/megaco running ontop of
m3ua  and not the binary one.


make the binary dissector check if it is really the text based one to be used and if so
call that dissector instead.



svn path=/trunk/; revision=15862
2005-09-19 08:06:25 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris 92e0e21362 Regenerate dissectors with the current asn2eth.
svn path=/trunk/; revision=15664
2005-09-02 05:43:49 +00:00
Luis Ontanon 03c8023311 avoid throwing a malformed packet
svn path=/trunk/; revision=15298
2005-08-11 23:51:35 +00:00
Luis Ontanon 1480f629dc Change a switch into an "if else if else if else" that fixes the "too large for switch" in HP-UX 10.20 .
The generated file has a lot of indentation changes due probably to a change in asn2eth.

The underlying reason for which I added this code (dissect_ber_integer() would not add as a "filterable" field if it is larger than 4 bytes, should be handled in dissect_ber_integer() ) remains there.

Should we change dissect_ber_integer() itself to make sure that a 5 byte unsigned integer which fits in 4 bytes gets added to the tree as "filterable"?


svn path=/trunk/; revision=15294
2005-08-11 18:21:23 +00:00
Jörg Mayer 54861853a8 More char -> const char warning fixes
svn path=/trunk/; revision=15155
2005-07-30 07:13:27 +00:00
Ronnie Sahlberg 0ca30abe65 change the symbol dissect_ber_CHOICE back into dissect_ber_choice
svn path=/trunk/; revision=14980
2005-07-21 21:12:09 +00:00
Luis Ontanon df4cce353b fix a string
svn path=/trunk/; revision=14915
2005-07-13 23:40:06 +00:00
Ronnie Sahlberg 3a51ba4293 make dissect_ber_choice take a guint* that will return the
index of the branch taken or -1  to make prettifications easier to implement.


change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all
occurences of the use of this function

update asn2eth to use the new name/signature

update all occurences of this function to the new name and new signature.



svn path=/trunk/; revision=14758
2005-06-26 05:48:50 +00:00
Luis Ontanon bfa7197fcf if exists call the h248term subdissector.
svn path=/trunk/; revision=14717
2005-06-20 21:21:06 +00:00
Luis Ontanon acdc3d771a - make sure there's something to add to colinfo.
- auditValueRequest is a request too

svn path=/trunk/; revision=14567
2005-06-06 18:51:05 +00:00
Luis Ontanon bc1292ff1d some cosmetic fixes
svn path=/trunk/; revision=14401
2005-05-20 19:38:24 +00:00
Luis Ontanon 1eeda6e946 - make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets
- set COL_INFO to something useful


svn path=/trunk/; revision=14361
2005-05-13 11:16:05 +00:00
Luis Ontanon 5535853bf2 - export Audio Codec modes from isup/bicc
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248


svn path=/trunk/; revision=14343
2005-05-10 21:54:37 +00:00
Anders Broman 3d0fbb8c63 Dissect MTP3 with service indicator 14 as H248.
svn path=/trunk/; revision=13505
2005-02-24 22:36:26 +00:00
Anders Broman 544d47560a Add dissection of packet tdmc
svn path=/trunk/; revision=13484
2005-02-23 23:12:48 +00:00
Ronnie Sahlberg fbf762bda5 update asn2eth and all generated dissectors to new dissect_ber_boolean that takes a implicit_tag parameter
svn path=/trunk/; revision=13479
2005-02-23 08:57:47 +00:00
Anders Broman 915e63ae18 Add dissection of some more packages.
svn path=/trunk/; revision=13265
2005-02-03 21:57:42 +00:00
Ronnie Sahlberg 262d2b36c8 support H.248 BER over SCTP PPID 7
svn path=/trunk/; revision=13213
2005-01-31 03:31:13 +00:00
Ronnie Sahlberg 8afae320de update of the asn2eth compiler to use the types ber_[choice|sequence]_t instead of ber_[choice|sequence]
regenerated all dissectors


fixed the choice/sequence struct to use unsigned entities for class and tag
(to reduce some compiler warning and because it should be signed quantities)



svn path=/trunk/; revision=12740
2004-12-13 08:15:34 +00:00