Commit Graph

50903 Commits

Author SHA1 Message Date
Irene Rüngeler 4729c083ac Add 'Filter Association' to context menu in packet list.
svn path=/trunk/; revision=54219
2013-12-18 13:49:10 +00:00
Martin Mathieson 485faca86d Add cast to try to fix buildbot failure
svn path=/trunk/; revision=54218
2013-12-18 13:37:20 +00:00
Martin Mathieson ae50f1d21e Fix a test to allow deciphering to happen on the first pass, and close the gcrypt handles after use.
svn path=/trunk/; revision=54216
2013-12-18 13:08:57 +00:00
Stig Bjørlykke 52a05e6275 Added ByteArray base64_decode().
svn path=/trunk/; revision=54215
2013-12-18 12:55:43 +00:00
Stig Bjørlykke aa2961280f Added support for continuation line in content type.
svn path=/trunk/; revision=54214
2013-12-18 12:54:18 +00:00
Martin Mathieson d536d5fb7d Remove unused variables to try to unbreak MAC buildbots
svn path=/trunk/; revision=54213
2013-12-18 12:19:42 +00:00
Martin Mathieson 17e31af34f Only convert string key once, during update uat callback
svn path=/trunk/; revision=54212
2013-12-18 12:05:11 +00:00
Irene Rüngeler d54801bff5 Fix warning because of functions defined but not used.
svn path=/trunk/; revision=54211
2013-12-18 09:53:25 +00:00
Irene Rüngeler d65cb2e9ab Ignore the first line of the chunk statistics file.
svn path=/trunk/; revision=54210
2013-12-18 08:04:01 +00:00
Anders Broman e8b935ad6e Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54209
2013-12-18 06:51:09 +00:00
Jeff Morriss 7dfbe304a7 Translate a little leftover German to English.
svn path=/trunk/; revision=54208
2013-12-18 02:25:53 +00:00
Jeff Morriss 189a80048a Fix compilation when we don't HAVE_GCRYPT.
svn path=/trunk/; revision=54207
2013-12-18 02:16:42 +00:00
Jeff Morriss 5c8e65009e Presumably ansi_tsb58_language_ind_vals shouldn't be static (since it's listed in the header file).
svn path=/trunk/; revision=54206
2013-12-18 02:08:17 +00:00
Michael Mann 88b9db9bd6 ANSI A-interface improvements. Bug 9471 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471)
From Michael Lum

svn path=/trunk/; revision=54205
2013-12-18 01:30:50 +00:00
Evan Huus 01c048b838 Add two missing BASE_EXT_STRING flags as caught by Alexis's ASAN fuzzing.
svn path=/trunk/; revision=54204
2013-12-17 23:03:27 +00:00
Evan Huus a2bb473ead Fix what appears to be a misuse of pointers in the LLDP dissector as caught by
Alexis's ASAN fuzzing. Pass the address of a guid on the stack, not the address
of a pointer to a guid which doesn't actually point to anything...

svn path=/trunk/; revision=54203
2013-12-17 22:38:40 +00:00
Jakub Zawadzki ff2a5847b9 sign_ext.h: use G_GINT64_CONSTANT(), add sample for alternative method of sign extension.
Alternative method looks much nicer in dissasembly.

svn path=/trunk/; revision=54202
2013-12-17 22:16:06 +00:00
Anders Broman e6d09c1634 Make local functions static. Include *.h when needed.
svn path=/trunk/; revision=54201
2013-12-17 22:07:32 +00:00
Jeff Morriss be09c39208 Add SVN properties.
svn path=/trunk/; revision=54200
2013-12-17 22:03:37 +00:00
Guy Harris 9628624867 Get rid of trailing periods in some error messages for consistency; the
others don't have trailing periods, and the caller adds a period as
desired.

svn path=/trunk/; revision=54199
2013-12-17 21:51:45 +00:00
Jakub Zawadzki c8716a45ee Put sign_ext.h in Makefile.
svn path=/trunk/; revision=54198
2013-12-17 21:38:59 +00:00
Jakub Zawadzki 0de43ce2dd Create sign extension routines in <wsutil/sign_ext.h>, use it in few places.
svn path=/trunk/; revision=54197
2013-12-17 21:36:33 +00:00
Michael Mann 6db9eb0b73 Bugfix OpenSafety "heuristics" to only consider a packet "handled" if a subdissector is called. Fixes bug 9572 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9572)
Also removed tree check in Modbus dissector because dissector_try_string() is being called under it.

#BACKPORT(1.10)

svn path=/trunk/; revision=54193
2013-12-17 20:06:03 +00:00
Alexis La Goutte c03bcb5694 From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8805
Wireshark not recognizing skinny version 19

Allow Wireshark to decode skinny version 19 (0x13)
Only allow, no found spec to support all feature/packet of skinny 19

Also fix a encoding arg

svn path=/trunk/; revision=54189
2013-12-17 18:53:01 +00:00
Alexis La Goutte e9946f0130 Make Ubuntu Buildbot happy
Fix following error:
../../../ui/qt/sctp_chunk_statistics_dialog.cpp: In member function ‘void SCTPChunkStatisticsDialog::fillTable(bool)’:
../../../ui/qt/sctp_chunk_statistics_dialog.cpp:145:29: error: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Werror=unused-result]

svn path=/trunk/; revision=54188
2013-12-17 18:43:34 +00:00
Alexis La Goutte f1a440b539 Remove trailing whitespace and add modelines
svn path=/trunk/; revision=54187
2013-12-17 18:43:24 +00:00
Michael Mann 69ac243b07 General cleanup of ZBEE ZCL dissector. Removed unnecessary casts and wrapping functions.
Tried to remove zcl_cluster_id global, but it's used in a function that is called by other dissectors that I'm not sure if they are expecting the zcl_cluster_id to be "saved" (or if -1 could be passed in for cluster id from those dissectors).  Removed as many uses of it as possible if someone knows the dissectors better to make that call.

svn path=/trunk/; revision=54186
2013-12-17 17:32:20 +00:00
Michael Mann 79d336c664 Handle signed integers > 32 bits. Bug 8454 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8454)
svn path=/trunk/; revision=54183
2013-12-17 16:50:33 +00:00
Martin Mathieson 1b4ea6bb68 Preferences to control whether deciphering should be done for signalling and user plane
svn path=/trunk/; revision=54182
2013-12-17 16:40:42 +00:00
Bill Meier 87e2aa3383 From "bd": Fix " Wireshark stops showing new packets but dumpcap keeps writing them to the temp file"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9571

From me: Fixed in a slightly different manner than sugested in the patch attached to the bug.



svn path=/trunk/; revision=54181
2013-12-17 15:02:47 +00:00
Martin Mathieson e79de9873d First working version of deciphering with AES (EEA2). Lots of improvements still to make
svn path=/trunk/; revision=54180
2013-12-17 14:49:21 +00:00
Pascal Quantin d319ad5d92 Do not modify the bytes given to proto_tree_add_uint_format_value() in case there is a mask present in hf definition.
Otherwise the bits displayed in the tree are not the right ones.

svn path=/trunk/; revision=54179
2013-12-17 13:31:58 +00:00
Evan Huus 30447ecd8f Fix preprocessor macro and indentation.
svn path=/trunk/; revision=54178
2013-12-17 13:21:26 +00:00
Pascal Quantin 894d8d096b Fix a crash when calling try_val_to_str_ext()
svn path=/trunk/; revision=54177
2013-12-17 13:11:44 +00:00
Alexis La Goutte 3d6c71e906 Fix indent (use 4 spaces) and add modelines
svn path=/trunk/; revision=54176
2013-12-17 13:06:11 +00:00
Pascal Quantin 2f3a943f0a Fix a typo and check that handle exists before calling call_dissector()
svn path=/trunk/; revision=54175
2013-12-17 11:34:45 +00:00
Pascal Quantin 0f6429c3bf Fix the offset when dissecting a Signal reserved field
svn path=/trunk/; revision=54174
2013-12-17 11:28:48 +00:00
Pascal Quantin 0db718781b Comment a useless increment
svn path=/trunk/; revision=54173
2013-12-17 10:54:57 +00:00
Alexis La Goutte bde542ba74 From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9547
Zbee ZCL wrong cmdID in DefaultRespons

Default Response command generated by Specific command cluster contains wrong cmdId decoding. The value shows the cross-cluster command id but not the specific cluster command id name.
Draft of solution is already created (now is under test). The idea is to add a cmdId function callback in zbee_zcl_init_cluster in order to call it when wireshark has to decode specific cluster cmd in default response.

svn path=/trunk/; revision=54171
2013-12-17 10:43:08 +00:00
Alexis La Goutte 7e2353f5d4 Make translatable ready SCTP Graph for Qt
svn path=/trunk/; revision=54170
2013-12-17 10:22:00 +00:00
Irene Rüngeler 7eb50571f4 Find the right frame when plottable was clicked.
svn path=/trunk/; revision=54167
2013-12-17 09:51:34 +00:00
Irene Rüngeler 25a74d3f2a Fill the chunk statistics. Read line with fgets instead of getline.
svn path=/trunk/; revision=54166
2013-12-17 08:56:47 +00:00
Irene Rüngeler 555b8a581a Add the header files only once.
svn path=/trunk/; revision=54165
2013-12-17 08:54:54 +00:00
Anders Broman a1f179c4f5 Make local functions static. Include *.h when needed.
svn path=/trunk/; revision=54164
2013-12-17 06:10:41 +00:00
Martin Mathieson 5c085177fe Intialise a variable to avoid a (bogus) warning with my version of gcc
svn path=/trunk/; revision=54163
2013-12-16 23:26:09 +00:00
Martin Mathieson f9abd6f9e0 Fix compilation for when HAVE_LIBGCRYPT is not defined
svn path=/trunk/; revision=54162
2013-12-16 23:21:31 +00:00
Guy Harris 7851e21345 Fix compiler warnings.
svn path=/trunk/; revision=54161
2013-12-16 23:08:09 +00:00
Guy Harris e4a880b819 Get rid of unused variable.
svn path=/trunk/; revision=54160
2013-12-16 23:00:58 +00:00
Guy Harris 8bbff418d3 Fix typo in formatting string (%%s should be %s).
Mark unused argument as such.

svn path=/trunk/; revision=54159
2013-12-16 22:43:10 +00:00
Guy Harris 068008f04f Use proto_tree_add_item() in preference to fetching the string and
adding it with proto_tree_add_string().  Use tvb_get_string_enc() rather
than tvb_get_unicode_string() to fetch strings.

We assume a UTF-16 encoding for all "Unicode" strings.

Use tvb_strsize() and tvb_unicode_strsize() to get the lengths of
null-terminated strings.

Get rid of unused ett_nt_unicode_string variable.

svn path=/trunk/; revision=54158
2013-12-16 22:39:41 +00:00