Commit graph

146 commits

Author SHA1 Message Date
Pascal Quantin
ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209.
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Guy Harris
b8af5b44d1 #if 0 out some variables that are used only in now-#if 0'ed code.
svn path=/trunk/; revision=47040
2013-01-11 21:20:57 +00:00
Pascal Quantin
9f387eddbb Try to deduce NAS EPS Detach Request direction from message size
svn path=/trunk/; revision=47039
2013-01-11 20:54:04 +00:00
Pascal Quantin
952ccb4b83 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8168 :
Detect properly the EMM Service Request message

svn path=/trunk/; revision=46991
2013-01-07 21:37:55 +00:00
Pascal Quantin
0b20f855f0 Upgrade NAS disssectors to v11.5.0
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
Bill Meier
be99fcad4d Minor cleanup:
- prefs callback not needed;
- move proto_reg_handoff...() to the end of the file as per convention;
- reformat some log lines.

svn path=/trunk/; revision=46358
2012-12-03 22:42:56 +00:00
Bill Meier
727ed68381 Fix [-Wshadow] warning for purported variable shadowing another.
svn path=/trunk/; revision=46356
2012-12-03 22:26:34 +00:00
Anders Broman
810a200141 Revert 46018. Needs rethinking.
svn path=/trunk/; revision=46028
2012-11-14 10:02:15 +00:00
Pascal Quantin
9145ad5781 Display text in subtree
svn path=/trunk/; revision=46026
2012-11-13 21:59:14 +00:00
Anders Broman
6edabe05d8 Try to fix dissection with g_nas_eps_dissect_plain == TRUE.
svn path=/trunk/; revision=46018
2012-11-13 12:54:58 +00:00
Pascal Quantin
4518ece9f9 From Umberto Corponi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7912 :
Allow dissection of ESM messages with integrity protection and EEA0 ciphering

From me:
Tighten heuristic to check for allowed EPS bearer identity values

svn path=/trunk/; revision=45789
2012-10-25 21:37:12 +00:00
Pascal Quantin
924f9663fd Enhance dissection of Open Channel proactive command
svn path=/trunk/; revision=45413
2012-10-08 22:30:47 +00:00
Pascal Quantin
88324e39bb Use a value string array for EPS Bearer Identity and remove useless de_esm_lnkd_eps_bearer_id function
svn path=/trunk/; revision=45267
2012-10-02 20:44:36 +00:00
Pascal Quantin
ff3bd58b74 Upgrade NAS EPS dissector to v11.4.0 (Release 11)
svn path=/trunk/; revision=45253
2012-10-02 12:46:21 +00:00
Pascal Quantin
6dedc6628b Test Procedures messages should be also integrity protected
svn path=/trunk/; revision=45046
2012-09-21 19:58:34 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Pascal Quantin
777bbfb20d Use same capitalization for Service request message as for other messages
svn path=/trunk/; revision=43761
2012-07-17 10:35:21 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Pascal Quantin
053707aef8 Fix dissection of NAS EPS Service Request message (broken in r42200)
svn path=/trunk/; revision=43474
2012-06-25 11:12:54 +00:00
Pascal Quantin
2d5792d19b Fix typo errors
svn path=/trunk/; revision=43473
2012-06-25 10:16:15 +00:00
Pascal Quantin
41b3988bbd Fix function name (it is an Authentication failure, not an Attach failure)
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
Pascal Quantin
3c20eeb452 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
Identity request, Identity response and Authentication failure message dissection are swapped

svn path=/trunk/; revision=43253
2012-06-14 07:14:59 +00:00
pascal
0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs)
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
pascal
774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1)
svn path=/trunk/; revision=42722
2012-05-20 09:50:34 +00:00
Bill Meier
c055ca8c7e General minor cleanup including:
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
2012-05-07 22:11:34 +00:00
Jakub Zawadzki
77dc38ec5a value_string_ext: Reorder entries in value_string arrays to get Binary Search instead of Linear Search.
svn path=/trunk/; revision=42418
2012-05-04 07:34:06 +00:00
Anders Broman
949079e2b4 From David Wei:
Bug fixes and improvements to Sm (GTPv2) and SGmb (DIAMETER) dissectors.

svn path=/trunk/; revision=42220
2012-04-24 12:33:00 +00:00
Bill Meier
8caed06a76 Use tvb_new_subset_remaining(...) in place of tvb_new_subset(..., -1, -1);
Use value_string_ext to reference a few value_strings;
Use val_to_str_const() in place of val_to_str() in a few cases;
Use BASE_NONE for a few hf[] FT_BOOLEAN entries with 0x0 bitmask.

svn path=/trunk/; revision=41539
2012-03-13 17:21:46 +00:00
Alexis La Goutte
77afe2d93d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41305
2012-03-02 11:05:08 +00:00
Anders Broman
501216eb8a From Pascal Quantin:
[NAS EPS] Fix description of EPS Attach information element.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6886

svn path=/trunk/; revision=41245
2012-02-29 17:01:57 +00:00
Anders Broman
a2df0df2ae From Pascal Quantin:
[NAS EPS] PDN Connectivity Request message dissection fixes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6845

svn path=/trunk/; revision=41033
2012-02-15 22:56:20 +00:00
Anders Broman
f00ac880ca From Pascal Quantin:
Dissect operator-specific QCI values in EPS quality of service IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6760

svn path=/trunk/; revision=40699
2012-01-24 19:09:12 +00:00
Chris Maynard
ae9c9a3906 Fix some duplicate display filter names.
svn path=/trunk/; revision=40664
2012-01-23 19:17:42 +00:00
Anders Broman
6aef22ffd9 Updates from David Wei.
svn path=/trunk/; revision=40244
2011-12-19 16:57:17 +00:00
Anders Broman
932ea790e8 Fix bugs related to Nounce IE dissection.
svn path=/trunk/; revision=39987
2011-11-22 17:44:50 +00:00
Anders Broman
71039b37c6 Fix "With the current changes NAS messages with the "null ciphering algorithm" EEA0 are not handled."
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6348

svn path=/trunk/; revision=39911
2011-11-17 20:03:36 +00:00
Anders Broman
c7fb9d9fe3 From Pascal Quantin:
Fix dissection of PLMN List IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6513

svn path=/trunk/; revision=39674
2011-10-30 15:57:30 +00:00
Anders Broman
05452c11ab From Pascal Quantin.
wrong decoding of Activate default EPS bearer context request message containing a IPv6 interface id.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6484

svn path=/trunk/; revision=39575
2011-10-25 19:15:55 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Anders Broman
56c3bd0686 From Pascal Quantin.
LTE Positioning Protocol dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6460

svn path=/trunk/; revision=39436
2011-10-16 16:02:26 +00:00
Anders Broman
c8bbccfd2a From Pascal Quantin.
a follow-up patch that fixes the dissection of the Generic NAS transport messages.

svn path=/trunk/; revision=39405
2011-10-13 18:22:55 +00:00
Anders Broman
5b34fd161d From Pascal Quantin.
Add dissection of Location services messages
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6454

svn path=/trunk/; revision=39395
2011-10-12 21:17:23 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman
8ee02b09e0 Tighten the check on wheter a message really is chipered or not.
svn path=/trunk/; revision=39096
2011-09-23 06:55:10 +00:00
Anders Broman
900484d992 From Pascal Quantin:
Update of 3GPP RRC and LTE RRC dissectors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6333

svn path=/trunk/; revision=38964
2011-09-11 19:09:02 +00:00
Chris Maynard
5959387e7d Use col_append_sep_str() to comma-separate info column text. Fixes bug 6186.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6186

svn path=/trunk/; revision=38564
2011-08-16 14:54:59 +00:00
Bill Meier
111e08bb3d Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
Whitespace changes: "4 space tabs" --> spaces.

svn path=/trunk/; revision=38047
2011-07-15 16:59:18 +00:00
Chris Maynard
568fdf18a7 All ELEM_MAND_* macros ensure curr_len > 0; no need to check again afterwards.
Resolves Coverity CIDs 381-382.

svn path=/trunk/; revision=37200
2011-05-17 14:41:01 +00:00
Anders Broman
7dce5861cc From Pascal Quantin:
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00