Commit Graph

26 Commits

Author SHA1 Message Date
Guy Harris a56c79201d Arguments to hash routines are gconstpointer's; assign them to const
pointers.

The first argument to "sscanf()" is a "const char *"; don't cast const
pointers to "char *" when passing them to "sscanf()".

Assign the result of "tvb_get_ptr()" to const pointers, not non-const
pointers.

Make the "pdata" argument to various DCE routines a const pointer.

svn path=/trunk/; revision=6688
2002-11-28 03:57:50 +00:00
Guy Harris 86af47dd68 From Didier Gautheron: handle the padding in AFP login packets that put
the password on an even boundary.

svn path=/trunk/; revision=6509
2002-10-25 21:59:47 +00:00
Guy Harris 5b99f89521 From Didier Gautheron: better AFP 3.x dissector.
svn path=/trunk/; revision=6449
2002-10-17 22:38:19 +00:00
Guy Harris 57c62c7879 From Didier Gautheron: add AFP 3.1's FPEnumerateExt2 call, and add a
warning when TCP or UDP ports are reused in different conversations.

svn path=/trunk/; revision=6391
2002-10-09 23:16:46 +00:00
Guy Harris 497183e5c1 From Didier Gautheron: bail out in "loop_record()" if the size of the
structure to be dissected is 0.

Also, in "loop_record()":

	Make the variable in which that size is stored a "guint" to
	avoid overflows.

	Free up the name string as soon as we're done with it, so that
	we won't leak it if we throw an exception.

svn path=/trunk/; revision=6301
2002-09-18 01:10:02 +00:00
Jörg Mayer 7c4176d868 Removed trailing whitespaces from .h and .c files using the
winapi_cleanup tool written by Patrik Stridvall for the wine
project.

svn path=/trunk/; revision=6117
2002-08-28 21:04:11 +00:00
Jörg Mayer 173fe5aef4 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

svn path=/trunk/; revision=5932
2002-08-02 23:36:07 +00:00
Guy Harris ff0df5d8a4 From Didier Gautheron: add FPGetUserInfo.
svn path=/trunk/; revision=5911
2002-07-29 06:35:12 +00:00
Guy Harris 77fa06b899 From Joerg Mayer:
dftest.c:
	     Remove #if-0-ed includes

	packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
	     Remove redundant include varargs (already in snprintf.h,
	     and required only for snprintf.h)

	Remove unused include of snprintf.h from files not using
	"snprintf()".

svn path=/trunk/; revision=5889
2002-07-17 00:43:03 +00:00
Guy Harris 38b8101248 From Didier Gautheron: assorted small fixes, more AFP calls, and DSI/ASP
error code in the Info column.

svn path=/trunk/; revision=5712
2002-06-20 00:44:33 +00:00
Guy Harris ca03167c44 Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourth
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to
run to the end of the parent tvbuff.

svn path=/trunk/; revision=5599
2002-05-30 05:26:05 +00:00
Guy Harris aadc22d704 From Didier Gautheron: do case-insensitive comparison against the
authentication mode, and add support for the "exchange file" operation.

svn path=/trunk/; revision=5449
2002-05-11 22:40:40 +00:00
Guy Harris 04ad5f17ea From Didier Gautheron:
afp :
	more calls.
    asp :
	move release transaction to atp.
	dissect asp call.
	fix a bug with transaction handling (conversation +tid are not
	enough as key ).
    atp :
	deal with one packet transaction without ATP_EOM.
    dsi:
	safeguard against overflow for unreassembled packet.
	more flags decoded.

Update the "packet-atalk.c" comment to reflect all the protocols in it.

svn path=/trunk/; revision=5376
2002-05-03 21:25:43 +00:00
Guy Harris 4b8e35553a Mark some unused arguments as such.
Fix white space.

svn path=/trunk/; revision=5339
2002-05-01 10:01:42 +00:00
Guy Harris 2d7f732677 From Didier Gautheron:
more calls supported in AFP;

	ATP desegmentation;

	show the name for NBP function 1 (broadcast request);

	"get status" reply for DSI.

svn path=/trunk/; revision=5316
2002-04-30 22:05:33 +00:00
Guy Harris 0f18641f5b Have separate fields for volume, long file name, short file name, and
Unicode file name offsets.

Display the "UNIX privileges" field as a 4-longword structure, as part
of the AFP 3.0 spec claims; unfortunately, another part claims it's only
4 bytes, but, unless a "long" is 8 bits, one or the other claim must be
false.

Completely get rid of the static "afp_handle" variable - it's not
necessary.

Put the Unicode name offset into the tree, if present, in
"parse_file_bitmap()" and "parse_dir_bitmap()".

Get rid of some unused variables.

Put the newline mask and character into the tree for FPRead.

svn path=/trunk/; revision=5289
2002-04-29 09:38:34 +00:00
Guy Harris 9a80f0a521 Removal (or, at least, #ifdeffing out) of unused variables and
functions, from David Frascone.

svn path=/trunk/; revision=5288
2002-04-29 08:20:18 +00:00
Guy Harris fd629d84a8 Show unknown AFP command codes in decimal in the summary line, as we
show them in decimal in the protocol tree.

svn path=/trunk/; revision=5282
2002-04-28 23:47:44 +00:00
Guy Harris 6ee5eebf6c Mark requests as such in the Info column.
svn path=/trunk/; revision=5278
2002-04-28 22:16:50 +00:00
Guy Harris e38d83af1a Set the nanoseconds value of time stamps to 0, rather than using
whatever random junk was in there.

svn path=/trunk/; revision=5276
2002-04-28 22:08:50 +00:00
Guy Harris 640a5e494a Pass even zero-length DSI and ASP "command" messages to the AFP
dissector, so it can show them as replies.

Put the command code into the protocol tree for replies.

Fix some additional AFP function names to match the names in the AFP
spec.

svn path=/trunk/; revision=5275
2002-04-28 21:53:31 +00:00
Guy Harris 04687b1e40 Give AFP messages the same names they're given in Apple's documentation.
svn path=/trunk/; revision=5274
2002-04-28 21:22:20 +00:00
Guy Harris b09a5af611 Clean up field names and descriptions.
Clean up white space.

svn path=/trunk/; revision=5273
2002-04-28 21:04:04 +00:00
Guy Harris 6db6535a41 Decode replies to FPWrite.
svn path=/trunk/; revision=5271
2002-04-28 19:33:32 +00:00
Guy Harris a8dd5ff42a Updates from Didier Gautheron:
More calls, more fields, and other updates, for AFP.

	Decode the error code for DSI.

Also, have separate fields for the code field in DSI when it's a data
offset and when it's an error code.

svn path=/trunk/; revision=5270
2002-04-28 19:21:39 +00:00
Guy Harris 9469b47866 ATP, ASP, and AFP support, from Didier Gautheron.
svn path=/trunk/; revision=5254
2002-04-25 23:58:02 +00:00