osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
52322 commits 26 branches 0 tags 795 MiB
Commit graph

282 commits

Author SHA1 Message Date
Pascal Quantin
d6548f9301 Remove unused const variables errors seen with recent Clang version 
Fixes bug 9886

Change-Id: I8624ef1c5874aea5521d21c998510fc29c838936
Reviewed-on: https://code.wireshark.org/review/657
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-15 17:52:16 +00:00
Alexis La Goutte
5d2409116e Fix indent (use 2 spaces) 
Change-Id: If7872c510d20e9f04e44e3fdf09c023e5ac602d9
Reviewed-on: https://code.wireshark.org/review/648
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-15 09:02:56 +00:00
0xbismarck
a59ac1bd10 Bug 9704: GSM_MAP SendRoutingInfoForSM incomplete 
Added the field information for Phase 1 for the Send Routing Info
For Sm message per request of ticket 9704. Code per the suggestion of
Anders Broman. Adding Phase 1 code to GSMMAP.asn.

Did not have any data to verify that the change worked.

Change-Id: Ic387e2e12e8893abb0f453f5010909ffbfd1808c
Reviewed-on: https://code.wireshark.org/review/147
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-13 22:14:28 +00:00
AndersBroman
3be07682c7 Omitting SubscriberData makes CONTENT OF fail and InsertSubscriberDataArg will not get all its tags 
Change-Id: I2ace2271d9ce5650e5239c12e64080463aae9367
Reviewed-on: https://code.wireshark.org/review/556
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-08 08:56:13 +00:00
Pascal Quantin
3a4b311e8b When dissecting GSM MAPv1/v2 messages, display opcode 44 or 46 as forwardSM 
Fixes bug 9829

Change-Id: Ib56bc7dc79ca27667fb89691817f6e568006d3a8
Reviewed-on: https://code.wireshark.org/review/494
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-04 12:19:07 +00:00
Bill Meier
1dff4e309d Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors. 
Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4
Reviewed-on: https://code.wireshark.org/review/412
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
 2014-02-26 19:38:21 +00:00
Jeff Morriss
8c608e6e82 Remove $Id$ from the ASN.1 dissectors and regenerate them. 
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
 2014-02-18 03:05:28 +00:00
Guy Harris
5e0641f271 Use tvb_get_string_enc() with an explicit encoding. 
svn path=/trunk/; revision=54886
 2014-01-22 02:04:15 +00:00
Anders Broman
1f8d2e25d2 Update to version V12.3.0 (2013-12). 
svn path=/trunk/; revision=54815
 2014-01-15 07:13:23 +00:00
Anders Broman
5a3ba6c19b Omit assignment for not used types. 
svn path=/trunk/; revision=54614
 2014-01-06 08:30:53 +00:00
Anders Broman
0c3f422b30 Omit assignment for not used types. 
svn path=/trunk/; revision=54596
 2014-01-04 17:48:15 +00:00
Anders Broman
c7c5e4f54e Omit assignment for not used types. 
svn path=/trunk/; revision=54592
 2014-01-04 11:54:27 +00:00
Anders Broman
4763f36a75 Omit assignment for not used types. 
svn path=/trunk/; revision=54588
 2014-01-04 11:26:30 +00:00
Anders Broman
2b32fed0ef Omit assignment for not used types. 
svn path=/trunk/; revision=54587
 2014-01-04 11:24:33 +00:00
Anders Broman
72970675bd Add the rest of the NOKIA extensions. 
svn path=/trunk/; revision=54586
 2014-01-04 10:06:04 +00:00
Anders Broman
4f62f2cfa3 Add a few more of the NOKIA extensions. 
svn path=/trunk/; revision=54580
 2014-01-03 13:29:48 +00:00
Pascal Quantin
6ebc058f47 Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it. 
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.

svn path=/trunk/; revision=54534
 2014-01-01 14:33:19 +00:00
Guy Harris
edb6cf0b16 Get rid of no-longer-used variables. 
svn path=/trunk/; revision=54433
 2013-12-24 01:30:00 +00:00
Guy Harris
0d7a48a8bf Add a ENC_3GPP_TS_23_038 encoding, for the standard SMS alphabet in a 
bit-packed string, and use it in some places.

svn path=/trunk/; revision=54428
 2013-12-24 00:20:09 +00:00
Guy Harris
5084f58ce2 We support ENC_UCS_2, so use that in proto_tree_add_item() and 
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.

svn path=/trunk/; revision=54350
 2013-12-22 02:12:32 +00:00
Anders Broman
4124b7aa17 - Forward declaration of register functions. 
svn path=/trunk/; revision=53872
 2013-12-08 22:02:12 +00:00
Jakub Zawadzki
65db82872c When including <epan/prefs.h> don't force inclusion of <epan/uat.h> 
svn path=/trunk/; revision=53769
 2013-12-03 22:16:49 +00:00
Anders Broman
861e0334f4 From Vineeth: 
Support for Nokias GSM MAP Private Extensions

svn path=/trunk/; revision=53600
 2013-11-26 20:29:17 +00:00
Pascal Quantin
696194999e From Vasil Velichkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9382 : 
Fix dissection of GSM MAPv3 ReportSM_DeliveryStatusRes

svn path=/trunk/; revision=53148
 2013-11-07 21:08:15 +00:00
Michael Mann
c0fcebb07a Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new. 
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector.  For now, all calls to call_ber_oid_callback have the data parameter set to NULL.

svn path=/trunk/; revision=52994
 2013-10-31 00:57:03 +00:00
Michael Mann
1c96e97f71 Update the ASN.1 generated dissectors that were missed as part of the patches in bug 9344 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344) 
svn path=/trunk/; revision=52978
 2013-10-30 02:02:08 +00:00
Michael Mann
3b91b9586f Pass tcap_private into the dissectors that need it rather than use private_data. Not sure if value_ptr is the "proper" place to pass tcap_private "internally" within the TCAP dissector, but it gets away from (potential) private_data (ab)use. 
svn path=/trunk/; revision=52916
 2013-10-28 13:36:49 +00:00
Pascal Quantin
76e8ff1d8d Replace the 3 dissector tables (with a single entry in each) by a direct call to the GSM SMS dissector 
svn path=/trunk/; revision=52336
 2013-10-02 18:04:06 +00:00
Pascal Quantin
a0c53ffaa1 emem -> wmem conversion: 
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
 2013-09-22 15:50:55 +00:00
Jörg Mayer
ac6214533e Regenerate all files where the .cnf files had whitespace changes. 
svn path=/trunk/; revision=52125
 2013-09-17 18:55:18 +00:00
Chris Maynard
0c41507bad Change some internal dissector table UI names so it's clear which protocol they pertain to and it's easier to find in the list. 
svn path=/trunk/; revision=51904
 2013-09-09 21:55:57 +00:00
Anders Broman
08d223eb71 When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)" 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015

svn path=/trunk/; revision=51208
 2013-08-08 04:36:54 +00:00
Michael Mann
7878e93cad expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable. 
svn path=/trunk/; revision=50377
 2013-07-03 23:43:26 +00:00
Michael Mann
98492c5619 expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable 
svn path=/trunk/; revision=50337
 2013-07-03 02:59:31 +00:00
Evan Huus
9fa4a8e6b6 Convert a batch of asn1 dissectors from emem to wmem. 
svn path=/trunk/; revision=50057
 2013-06-19 20:43:03 +00:00
Michael Mann
7fe5422c4b Convert ASN.1 dissectors to use filterable expert info. 
NOTE: Kerberos ASN.1 template was updated, but not generated to source.

svn path=/trunk/; revision=49707
 2013-06-03 03:42:36 +00:00
Pascal Quantin
0ee4d0a00a Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

svn path=/trunk/; revision=49599
 2013-05-27 20:26:49 +00:00
Anders Broman
5b279569d2 Export CellGlobalIdOrServiceAreaIdOrLAI. 
svn path=/trunk/; revision=49312
 2013-05-15 16:48:49 +00:00
Pascal Quantin
a37c044203 Update the ASN.1 based dissectors following the changes done in r48812 
svn path=/trunk/; revision=48820
 2013-04-11 18:14:53 +00:00
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Anders Broman
dafdc19d9e -Wmissing-prototypes 
svn path=/trunk/; revision=48609
 2013-03-28 07:34:13 +00:00
Chris Maynard
186d0c2006 Fix another incorrectly duplicated display filter, this time for hf_gsm_map_etsi_pdp_type_number. 
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48601
 2013-03-27 21:41:56 +00:00
Chris Maynard
da30b9eb92 Fix the incorrectly duplicated display filter for hf_gsm_map_dlci. 
#BACKPORT(1.6, 1.8)

svn path=/trunk/; revision=48597
 2013-03-27 20:44:47 +00:00
Pascal Quantin
88c0e8e873 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8517 : 
Do not tap an unknown Opration Code

svn path=/trunk/; revision=48539
 2013-03-24 21:53:53 +00:00
Anders Broman
1b788d4061 Update to V11.5.0 (2012-12). 
svn path=/trunk/; revision=48195
 2013-03-08 17:55:53 +00:00
Pascal Quantin
7fdbff4822 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 : 
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly.

svn path=/trunk/; revision=47927
 2013-02-27 23:08:17 +00:00
Anders Broman
e5556e29ce Export TBCD-STRING. 
svn path=/trunk/; revision=47496
 2013-02-05 15:12:13 +00:00
Anders Broman
4a8f124c43 Add an OID translation. 
svn path=/trunk/; revision=47386
 2013-01-31 16:59:39 +00:00
Jaap Keuter
f177deead0 Fix for CID 280252. 
We can be sure we've at least 0 bytes remaining in the TVB.

svn path=/trunk/; revision=47162
 2013-01-19 13:06:26 +00:00
Anders Broman
5c1bc94608 "Fill" a couple of value_string(ext) 
svn path=/trunk/; revision=46518
 2012-12-12 12:48:12 +00:00