Add a `-l n` option which will check the .c and .cpp files from the last
[n] commits.
Fix some shellcheck warnings.
Change-Id: I8185d6c6c5b08576315b47847795d210d47b042e
Reviewed-on: https://code.wireshark.org/review/33646
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
with last draft, there is temporary registered value to IANA
Global Association Source (30)
Extended Association Id(31)
ASSOCIATION (40)
Bug: 15834
Change-Id: I07a1eefdf650a295a6b9d9ae457f9d85204dab63
Ping-Bug: 11782
Reviewed-on: https://code.wireshark.org/review/33641
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This is no more required.
Change-Id: Ib88066eaa0cb7f8b30cfe93bbdc797882802b992
Reviewed-on: https://code.wireshark.org/review/33642
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
This reverts commit 5d0fec3363.
"set -e" breaks all macOS builds after completing the script block.
Change-Id: I5c297fd4b1b816d3143fa8fd8a51eb848c7c2de4
Reviewed-on: https://code.wireshark.org/review/33638
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
The TCP MSS option is annotated by expert items as follows:
- in a SYN packet the lack of the MSS option could indicate
a misconfigured node.
- in a non-SYN packet the presence of the MSS option could indicate
a malfunctioning node.
Change-Id: Ie3827cd6c7dcf605ac2f72a3a080418611637070
Reviewed-on: https://code.wireshark.org/review/33632
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Move plus-8.png to stock_icons/8x8 and rename it list-add.template.png
which conforms to the Freedesktop icon naming specifications and makes
it a template icon.
Update our style sheet when we recive a QEvent::PaletteChange.
Ping-Bug: 15511
Change-Id: I4b8ddcb4eb64f11faec21d5df4a3fd7fdc5cf488
Reviewed-on: https://code.wireshark.org/review/33626
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
If a DnD is initiated from the ProtoTree it actually copies the complete
text of the expanded tree elements. This can be dropped in any text-window
outside of Wireshark
Change-Id: Ia174bcf2f061ddb23439c3243149bb54a1ba89d9
Reviewed-on: https://code.wireshark.org/review/33630
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
If you start dragging on an empty field, you pick up the value of
a field you drag over. This is fixed
Change-Id: I7e1c5e353dbc79ee1193b305729fb44d62d98470
Reviewed-on: https://code.wireshark.org/review/33629
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
wmem should not be used inside a model, as the memory managment of
those models is part of the responsibility of Qt. It could happen,
that the file is closed, but the model still needs to access the
information, in which case the memory access fails.
Change-Id: I740a4bae61cc32f0f0245515c23abf175ef588f1
Reviewed-on: https://code.wireshark.org/review/33622
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Allow for drag-and-drop on info and protocol columns. Protocol columns
may also be dragged to the display filter, everything else is dragged
as plain-text and can just be used as text
Change-Id: I0fff390580c22175efe50037b18d7199949fd8eb
Reviewed-on: https://code.wireshark.org/review/33621
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Only initiate drag-and-drop when the left mousebutton has been
clicked, and also add the filter as plain text, so to enable
dragging to external applications.
Change-Id: I2f6ac7f9c543d003070c2a6c0ce671ed5a215669
Reviewed-on: https://code.wireshark.org/review/33620
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Change-Id: Id67a159615ba2d8edbfabd36d33d3e01438a3c77
Reviewed-on: https://code.wireshark.org/review/33625
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
USBPcap 1.5.0.0 features two main changes:
* Introduction of USB IRP Info transfer type (0xFE)
This type is used when the IRP is of general interest to the user,
but does not really directly match to any USB payload. When such
type is encountered, display the URB Function code in Info column.
Currently following URB functions are recorded as USB IRP Info:
* URB_FUNCTION_SYNC_RESET_PIPE_AND_CLEAR_STALL
* URB_FUNCTION_SYNC_RESET_PIPE
* URB_FUNCTION_SYNC_CLEAR_STALL
* URB_FUNCTION_ABORT_PIPE
* URB_FUNCTION_CLOSE_STATIC_STREAMS
* Introduction of control stage COMPLETE (0x03)
The control transactions are now recorded as 2 packets: SETUP and
COMPLETE. All Wireshark versions since the USBPcap pseudoheader
support was implemented correctly pass the data to subdissectors.
This makes the USBPcap control packets behave just like usbmon.
Ping-Bug: 15842
Change-Id: Idc0edf2a0fcf58997531c492293e0719f037493f
Reviewed-on: https://code.wireshark.org/review/33623
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
It was used for two purposes:
1) passing the subcommand to dissectors for the request setup,
parameters, and data;
2) getting the security descriptor and extended attribute length
from the request parameters and passing them to the dissector
for the request data.
It was completely unused for responses.
Pass the subcommand as an argument to all routines that need it,
pass pointers to local variables to the request parameters dissector,
and pass those variables to the request data dissector.
This makes it a bit clearer what information is needed where, and
completely eliminates the structure for response dissection.
Change-Id: I431daa79da41dc4166490a564efee71cdb83edc1
Reviewed-on: https://code.wireshark.org/review/33614
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This will stop if the build fails as soon as one command fails.
This prevents for instance to run the tests if one executable
failed to compile.
A long discussion is still in place and this looks like the quickest
solution: https://github.com/travis-ci/travis-ci/issues/1066
Change-Id: Ifa630bc37b43b4ee9693cebdbb5b8a6ddf127aad
Reviewed-on: https://code.wireshark.org/review/33612
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add an optional paramter of type Proto to DissectorTable.new().
If the caller provides a Proto, we can get the protocol id and
use it when we register the dissector table.
Change-Id: I3ab0819c41fa97288ec962d8d495b63d4750ce4b
Reviewed-on: https://code.wireshark.org/review/33608
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
DCP_ABORT now needs the prepare seqno for MB-34474.
Change-Id: Idf36f85f593735e31c7be96b0c9253d90fdb825f
Reviewed-on: https://code.wireshark.org/review/33597
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reorder the code to have a single return statement at the end.
Take advantage of the fact that WSLUA_OPTARG_ERROR terminates
the C function that called it.
Do only the parameter checks in the switch-case statement.
Get rid of the intermediate steps when we copy name and ui_name.
Change-Id: Ie8917d19589a6ee16a4a5d14f2c1711d35cc8114
Reviewed-on: https://code.wireshark.org/review/33607
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix "Resize Column to Width" and display filter drop menu
to use UTF8_HORIZONTAL_ELLIPSIS.
Change-Id: I0ce2507741e985fbf840296cc956358accc02b01
Reviewed-on: https://code.wireshark.org/review/33611
Reviewed-by: Roland Knall <rknall@gmail.com>
As per p2p spec 1.5v table 13: Group Capability Bitmap definition
7th bit is IP over eapol support.
Change-Id: Ie99a7db0cfe32f30303b2e06358aa375de5bac7f
Reviewed-on: https://code.wireshark.org/review/33599
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Allow cells to be used in drag-and-drop operations
Change-Id: I6eeb5e32076ba9dddc73265e213e8cfeae1f0783
Reviewed-on: https://code.wireshark.org/review/33604
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
The context menu got removed, adding it back
Change-Id: Ia44a6ed576a88be5a07d76c184740a2fd9bfa844
Reviewed-on: https://code.wireshark.org/review/33602
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
USBPcap control status packets for non standard request types (eg.
Vendor) were incorrectly treated as the standard request type. This
resulted in confusing Info column description.
Describe status packet of non standard request types as "URB_CONTROL
status". Do not try any extra labelling as the overall idea of
Setup/Data/Status is not too good and will be revised in future USBPcap
versions.
Ping-Bug: 11743
Ping-Bug: 15842
Change-Id: Iade5cb85aa01e65874006eb4c7a242568f07b7c8
Reviewed-on: https://code.wireshark.org/review/33596
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Allows the width of a column to be set using an entry on the context menu
Change-Id: Ibb7a9dd9a0dbe99f888cde8d4a274676acf920f1
Reviewed-on: https://code.wireshark.org/review/33580
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The C code introduced ft_none dissector tables some time ago. They have
no indicator to select the next protocol, only Decode As is supported
for them.
Allow lua code to create ft_none dissector tables as well. The patch
is trying to make as few changes as possible to DissectorTable_new().
Change-Id: Ie3ff58f092e6922ab7878d202c7484a64b2430a3
Reviewed-on: https://code.wireshark.org/review/33588
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
It shouldn't be used by anything outside packet-smb.c; the standard
string-encoding mechanisms should be used for UTF-16 strings.
Change-Id: Ibfc8f5c460c5aef85a5a2a3ee39a066fd9501b16
Reviewed-on: https://code.wireshark.org/review/33592
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
It's now the ResponseType field; dissect it as such.
Change-Id: Ibc4a8031bf0c1d758a232cbd6b8487d4edcaccd6
Reviewed-on: https://code.wireshark.org/review/33591
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
RFC 6126 (Babel) is updated by RFC 6126bis. This adds the
following features from 6126bis and related drafts:
- Unicast (draft-ietf-babel-rfc6126bis-09)
- Mandatory (draft-ietf-babel-rfc6126bis-09)
- Unscheduled Hello (draft-ietf-babel-rfc6126bis-09)
- HMAC, PC, Challenge Request and Reply (draft-ietf-babel-hmac-04)
- Packet Trailer (draft-ietf-babel-rfc6126bis-09)
Bug: 15846
Change-Id: I83db9d68e3971a2adc6276882cb5c8d288eb8c98
Reviewed-on: https://code.wireshark.org/review/33564
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This is a cleanup patch to remove unused or unnecessary code from
packet list and put it in its respective header class for better
code maintenance
Change-Id: Ib7d7f34ab9cdd802199b3f279499855c80f8f0c5
Reviewed-on: https://code.wireshark.org/review/33587
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
