osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
34,691 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

14812 Commits

Author SHA1 Message Date
Bill Meier 57833dc778 Don't assign to a proto_item* if the value won't be used: Coverity 942-951 
Also: minor Code & Whitespace cleanup.

svn path=/trunk/; revision=36317
 2011-03-24 22:27:20 +00:00
Stephen Fisher df50d409fb Only display the 3 digits of precision after the decimal that we have 
from the ICMP conversation response time tracking. 


svn path=/trunk/; revision=36316
 2011-03-24 21:22:07 +00:00
Bill Meier 78dda7cc7e Don't assign to a proto_item* if the value won't be used: Coverity 1124-1128; 
Also: minorwhitespace cleanup.


svn path=/trunk/; revision=36314
 2011-03-24 20:17:22 +00:00
Chris Maynard 9493ebe8e9 Display the value of the ICMP echo request/reply response time in milliseconds. 
svn path=/trunk/; revision=36313
 2011-03-24 18:05:10 +00:00
Tomas Kukosa 7755178447 Export next_tvb_... functions 
svn path=/trunk/; revision=36311
 2011-03-24 16:21:31 +00:00
Jeff Morriss 01ec42762f From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 3 :
Enhance MySQL : Request/Response sub-dissector/function 
(white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()...)

Patch 4 :
Enhance MySQL : packet_ok, server, capa sub-dissector/function (white space
changes, use ENC_NA when appropriate, use proto_tree_add_item()...)

Split mysql_dissect_caps in mysql_dissect_caps_client and
mysql_dissect_caps_server

Rename mysql_dissect_ext_caps to mysql_dissect_ext_caps_client

svn path=/trunk/; revision=36309
 2011-03-24 15:31:52 +00:00
Anders Broman db3a34973a Beutify IMEISV IE output. 
svn path=/trunk/; revision=36308
 2011-03-24 10:36:39 +00:00
Anders Broman d11e6439cd Fix Checkapi errors 
Error: the name for field " N32" ("gsm_rlcmac_dl.n32") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N51" ("gsm_rlcmac_dl.n51") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N26" ("gsm_rlcmac_dl.n26") has leading space in packet-gsm_rlcmac.c

svn path=/trunk/; revision=36307
 2011-03-24 10:35:29 +00:00
Anders Broman 4cd37afb6c From Vincent Helfre: 
I updated again the csn1 dissector to associate hf_field to each element.

svn path=/trunk/; revision=36306
 2011-03-24 09:20:14 +00:00
Jeff Morriss bb61772be7 From Dirk: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2930 : 
Make the image (png, gif, jfif) dissectors "new style" so that they don't
dissect data that does not belong to them.

Modify the HTTP dissector to call heuristic dissectors on the body if the
registered subdissector does not accept/dissect the data.

From me: don't use assert() and don't add a preference to the HTTP dissector
for this behavior: it makes sense to behave like that by default.

svn path=/trunk/; revision=36305
 2011-03-24 02:49:05 +00:00
Jeff Morriss 8c73d0c6f4 If we've already seen a segment which starts a multi-segment pdu (i.e., it's 
a retransmission), don't add it to the list (tree) of multi-segment pdus.

Otherwise, if we'd already seen the rest of the pdu and the other segments
were not retransmitted, the retransmission would break dissection of the pdu
because lookups for the segment would find the retransmission (to which the
other segments were not attached).

Since we know this segment is a retransmission, don't bother handing it off
to the subdissector either.

Use PINFO_FD_VISITED().
Add some white space in the desegmentation routine to improve readability.

Apply the same changes to the SSL dissector.

svn path=/trunk/; revision=36304
 2011-03-24 02:10:04 +00:00
Ronnie Sahlberg 5f502a5bfb remove a conditional that can never be true 
coverity 247


svn path=/trunk/; revision=36301
 2011-03-23 21:17:29 +00:00
Chris Maynard 276e9cced3 Add ICMP echo request/reply conversation tracking. Closes bug 5770. 
svn path=/trunk/; revision=36298
 2011-03-23 20:20:40 +00:00
Jeff Morriss e7a6230eca From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 1 :
Enhance MySQL : Reorder hf and Proto_reg

Patch 2 :
Enhance MySQL : white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()

svn path=/trunk/; revision=36296
 2011-03-23 19:12:24 +00:00
Bill Meier 95402cf9de Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)' 
Coverity 345

svn path=/trunk/; revision=36293
 2011-03-23 15:21:18 +00:00
Bill Meier ae465d5d39 Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)' 
Coverity 346 & 347

svn path=/trunk/; revision=36292
 2011-03-23 15:15:02 +00:00
Stig Bjørlykke 03941b54ed Fixed second parameter to create_persconffile_profile. 
svn path=/trunk/; revision=36291
 2011-03-23 14:58:34 +00:00
Stig Bjørlykke 714c8c52b9 Ensure we create the "Default" personal configuration files directory before 
creating a new profile.  This fixes a bug when trying to create a new profile
from a newly installed wireshark with no saved preferences.

svn path=/trunk/; revision=36290
 2011-03-23 14:52:39 +00:00
Bill Meier fc11b62891 Fix bug: 'guint8 |=0x8000'. 
Coverity 350

svn path=/trunk/; revision=36289
 2011-03-23 14:51:40 +00:00
Jeff Morriss 50c8f0f80a Don't use C++/C99-style comments. 
svn path=/trunk/; revision=36288
 2011-03-23 13:18:38 +00:00
Martin Mathieson d620640a70 Remove some unncessary assignments to proto_item pointers. 
Coverity 904 & 905.

svn path=/trunk/; revision=36287
 2011-03-23 11:35:03 +00:00
Martin Mathieson b47c36a4bd Don't assign proto_item pointers that are not used. 
Coverity CIDs 1021 & 1022.

svn path=/trunk/; revision=36286
 2011-03-23 10:58:24 +00:00
Martin Mathieson 473b578880 Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack. 
svn path=/trunk/; revision=36285
 2011-03-23 10:12:35 +00:00
Anders Broman fd782e736c From Vincent Helfre: 
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description

svn path=/trunk/; revision=36284
 2011-03-23 09:14:50 +00:00
Stig Bjørlykke aca69d699a Removed "comparing an array to null", with no effect. 
Coverity 532.

svn path=/trunk/; revision=36279
 2011-03-23 07:25:08 +00:00
Ronnie Sahlberg 0832de6b8e value&0x03 does not need to be shifted to the right by two. 
cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value

coverity 342


svn path=/trunk/; revision=36278
 2011-03-23 06:50:09 +00:00
Anders Broman 691c566900 CID 453,454 
Missing break

svn path=/trunk/; revision=36277
 2011-03-23 05:48:58 +00:00
Ronnie Sahlberg 89d3156883 Shift the correct number of steps when masking the UAAERP bit to 0/1 
coverity 348

svn path=/trunk/; revision=36274
 2011-03-23 04:55:22 +00:00
Ronnie Sahlberg 24eb2e7b6e The NSG bits in the login pdu are 0x0c not 0xc0 
coverity 344


svn path=/trunk/; revision=36273
 2011-03-23 04:50:17 +00:00
Ronnie Sahlberg feaf55330e Coverity 989 
Remove some item=  assignments we dont need since we never use the value
of the created item.


svn path=/trunk/; revision=36269
 2011-03-22 20:48:36 +00:00
Bill Meier 1f5bfa75b1 Remove two tests for fail return from g_malloc(); Fixes Coverity #424 "FORWARD_NULL" 
svn path=/trunk/; revision=36267
 2011-03-22 19:27:48 +00:00
Stig Bjørlykke fac93b08b2 Allocate correct size of nwk_keyring. 
Coverity 715.

svn path=/trunk/; revision=36265
 2011-03-22 19:16:19 +00:00
Stig Bjørlykke 41d5c9b750 Allocate correct size of hash_key. 
Coverity 713.

svn path=/trunk/; revision=36264
 2011-03-22 19:13:48 +00:00
Stig Bjørlykke f51139e659 Allocate correct size of reload_frame. 
Coverity 714.

svn path=/trunk/; revision=36263
 2011-03-22 19:13:05 +00:00
Stig Bjørlykke 2cc2403a33 Initialize al_cto before usage. 
Coverity 808.

svn path=/trunk/; revision=36260
 2011-03-22 18:42:02 +00:00
Bill Meier fda538056f Fix potential array overrun: Coverity CID #565. 
svn path=/trunk/; revision=36258
 2011-03-22 18:26:36 +00:00
Martin Mathieson 46857df13e Fix mask when extracting FACH Indicator. 
Coverity CID 349.

svn path=/trunk/; revision=36257
 2011-03-22 18:24:38 +00:00
Martin Mathieson 0370a7977d Remove redundant comparison. 
Coverity CID 361.

svn path=/trunk/; revision=36256
 2011-03-22 18:06:58 +00:00
Martin Mathieson 034820599a Make a struct static to avoid growing the stack too much. 
Coverity CID 753.

svn path=/trunk/; revision=36255
 2011-03-22 17:46:59 +00:00
Martin Mathieson bed50222ac Don't assign top_ti - delete it for now. 
Coverity CID 862

svn path=/trunk/; revision=36254
 2011-03-22 17:37:47 +00:00
Stephen Fisher b494b86514 From Dirk via bug #5771: Add heuristic dissector for images and HTTP 
Also add to AUTHORS file.


svn path=/trunk/; revision=36253
 2011-03-22 16:43:16 +00:00
Martin Mathieson 4611533752 There can be up to 15 DL HARQ processes (depending upon TDD config index). 
svn path=/trunk/; revision=36250
 2011-03-22 14:39:02 +00:00
Stig Bjørlykke 9ec9b1ccb9 Pass pointers to structs instead of struct values to create_ntlmssp_v2_key. 
Coverity 567.

svn path=/trunk/; revision=36248
 2011-03-22 12:12:04 +00:00
Stig Bjørlykke bdf603c403 Close fp in error case in ssl_parse_key_list to avoid leakage. 
Coverity 597.

svn path=/trunk/; revision=36246
 2011-03-22 11:40:15 +00:00
Stig Bjørlykke a07fff3b15 Corrected hack for TAPA by checking for "not IPv4". 
Coverity 343.

svn path=/trunk/; revision=36244
 2011-03-22 10:12:07 +00:00
Ronnie Sahlberg ff04f85940 Coverity 512 
Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.



svn path=/trunk/; revision=36241
 2011-03-22 09:35:26 +00:00
Anders Broman 1ab6930388 - Add 9.4.5 IMEISV IE dissection 
- UE Time Zone is TLV
- Cell Global Identity  PDU type is SGSAP_PDU_TYPE

svn path=/trunk/; revision=36239
 2011-03-22 09:06:42 +00:00
Bill Meier bdd6f7f692 Re-arrange code so Coverity Prevent doesn't falsely report several INFINITE_LOOPs: Coverity 427-429 (run 617) 
svn path=/trunk/; revision=36233
 2011-03-22 00:38:55 +00:00
Bill Meier 56bea38672 Fix an "infinite loop" defect reported by Coverity Prevent (Coverity 430 (run 616)). 
svn path=/trunk/; revision=36231
 2011-03-21 19:33:19 +00:00
Stig Bjørlykke 62559137c4 Corrected decoding of oid values with length 5. 
This fixes coverity 340.

svn path=/trunk/; revision=36230
 2011-03-21 18:58:48 +00:00