Commit graph

6119 commits

Author SHA1 Message Date
Bill Meier
2078ed4a5f Fix one add'tl warning as reported by David Kirkby
svn path=/trunk/; revision=24298
2008-02-11 01:41:49 +00:00
Guy Harris
6dd81aa615 The type field of an mtp3_addr_pc_t is a "which SS7 standard is this?"
type, not a "how do I format addresses?" type; declare it as such, and
remove the comment that pointed out that the type field had the wrong
(C) type.

svn path=/trunk/; revision=24297
2008-02-10 21:38:52 +00:00
Bill Meier
bad9f18d33 Fix (Sun) compiler warnings as reported by David Kirkby: Part 1
svn path=/trunk/; revision=24295
2008-02-09 23:35:28 +00:00
Anders Broman
d6aea2d0a1 - Add application Id:s to Diameter
- Further dissect 3GPP Radius AVP:s.

svn path=/trunk/; revision=24293
2008-02-08 16:32:12 +00:00
Stig Bjørlykke
42fe2398b9 Added missing "svn:keywords Id" and "svn:eol-style native" for some
c and h files.

svn path=/trunk/; revision=24290
2008-02-08 09:45:36 +00:00
Ronnie Sahlberg
4284906aba based on the novell idllib sources :
add dissection of the 16 byte header prior to the NDR data when NDR is 
transported as a blob ontop of !dcerpc
like the LOGON_INFO in the PAC in kerberos


svn path=/trunk/; revision=24289
2008-02-08 09:20:02 +00:00
Stig Bjørlykke
28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Stig Bjørlykke
36431783b7 Removed a break which disabled some code.
svn path=/trunk/; revision=24285
2008-02-07 15:12:50 +00:00
Stig Bjørlykke
64d9306f29 Rewrote some "if(tree)" code inside a switch-case to avoid unused code
(which did not work as expected).

switch(type) {
  case 1:
    ...
    break;
  if(tree) {
    case 2:
      ...
      break;
  }
}

svn path=/trunk/; revision=24284
2008-02-07 15:05:42 +00:00
Stig Bjørlykke
c6af1bfdd4 Removed some "statement not reached" warnings.
svn path=/trunk/; revision=24282
2008-02-07 12:14:40 +00:00
Stig Bjørlykke
609bb57097 Corrected some types.
svn path=/trunk/; revision=24280
2008-02-07 11:42:11 +00:00
Stig Bjørlykke
138381e214 From Thomas Dreibholz (bug 2248):
Add a dissector for the Scripting Service Protocol provided as part of the
RSPLIB package.  RSPLIB is an Open Source implementation of the upcoming
Reliable Server Pooling standard.  The scripting service is an application
for load distribution, based on Reliable Server Pooling.

From me:
Shorten the protocol name to SSP.

svn path=/trunk/; revision=24276
2008-02-06 14:28:30 +00:00
Anders Broman
d1c0ab9ab0 Update gsm map asn1 files to latest version.
svn path=/trunk/; revision=24270
2008-02-05 06:10:34 +00:00
Stig Bjørlykke
ceca9ab2e9 From Shane Kearns (bug 2242):
1) update SDP dissector with new IDs from assigned numbers document
   https://www.bluetooth.org/apps/content/default.aspx?doc_id=49709
2) decode attribute IDs in an "attribute ID list" parameter (previously it
   showed raw number only)
3) removed some duplicate entries in vs_service_classes

svn path=/trunk/; revision=24267
2008-02-04 11:56:30 +00:00
Martin Mathieson
0c700edaba Add mapping for s1ap_r8.
svn path=/trunk/; revision=24264
2008-02-03 23:04:04 +00:00
Stig Bjørlykke
ef625890aa From Shane Kearns (bug 2237):
Added support for Symbian OS btsnoop.

The bluetooth HCI layer in Symbian OS can be configured to log all packets to a
file.  The log format, "btsnoop" is based on the RFC1761 "snoop" format - but
differences in the header make it incompatible.

The btsnoop format supports logging of these formats:
"H1" (raw HCI packets without framing)
"H4" (HCI UART packets including packet type header)
"H5" (HCI 3 wire UART packets including framing)
"BCSP" (HCI bluecore serial protocol including framing)

"H1" and "H4" are section numbers in the original v1 bluetooth specifications,
but still used colloquially - wireshark's existing support for Linux bluez HCI
logs uses the "H4" name.

In practice, the "H1" format is used for H5,BCSP and USB HCI logs, as the HCI
packet logs are mainly useful for debugging higher layers, bluetooth profiles
and bluetooth applications.

From me:
Deleted some unused prototypes.
Mark an unused parameter.

svn path=/trunk/; revision=24263
2008-02-03 21:11:53 +00:00
Stig Bjørlykke
a341198859 From Shane Kearns (bug 2239):
L2CAP dissector is missing retransmission & flow control modes (these were
introduces in BT 1.2 specification)
Configuration commands were not fully decoded because of a bigend/littleend
issue
L2CAP commands had the wrong length set to the protocol tree by reading from
the wrong buffer offset
Also the dissect_options() function consumes all remaining data in the L2CAP
packet, which prevents decoding of other commands which follow a config
request/config response in the same packet.

From me:
Mark an unused parameter.

svn path=/trunk/; revision=24262
2008-02-03 21:04:01 +00:00
Stig Bjørlykke
47d744b59d More rewrite of prohibited APIs (sprintf, strcpy, strcat).
svn path=/trunk/; revision=24258
2008-02-03 15:38:20 +00:00
Anders Broman
2ab56c11e8 Update asn1 files to 3GPP TS 25.433 V7.7.0 (2007-12)
svn path=/trunk/; revision=24256
2008-02-03 13:47:50 +00:00
Anders Broman
2942ff4d5b Get rid of some warnings.
svn path=/trunk/; revision=24251
2008-02-03 10:07:42 +00:00
Anders Broman
3ead3cd279 Update asn1 files to GPP TS 25.413 V7.8.0 (2008-01).
svn path=/trunk/; revision=24250
2008-02-03 09:51:57 +00:00
Stig Bjørlykke
677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Stig Bjørlykke
f4871e6269 Fixed a possible buffer overflow in dissect_fmp_flushCmd() when cmd has
all bits set.

svn path=/trunk/; revision=24248
2008-02-02 17:17:16 +00:00
Stig Bjørlykke
dc1f6dc424 Rewrote strcat -> strncat, and fixed to show more than the last remaining
Cmd_Argv value for Remote Command.

svn path=/trunk/; revision=24247
2008-02-02 17:13:30 +00:00
Jaap Keuter
1c2f043913 From Peter Kjellerstedt:
I was capturing an RTP stream the other day which contained JPEG images
streamed according to RFC 2435. However, Wireshark reported them as malformed.
After some debugging of the Wireshark code it turned out that the decoding of
JPEG images which contain a quantization table was incorrect. I have attached a
patch to correct the decoding.

svn path=/trunk/; revision=24246
2008-02-02 16:41:12 +00:00
Jaap Keuter
1a9aa1ae62 From Alan McBride:
The decoding of a SubscribeCOVProperty packet is not properly decoding the
Monitored Property Identifier field. It leaves a number of decoded bytes at the
end as data.

svn path=/trunk/; revision=24245
2008-02-02 16:30:46 +00:00
Sake Blok
0446fc0d94 Fix for bug 2202, when an ethernet frame with padding is encountered, the
reported length is 46, so there was a one-off error in the code.


svn path=/trunk/; revision=24244
2008-02-02 09:21:09 +00:00
Anders Broman
df0e82fa10 Dissect the FLUTE "data".
svn path=/trunk/; revision=24228
2008-01-30 22:34:17 +00:00
Jeff Morriss
8ba9f2d3a4 Move glib-2 specific code out of gsmmap.cnf (where we can't #ifdef around
it--asn2wrs doesn't understand #ifdef's) to packet-gsm-template.c

svn path=/trunk/; revision=24227
2008-01-30 17:11:06 +00:00
Mike Duigou
136e5c2e1f cleanup initial comment. fix urls and email addresses.
svn path=/trunk/; revision=24224
2008-01-29 23:28:10 +00:00
Bill Meier
fcff7d7613 Add missing 'static int' for dissect_diameter_3gpp_tmgi(...)
svn path=/trunk/; revision=24223
2008-01-29 20:33:43 +00:00
Anders Broman
9e03164d14 Dissect 3GPP AVP Code: 900 TMGI
svn path=/trunk/; revision=24222
2008-01-29 20:05:02 +00:00
Stig Bjørlykke
70d1699bb2 SSI dBm signal is signed.
svn path=/trunk/; revision=24218
2008-01-29 09:56:11 +00:00
Anders Broman
dd1ae8f4f7 Dissect Vendor id and Auth-application Id.
svn path=/trunk/; revision=24216
2008-01-28 19:55:20 +00:00
Stig Bjørlykke
dc3900dc00 Make use of an unused value.
svn path=/trunk/; revision=24213
2008-01-27 23:33:09 +00:00
Anders Broman
39b64a4d6c Add the forgotten file.
svn path=/trunk/; revision=24212
2008-01-27 23:18:57 +00:00
Anders Broman
ce40fc22a4 Make it possible to do subdissection of Diameter AVP:s and add dissection
of some 3GPP AVP:s.

svn path=/trunk/; revision=24211
2008-01-27 21:06:33 +00:00
Anders Broman
c3fa6a267c Uncomplete code change.
svn path=/trunk/; revision=24207
2008-01-27 14:27:11 +00:00
Anders Broman
1144c36b11 Fix reassembly.
svn path=/trunk/; revision=24205
2008-01-27 11:03:56 +00:00
Graeme Lunt
bf8ce12ca3 Use the standard X.402 module as a separate file rather than as cut/paste into the ACP133 module.
svn path=/trunk/; revision=24197
2008-01-26 10:18:10 +00:00
Graeme Lunt
2f97f065ff Remove "LDAP over SSL" registration as now handled by the LDAP dissector.
svn path=/trunk/; revision=24196
2008-01-26 10:14:26 +00:00
Graeme Lunt
fcef5823db 1) Support for configurable LDAP over SSL port
2) Support for RFC 3909 - cancelRequest extendedOperation
3) Support for RFC 3062 - passwordModify extendedOperation
4) Column information for ExtendedRequest, SearchResultRef and AbandonRequest
5) Column information for multiple LDAP operations in the same packet (uses " | " separator)


svn path=/trunk/; revision=24195
2008-01-26 10:12:22 +00:00
Graeme Lunt
b3e2ef167b 1) Correct attribute name.
2) Add subtreespecification attribute.
3) Label each attribute in the tree with the attribute type.


svn path=/trunk/; revision=24194
2008-01-26 10:05:13 +00:00
Jaap Keuter
c944d49dd6 From Bill Florac:
Corrected ATTRRPLY dissection. 
Removed a few unnecessary semi-colons.

svn path=/trunk/; revision=24193
2008-01-25 21:31:50 +00:00
Anders Broman
f0582373ef Decode som more MBMS elements. Diameter XML fixes.
svn path=/trunk/; revision=24192
2008-01-25 17:27:54 +00:00
Jaap Keuter
bfdf65c9ff From Thomas Morin:
I have written the attached patch to improve the userfriendly-ness of the
summary displayed in the last column of the packet list for IGMP packets.

The current code only tells the user the type of packet (REPORT, LEAVE, QUERY),
but doesn't include any information about what multicast group is joined to or
left.   Worse, for IGMPv3 Reports the user cannot tell quickly if the multicast
group is joined-to or left, without having to look at the inside of the packet
to know the type of report (include all, include none, exlude none, exclude
all, etc.).

svn path=/trunk/; revision=24190
2008-01-25 06:32:53 +00:00
Jaap Keuter
139b0e041c From Bill Florac::
Corrected display of attributes from previous patch (24165)
For V2, if field length was 0, do not display the empty field. This makes it
easier to read. I only did V2 as I do not have means to test V1.

svn path=/trunk/; revision=24189
2008-01-25 06:23:28 +00:00
Stig Bjørlykke
2df21cb1b7 Fixed some strcpy -> strncpy/g_snprintf cleanups.
Removed a debug printout in t38.

svn path=/trunk/; revision=24188
2008-01-24 23:01:37 +00:00
Stig Bjørlykke
c2f444f656 Added some parantheses to avoid a warning.
svn path=/trunk/; revision=24187
2008-01-24 22:51:17 +00:00
Stig Bjørlykke
c785bbf558 Removed even more C++ style comments.
svn path=/trunk/; revision=24186
2008-01-24 22:33:49 +00:00