Commit Graph

243 Commits

Author SHA1 Message Date
Martin Mathieson 4b182514c4 More progress on DRX checking
svn path=/trunk/; revision=52333
2013-10-02 16:51:10 +00:00
Martin Mathieson b3c3bd6e93 Call mac_lte_drx_control_element_received and make it static again
svn path=/trunk/; revision=52318
2013-10-01 16:19:42 +00:00
Martin Mathieson acf8fbb75d Deep copy needed (clang warning flagged by Alexis!)
svn path=/trunk/; revision=52291
2013-09-30 10:15:50 +00:00
Martin Mathieson 9e93af2470 And also where it is declared. Doesn't VSC++ warn about anything?
svn path=/trunk/; revision=52232
2013-09-27 16:40:50 +00:00
Martin Mathieson e8488209f8 Temporarily make an uncalled function non-static, until it gets called
svn path=/trunk/; revision=52231
2013-09-27 16:38:45 +00:00
Martin Mathieson e4186e832d Remove unused parameter
svn path=/trunk/; revision=52230
2013-09-27 16:29:05 +00:00
Martin Mathieson f655b556f7 Another step towards DRX support in LTE MAC
svn path=/trunk/; revision=52229
2013-09-27 16:18:09 +00:00
Martin Mathieson eb7cb19709 Another step towards tracking UE DRX state
svn path=/trunk/; revision=52190
2013-09-23 17:34:18 +00:00
Michael Mann 9e3f9b449f expert_add_info_format_text -> expert_add_info_format
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
Martin Mathieson e67292ff14 Move where timing reference for DRX timers will be set
svn path=/trunk/; revision=51783
2013-09-05 13:11:54 +00:00
Michael Mann 239971eca9 Fix some expert filter field names (one of which was illegal)
svn path=/trunk/; revision=51763
2013-09-05 02:52:08 +00:00
Michael Mann e65df7f453 Batch of filterable expert info.
Some of the FT_NONE hf_ variables were removed in favor of proto_tree_add_expert. It may also be possible to remove some of the booleans surrounding the expert info.

New expert display filters may need to be double-checked to make sure they make sense.

svn path=/trunk/; revision=51760
2013-09-05 01:05:16 +00:00
Martin Mathieson 86656b31d2 Another small step towards modelling and reporting upon DRX state in
MAC.

svn path=/trunk/; revision=51748
2013-09-04 16:56:37 +00:00
Pascal Quantin 84bf0acc00 Convert a few dissectors from EMEM to WMEM API
svn path=/trunk/; revision=51597
2013-08-30 14:49:55 +00:00
Martin Mathieson a09ee6af03 The first step towards tracking and showing DRX info in MAC:
- send release from RRC
- show current DRX config from each frame, including a link back to the
  RRC config frame
- show simple DRX state for each frame (currently only offset into long
  cycle and whether within long cycle 'on' period)

TODO:
- simulate timers in response to new UL/DL transmissions or DL CRC
  errors
- maintain whether in long or short cycle
- show state of all timers

svn path=/trunk/; revision=51585
2013-08-30 04:08:57 +00:00
Pascal Quantin 40607cbd27 Check presence of PagingRecordList before trying to fetch the number of Paging Ids
svn path=/trunk/; revision=51312
2013-08-12 09:56:30 +00:00
Martin Mathieson aabda8b275 Improve stats of broadcast messages
svn path=/trunk/; revision=51219
2013-08-08 14:45:45 +00:00
Pascal Quantin 218608f1a2 Count SDUs even when dumping only the MAC header
svn path=/trunk/; revision=50420
2013-07-06 21:07:42 +00:00
Pascal Quantin 784c7d680b Fix a null pointer dereference in downlink direction
svn path=/trunk/; revision=50374
2013-07-03 21:26:12 +00:00
Martin Mathieson b4c6e0eb1c Add an option (switched off) to decode the Contention Resolution body as
an RRC UL CCCH PDU.

svn path=/trunk/; revision=50024
2013-06-18 23:36:35 +00:00
Martin Mathieson ece132a5ce Configure MAC LCID -> RLC channel settings from RRC.
svn path=/trunk/; revision=50016
2013-06-18 21:02:00 +00:00
Pascal Quantin eecfb7c423 Apply r49983 to other dissectors
svn path=/trunk/; revision=49984
2013-06-17 18:44:19 +00:00
Martin Mathieson f4b3cb0917 Clarify interface/test for DL HARQ id, and remove a trailing comma from
an enum.

svn path=/trunk/; revision=49961
2013-06-16 15:11:21 +00:00
Anders Broman 85a8e304dd Add the posibillity to use a key for per-packet-data.
svn path=/trunk/; revision=49259
2013-05-12 18:11:02 +00:00
Martin Mathieson 74e15c70cc Flag as malformed expert info if we see padding subheaders at start and
end of subheader list.

svn path=/trunk/; revision=49035
2013-04-25 21:07:32 +00:00
Martin Mathieson 08c91ded8a Add a context field for the carrierId.
svn path=/trunk/; revision=48859
2013-04-15 20:56:49 +00:00
Evan Huus 37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Anders Broman d0efafbcb1 From beroset:
remove C++ incompatibilities from UAT_VS_DEF macro and all uses

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48259
2013-03-12 06:40:13 +00:00
Anders Broman 2cc8731bec From beroset:
remove C++ incompatibilities

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48185
2013-03-08 06:06:56 +00:00
Guy Harris 29715ccc8f How can I get a new tvbuff that starts at an offset within a given
tvbuff and runs to the end of the tvbuff?  Let me count the ways....

Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().

svn path=/trunk/; revision=47751
2013-02-19 23:17:07 +00:00
Martin Mathieson 8cdb2c675b Make the number of RAPIDs in an RAR PDU a generated field.
svn path=/trunk/; revision=47688
2013-02-16 00:05:37 +00:00
Martin Mathieson 9ab999a6f8 Fix a copy and paste error.
svn path=/trunk/; revision=46573
2012-12-17 14:39:59 +00:00
Martin Mathieson 76966a2cec Check that system frame number is in range.
svn path=/trunk/; revision=46548
2012-12-16 00:02:50 +00:00
Pascal Quantin 70c283816b Dissect eMBMS MTCH LCIDs
svn path=/trunk/; revision=46504
2012-12-11 23:20:22 +00:00
Martin Mathieson 5e90582d54 Add versions of a function that doesn't need do substitute specifiers.
svn path=/trunk/; revision=46298
2012-11-29 22:25:18 +00:00
Jeff Morriss 0266cceef3 Make all enum_val_t's const.
svn path=/trunk/; revision=46292
2012-11-29 20:15:37 +00:00
Martin Mathieson 878966a16e Add another DL error code.
svn path=/trunk/; revision=45995
2012-11-10 23:23:25 +00:00
Martin Mathieson fa79b7580a When configuring DRB mappings (from signalling channel), create a
separate table for each UE.

svn path=/trunk/; revision=45494
2012-10-12 03:00:38 +00:00
Bill Meier add85b1cbb Remove unneeded code ("[set_but_unused]").
svn path=/trunk/; revision=45347
2012-10-06 15:56:08 +00:00
Bill Meier 4f578199b5 Minor changes:
- proto_reg_handoff...() called only once: simplify;
- move proto_register...() to just before proto_reg_handoff...() as per convention;
- misc.

svn path=/trunk/; revision=45345
2012-10-06 15:52:14 +00:00
Martin Mathieson 5bd351fb32 Look up once and store the RLC and PDCP dissectors.
svn path=/trunk/; revision=45341
2012-10-06 14:59:51 +00:00
Pascal Quantin 5ec061bf0c Add options to dissect MCCH from LTE MAC/RLC dissectors
svn path=/trunk/; revision=45239
2012-10-01 19:51:07 +00:00
Pascal Quantin 7dd916459e Let's be consistent and display lte_rrc root for all LTE RRC messages
svn path=/trunk/; revision=45080
2012-09-23 21:01:05 +00:00
Pascal Quantin a8f9cd6593 Upgrade MAC LTE dissector to v11.0.0
svn path=/trunk/; revision=45048
2012-09-21 20:11:11 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Martin Mathieson d729f21ad2 Revert r45005.
svn path=/trunk/; revision=45006
2012-09-19 16:56:59 +00:00
Martin Mathieson a232ae9242 Make proto_item_append_string() behave sanely, and use it in a few more
dissectors.

svn path=/trunk/; revision=45005
2012-09-19 11:58:32 +00:00
Pascal Quantin cb5b915840 Fix dissection of Scheduling Information MAC Control Element when it is the only LCID in the MCH PDU
svn path=/trunk/; revision=44973
2012-09-18 17:26:00 +00:00
Jakub Zawadzki 9f92dc93c5 Add data parameter to call_dissector_only.
svn path=/trunk/; revision=44872
2012-09-11 08:28:07 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00