Commit Graph

50036 Commits

Author SHA1 Message Date
Guy Harris 9dd06cd401 Fix errors.
svn path=/trunk/; revision=53157
2013-11-08 01:23:18 +00:00
Guy Harris bf4e84aba6 For open dialogs, offer a list of sets of extensions, not of file types;
.cap, for example, doesn't refer to a particular file type - a whole
bunch of file types use .cap.

Also offer, in addition to "All Files", "All Capture Files", which
matches all the extensions we know about.

svn path=/trunk/; revision=53156
2013-11-08 01:08:42 +00:00
Jörg Mayer 28129427d4 As the code seems to be working now for two people
(both using Linux) it's time to be able to play with
the new HFI code.
Run cmake with -DHAVE_HFI_SECTION_INIT and you are good to go.

svn path=/trunk/; revision=53155
2013-11-08 00:23:32 +00:00
Jörg Mayer 9aa9d608cf With the new HFI code the compiler complains about unused element - great!
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-mint.c:205:26: error: ‘hfi_mint_control_0x0c_unknown4’ defined but not used [-Werror=unused-variable]
 static header_field_info hfi_mint_control_0x0c_unknown4 MINT_HF_INIT =
                          ^

svn path=/trunk/; revision=53154
2013-11-08 00:13:02 +00:00
Jörg Mayer 5ba977e34b The release notes update caused a new NEWS file to be built. Commit it.
Question: Should we remove the generated NEWS file from the repo?

svn path=/trunk/; revision=53153
2013-11-08 00:03:51 +00:00
Jörg Mayer 7c2c2d89f5 Fix:
cd /home/jmayer/work/wireshark/svn/build/qt-gtk3/epan && /usr/bin/cc  -DG_DISABLE_DEPRc
In file included from /home/jmayer/work/wireshark/svn/trunk/epan/packet.h:29:0,
                 from /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dp:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dparityfec.c: In functio:
/home/jmayer/work/wireshark/svn/trunk/epan/proto.h:2128:2: error: ISO C90 forbids mixe]
  extern header_field_info __start__data_ ##proto[]; \
  ^
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dparityfec.c:331:4: note’
    proto_register_fields(proto_2dparityfec, hfi, array_length(hfi));
    ^
cc1: all warnings being treated as errors


svn path=/trunk/; revision=53152
2013-11-08 00:01:19 +00:00
Gerald Combs 06fdf8130d Fix the AsciiDoc description.
svn path=/trunk/; revision=53151
2013-11-07 23:43:35 +00:00
Jakub Zawadzki 1dffd1a949 GCC on amd64 align header_field_info variables to 16-bytes, this cause problems with proto_register_fields_section().
sizeof(void *) alignment should be enough, use it in HFI_INIT.

This fixes http://www.wireshark.org/lists/wireshark-dev/201311/msg00069.html

svn path=/trunk/; revision=53150
2013-11-07 23:20:06 +00:00
Jörg Mayer fa3332e8ed Remove extraction of cmake parameters from autotools files.
While it was an interesting exercise it just doesn't
work good enough to stay, i.e. it doesn't automatically
pick up changes but requires rerunning cmake instead.

svn path=/trunk/; revision=53149
2013-11-07 21:40:31 +00:00
Pascal Quantin 696194999e From Vasil Velichkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9382 :
Fix dissection of GSM MAPv3 ReportSM_DeliveryStatusRes

svn path=/trunk/; revision=53148
2013-11-07 21:08:15 +00:00
Jörg Mayer a00f13bbc3 Turn WANT_PACKET_EDITOR into an option until such a time that
it isn't a compile time option any more.

svn path=/trunk/; revision=53147
2013-11-07 20:32:41 +00:00
Jakub Zawadzki ce6ca9a05d Add infrastructure for section-initializing protocol hfis (without array).
configure implementation later.

svn path=/trunk/; revision=53146
2013-11-07 20:14:18 +00:00
Gerald Combs 3f385b31ab Print LC_VERSION_MIN_MACOSX for each executable and library.
svn path=/trunk/; revision=53145
2013-11-07 17:55:46 +00:00
Evan Huus 5c319860fb Add a p_add_proto_data call to dissect_ndmp to match the one in
dissect_ndmp_heur.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9393

Potentially we should add a void *data to tcp_dissect_pdus instead...?

svn path=/trunk/; revision=53144
2013-11-07 17:06:04 +00:00
Evan Huus 6441f10c41 Add modelines. Minor indentation fixes.
svn path=/trunk/; revision=53143
2013-11-07 17:03:04 +00:00
Pascal Quantin 8f112c0390 Fix dissection of MBIM data packets when using 32-bits NDPs
svn path=/trunk/; revision=53142
2013-11-07 16:53:59 +00:00
Michael Mann eac2762d46 8-bit counter variable not big enough and causes infinite loop. Bug 9392 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9392).
svn path=/trunk/; revision=53141
2013-11-07 15:54:11 +00:00
Alexis La Goutte 50ddf471e8 Try 2 to fix Mac OS X 10.5 buildbot
Include old-gtk-compat.h

svn path=/trunk/; revision=53140
2013-11-07 10:41:53 +00:00
Pascal Quantin 9201e8ce14 3GPP2 SMS: add support for KSC5601 (Korean) character set
svn path=/trunk/; revision=53139
2013-11-07 10:27:11 +00:00
Alexis La Goutte 9fd106a5e2 (re)Fix warning found by fix-encodings-arg tool
svn path=/trunk/; revision=53138
2013-11-07 09:53:56 +00:00
Alexis La Goutte 1f8282d282 Try to fix Mac OS 10.5 Buildbot (with old Glib...)
gtk_dialog_get_action_area is available only Glib 2.14

svn path=/trunk/; revision=53137
2013-11-07 09:33:39 +00:00
Alexis La Goutte c8dc57aaad Remove C++ comments
svn path=/trunk/; revision=53136
2013-11-07 09:03:46 +00:00
Alexis La Goutte 5af14eaf16 Add Edit Packet in Right Click
svn path=/trunk/; revision=53135
2013-11-07 07:43:19 +00:00
Alexis La Goutte 49485528d8 Add Packet Editor Preference
svn path=/trunk/; revision=53134
2013-11-07 07:43:11 +00:00
Alexis La Goutte 6261789695 Add WANT_PACKET_EDITOR to CMake
svn path=/trunk/; revision=53133
2013-11-07 07:43:01 +00:00
Alexis La Goutte 4bff9d32a0 Enable Packet Editor by default
svn path=/trunk/; revision=53132
2013-11-07 07:42:35 +00:00
Michael Mann 21ddc7ae4e Revert r53118 as it breaks reassemble_test.
svn path=/trunk/; revision=53130
2013-11-07 04:50:53 +00:00
Michael Mann b9e36145f4 Got burned by forgetting to compile first...
svn path=/trunk/; revision=53129
2013-11-07 03:13:53 +00:00
Michael Mann 4fb9091422 Have the gsm_rlcmac_ul and gsm_rlcmac_dl use the data parameter of the dissector function instead of pinfo->private_data to receive a RlcMacPrivateData_t structure.
This work was done in bug 7615 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615), but the tie in to use the RlcMacPrivateData_t structure (passed by the GSMTAP dissector) was never completed.  Whenever that picks up again, the data parameter of the dissector should be used instead of pinfo->private_data.

svn path=/trunk/; revision=53128
2013-11-07 02:47:22 +00:00
Guy Harris f380299687 Note that bug 8808 and bug 9390 are fixed.
svn path=/trunk/; revision=53125
2013-11-07 02:11:51 +00:00
Jörg Mayer 29fef43b40 With the updated pidl it is now possible to generate several
of the dcerpc dissectors again. Commit those of the generated
onces that actually compile.

svn path=/trunk/; revision=53122
2013-11-06 22:55:17 +00:00
Jörg Mayer f7f47af562 Reapply the removal or the use of private_data that got removed by
syncing from samba.org.
If any other patches were applied, then I missed them and they are
lost unless reapplied.

svn path=/trunk/; revision=53121
2013-11-06 22:50:28 +00:00
Jörg Mayer 02fe7ff23a Copy over the current WIP from samba.org::ftp/unpacked/samba_4_0_test/pidl
- As the pidl in Wireshark doesn't work anyway we can just mirror the WIP
  so that patches to our code base are against the current code.

svn path=/trunk/; revision=53120
2013-11-06 22:48:50 +00:00
Michael Mann f9e5c14dde Add Zoltan Lajos Kis as author
svn path=/trunk/; revision=53119
2013-11-06 22:07:04 +00:00
Michael Mann c59fab0352 Correctly report segments marked with REASSEMBLE_FLAGS_NO_FRAG_NUMBER. Bug 9304 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9304)
Instead of incrementing the offset for each new segment by one we add the length of the segment so that each segment is correctly shown in the segment list.

It proves to be very useful to find which packet (segment) is causing an application dissector to go wrong.

From Matthieu Patou

svn path=/trunk/; revision=53118
2013-11-06 21:59:03 +00:00
Jakub Zawadzki c011e54567 Fix buildbot, typo:
tvbuff.c:1258: warning: passing argument 2 of '__builtin___memcpy_chk' makes pointer from integer without a cast
	tvbuff.c:1258: warning: passing argument 2 of '__inline_memcpy_chk' makes pointer from integer without a cast

svn path=/trunk/; revision=53117
2013-11-06 21:15:46 +00:00
Michael Mann 912b591200 NFC: PN532: Dissect InListPassiveTarget Response and Diagnose request and response. Bug 9333 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9333)
From Michal Labedzki

From me: adjust datatype to guint8 on a few local variables to quiet the Microsoft compiler.

svn path=/trunk/; revision=53116
2013-11-06 20:57:23 +00:00
Michael Mann 99e20da08e Add response time to the rtpproxy dissector. Bug 9380 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9380)
From Peter Lemenkov.

svn path=/trunk/; revision=53115
2013-11-06 20:39:10 +00:00
Guy Harris 2a088c1d53 Add support for displaying dates as year and day-of-year (1-origin).
In the process, fix various man page descriptions of the -t flag,
and add support for UTC absolute times in the iousers and iostat TShark
taps.

svn path=/trunk/; revision=53114
2013-11-06 20:39:09 +00:00
Jakub Zawadzki 67f69e99e8 tvb: optimize tvb_get_*guid()
we already have valid ptr from ensure_contiguous() so use it to fill structure.

svn path=/trunk/; revision=53113
2013-11-06 20:34:27 +00:00
Jakub Zawadzki b4be2fa489 tvbuff: use always ops->tvb_size
svn path=/trunk/; revision=53112
2013-11-06 20:22:28 +00:00
Jakub Zawadzki d54b3a74f6 tvbuff: cleanup, remove dead code.
ensure_contiguous() will throw exception but won't return NULL.

svn path=/trunk/; revision=53111
2013-11-06 19:03:14 +00:00
Michael Mann dc53bb7648 Bluetooth: OBEX: Storing info about previous protocol is not needed anymore. Bug 9303 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9303)
From Michal Labedzki.

svn path=/trunk/; revision=53110
2013-11-06 18:40:29 +00:00
Evan Huus 5efc340771 Mark more unused parameters.
svn path=/trunk/; revision=53109
2013-11-06 17:52:11 +00:00
Evan Huus 99d8439ce0 Add a license-ignore for tools/html2text.py
Update the preamble to COPYING to clarify that pidl isn't the only tool we carry
which isn't GPLv2-compatible.

svn path=/trunk/; revision=53108
2013-11-06 17:43:49 +00:00
Michael Mann 55922b6bac Fix for checking RTPS sub message length. Bug 9378 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9378)
From Steve Osselton

#BACKPORT(1.10)

svn path=/trunk/; revision=53107
2013-11-06 16:51:19 +00:00
Michael Mann c278a0ac0a SID28 is special kind of SID where no matter what it uses 28 bytes it's used in the DRS protocol. Bug 9337 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9337)
From Matthieu Patou

svn path=/trunk/; revision=53106
2013-11-06 16:30:14 +00:00
Bill Meier a4b4c92a45 Add _U_ to a function parameter to fix a compiler warning
svn path=/trunk/; revision=53105
2013-11-06 16:00:11 +00:00
Bill Meier 53fabc2f8a Add _U_ to a few function parameters to fix compiler warnings
Note: I hope the following is not indicative of something wrong with the code.
      (I've just marked di as _U_).

packet-dcerpc-netlogon.c: In function 'dissect_secchan_nl_auth_message':
packet-dcerpc-netlogon.c:7582:75: error: unused parameter 'di' [-Werror=unused-parameter]
                                            proto_tree *tree, dcerpc_info *di, guint8 *drep)


svn path=/trunk/; revision=53104
2013-11-06 15:54:24 +00:00
Bill Meier 0f61417ca4 Add _U_ to a function parameter to fix a compiler warning.
svn path=/trunk/; revision=53103
2013-11-06 15:46:36 +00:00