Commit Graph

64 Commits

Author SHA1 Message Date
Jörg Mayer af443c79c8 Add three more ICMPv6 type that only have a code of 0
svn path=/trunk/; revision=32120
2010-03-04 23:51:30 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Anders Broman 4d2e653901 From Didier Gautheron:
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Kovarththanan Rajaratnam cf8138e195 Remove check_col() guard
svn path=/trunk/; revision=30124
2009-09-24 19:50:43 +00:00
Kovarththanan Rajaratnam 90a5e748c2 Don't col_clear(COL_PROTOCOL) followed by col_set_str(COL_PROTOCOL). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)
svn path=/trunk/; revision=30090
2009-09-23 14:59:22 +00:00
Kovarththanan Rajaratnam 124faf721c Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
Bill Meier 75e727697f Remove unneeded #includes; Clean up indentation; Comment a few "closing braces".
svn path=/trunk/; revision=29538
2009-08-24 15:17:58 +00:00
Stig Bjørlykke ca5995f532 From Ivan Sy via bug 3931:
Added ND Proxy Flag for IPv6 RA flag.

svn path=/trunk/; revision=29533
2009-08-24 08:00:39 +00:00
Bill Meier c66f265dda Rework code slightly to prevent a GCC 'strict-aliasing' warning.
svn path=/trunk/; revision=29532
2009-08-23 23:52:40 +00:00
Jaap Keuter 1711f5899b From Ivan Sy:
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not 
just its equivalent.

Cleaned up presentation and included record number as well.

svn path=/trunk/; revision=29528
2009-08-23 17:18:29 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Balint Reczey 181f4c8364 Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
svn path=/trunk/; revision=29393
2009-08-12 12:55:27 +00:00
Balint Reczey 80fbe4959a From Ivan Sy (with minor modifications):
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.

svn path=/trunk/; revision=29387
2009-08-11 23:20:03 +00:00
Stig Bjørlykke 2002748969 Cleanup handling of ICMPv6 type and code (not complete):
- Use value_string to convert strings
- Added more types and codes from IANA

Removed use of check_col()
Some white space cleanup

svn path=/trunk/; revision=29054
2009-07-10 12:48:48 +00:00
Jaap Keuter 9ba3058f05 From Shinsuke SUZUKI:
Due to an incorrect offset setting in packet-icmpv6.c Wireshark cannot parse RA router-lifetime and RA flags properly.

svn path=/trunk/; revision=28818
2009-06-23 06:45:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 871c9c7152 ep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);
ep_strbuf_append() --> ep_strbuf_append_c() in a few cases.

svn path=/trunk/; revision=28052
2009-04-14 18:31:02 +00:00
Gerald Combs 7265c99e0c Get rid of a bunch of size_t's.
svn path=/trunk/; revision=27967
2009-04-05 23:42:26 +00:00
Guy Harris ee8ddd5123 Use an emem_strbuf_t in bitrange().
svn path=/trunk/; revision=27965
2009-04-05 18:20:20 +00:00
Stig Bjørlykke c11055cda9 Fixed some data types to remove some warnings in the solaris build.
svn path=/trunk/; revision=27825
2009-03-23 12:41:56 +00:00
Jaap Keuter b4278f490c From Evan Black:
SeND:
rfc 3971:
1) Certification Path Solicitation was not being dissected.
2) CGA Parameter was not dissected.

rfc 4581:
Adding support.

svn path=/trunk/; revision=26699
2008-11-05 10:59:20 +00:00
Stig Bjørlykke bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Stig Bjørlykke cb51efd25d From Roy Marples (bug 2781 and bug 2796):
Display FQDN binary encoded name as text
Ensure that get_dns_name does not cross packet sub boundry

From me:
Preserve the usage of bootp.fqdn.name as a display filter

svn path=/trunk/; revision=25981
2008-08-11 12:00:27 +00:00
Bill Meier 33af75a599 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25628
2008-06-28 21:09:57 +00:00
Guy Harris 83fc9d5e09 Constify a bunch of stuff, to squelch -Wwrite-strings warnings.
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.

Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).

Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().

Clean up some indentation.

svn path=/trunk/; revision=25601
2008-06-25 09:12:35 +00:00
Bill Meier 44af6ef887 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25290
2008-05-14 01:47:41 +00:00
Anders Broman 02353b11ce From bboissin:
fix RFC4191 handling
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2498

svn path=/trunk/; revision=25156
2008-04-23 20:42:02 +00:00
Anders Broman b0ab25b6ea add support for ND RDNSS (icmpv6)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2364 (re written)

svn path=/trunk/; revision=24672
2008-03-17 21:21:48 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Jeff Morriss d970b9f59d Initialize asn1_ctx before using it. Fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2317
svn path=/trunk/; revision=24523
2008-03-01 16:23:14 +00:00
Anders Broman c927060138 Dissect Name and Certificate and add some extensions pkix1explicit.
svn path=/trunk/; revision=24464
2008-02-25 22:17:24 +00:00
Anders Broman 32ae9c1d7f Dissect Type: 149 (Certification Path Advertisement).
svn path=/trunk/; revision=24456
2008-02-24 21:04:42 +00:00
Anders Broman b10481a009 Fix bug No support for Secure Neighbor Discovery ICMPv6 options.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2284

svn path=/trunk/; revision=24454
2008-02-24 17:14:47 +00:00
Anders Broman e6837f14d4 Correct a typo and at least print the name of type 148 and 149.
svn path=/trunk/; revision=24445
2008-02-23 19:57:09 +00:00
Anders Broman 48c58e1b63 Put names on some more options solves part of bug
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2284

svn path=/trunk/; revision=24444
2008-02-23 19:17:23 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Jeff Morriss 5bf0217530 As requested by Mike Rogovin: register the ICMP dissector by name. For completeness, also register ICMPv6 by name.
svn path=/trunk/; revision=22422
2007-07-30 17:21:40 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Jaap Keuter 37cd69bf41 From Nicolas Dichtel:
here is a patch that transforms "valid lifetime" and "prefered lifetime" in a prefix option (in RA)
in human readable format. Following the RFC2461 Section 4.6.2, if the value is 0xffffffff, this means lifetime
is infinity.

svn path=/trunk/; revision=19779
2006-11-02 16:47:13 +00:00
Martin Mathieson a6aa5da48f A little prettifying:
- Most Router Advertisement fields are now properly filterable
- Option tree has improved label, length set, fixed fields filterable

svn path=/trunk/; revision=19739
2006-10-30 15:36:40 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris 3ea3ee1fa2 Get rid of an unused function argument.
Clean up indentation.

svn path=/trunk/; revision=17762
2006-03-29 22:04:37 +00:00
Jörg Mayer 1900bf87fc done:
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value
packet-pim.c: whitespace change
packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error
packet-clnp.c: Fix incorrect use of g_snprintf return value
packet-isakmp.c: g_snprintf takes trailing \0 into account
packet-tr.c: Fix incorrect use of g_snprintf return value
packet-radius.c: Fix incorrect use of g_snprintf return value
packet-radius.h: constify a string variable
packet-ldap.c: The return value isn't needed, so don't use it incorrectly
packet-tcp.c: Fix incorrect use of g_snprintf return value
packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT
packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account
packet-pvfs2.c: g_snprintf takes trailing \0 into account
packet-ptp.c: Remove #include snprintf
packet-ppp.c: Fix incorrect use of g_snprintf return value
packet-ospf.c: Fix incorrect use of g_snprintf return value
packet-mip6.c: snprintf -> g_snprintf
packet-bootp.c: Remove a commented out bad use of g_snprintf
packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account

2do:

     52 packet-ieee80211.c: 2DO
      2 packet-nfs.c: 2DO - too many side effects
     33 packet-bgp.c: 2DO
     18 packet-dns.c: 2DO
     14 packet-dcm.c: 2DO
     13 packet-x11.c: 2DO
     11 packet-kerberos.c: 2DO
     10 packet-diameter.c: 2DO
      9 packet-snmp.c: 2DO
      9 packet-pgm.c: 2DO
      7 packet-nbns.c: 2DO
      6 packet-fcswils.c: 2DO
      5 packet-wccp.c: 2DO
      5 packet-cops.c: 2DO
      4 packet-wtp.c: 2DO


svn path=/trunk/; revision=17038
2006-01-16 07:59:44 +00:00
Anders Broman 480e4e949a From Martin André
the attached patch implements a dissector for the Fast Handovers for Mobile IPv6 protocol (RFC4068). This patch was produced against version 0.10.13 and extends the following files:
- packet-icmpv6.c
- packet-ipv6.h
- packet-mip6.c
- packet-mip6.h

svn path=/trunk/; revision=16302
2005-10-25 06:00:53 +00:00
Ronnie Sahlberg bc655dfba3 improve get_dns_name now that we have cheap emem allocated buffers
and get rid of a few strcpy()
a whole lot of arrays from the stack
and make the function prototype slightly nicer.



svn path=/trunk/; revision=16166
2005-10-08 12:31:06 +00:00
Guy Harris 973920e91d Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses to
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()".

Fix a call in the BGP dissector to properly fetch an IEEE floating-point
number.

Update some I-D info.

svn path=/trunk/; revision=15774
2005-09-13 00:50:43 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Guy Harris 374c3d0b75 Export "bytestring_to_str()", and use it when adding the link-layer
address for the ND_OPT_TARGET_LINKADDR ICMPv6 packet type.

svn path=/trunk/; revision=15591
2005-08-28 06:44:06 +00:00