Commit Graph

113 Commits

Author SHA1 Message Date
Anders Broman 95e14efafd From Alexis La Goutte:
Patch to fix a typo error....

svn path=/trunk/; revision=35816
2011-02-04 11:52:50 +00:00
Stig Bjørlykke 84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly.
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Jeff Morriss 6cfdeed280 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

svn path=/trunk/; revision=35529
2011-01-14 03:44:58 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman 250373865e from Alexis La Goutte:
Cleanup and update ISAKMP Dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5360

svn path=/trunk/; revision=34754
2010-11-02 16:58:43 +00:00
Bill Meier 0b9a803e45 #include <string.h> apparently req'd on OSX ...
svn path=/trunk/; revision=34465
2010-10-10 23:48:16 +00:00
Bill Meier 93b94a23ca Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
Bill Meier 3b48b69866 Use extended ipproto value_string (ipproto_val_ext).
svn path=/trunk/; revision=34214
2010-09-23 17:55:11 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Jeff Morriss ed75cdd99c Make a variable a guint8* instead of a char* since it a) holds TVB data and b) matches what tvb_new_child_real_data() wants for its 2nd argument. This cleans up a warning from the Sun compiler.
svn path=/trunk/; revision=32599
2010-04-29 15:23:10 +00:00
Jeff Morriss d70a710c79 Dissectors aren't allowed to call g_assert()
svn path=/trunk/; revision=32550
2010-04-24 14:13:37 +00:00
Jaap Keuter 3d077f2cdd From Alexis La Goutte:
Enhancements ISAKMP Vendor ID.

svn path=/trunk/; revision=32547
2010-04-23 21:58:05 +00:00
Jaap Keuter deef2df47d From Alexis La Goutte:
Add IKE Notify Message from RFC5685: Redirect Mechanism for IKEv2
Add IKE Notify Message from RFC5723: Session Resumption for IKEv2
Add IKE Notify Message from Cisco Unity

svn path=/trunk/; revision=32290
2010-03-25 22:41:46 +00:00
Jaap Keuter b899efbaf4 From Alexis La Goutte:
Add IKEv2 Config Attributes from Experimental RFC5739:
IPv6 Configuration in IKEv2
Updates missing IKEv2 Config Attributes from RFC4306 (SUPPORTED_ATTRIBUTES and INTERNAL_IP6_SUBNET)

svn path=/trunk/; revision=32288
2010-03-25 22:29:17 +00:00
Guy Harris b9d9dd8ec1 Mark unused arguments.
Clean up white space.

svn path=/trunk/; revision=32149
2010-03-09 01:34:55 +00:00
Anders Broman 2864c2a643 From Alexis La Goutte:
Enchancement ISAKMP dissector (IKEv1 / IKEv2).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4546

svn path=/trunk/; revision=32148
2010-03-08 21:22:07 +00:00
Stig Bjørlykke 2f8830b4d0 From LEGO via bug 3459:
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

svn path=/trunk/; revision=32112
2010-03-04 12:50:18 +00:00
Jaap Keuter 0c12762330 Add two missing headerfields which were missing in revision 32033.
svn path=/trunk/; revision=32037
2010-02-27 21:09:25 +00:00
Guy Harris 0811fba435 Squelch a compiler warning.
svn path=/trunk/; revision=32035
2010-02-27 19:15:36 +00:00
Jaap Keuter 9dd11bb90e From Alexis La Goutte:
Add support of notify msg type for RFC3706 Dead Peer Detection (DPD)
and dissect DPD Sequence.
Cleanup and enhancement for dissect CFG attributes.

svn path=/trunk/; revision=32033
2010-02-27 18:55:11 +00:00
Guy Harris f3b4098040 Constify.
Don't have variables that point to string constants, just make the
string constants be static const arrays.

strlen(array of unspecified size initialized with a string) ==
sizeof array - 1; the latter can be computed at compile time.

svn path=/trunk/; revision=32020
2010-02-27 00:51:14 +00:00
Bill Meier 0958c9f41b Do SVN #31896 in a (somewhat) better way.
svn path=/trunk/; revision=31897
2010-02-16 19:57:46 +00:00
Bill Meier ec023d7c92 Properly specify the IKE2 Decryption table default Encryption & Integrity Algorithms;
This ensures that the correct defaults are shown when creating a new entry 
in the IKEV2 Decryption Table.

svn path=/trunk/; revision=31896
2010-02-16 19:29:07 +00:00
Ronnie Sahlberg 7d52b73e5d these two guys are actually range-strings and not value-string
so it is surprising we didnt catche these before.


gcc complains about strict alignment on these



svn path=/trunk/; revision=31842
2010-02-09 07:42:38 +00:00
Anders Broman 96bcad4ea8 Initialize sub_cfg_attr_type_tree.
svn path=/trunk/; revision=31841
2010-02-09 06:52:49 +00:00
Anders Broman bceda505c0 From Alexis La Goutte:
ISAKMP Enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2905

svn path=/trunk/; revision=31840
2010-02-09 06:15:49 +00:00
Stig Bjørlykke 539b558f8c Renamed some reassembled data texts.
Removed some check_col().

svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier de4c6ff515 Fix a number of gcc _Wshadow warnings
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Gerald Combs 8fc1491a60 Switch to using a bundled version of the openSUSE Build Service packages
for GNUTLS since they provide 32-bit and 64-bit Windows packages. We no
longer have winposixtype.h, so remove its #includes and add a ssize_t
typedef to config.h.win32.

svn path=/trunk/; revision=31341
2009-12-21 21:06:01 +00:00
Stig Bjørlykke 056c915e61 Removed unused argument in v2_attrval2str().
svn path=/trunk/; revision=30606
2009-10-18 21:15:37 +00:00
Bill Meier 7a43e8853b Oops: #include <stdio.h> *is* required .....
svn path=/trunk/; revision=30575
2009-10-16 16:01:20 +00:00
Bill Meier 22c70b409a #include <stdio.h> not req'd; Fix some typos in text strings;
Adjust some indentation & spacing, reformat some long lines.

svn path=/trunk/; revision=30573
2009-10-16 14:37:40 +00:00
Bill Meier f59bf50023 Use GSlice instead of GMemChunks for GLib >= 2.10. Fixes a memory leak.
svn path=/trunk/; revision=30572
2009-10-16 14:22:00 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Michael Tüxen 191709f6af Get it compiling when HAVE_LIBGCRYPT is not defined.
svn path=/trunk/; revision=29315
2009-08-06 21:55:10 +00:00
Gerald Combs 85f68c7461 Fix compilation warnings in a few dissectors and try moving them to the
"clean" list.

svn path=/trunk/; revision=29313
2009-08-06 20:55:04 +00:00
Jaap Keuter d779b4f96f From Neil Piercy:
The Cert Authority hashes in the IKEv2 Cert Request are not dissected properly:
the display offset is not correctly moved on, so the same info is displayed for
all Cert Authority fields.

svn path=/trunk/; revision=29234
2009-07-29 18:26:55 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jörg Mayer c321f29518 Trivial warning fixes:
- Might be used uninitialized
- not a prototype
- comma at end of enum


svn path=/trunk/; revision=28730
2009-06-15 02:34:53 +00:00
Stig Bjørlykke 6cc936929a Ok, private_data is only saved if HAVE_LIBGCRYPT.
svn path=/trunk/; revision=28417
2009-05-19 20:00:05 +00:00
Stig Bjørlykke af7304aa79 Move pd variables outside HAVE_LIBGCRYPT.
svn path=/trunk/; revision=28414
2009-05-19 18:28:24 +00:00
Stig Bjørlykke fc3f1b5283 From Artem Tamazov (bug 3472):
Save/Restore pinfo->private_data when used.

svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Anders Broman 4ec2c4ff47 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28363
2009-05-14 19:28:07 +00:00
Jaap Keuter 900b052135 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28214
2009-05-01 07:12:46 +00:00
Jaap Keuter 55a1bf9af6 Fix build without HAVE_LIBGCRYPT.
svn path=/trunk/; revision=28097
2009-04-20 20:27:16 +00:00
Jaap Keuter 03f2402950 From Naoyoshi Ueda:
Currently wireshark has ability to decrypt ISAKMP IKEv1 packets, but not IKEv2
packets. With attached patch decryption of IKEv2 packets is now passible. 

svn path=/trunk/; revision=28089
2009-04-20 05:40:58 +00:00
Bill Meier 4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00