Commit Graph

1982 Commits

Author SHA1 Message Date
Luis Ontanon 3e98d671fd From Graeme Hewson:
don't try to call register_all_plugin_tap_listeners() if configured without plugins.

svn path=/trunk/; revision=13737
2005-03-12 21:36:24 +00:00
Ulf Lamping 801e9dd35e from Stefano Pettini: add CSV export function, similar to PSML export
svn path=/trunk/; revision=13724
2005-03-11 20:56:31 +00:00
Guy Harris c0f813c0a4 Flag an unused argument as unused, to squelch compiler warnings, and
don't flag a used argument as unused.

svn path=/trunk/; revision=13706
2005-03-11 01:15:35 +00:00
Jörg Mayer bce97ef171 Warning fix: voip_calls_dlg.c:733: implicit declaration of function rtp_event_init_tap
svn path=/trunk/; revision=13705
2005-03-10 21:47:35 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Jörg Mayer 8783c27b4b Warning fix: function declaration isn’t a prototype
svn path=/trunk/; revision=13693
2005-03-10 14:04:35 +00:00
Jörg Mayer 33145f026d Warning fix: ISO C forbids zero-size array ‘tsns
svn path=/trunk/; revision=13692
2005-03-10 12:49:05 +00:00
Jörg Mayer 9804663036 Trivial warning fixes
svn path=/trunk/; revision=13691
2005-03-10 12:43:35 +00:00
Ulf Lamping 2f73c1d242 removed some MSVC compiler warnings, mostly I've casted "downsized function parameters"
svn path=/trunk/; revision=13684
2005-03-09 23:00:21 +00:00
Guy Harris ae622c416d From Francisco Alcoba: don't generate long filter expressions, fall back
to the old filter mechanism if the filter expression is too long.

svn path=/trunk/; revision=13675
2005-03-09 10:12:05 +00:00
Lars Roland 466603ba82 add a default size to stats_tree windows. so we do not have to resize them everytime.
svn path=/trunk/; revision=13655
2005-03-07 21:11:34 +00:00
Luis Ontanon 27915a0f80 From Alejandro Vaqero:
- Fix a problem when pressing a key when  the "Graph" is  displayed
without any frame selected.

   - Add support for RTP Payload changes. Now the graph will show any
change in the RTP payload type. This is useful for example to show DTMF
2833 in a call.

-This line, and those below, will be ignored--

M    gtk/graph_analysis.c
M    gtk/voip_calls.c
M    gtk/voip_calls.h

svn path=/trunk/; revision=13651
2005-03-07 19:10:21 +00:00
Luis Ontanon e968b0c066 From Francisco Alcoba:
- Correct the order of the calls in the VoIP Calls dialog when ordering by time fields
 - Prevent an assertion when ordering on the last columns


svn path=/trunk/; revision=13649
2005-03-07 11:01:16 +00:00
Jörg Mayer 58d8f2f652 - pcap.h needs to be included before capture.h
- As capture.h is empty without libpcap defined, only include it in that
  case and don't protect the file internally against libpcap any more.

svn path=/trunk/; revision=13648
2005-03-07 10:19:33 +00:00
Guy Harris 802859d3fd Call the "new-style init" routine for plugins a "register" routine, as
it serves the same purpose as the register routine in a built-in
dissector, and don't require all dissectors to have one, as they might
just be taps.

Get rid of the stats tree's init routine, as it's just a tap, and as it
doesn't do anything.

Update the idl2eth Python script to generate plugins with register routines.

svn path=/trunk/; revision=13644
2005-03-07 02:44:41 +00:00
Jörg Mayer a0506eb598 Undo the last "fix" (13626): Unconditionally including <pcap.h> is
going to cause trouble for compilations without libpcap.

svn path=/trunk/; revision=13628
2005-03-06 10:26:00 +00:00
Jörg Mayer bef62eee0d Warning fix:
menu.c:1841:1: warning: C++ style comments are not allowed in ISO C90
menu.c:1841:1: warning: (this will be reported only once per input file)
(just removed it)

svn path=/trunk/; revision=13627
2005-03-06 10:03:53 +00:00
Jörg Mayer af9b899e73 Warning fix:
../capture.h:115: warning: struct pcap_stat declared inside parameter list
../capture.h:115: warning: its scope is only this definition or declaration,
        which is probably not what you want
../capture.h:125: warning: struct pcap_stat declared inside parameter list


svn path=/trunk/; revision=13626
2005-03-06 10:02:39 +00:00
Guy Harris 55eaf4bbae Get rid of a redundant test.
svn path=/trunk/; revision=13604
2005-03-05 23:44:23 +00:00
Guy Harris 8cffb1cad3 From Laurent Rabret: handle the case where there's no file name (i.e.,
an unsaved live capture), and avoid dividing by zero.

svn path=/trunk/; revision=13601
2005-03-05 20:52:03 +00:00
Gerald Combs eb372831dd When analyzing RTP streams, use the source address as well as the SSRC
to determine forward and reverse directions.  This fixes a capture I
have which has the same SSRC in the forward and reverse streams.

svn path=/trunk/; revision=13599
2005-03-05 17:57:27 +00:00
Ronnie Sahlberg 91a8ef6b5f from didier: bug fix for the menu,
if ethereal could not open the file   make us still be able to use the Open menu item to open a different file



svn path=/trunk/; revision=13589
2005-03-04 22:25:02 +00:00
Luis Ontanon 2e28b1b828 From Alejandro Vaquero:
Avoid adding to a call non ISUP mtp3 packets towards the same destination as a copy of the last ISUP packet towards that dpc.

svn path=/trunk/; revision=13576
2005-03-02 23:25:41 +00:00
Luis Ontanon 93b30edbb5 This is the rest of the patch from Francisco Alcoba.
I forgot to check in changes to these files yesterday


svn path=/trunk/; revision=13575
2005-03-02 23:22:11 +00:00
Luis Ontanon 28e58deeb1 Frrom Francisco Alcoba
- Name resolution support for the RTP Stream Analysis functionality
- fix a crash when trying to analyze with no stream selected.


svn path=/trunk/; revision=13572
2005-03-02 01:24:18 +00:00
Luis Ontanon f7d5537137 From Alejandro Vaquero:
patch to the voip calls facility to:

- Add a horizontal scrollbar in the "Graph" to scroll the "comments"
- Fix a "state" bug in H323 and SIP calls
- Fix a bug that can make the "graph" to crash, and also clean up the "address" when the window is close



svn path=/trunk/; revision=13565
2005-03-01 16:19:46 +00:00
Luis Ontanon 6e0186da12 - do not free the string passed to register_ethereal_tap()
it caused the taps to have "funny" names.

- rename the window as "$name Stats Tree"


svn path=/trunk/; revision=13546
2005-02-28 01:20:52 +00:00
Luis Ontanon 5319cabe88 Make sure that plugin tap listeners get registered before the non-plugin tap listeners
that's because stat trees are registered as tap listeners by either
gtk/stats_tree_stat.c or tap-stats_tree.c


svn path=/trunk/; revision=13545
2005-02-28 00:55:49 +00:00
Guy Harris dd4b0b718b The stats tree stuff should ultimately allow us to have plugin taps, so
add infrastructure for them, and display the plugin type (which could be
both dissector *and* tap) in the list of plugins.

svn path=/trunk/; revision=13543
2005-02-27 22:04:48 +00:00
Guy Harris 343810d95a Move "get_natural_int()" and "get_positive_int()" from "capture_opts.c"
to "clopts_common.c", make them not static, and use them in "gtk/main.c".

svn path=/trunk/; revision=13541
2005-02-27 21:15:30 +00:00
Luis Ontanon c81ca733db the last commit broke windows compilation.
minor changes in typing variables
 exclude a GTK2 call from being called while using GTK1


svn path=/trunk/; revision=13539
2005-02-27 20:17:06 +00:00
Ulf Lamping e7fafa28c6 some clarification of the capture child thing
svn path=/trunk/; revision=13535
2005-02-27 17:30:33 +00:00
Luis Ontanon 93c46dde91 Several fixes to the stats_tree
- Avoid creating a copy of every branch at reinitialization
       this used to cause some GTK warnings and a leakage of tree nodes

- propperly check the optarg to avoid getting junk in the filter text
       this caused a crash


svn path=/trunk/; revision=13534
2005-02-27 16:55:24 +00:00
Luis Ontanon 624d86fe0d abort early in main_filter_packets() if dftext is NULL
svn path=/trunk/; revision=13532
2005-02-27 14:01:12 +00:00
Luis Ontanon a33f8ebbad few fixes to The SCTP associations dialog
- do not call main_filter_packets() with a null dfilter string
- fix two leaks


svn path=/trunk/; revision=13531
2005-02-27 13:57:45 +00:00
Luis Ontanon b8ba4f9180 From Martin Mathielson
- from the "Capture Options" dialog, if you select the Capture Filter(s)
file browser, Cancel doesn't work.


svn path=/trunk/; revision=13530
2005-02-27 13:00:22 +00:00
Luis Ontanon 6180287d82 From Martin Mathielson
- from the "RTP streams" dialog, pressing 'Analyze' with no stream selected
would throw up an 'invalid filter' error.  This patch avoids anything if no
steam(s) are selected.



svn path=/trunk/; revision=13529
2005-02-27 12:45:07 +00:00
Luis Ontanon 8802528974 - undo disabling the GTK2 version
- do not declare a variable after the first statement or else windows compilation fails


svn path=/trunk/; revision=13522
2005-02-25 22:57:43 +00:00
Luis Ontanon d971fa0062 Temporarily disable the gtk2 version that causes a compilation error on windows.
svn path=/trunk/; revision=13521
2005-02-25 22:30:58 +00:00
Ronnie Sahlberg 4a338216da pinfo->private_data was a quite subptimal idea
change the decodeas for dcerpc so that it actually works again for dcerpc over smb



svn path=/trunk/; revision=13515
2005-02-25 10:30:21 +00:00
Luis Ontanon 51913513e2 Get stats_tree compiled
svn path=/trunk/; revision=13507
2005-02-25 04:02:00 +00:00
Luis Ontanon ca67abe524 some more work for
- beautify the text output
- make gtk1 textbox implementation usable (I hope)


svn path=/trunk/; revision=13506
2005-02-25 03:56:12 +00:00
Luis Ontanon 00435bf390 Update to the stats_tree tapping API
- change the tap init_string to %s,tree instead of %s,stat
- change the registration key (it used to be tapname, that disallowed to register more than one tap per protocol)
- add a "pivot" node for convenience


svn path=/trunk/; revision=13502
2005-02-24 22:02:31 +00:00
Lars Roland 2ed9ca813b By Francisco Alcoba:
Support for name resolution and IPv6 in VoIP Call Analysis

svn path=/trunk/; revision=13501
2005-02-24 21:31:20 +00:00
Guy Harris ad4374e213 Mallocate the strings to be put into the columns, rather than filling in
fixed-length buffers.

svn path=/trunk/; revision=13492
2005-02-24 05:42:03 +00:00
Guy Harris b94c5514fe Don't include "../image/eicon3d64.xpm", as we're not using it for now.
svn path=/trunk/; revision=13491
2005-02-24 05:40:55 +00:00
Luis Ontanon 516d559fe8 From Alejandro Vaquero
voip_calls_dlg.c
    Change the "prepare filter" function to be protocol independent. Now it uses the
    "frame_num"s  from the Graph structure to create the filter. This also add support
    to MGCP and H323 LRQ/LCF filters that were not supported before.

graph_analysis.c:
    Change the mouse scroll wheel implementation to make a 3 line step change instead of 1 line.


svn path=/trunk/; revision=13489
2005-02-24 04:15:40 +00:00
Ronnie Sahlberg 76d9049746 g_strrstr does not exist in gtk 1
replace it with strstr


svn path=/trunk/; revision=13477
2005-02-23 08:37:30 +00:00
Ulf Lamping 72547c8d02 use the applications name (currently "ethereal" or "tethereal") in capture_opts, instead of hardcoded "ethereal" for both.
svn path=/trunk/; revision=13476
2005-02-23 08:34:12 +00:00
Ulf Lamping d643a55488 move capture_opts related things (init, command line, ...) from capture.c to a new file capture_opts.c and let both ethereal and tethereal use it.
svn path=/trunk/; revision=13474
2005-02-23 01:01:19 +00:00