c50b988807
From Shekhar Chandra: support for version 3.0 of netscaler packet wire format.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9280
From me: fix indentation(tabs->spaces) and trailing whitespace.
svn path=/trunk/; revision=52665
2013-10-18 03:36:04 +00:00
42c52d8612
Add more filterable fields around EDNS(0)
...
svn path=/trunk/; revision=52664
2013-10-18 01:53:32 +00:00
98f3bb5f15
Sign all of the executables.
...
svn path=/trunk/; revision=52663
2013-10-17 22:34:38 +00:00
e746a62459
Bugfix an apparent typo in edns0 "Higher bits in extended RCODE". Bug 9199 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9199 ).
...
#BACKPORT(1.10)
svn path=/trunk/; revision=52662
2013-10-17 20:54:42 +00:00
e7202d159a
If static analysis is enabled disable error checking when compiling the
...
Qt code. This should hopefully work around a builder issue.
svn path=/trunk/; revision=52661
2013-10-17 17:50:00 +00:00
cbe8af0a8b
Revert the optimization in r52578. As Jakub predicted, it caused at least one
...
infinite loop to pop up. We're just going to have to eat the performance hit.
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9282 )
svn path=/trunk/; revision=52660
2013-10-17 12:24:25 +00:00
744f47107e
H.225.0: fix handling of compound parameters in Generic Extensible Framework (H.460.22 did not work well)
...
svn path=/trunk/; revision=52659
2013-10-17 11:24:43 +00:00
934bfff003
Temporarily revert r52651 it caused a regression when trying to tvb_memcpy from
...
a negative offset (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9277 )
svn path=/trunk/; revision=52658
2013-10-17 02:43:21 +00:00
747f1409a1
Properly decode CAPWAP Data Keep-Alive's. Bug 9165 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9165 )
...
From Andreas Schultz
From me: Use expert API instead of throwing exception for a bad length.
svn path=/trunk/; revision=52657
2013-10-17 02:13:23 +00:00
9e494dbe18
Be able to search through HTTP request and HTTP response lines. Bug 9134 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9134 )
...
From Edwin Groothuis
svn path=/trunk/; revision=52656
2013-10-17 01:23:12 +00:00
5344c7fef2
If the length we allocated was 0, don't try and write to the returned pointer.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9276
svn path=/trunk/; revision=52655
2013-10-16 22:52:40 +00:00
f6884b5945
Add checks to see if CC and/or CXX are Clang. Add "-Qunused-arguments"
...
to CFLAGS and/or CXXFLAGS as needed.
svn path=/trunk/; revision=52654
2013-10-16 22:39:44 +00:00
80b5c92af0
Remove trailing blanks; Fix some indentation;
...
Add editor modelines.
svn path=/trunk/; revision=52653
2013-10-16 20:35:08 +00:00
94ba4e9875
Fix inconsistent indentation & formatting, trailing blanks.
...
Add some parens.
Add editor modelines.
svn path=/trunk/; revision=52652
2013-10-16 20:32:57 +00:00
4223c93c37
Create an internal _tvb_memcpy() without the sanity checks to be caled from tvb internal routines with sanity checks to avoid duplicated checks.
...
svn path=/trunk/; revision=52651
2013-10-16 20:05:59 +00:00
26ad68d45b
Prepend to lists rather than append as that's more efficient.
...
svn path=/trunk/; revision=52650
2013-10-16 20:02:14 +00:00
fe55299806
Don't bother checking for clang, just add -Qunused-arguments to the
...
compiler flags checks.
svn path=/trunk/; revision=52649
2013-10-16 18:40:13 +00:00
09066e4eba
In packet-wsp.c, don't use the get_long_integer macro where we only need the
...
very smallest part of its logic. Just call tvb_get_guint8 directly and check
that the return is between 1 and 4. Properly fixes the set-but-unused and
associated warnings that were showing up.
svn path=/trunk/; revision=52648
2013-10-16 18:08:24 +00:00
7c2219f301
1.11.0 -> 1.11.1
...
svn path=/trunk/; revision=52647
2013-10-16 17:32:45 +00:00
5fba0c2474
If we're using Clang add -Qunused-arguments in order to avoid a bunch
...
of warnings described at
http://petereisentraut.blogspot.com/2011/05/ccache-and-clang.html
svn path=/trunk/; revision=52646
2013-10-16 17:22:58 +00:00
1701f42969
Fix warnings found by Clang 5.0 (-Wself-assign and -Wparentheses-equality).
...
Move code from ipv6-utils.h to packet-ipv6.c since that was the only
place it was used. Comment out unused code.
svn path=/trunk/; revision=52645
2013-10-16 17:19:59 +00:00
4515b2b3aa
Fix a comment.
...
svn path=/trunk/; revision=52644
2013-10-16 17:05:29 +00:00
2aa86c5af7
Back out the previous commit. We'll have to find a different fix.
...
svn path=/trunk/; revision=52643
2013-10-16 16:44:56 +00:00
cdebec19c8
Work around a self-assingment error picked up by Clang 5.0.
...
svn path=/trunk/; revision=52642
2013-10-16 16:41:28 +00:00
9b40d29017
Fix (what appears to be) a minor bug when dissecting RTMP.
...
svn path=/trunk/; revision=52641
2013-10-16 14:17:05 +00:00
938206442c
Upgrade RRLP dissector to V11.0.0
...
svn path=/trunk/; revision=52640
2013-10-16 03:06:46 +00:00
55f3af2174
Fix various: whitespace, comments & etc.
...
Add editor modelines.
svn path=/trunk/; revision=52639
2013-10-16 02:39:09 +00:00
9ae071f406
Add blank line before 'and by'
...
svn path=/trunk/; revision=52638
2013-10-16 02:34:03 +00:00
d61a6dd316
Add Ed Beroset to the list of Wireshark authors.
...
svn path=/trunk/; revision=52637
2013-10-16 01:10:04 +00:00
f6e09faa2d
From Ed Beroset: add modelines and fix irregular indenting;
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9273
This patch adds modelines and cleans up the irregular indentation of
this dissector's code. The only other change was in
asn1/c1222/packet-c1222-template.c to consolidate an #ifdef that had a
redundant #endif (line 812) and subsequent reopening #ifdef (line
824). The only thing between them was comments, so the span of the
original #ifdef (line 644) was simply extended by eliminating those
two lines.
The purpose for this patch is to make the file easier to edit and
understand in advance of more substantive patches later. This patch
is intended to be easy to review by having only non-substantive
changes.
svn path=/trunk/; revision=52636
2013-10-16 00:57:28 +00:00
78d3fe6248
Update the list of new protocols supported
...
svn path=/trunk/; revision=52635
2013-10-16 00:35:02 +00:00
7b3dfaa525
As suggested separately by both Jakub and Anders: only read the
...
WIRESHARK_DEBUG_WMEM_OVERRIDE environment variable once in wmem_init, not every
time wmem_allocator_new is called. We currently create a new pinfo pool for
every packet we dissect, so this is a small performance win, especially when
getenv is slow (which may happen if a large number of environment variables are
set, such as when fuzz-testing).
svn path=/trunk/; revision=52634
2013-10-15 23:16:35 +00:00
c4dcd0ca24
If CODE_SIGN_IDENTITY is set use it to sign the app bundle and the
...
installer package. Add commented-out code to sign the .dmg as well in
case Apple supports that in the future.
svn path=/trunk/; revision=52633
2013-10-15 23:03:48 +00:00
fb9d4296be
Adjust parenthesis to make gcc happy.
...
svn path=/trunk/; revision=52632
2013-10-15 21:31:32 +00:00
6731cba63a
Don't try heuristic dissectors on second pass if no match was found in the first one.
...
svn path=/trunk/; revision=52631
2013-10-15 21:28:04 +00:00
49343d633c
Fix ABI check error for libwireshark
...
svn path=/trunk/; revision=52630
2013-10-15 20:14:47 +00:00
6fcea10d50
1.11.0 → 1.11.1.
...
svn path=/trunk/; revision=52629
2013-10-15 19:21:04 +00:00
b4f3f2ffd6
Try building 1.11.0.
...
svn path=/trunk/; revision=52628
2013-10-15 18:40:00 +00:00
63e4539229
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9272
...
Add tshark -G column-formats report and document the missing ftypes, heuristic-decodes and plugins reports.
From me: Sort the reports. Add modelines to epan/column.c. Minor whitespace changes.
svn path=/trunk/; revision=52627
2013-10-15 18:27:35 +00:00
b0080ae123
g_slist_prepend() should be faster than g_slist_append() use it where the order shouldn't matter.
...
svn path=/trunk/; revision=52626
2013-10-15 18:21:03 +00:00
6bb579ea87
Micro-optimize print_columns(): replace g_snprintf() & g_strlcat() with memcpy().
...
svn path=/trunk/; revision=52625
2013-10-15 18:20:59 +00:00
9c3be9d5ae
Try to optimize heuristics slightly.
...
svn path=/trunk/; revision=52624
2013-10-15 18:19:57 +00:00
4ae53bc208
Reorder all of the bitmask trees according to its endianess from highest to lowest order bit.
...
These consist of the following bitmask fields:
[packet-smb.c] 'Create Flags', 'Access Mask', 'File Attributes', 'Share Access', 'Create Options',
'Security Flags', 'Optional Support'(in TreeConnect AndX responses), and "Quota Flags"
[packet-smb2.c] 'Flags', 'Session Flags', 'Security mode', and 'Interface Capabilities'.
[packet-smb.c] Made the tfs_file_attribute_xxx true_false_string values less verbose and more compact.
[packet-smb2.c] Changed all references to "RMDA" to RDMA".
[packet_smb.c] In dissect_qfi_SMB_FILE_NETWORK_OPEN_INFO() (GetInfo response) changed "Unknown Field"
to "Reserved" (See capture 'DMtrace2.cap' frame 20023).
svn path=/trunk/; revision=52623
2013-10-15 16:41:29 +00:00
821e1a7c34
Add another cast.
...
svn path=/trunk/; revision=52622
2013-10-15 16:40:19 +00:00
c70baa2037
Add casts to fix some shortening errors.
...
svn path=/trunk/; revision=52621
2013-10-15 16:29:38 +00:00
720de303c7
Add some missing parenthesis. Make sure we set our font in the right place.
...
Make the ColorUtils::fromColorT() convenience function a little more
convenient. Use it.
svn path=/trunk/; revision=52620
2013-10-15 15:22:03 +00:00
156659e308
limit the values written to phdr.(cap)len to guint32, not to guint16
...
We read a two-byte length field and add a constant number of header
bytes to this length, so we could in theory be larger than guint16.
svn path=/trunk/; revision=52619
2013-10-15 15:15:59 +00:00
ef33b36768
code review of parse_s1_W_stats()
...
range check for array index
don't assign the result of pntohs() to a gint16
range check for the values stored in phdr.(cap)len
svn path=/trunk/; revision=52618
2013-10-15 15:11:40 +00:00
7d66e3806b
Don't do canaries in blocks of guint32, it appears to cause alignment issues
...
when running tests on Solaris. Revert back to byte-at-a-time, but do fewer bytes
to avoid a performance hit.
svn path=/trunk/; revision=52617
2013-10-15 13:15:38 +00:00
586dea0e04
Check the length *before* accessing the array, and cap the
...
length-retrieved-from-packet at the size of the array we have.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9270
svn path=/trunk/; revision=52616
2013-10-15 13:05:31 +00:00
Bill Meier