Martin Mathieson
76bc0e537b
Pass ueid + channel-info into PDCP dissector.
...
This will allow me soon to track per-channel sequence numbers...
svn path=/trunk/; revision=34793
2010-11-05 18:00:35 +00:00
Martin Mathieson
3c5b012771
Don't allocate context struct until/unless heuristic signature string matches.
...
svn path=/trunk/; revision=34752
2010-11-02 15:17:58 +00:00
Martin Mathieson
d086e935e1
Add longer desriptions of SOStart and SOEnd fields.
...
svn path=/trunk/; revision=34584
2010-10-20 12:08:22 +00:00
Martin Mathieson
52e5567b2e
Track and give link back to frame containing previous NACK.
...
svn path=/trunk/; revision=34528
2010-10-15 21:07:45 +00:00
Bill Meier
4ae8d25300
Minor code cleanup:
...
- define some vars & fcns as static;
- remove an unused var;
- use tfs_set_notset in tfs.c;
- slightly simplify reg_handoff.
svn path=/trunk/; revision=34462
2010-10-10 20:39:00 +00:00
Martin Mathieson
5d84e780d9
Fix sequence numbers reported when duplicate SN detected.
...
svn path=/trunk/; revision=34161
2010-09-20 17:01:22 +00:00
Martin Mathieson
055d654cc2
Add bandwidth figures to RLC stats (per-UE and per-channel).
...
svn path=/trunk/; revision=34059
2010-09-03 15:22:28 +00:00
Martin Mathieson
0319e1f71a
Allow DRB frames to be passed to PDCP (where they may be decoded as IP).
...
svn path=/trunk/; revision=33649
2010-07-28 16:58:13 +00:00
Martin Mathieson
5a2ca22658
Minor formatting change.
...
svn path=/trunk/; revision=33590
2010-07-20 13:27:20 +00:00
Martin Mathieson
db478debbd
Allocate tap structs rather than using one static struct.
...
svn path=/trunk/; revision=33503
2010-07-13 16:25:34 +00:00
Martin Mathieson
a8aeaf6986
Change a couple of format specifiers: %-nu looks better than %0nu here
...
svn path=/trunk/; revision=33353
2010-06-28 17:25:58 +00:00
Martin Mathieson
f95aed808a
Further improvements to UM sequence analysis.
...
svn path=/trunk/; revision=33346
2010-06-28 10:50:03 +00:00
Martin Mathieson
b040f1ac8c
Improve UM analysis - make it more like AM.
...
svn path=/trunk/; revision=33328
2010-06-25 23:04:16 +00:00
Martin Mathieson
97df849b98
Add new strings/dissector function for signalling RRC messages that will add
...
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.
TODO: same for other RRC entry points...
svn path=/trunk/; revision=33251
2010-06-18 07:07:55 +00:00
Martin Mathieson
bc020a6d63
Work out better whether RLC segment is a complete upper-layer PDU or not.
...
svn path=/trunk/; revision=33242
2010-06-17 06:36:23 +00:00
Martin Mathieson
4fcd48495f
Add the direction to so expert info texts.
...
svn path=/trunk/; revision=33207
2010-06-10 15:28:41 +00:00
Martin Mathieson
5ed2e2f914
Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
...
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Martin Mathieson
253e2541e9
Put offset++ back in again.
...
svn path=/trunk/; revision=32531
2010-04-21 10:12:03 +00:00
Martin Mathieson
08100dc039
From Pascal Quantin:
...
Don't report as an error if see non-zero padding bits.
svn path=/trunk/; revision=32524
2010-04-20 15:41:03 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Martin Mathieson
1ef05048a3
Use val_to_str_const() where have no format is default string
...
svn path=/trunk/; revision=32188
2010-03-14 16:36:41 +00:00
Martin Mathieson
27efebc70c
Last missing SN wasn't coming out correctly if it was 1023...
...
svn path=/trunk/; revision=32174
2010-03-12 03:50:47 +00:00
Martin Mathieson
13e5793106
Write context fields inside own subtree.
...
Use common functions to append text to info column and tree items.
svn path=/trunk/; revision=32150
2010-03-09 01:39:08 +00:00
Martin Mathieson
c5a2423a7a
Fix another crashing problem.
...
A status PDU can contain multiple entries for the same SN (for different partial ranges). So make sure that we don't copy the same SN twice into our list of repeated NACKs (otherwise each instance in the tap struct will get added multiple times and we'll end up writing beyond the array bound).
svn path=/trunk/; revision=32133
2010-03-07 10:03:05 +00:00
Martin Mathieson
e10b2fb11e
Add hidden roots for each mode (i.e. rlc-lte.tm, rlc-lte.um, rlc-lte.am).
...
svn path=/trunk/; revision=32128
2010-03-06 19:35:40 +00:00
Martin Mathieson
5e8b6b21b2
Report accurate NACK count in stats (although not all values stored in array in tap).
...
svn path=/trunk/; revision=32117
2010-03-04 20:58:54 +00:00
Martin Mathieson
d5fb076397
Check that we haven't gone over MAX_NACKs!
...
svn path=/trunk/; revision=32115
2010-03-04 17:49:51 +00:00
Bill Meier
f041bb3e19
Fix a gcc -Wshadow warning.
...
svn path=/trunk/; revision=32093
2010-03-03 15:47:28 +00:00
Martin Mathieson
c40143abbc
Fix re-NACk detection by updating channel *after* have compared with tap_info!
...
svn path=/trunk/; revision=32091
2010-03-03 15:34:44 +00:00
Martin Mathieson
bec769f815
Add 'repeated-NACK' analysis.
...
This is a common symptom of serious problems.
svn path=/trunk/; revision=32085
2010-03-02 18:40:34 +00:00
Martin Mathieson
15e32b3c73
Re-order file, and give some types/vars more specific names.
...
svn path=/trunk/; revision=32075
2010-03-01 23:56:35 +00:00
Martin Mathieson
862dd48d35
Improve RLC AM sequence analysis by taking MAC retx into account.
...
svn path=/trunk/; revision=32071
2010-03-01 22:52:34 +00:00
Martin Mathieson
58edf76433
Fix test for AM Rx window, and add a seqnum.analysis.ok field.
...
svn path=/trunk/; revision=32051
2010-02-28 20:43:04 +00:00
Martin Mathieson
9a1100ce5a
Add 'missing SDUs' to tap info / RLC stats window.
...
Also includes typo fixes from Pascal Quantin.
svn path=/trunk/; revision=32049
2010-02-28 18:42:41 +00:00
Martin Mathieson
76d5a1eb75
Add some AM sequence analysis.
...
svn path=/trunk/; revision=32044
2010-02-28 02:18:35 +00:00
Martin Mathieson
8126a8ab32
Add a preference that allows the LTE RLC dissector to accept RLC PDUs truncated after the header rather than report missing data.
...
svn path=/trunk/; revision=31750
2010-02-01 11:00:08 +00:00
Stig Bjørlykke
fa8d45f2a3
From Didier Gautheron via bug 4420:
...
Call p_add_proto_data only once.
svn path=/trunk/; revision=31664
2010-01-25 18:24:14 +00:00
Stig Bjørlykke
c198fc6546
From Didier Gautheron via bug 4419:
...
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.
svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Bill Meier
1a4283ccf8
Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
...
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Martin Mathieson
417b1839f1
Add initial version of LTE RLC stats dialog.
...
svn path=/trunk/; revision=31588
2010-01-20 12:37:26 +00:00
Martin Mathieson
26c0a94dea
Don't crash by calling null RRC dissector because TM appeared on 'impossible' channel type.
...
svn path=/trunk/; revision=31468
2010-01-08 16:07:14 +00:00
Martin Mathieson
bd55fda74c
From Pascal Quantin: some typo fixes
...
svn path=/trunk/; revision=31455
2010-01-06 17:07:37 +00:00
Martin Mathieson
7897e78d02
Added casts wanted by win64 compiler.
...
svn path=/trunk/; revision=31440
2010-01-04 15:24:33 +00:00
Martin Mathieson
b8596e6ad6
Start to supply data for an RLC tap.
...
svn path=/trunk/; revision=31439
2010-01-04 14:07:24 +00:00
Martin Mathieson
68546e930e
From Pascal Quantin. Add support a UDP framing format for LTE RLC.
...
svn path=/trunk/; revision=31185
2009-12-07 10:23:35 +00:00
Martin Mathieson
0015dc63be
Show whether NACK is full or partial in expert info.
...
svn path=/trunk/; revision=31170
2009-12-04 11:22:33 +00:00
Martin Mathieson
33d4186696
Set extent of AM header root properly when there are extensions.
...
Give more descriptive expert text when we there is no data for non-extension segment.
svn path=/trunk/; revision=31079
2009-11-25 23:17:23 +00:00
Martin Mathieson
51e240596d
Dissect SRB2 as PDCP signalling too.
...
svn path=/trunk/; revision=31021
2009-11-19 18:23:53 +00:00
Martin Mathieson
fa8e0f479f
Trivial: comment update
...
svn path=/trunk/; revision=31004
2009-11-18 13:47:38 +00:00
Martin Mathieson
7af44b2991
Resuse struct for PDCP info when redissecting.
...
svn path=/trunk/; revision=30992
2009-11-17 17:30:40 +00:00