Adding LLS type Local Interface ID as defined in RFC8510
Ping-Bug: 15459
Change-Id: Ib9d99f56caf22e71b95aabb9e4f6ac16c15ae1c4
Reviewed-on: https://code.wireshark.org/review/32386
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The NL80211_ATTR_HT_CAPABILITY and NL80211_ATTR_VHT_CAPABILITY
attributes does not contain the full information element tlv
making the dissector fail to parse the attribute values.
Add a tag dissector function that dissects a numbered tag using
the 802.11 tag dissector table and use it to dissect HT/VHT
capability attributes properly.
The HE capabily tag is among the extended tags so must be handled
in some other way. For now leave the attribute undissected.
Change-Id: Ie85918634bafc2b39000a34b01e7a7dbaf6bd80d
Reviewed-on: https://code.wireshark.org/review/32365
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The NL80211_ATTR_FRAME attribute value contains a full 802.11
frame with header. Let the 802.11 dissector dissect this.
Change-Id: I2e97644d142b510deaf75a1c922dcac4a12e0a27
Reviewed-on: https://code.wireshark.org/review/32364
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Quite many nl80211 attributes are declared u64 so let the
generic attibute parser treat data of 8 bytes length as 64 bit
values.
Change-Id: I511fe8467fe950e019457a1552de280528272b70
Reviewed-on: https://code.wireshark.org/review/32362
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Warning:
** (process:13685): WARNING **: 23:48:34.135: Extended value string 'pixel_format_names' forced to fall back to linear search:
entry 114, value 35520758 [0x21e00f6] < previous entry, value 36700405 [0x23000f5]
This is causing test failures due to clopts testsuite getting
unexpected data in stderr.
Change-Id: I6fcc7315f0b99530da4f6dceda60e2da803972f5
Reviewed-on: https://code.wireshark.org/review/32367
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Use format_text() on strings when used in the TLV header.
Bug: 15572
Change-Id: Ia9dc585deff3d21782e552a018c80e63c700c73d
Reviewed-on: https://code.wireshark.org/review/32355
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
and a couple of pixel formats that where not properly decoded before
Change-Id: I43008e6f498f9f67dcd103486fb32c8885034ddf
Reviewed-on: https://code.wireshark.org/review/32086
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Fixed re-assembly of two PDU in single frame (was optimized out in last commit)
- Improved COL_INFO for C-FIND
- Improved COL_INFO for multiple PDUs in one frame
Change-Id: Ie4ba5023594f3ce65f55584631731ee9f9d0506b
Reviewed-on: https://code.wireshark.org/review/32087
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Generic fixes
- subfields with small number of bits that belong to large
bit fields are not being decoded correctly (they all become zero).
Generic update
- removed ett_[X] entries that were never being used
asterix bugfixes
- asterix.SAC bitmask not aligned
- asterix.SIC bitmask not aligned
I019 bugfixes
- I019/552 bitmask not aligned
I020 bugfixes
- I020/042 incorrect filter
- I020/170 too many spare bits
- I020/170 incorrect filter
- I020/230 incorrect filter
- I020/500#01.DOPy incorrect filter
- I020/500#03 incorrect filter
- I020/RE sub field names not in line with other CATs
- I020/RE.GVV.TA is signed (should be unsigned)
- I020/RE.GVA.TASD is signed (should be unsigned)
- I020/RE.PA#02 incorrect filter
- I020/RE.DA#04 incorrect filter
I021 bugfixes
- I021/110#01 is not a FIXED size field (it is an FX field)
- I021/260 bitmask not aligned
- I021/RE.MES#02 bitmask not aligned
- I021/RE.MES#03 bitmask not aligned
- I021/RE.MES#06 bitmask not aligned
I034 bugfixes
- I034/050 subfield indexes are missing
- I034/050#04 bitmask not aligned
- I034/060 subfield indexes are missing
I048 bugfixes
- I048/050 bitmask not aligned
- I048/060 bitmask not aligned
- I048/070 bitmask not aligned
- I048/080 bitmask not aligned
- I048/100 bitmask not aligned
- I048/120 bitmask not aligned
- I048/230 bitmask not aligned
- I048/RE.MD5 subfield indexes are followed by a comma
- I048/RE.MD5#02 bitmask not aligned
- I048/RE.MD5#05 bitmask not aligned
- I048/RE.M5N subfield indexes are followed by a comma
- I048/RE.M5N#02 bitmask not aligned
- I048/RE.M5N#05 bitmask not aligned
- I048/RE.RPC subfield indexes are followed by a comma
I062 bugfixes
- I062/060 bitmask not aligned
- I062/080.DUPF incorrect filter
- I062/110#02 bitmask not aligned
- I062/340#05 bitmask not aligned
- I062/380#10 bitmask not aligned
- I062/380#11 bitmask not aligned
- I062/390#03 bitmask not aligned
- I062/390#09.RWY is now a string instead of 3 different fields
- I062/390#12 bitmask not aligned
- I062/390#17 bitmask not aligned
- I062/510 bitmask not aligned
- I062/RE.CST bitmask not aligned
Change-Id: Ieefb53a10728205f2cefac718ac8668df29f1f8a
Reviewed-on: https://code.wireshark.org/review/32300
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add a new subtree with Header fields Version, Reserved and Length.
Include padding length in the TLV entry.
Change-Id: I7c39253f4d2f5f3b2d5721d10af3f8b563ea0d04
Reviewed-on: https://code.wireshark.org/review/32346
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
In uclibc, _header is already in sigcontext.h:
packet-gtp.c:2361:16: error: redefinition of 'struct _header'
typedef struct _header {
^~~~~~~
In file included from /home/dawncrow/buildroot-test/scripts/instance-0/output/host/i686-buildroot-linux-uclibc/sysroot/usr/include/bits/sigcontext.h:30:0,
from /home/dawncrow/buildroot-test/scripts/instance-0/output/host/i686-buildroot-linux-uclibc/sysroot/usr/include/signal.h:311,
from /home/dawncrow/buildroot-test/scripts/instance-0/output/host/i686-buildroot-linux-uclibc/sysroot/usr/include/glib-2.0/glib/gbacktrace.h:36,
from /home/dawncrow/buildroot-test/scripts/instance-0/output/host/i686-buildroot-linux-uclibc/sysroot/usr/include/glib-2.0/glib.h:34,
from ../../epan/proto.h:28,
from ../../epan/packet.h:14,
from packet-gtp.c:43:
/home/dawncrow/buildroot-test/scripts/instance-0/output/host/i686-buildroot-linux-uclibc/sysroot/usr/include/asm/sigcontext.h:173:8: note: originally defined here
struct _header {
To fix this issue, transform _header and other named structures (with
the exception of gtp_conv_info_t) into unnamed structures
Fixes:
- http://autobuild.buildroot.org/results/c41d42fe3489bc63c42e7ce7a9eccb1b4ca7b9b2
Change-Id: I78116233c2a8dd7c54723b7cb558254bd5143bd2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-on: https://code.wireshark.org/review/32335
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
If we go over 31, we get an invalid shift. It's due to malformed
packets. Add an expert info and exit the loop.
Bug: 14770
Change-Id: Icc17831ee23395ed2b0d414af09d86d1d1a6444c
Reviewed-on: https://code.wireshark.org/review/32316
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The elements in the tables listing UTF-8 and Boolean properties are
guints, which are *not* the same size as guint16's. (This isn't a
PDP-11 or a 68k-based machine with a compiler that has 16-bit ints or a
machine running 16-bit x86 code or....)
Bug: 15556
Change-Id: I14076584fea74c9c04e2d6b647212e7a2603c275
Reviewed-on: https://code.wireshark.org/review/32336
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This change adds dissectors for all error responses types up to
SMB3.1.1.
It also fixes "Malformed Packet" errors when dissecting error response
within compounded packet responses.
SMB2 Error responses are a bit convoluted. Error data can be a list
of error contexts which themselves can hold an error data field.
See [MS-SMB2] 2.2.2.1.
Pseudo-grammar summary:
ERROR_RESP := ERROR_DATA
ERROR_DATA := ( ERROR_CONTEXT + )
| ERROR_STATUS_STOPPED_ON_SYMLINK
| ERROR_SHARE_ID_SHARE_REDIRECT
| ERROR_BUFFER_TOO_SMALL
ERROR_CONTEXT := ... + ERROR_DATA
| ERROR_SHARE_ID_SHARE_REDIRECT
Change-Id: Ic601bfe53e0495e73736d6b00a5b8ce4d2517edc
Reviewed-on: https://code.wireshark.org/review/32314
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fixing some "implicit conversion loses integer precision" warnings
reported by clang with -Wshorten-64-to-32 option
Change-Id: Ica92971e689c28c6d1ea995e821d648a19186c09
Reviewed-on: https://code.wireshark.org/review/32331
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
in the case of compounded packets, there might be more packets after
the reparse data.
Change-Id: Ife820271be3f7443b352b4c0f75f10d1a0624699
Reviewed-on: https://code.wireshark.org/review/32312
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
* make the following return post-dissect offset:
- dissect_windows_sockaddr_in
- dissect_windows_sockaddr_in6
- dissect_windows_sockaddr_storage
* expose 'len' optional argument to dissect padded data
Change-Id: I83f0981b5aeb6a6f1f08df63fd1513d4b1dcbcef
Reviewed-on: https://code.wireshark.org/review/32313
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
display True/False if a property is of type "bool"
display string if a property is of type "utf-8"
Change-Id: I3655b401298fc4cca9bcf5388707c90c4c1540bb
Reviewed-on: https://code.wireshark.org/review/31934
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The spec is now accepted, so bringing these up to date.
Change-Id: I9489cd8c0b9255446c829f8202410d2d94272607
Reviewed-on: https://code.wireshark.org/review/31723
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Actual changes from Trond Myklebust, I just merged them.
Change-Id: I1038419f38835cc3015d8a44daaf0c9c9d682e81
Reviewed-on: https://code.wireshark.org/review/32290
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
this change adds support for reparse tags added by Windows Server for
NFS for special UNIX files (symlinks, devices, FIFOs, sockets).
previously code assumed all reparse tags were Windows symlinks and
would fail with "malformed packets" when parsing other tags.
Change-Id: Ia0a642ed8e196d3544168f47a6be9f59f03be6d4
Reviewed-on: https://code.wireshark.org/review/32273
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Moved cluster field before src field.
Change-Id: Id113ae60319f1ddb730aaa749a8daa5785da1fc0
Reviewed-on: https://code.wireshark.org/review/32282
Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
tcp.stream and udp.stream are already unsigned identifiers. An upcoming
http2.hashed_stream identifier can exercise the full unsigned 32-bit
number space, so be sure not to treat the stream identifier as signed
integer.
Change-Id: Ic5d398b2bda7eba7555e385ef3fcd44b490f78c9
Reviewed-on: https://code.wireshark.org/review/32287
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Alexander Gryanko <xpahos@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>